Re: [Patch v3] driver/i2c/mux: Add register-based mux i2c-mux-reg

2015-08-14 Thread Wolfram Sang
Do I have to add myself to MAINTAINER file for this driver? Do you want to maintain this driver? I prefer not, if that is OK. Not my most favourite answer, but yes, it is ok ;) -- To unsubscribe from this list: send the line unsubscribe linux-i2c in the body of a message to

Re: [Patch v3] driver/i2c/mux: Add register-based mux i2c-mux-reg

2015-08-13 Thread York Sun
On 08/11/2015 06:35 PM, Wolfram Sang wrote: Do I have to add myself to MAINTAINER file for this driver? Do you want to maintain this driver? I prefer not, if that is OK. York -- To unsubscribe from this list: send the line unsubscribe linux-i2c in the body of a message to

Re: [Patch v3] driver/i2c/mux: Add register-based mux i2c-mux-reg

2015-08-11 Thread Wolfram Sang
On Thu, Jun 18, 2015 at 12:57:38PM -0700, York Sun wrote: Based on i2c-mux-gpio driver, similarly the register-based mux switch from one bus to another by setting a single register. The register can be on PCIe bus, local bus, or any memory-mapped address. The endianness of such register can be

Re: [Patch v3] driver/i2c/mux: Add register-based mux i2c-mux-reg

2015-08-11 Thread York Sun
On 08/11/2015 08:39 AM, Wolfram Sang wrote: On Thu, Jun 18, 2015 at 12:57:38PM -0700, York Sun wrote: Based on i2c-mux-gpio driver, similarly the register-based mux switch from one bus to another by setting a single register. The register can be on PCIe bus, local bus, or any memory-mapped

Re: [Patch v3] driver/i2c/mux: Add register-based mux i2c-mux-reg

2015-08-11 Thread Wolfram Sang
+ if (of_find_property(np, little-endian, NULL)) { You should check for a big-endian property as well, no? I use the little-endian as an option to indicate the nature of litten-endian register. It is default to big-endian if this property doesn't exist. I prefer this way unless you

Re: [Patch v3] driver/i2c/mux: Add register-based mux i2c-mux-reg

2015-08-11 Thread York Sun
On 08/11/2015 09:16 AM, Wolfram Sang wrote: + if (of_find_property(np, little-endian, NULL)) { You should check for a big-endian property as well, no? I use the little-endian as an option to indicate the nature of litten-endian register. It is default to big-endian if this property

Re: [Patch v3] driver/i2c/mux: Add register-based mux i2c-mux-reg

2015-08-11 Thread Wolfram Sang
I'd think that little-endian or big-endian force a setting. If none is present, we shall take the CPU endianess. Or am I overlooking something? You are right. The current code checks for littel-endian property. If missing, the CPU endianess is used. Do you prefer to check littlen-endian

Re: [Patch v3] driver/i2c/mux: Add register-based mux i2c-mux-reg

2015-08-11 Thread Wolfram Sang
Do I have to add myself to MAINTAINER file for this driver? Do you want to maintain this driver? signature.asc Description: Digital signature

Re: [Patch v3] driver/i2c/mux: Add register-based mux i2c-mux-reg

2015-06-19 Thread Alexander Sverdlin
Hi! On 18/06/15 21:57, ext York Sun wrote: Based on i2c-mux-gpio driver, similarly the register-based mux switch from one bus to another by setting a single register. The register can be on PCIe bus, local bus, or any memory-mapped address. The endianness of such register can be specified in