Ok then, Wolfram!
Keep only:
ereqirq:
clk_disable_unprepare(i2c-clk);
And let everyone else just return?
I haven't looked at the details, but when you simply can return, do it.
It is rather pointless to add something in a patch, to remove it in the next.
Yup, just say in the
2014-07-04 19:24 GMT+02:00 Emil Goode emilgo...@gmail.com:
Hello,
I noticed one more thing.
On Fri, Jul 04, 2014 at 07:07:48PM +0200, Rickard Strandqvist wrote:
2014-07-04 11:10 GMT+02:00 Emil Goode emilgo...@gmail.com:
Hello Rickard,
Since this is a probe function there is also no
Hello Rickard,
Since this is a probe function there is also no need to release the devm_*
resources in the i2c_pxa_remove function, this leads to double free.
Also I have a few nit-pick comments below.
On Thu, Jul 03, 2014 at 10:19:16PM +0200, Rickard Strandqvist wrote:
Fix for possible null
2014-07-04 11:10 GMT+02:00 Emil Goode emilgo...@gmail.com:
Hello Rickard,
Since this is a probe function there is also no need to release the devm_*
resources in the i2c_pxa_remove function, this leads to double free.
Also I have a few nit-pick comments below.
On Thu, Jul 03, 2014 at
Hello,
I noticed one more thing.
On Fri, Jul 04, 2014 at 07:07:48PM +0200, Rickard Strandqvist wrote:
2014-07-04 11:10 GMT+02:00 Emil Goode emilgo...@gmail.com:
Hello Rickard,
Since this is a probe function there is also no need to release the devm_*
resources in the i2c_pxa_remove
On Friday, July 04, 2014 5:19 AM, Rickard Strandqvist wrote:
Fix for possible null pointer dereferenc, and there is a risk
for memory leak if something unexpected
s/dereferenc/dereference
The columns of this commit is too long.
Please keep about 80 columns.
happens and the function