Re: [PATCH v3 4/4] iio: humidity: si7020: added No Hold read mode

2015-10-28 Thread Nicola Corna
October 28 2015 12:30 AM, "Wolfram Sang" wrote: > Not a complete review, I just stumbled over this one: > >> + if (client->adapter->quirks && >> + client->adapter->quirks->flags | > > '|' should be '&', or? > Yes, sorry. I'll update the patch. Nicola Corna >> +

Re: [PATCH v3 4/4] iio: humidity: si7020: added No Hold read mode

2015-10-27 Thread Wolfram Sang
Not a complete review, I just stumbled over this one: > + if (client->adapter->quirks && > +client->adapter->quirks->flags | '|' should be '&', or? > +I2C_AQ_NO_CLK_STRETCH) > + return -ENODEV;