Re: [PATCH 1/5 v2] i2c/gpio: add DT support

2012-03-07 Thread Jean-Christophe PLAGNIOL-VILLARD
On 15:20 Wed 29 Feb , Jean-Christophe PLAGNIOL-VILLARD wrote: Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD plagn...@jcrosoft.com Cc: Nicolas Ferre nicolas.fe...@atmel.com Cc: linux-i2c@vger.kernel.org Cc: devicetree-disc...@lists.ozlabs.org --- v2: use devm_kzalloc use

[PATCH V1] i2c: gpio: Use open drain support from gpio driver

2012-03-07 Thread Laxman Dewangan
The gpio core driver (gpio library) supports the open drain pin handling. Therefore, it is not require it to handle in the i2c-gpio driver, just require to pass the OPEN_DRAIN type flag when requesting the gpio. Remove the handling of open drain pin in the i2c-gpio driver. Signed-off-by: Laxman

Re: [PATCH 1/5 v2] i2c/gpio: add DT support

2012-03-07 Thread Rob Herring
On 02/29/2012 08:20 AM, Jean-Christophe PLAGNIOL-VILLARD wrote: Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD plagn...@jcrosoft.com Cc: Nicolas Ferre nicolas.fe...@atmel.com Cc: linux-i2c@vger.kernel.org Cc: devicetree-disc...@lists.ozlabs.org --- v2: use devm_kzalloc use

Re: [PATCH V1] i2c: gpio: Use open drain support from gpio driver

2012-03-07 Thread Mark Brown
On Wed, Mar 07, 2012 at 07:08:14PM +0530, Laxman Dewangan wrote: The gpio core driver (gpio library) supports the open drain pin handling. Therefore, it is not require it to handle in the i2c-gpio driver, just require to pass the OPEN_DRAIN type flag when requesting the gpio. Reviwed-by: Mark

Re: [PATCH 1/5 v2] i2c/gpio: add DT support

2012-03-07 Thread Jean-Christophe PLAGNIOL-VILLARD
On 11:16 Wed 07 Mar , Rob Herring wrote: On 02/29/2012 08:20 AM, Jean-Christophe PLAGNIOL-VILLARD wrote: Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD plagn...@jcrosoft.com Cc: Nicolas Ferre nicolas.fe...@atmel.com Cc: linux-i2c@vger.kernel.org Cc:

Re: [PATCH V1] i2c: gpio: Use open drain support from gpio driver

2012-03-07 Thread Wolfram Sang
On Wed, Mar 07, 2012 at 05:31:57PM +, Mark Brown wrote: On Wed, Mar 07, 2012 at 07:08:14PM +0530, Laxman Dewangan wrote: The gpio core driver (gpio library) supports the open drain pin handling. Therefore, it is not require it to handle in the i2c-gpio driver, just require to pass the

Re: [PATCH V1] i2c: gpio: Use open drain support from gpio driver

2012-03-07 Thread Laxman Dewangan
The open drain support is already available from next-20120306. I was waiting for the change to be in tree before sending this patch. Hope I am not missing anything here. On Wednesday 07 March 2012 11:14 PM, Mark Brown wrote: * PGP Signed by an unknown key On Wed, Mar 07, 2012 at 06:39:22PM

Re: [PATCH 2/2] i2c: tegra: Remove unnecessary write to INT_STATUS

2012-03-07 Thread Wolfram Sang
On Tue, Mar 06, 2012 at 09:37:07AM +0530, Alok Chauhan wrote: Signed-off-by: Alok Chauhan al...@nvidia.com Thanks, I updated the patch. -- Pengutronix e.K. | Wolfram Sang| Industrial Linux Solutions | http://www.pengutronix.de/ |

Re: [PATCH V1] i2c: gpio: Use open drain support from gpio driver

2012-03-07 Thread Mark Brown
On Wed, Mar 07, 2012 at 11:38:25PM +0530, Laxman Dewangan wrote: The open drain support is already available from next-20120306. I was waiting for the change to be in tree before sending this patch. Hope I am not missing anything here. Nobody should be merging -next into their trees, it's

Re: [PATCH 1/5 v2] i2c/gpio: add DT support

2012-03-07 Thread Rob Herring
On 03/07/2012 11:22 AM, Jean-Christophe PLAGNIOL-VILLARD wrote: On 11:16 Wed 07 Mar , Rob Herring wrote: On 02/29/2012 08:20 AM, Jean-Christophe PLAGNIOL-VILLARD wrote: Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD plagn...@jcrosoft.com Cc: Nicolas Ferre nicolas.fe...@atmel.com Cc:

Re: [PATCH V1] i2c: gpio: Use open drain support from gpio driver

2012-03-07 Thread Linus Walleij
On Wed, Mar 7, 2012 at 6:31 PM, Mark Brown broo...@opensource.wolfsonmicro.com wrote: On Wed, Mar 07, 2012 at 07:08:14PM +0530, Laxman Dewangan wrote: The gpio core driver (gpio library) supports the open drain pin handling. Therefore, it is not require it to handle in the i2c-gpio driver,

RE: [PATCH v2] i2c: tegra: Add delay before reset the controller

2012-03-07 Thread Alok Chauhan
Hi all, If there are no more concern then can we merge this patch to i2c tegra driver? Thanks Alok On Mon, Dec 26, 2011 at 4:44 PM, Alok Chauhan al...@nvidia.com wrote: From: Alok Chauhan al...@nvidia.com In NACK error condition, I2C controller violates clock-to-data setup time before

Re: [PATCH V1] i2c: gpio: Use open drain support from gpio driver

2012-03-07 Thread Wolfram Sang
Acked-by: Linus Walleij linus.wall...@linaro.org I'd ask Grant to take this into the GPIO tree if Broonie can ACK it. Uhm, why? What's wrong with going in via I2C? -- Pengutronix e.K. | Wolfram Sang| Industrial Linux Solutions |