Re: [RFC] i2c: Revert back to old device naming for ACPI enumerated I2C slaves

2015-08-25 Thread Wolfram Sang
So I am not surprised that this only shows up now. I am, to be honest. It shows running lm-sensors with ACPI on a kernel newer than 18 months. Not a rare scenario, so I thought. And thanks to Mark's recent post I understand now that this is only relevant for ACPI5 enumerated devices. I

Re: [RFC] i2c: Revert back to old device naming for ACPI enumerated I2C slaves

2015-08-25 Thread Wolfram Sang
On Tue, Aug 25, 2015 at 08:18:30AM -0700, Guenter Roeck wrote: On 08/25/2015 07:57 AM, Wolfram Sang wrote: On Tue, Aug 25, 2015 at 06:25:13AM +0100, Mark Brown wrote: On Mon, Aug 24, 2015 at 01:52:02PM +0300, Jarkko Nikula wrote: Commit 70762abb9f89 (i2c: Use stable dev_name for ACPI

Re: [RFC] i2c: Revert back to old device naming for ACPI enumerated I2C slaves

2015-08-25 Thread Guenter Roeck
On 08/25/2015 09:18 AM, Wolfram Sang wrote: On Tue, Aug 25, 2015 at 08:18:30AM -0700, Guenter Roeck wrote: On 08/25/2015 07:57 AM, Wolfram Sang wrote: On Tue, Aug 25, 2015 at 06:25:13AM +0100, Mark Brown wrote: On Mon, Aug 24, 2015 at 01:52:02PM +0300, Jarkko Nikula wrote: Commit

Re: [RFC] i2c: Revert back to old device naming for ACPI enumerated I2C slaves

2015-08-25 Thread Jarkko Nikula
On 08/25/2015 08:03 AM, Dustin Byford wrote: On Mon Aug 24 13:52, Jarkko Nikula wrote: I don't know how common ACPI enumerated I2C hwmon devices are but I guess they exists since Dustin notices this issue and wrote With that change, /sys/bus/i2c/devices/i2c-0-004a, for example, became

Re: [RFC] i2c: Revert back to old device naming for ACPI enumerated I2C slaves

2015-08-25 Thread Wolfram Sang
In this particular case it looks like we need a mechanism to use the old naming scheme for hwmon and the new one for everything else or something similar. I'm afraid I am not familiar enough with the i2c core to suggest anything specific ATM, though. Well, it boils down to directory names

Re: [Patch v2] i2c: imx: implement bus recovery

2015-08-25 Thread Linus Walleij
On Wed, Aug 19, 2015 at 9:02 AM, Uwe Kleine-König u.kleine-koe...@pengutronix.de wrote: On Wed, Aug 19, 2015 at 03:44:49AM +, Gao Pandy wrote: From: Uwe Kleine-König mailto:u.kleine-koe...@pengutronix.de Sent: Thursday, August 13, 2015 4:15 PM +static void

Re: [RFC] i2c: Revert back to old device naming for ACPI enumerated I2C slaves

2015-08-25 Thread Wolfram Sang
On Tue, Aug 25, 2015 at 06:25:13AM +0100, Mark Brown wrote: On Mon, Aug 24, 2015 at 01:52:02PM +0300, Jarkko Nikula wrote: Commit 70762abb9f89 (i2c: Use stable dev_name for ACPI enumerated I2C slaves) broke the lm-sensors which relies on I2C hwmon slave devices under /sys/bus/i2c/devices/

Re: [RFC] i2c: Revert back to old device naming for ACPI enumerated I2C slaves

2015-08-25 Thread Guenter Roeck
On 08/25/2015 07:57 AM, Wolfram Sang wrote: On Tue, Aug 25, 2015 at 06:25:13AM +0100, Mark Brown wrote: On Mon, Aug 24, 2015 at 01:52:02PM +0300, Jarkko Nikula wrote: Commit 70762abb9f89 (i2c: Use stable dev_name for ACPI enumerated I2C slaves) broke the lm-sensors which relies on I2C hwmon

Re: [RFC] i2c: Revert back to old device naming for ACPI enumerated I2C slaves

2015-08-25 Thread Mark Brown
On Tue, Aug 25, 2015 at 04:57:56PM +0200, Wolfram Sang wrote: On Tue, Aug 25, 2015 at 06:25:13AM +0100, Mark Brown wrote: On Mon, Aug 24, 2015 at 01:52:02PM +0300, Jarkko Nikula wrote: Commit 70762abb9f89 (i2c: Use stable dev_name for ACPI enumerated I2C slaves) broke the lm-sensors

RE: [Patch V4] i2c: imx: add runtime pm support to improve the performance

2015-08-25 Thread Gao Pandy
From: Heiner Kallweit mailto:hkallwe...@gmail.com Sent: Wednesday, August 26, 2015 3:53 AM To: Gao Pan-B54642; w...@the-dreams.de Cc: linux-i2c@vger.kernel.org; Li Frank-B20596; Duan Fugang-B38611; u.kleine-koe...@pengutronix.de; ker...@pengutronix.de Subject: Re: [Patch V4] i2c: imx: add

[Patch V5] i2c: imx: add runtime pm support to improve the performance

2015-08-25 Thread Gao Pan
In our former i2c driver, i2c clk is enabled and disabled in xfer function, which contributes to power saving. However, the clk enable process brings a busy wait delay until the core is stable. As a result, the performance is sacrificed. To weigh the power consumption and i2c bus performance,

[PATCH] drivers: i2c: exynos5: irq spinlock rt-safe

2015-08-25 Thread Anders Roxell
The exynos5_i2c_message_start enables interrupts while holding the i2c lock which is sought by the irq handler. If an IRQ is received before this lock is released then a deadlock occurs. This is only seen on an RT patched kernel, due to the transformation of spinlocks into sleeping locks. By

Re: [Patch V4] i2c: imx: add runtime pm support to improve the performance

2015-08-25 Thread Heiner Kallweit
Am 25.08.2015 um 04:20 schrieb Gao Pan: In our former i2c driver, i2c clk is enabled and disabled in xfer function, which contributes to power saving. However, the clk enable process brings a busy wait delay until the core is stable. As a result, the performance is sacrificed. To weigh the

[RESEND PATCH 1/7] i2c: core: Export I2C module alias information in dummy driver

2015-08-25 Thread Javier Martinez Canillas
The I2C core always reports the MODALIAS uevent as i2c:modalias regardless of the mechanism that was used to register the device (i.e: OF or board code) and the table that is used later to match the driver with the device (i.e: I2C id table or OF match table). So drivers needs to export the I2C

Re: [PATCH] drivers: i2c: exynos5: irq spinlock rt-safe

2015-08-25 Thread Thomas Gleixner
On Tue, 25 Aug 2015, Anders Roxell wrote: The exynos5_i2c_message_start enables interrupts while holding the i2c lock which is sought by the irq handler. If an IRQ is received before this lock is released then a deadlock occurs. That's crap. The interrupt handler runs in an irq thread as RT

[PATCH 3/4] i2c-piix4: Add support for multiplexed main adapter in SB800

2015-08-25 Thread Christian Fetzer
The SB800 chipset supports a multiplexed main SMBus controller with four ports. The multiplexed ports share the same SMBus address and register set. The port is selected by bits 2:1 of the smb_en register (0x2C). Only one port can be active at any point in time therefore a mutex is needed in

RE: [Patch V4] i2c: imx: add runtime pm support to improve the performance

2015-08-25 Thread Gao Pandy
From: Heiner Kallweit mailto:hkallwe...@gmail.com Sent: Tuesday, August 25, 2015 2:37 PM To: Gao Pan-B54642; w...@the-dreams.de Cc: linux-i2c@vger.kernel.org; Li Frank-B20596; Duan Fugang-B38611; u.kleine-koe...@pengutronix.de; ker...@pengutronix.de Subject: Re: [Patch V4] i2c: imx: add

[PATCH 0/4] Support multiplexed main SMBus interface on SB800

2015-08-25 Thread Christian Fetzer
This is an attempt to upstream the patches created by Thomas Brandon and Eddi De Pieri to support the multiplexed main SMBus interface on the SB800 chipset. (https://www.mail-archive.com/linux-i2c@vger.kernel.org/msg06757.html) I have mainly rebased the latest patch version and tested the driver

[PATCH 2/4] i2c-piix4: Convert piix4_main_adapter to array

2015-08-25 Thread Christian Fetzer
The SB800 chipset supports a multiplexed main SMBus controller with four ports. Therefore the static variable piix4_main_adapter is converted into a piix4_main_adapters array that can hold one i2c_adapter for each multiplexed port. The auxiliary adapter remains unchanged since it represents the

[PATCH 4/4] i2c-piix4: Add adapter port name support for SB800 chipset

2015-08-25 Thread Christian Fetzer
This patch adds support for port names for the SB800 chipset. Since the chipset supports a multiplexed main SMBus controller, adding the channel name to the adapter name is necessary to differentiate the ports better (for example in sensors output). Signed-off-by: Christian Fetzer

[PATCH 1/4] i2c-piix4: Optionally release smba in piix4_adap_remove

2015-08-25 Thread Christian Fetzer
This is in preparation to support the multiplexed SMBus main controller in the SB800 chipset where the controller address is shared among the four multiplexed ports. As such the address region should be only freed for the first multiplexed adapter to avoid double free warnings. Signed-off-by:

RE: [Patch V4] i2c: imx: add runtime pm support to improve the performance

2015-08-25 Thread Gao Pandy
From: linux-i2c-ow...@vger.kernel.org [mailto:linux-i2c- ow...@vger.kernel.org] On Behalf Of Gao Pandy Sent: Tuesday, August 25, 2015 7:09 PM To: Heiner Kallweit; w...@the-dreams.de Cc: linux-i2c@vger.kernel.org; Li Frank-B20596; Duan Fugang-B38611; u.kleine-koe...@pengutronix.de;

Re: [Patch V4] i2c: imx: add runtime pm support to improve the performance

2015-08-25 Thread Heiner Kallweit
Am 25.08.2015 um 13:09 schrieb Gao Pandy: From: Heiner Kallweit mailto:hkallwe...@gmail.com Sent: Tuesday, August 25, 2015 2:37 PM To: Gao Pan-B54642; w...@the-dreams.de Cc: linux-i2c@vger.kernel.org; Li Frank-B20596; Duan Fugang-B38611; u.kleine-koe...@pengutronix.de; ker...@pengutronix.de

[RESEND PATCH 0/7] Export I2C and OF module aliases in missing drivers

2015-08-25 Thread Javier Martinez Canillas
Hello, This is a resend of the patches that were not picked from the series [PATCH 00/27] Export I2C and OF module aliases in missing drivers [0] posted about a month ago. The patches have no dependencies and can be picked individually by the relevant maintainer. I preferred to resend instead