Am 28.08.2015 um 08:30 schrieb Gao Pan:
> In our former i2c driver, i2c clk is enabled and disabled in
> xfer function, which contributes to power saving. However,
> the clk enable process brings a busy wait delay until the core
> is stable. As a result, the performance is sacrificed.
>
> To
In our former i2c driver, i2c clk is enabled and disabled in
xfer function, which contributes to power saving. However,
the clk enable process brings a busy wait delay until the core
is stable. As a result, the performance is sacrificed.
To weigh the power consumption and i2c bus performance,
We offer private, commercial and personal loans with very low annualinterest
rates as low as 2% in one year to 50 years repayment period anywhere in the
world. We offer loans ranging from $5000 to $100 million. Our loans are well
insured for maximum security is our priority. Are you losing
On Fri, Aug 21, 2015 at 03:26:23AM +, York Sun wrote:
> Sorry for top posting, I am out and replying using web access.
>
> This patch looks OK. I cannot test it until earliest next Friday.
Did you have the chance to test it?
Thanks,
Wolfram
signature.asc
Description: Digital
> > The dummy driver is always loaded when the i2c core inits.
> >
>
> Ok, I wondered if that was the case but I
> was not sure so I posted it just in case.
Check the source code, this part is pretty obvious...
signature.asc
Description: Digital signature
On Wed, Aug 26, 2015 at 11:59:33PM +0300, Vladimir Zapolskiy wrote:
> Every call of of_parse_phandle() increments user count of found device
> node, if OF_DYNAMIC is enabled.
>
> The change fixes all similar addressed cases in drivers/i2c.
>
> Signed-off-by: Vladimir Zapolskiy
On 08/31/2015 03:24 PM, Wolfram Sang wrote:
> On Fri, Aug 21, 2015 at 03:26:23AM +, York Sun wrote:
>> Sorry for top posting, I am out and replying using web access.
>>
>> This patch looks OK. I cannot test it until earliest next Friday.
>
> Did you have the chance to test it?
>
I am
On 2015-08-25 23:51, Thomas Gleixner wrote:
> On Tue, 25 Aug 2015, Anders Roxell wrote:
>
> > The exynos5_i2c_message_start enables interrupts while holding the i2c
> > lock which is sought by the irq handler. If an IRQ is received before
> > this lock is released then a deadlock occurs.
>
>
On 08/20/2015 04:40 PM, Wolfram Sang wrote:
> Checking was done at three different locations, just do it once and
> properly at probing time.
>
> Signed-off-by: Wolfram Sang
> Cc: York Sun
> ---
>
> York Sun: Can you test this patch? I can only
Hello Wolfram,
On 08/31/2015 10:31 PM, Wolfram Sang wrote:
>
>>> The dummy driver is always loaded when the i2c core inits.
>>>
>>
>> Ok, I wondered if that was the case but I
>> was not sure so I posted it just in case.
>
> Check the source code, this part is pretty obvious...
>
Yes, sorry
On Tue, Sep 01, 2015 at 12:30:22AM +0200, Javier Martinez Canillas wrote:
> Hello Wolfram,
>
> On 08/31/2015 10:31 PM, Wolfram Sang wrote:
> >
> >>> The dummy driver is always loaded when the i2c core inits.
> >>>
> >>
> >> Ok, I wondered if that was the case but I
> >> was not sure so I posted
> -Original Message-
> From: Heiner Kallweit [mailto:hkallwe...@gmail.com]
> Sent: Monday, August 31, 2015 2:14 PM
> To: Gao Pan-B54642; w...@the-dreams.de
> Cc: linux-i2c@vger.kernel.org; Li Frank-B20596; Duan Fugang-B38611;
> u.kleine-koe...@pengutronix.de; ker...@pengutronix.de
>
dw_readl() and dw_writel() are not used outside of i2c-designware-core and
they are not exported so make them static and remove their forward
declaration.
Signed-off-by: Jarkko Nikula
---
drivers/i2c/busses/i2c-designware-core.c | 4 ++--
There is some code duplication in i2c-designware-platdrv and
i2c-designware-pcidrv probe functions. What is even worse that duplication
requires i2c_dw_xfer(), i2c_dw_func() and i2c_dw_isr() i2c-designware-core
functions to be exported.
Therefore move common code into new i2c_dw_probe() and make
Make it easier to distinguish between i2c-designware-platdrv and
i2c-designware-core functions and to be consistent with
i2c-designware-pcidrv.
Signed-off-by: Jarkko Nikula
---
drivers/i2c/busses/i2c-designware-platdrv.c | 24
1 file
i2c_dw_is_enabled() became unused by the commit be58eda775c8
("i2c: designware-pci: Cleanup driver power management") and
i2c_dw_enable() by the commit 3a48d1c08fe0 ("i2c: prevent spurious
interrupt on Designware controllers").
Signed-off-by: Jarkko Nikula
---
It bothered to me to see "static struct i2c_algorithm i2c_dw_algo {}"
defined twice both in i2c-designware-pcidrv.c and
i2c-designware-platdrv.c and so many exported i2c-designware-core
functions.
It turned out some of them became unused or are local and there were
also duplicated probe code that
There is no need to clear interrupts in i2c_dw_pci_probe() since only place
where interrupts are unmasked is i2c_dw_xfer_init() and there interrupts
are always cleared after commit 2a2d95e9d6d2 ("i2c: designware: always
clear interrupts before enabling them").
This allows to cleanup the code and
18 matches
Mail list logo