Re: [Patch V6] i2c: imx: add runtime pm support to improve the performance

2015-08-31 Thread Heiner Kallweit
Am 28.08.2015 um 08:30 schrieb Gao Pan: > In our former i2c driver, i2c clk is enabled and disabled in > xfer function, which contributes to power saving. However, > the clk enable process brings a busy wait delay until the core > is stable. As a result, the performance is sacrificed. > > To

[Patch V7] i2c: imx: add runtime pm support to improve the performance

2015-08-31 Thread Gao Pan
In our former i2c driver, i2c clk is enabled and disabled in xfer function, which contributes to power saving. However, the clk enable process brings a busy wait delay until the core is stable. As a result, the performance is sacrificed. To weigh the power consumption and i2c bus performance,

Re: Do you need a loan?

2015-08-31 Thread
We offer private, commercial and personal loans with very low annualinterest rates as low as 2% in one year to 50 years repayment period anywhere in the world. We offer loans ranging from $5000 to $100 million. Our loans are well insured for maximum security is our priority. Are you losing

Re: [PATCH] i2c: mux: reg: simplify register size checking

2015-08-31 Thread Wolfram Sang
On Fri, Aug 21, 2015 at 03:26:23AM +, York Sun wrote: > Sorry for top posting, I am out and replying using web access. > > This patch looks OK. I cannot test it until earliest next Friday. Did you have the chance to test it? Thanks, Wolfram signature.asc Description: Digital

Re: [RESEND PATCH 1/7] i2c: core: Export I2C module alias information in dummy driver

2015-08-31 Thread Wolfram Sang
> > The dummy driver is always loaded when the i2c core inits. > > > > Ok, I wondered if that was the case but I > was not sure so I posted it just in case. Check the source code, this part is pretty obvious... signature.asc Description: Digital signature

Re: [PATCH] i2c: muxes: fix leaked i2c adapter device node references

2015-08-31 Thread Wolfram Sang
On Wed, Aug 26, 2015 at 11:59:33PM +0300, Vladimir Zapolskiy wrote: > Every call of of_parse_phandle() increments user count of found device > node, if OF_DYNAMIC is enabled. > > The change fixes all similar addressed cases in drivers/i2c. > > Signed-off-by: Vladimir Zapolskiy

Re: [PATCH] i2c: mux: reg: simplify register size checking

2015-08-31 Thread York Sun
On 08/31/2015 03:24 PM, Wolfram Sang wrote: > On Fri, Aug 21, 2015 at 03:26:23AM +, York Sun wrote: >> Sorry for top posting, I am out and replying using web access. >> >> This patch looks OK. I cannot test it until earliest next Friday. > > Did you have the chance to test it? > I am

Re: [PATCH] drivers: i2c: exynos5: irq spinlock rt-safe

2015-08-31 Thread Anders Roxell
On 2015-08-25 23:51, Thomas Gleixner wrote: > On Tue, 25 Aug 2015, Anders Roxell wrote: > > > The exynos5_i2c_message_start enables interrupts while holding the i2c > > lock which is sought by the irq handler. If an IRQ is received before > > this lock is released then a deadlock occurs. > >

Re: [PATCH] i2c: mux: reg: simplify register size checking

2015-08-31 Thread York Sun
On 08/20/2015 04:40 PM, Wolfram Sang wrote: > Checking was done at three different locations, just do it once and > properly at probing time. > > Signed-off-by: Wolfram Sang > Cc: York Sun > --- > > York Sun: Can you test this patch? I can only

Re: [RESEND PATCH 1/7] i2c: core: Export I2C module alias information in dummy driver

2015-08-31 Thread Javier Martinez Canillas
Hello Wolfram, On 08/31/2015 10:31 PM, Wolfram Sang wrote: > >>> The dummy driver is always loaded when the i2c core inits. >>> >> >> Ok, I wondered if that was the case but I >> was not sure so I posted it just in case. > > Check the source code, this part is pretty obvious... > Yes, sorry

Re: [RESEND PATCH 1/7] i2c: core: Export I2C module alias information in dummy driver

2015-08-31 Thread Wolfram Sang
On Tue, Sep 01, 2015 at 12:30:22AM +0200, Javier Martinez Canillas wrote: > Hello Wolfram, > > On 08/31/2015 10:31 PM, Wolfram Sang wrote: > > > >>> The dummy driver is always loaded when the i2c core inits. > >>> > >> > >> Ok, I wondered if that was the case but I > >> was not sure so I posted

RE: [Patch V6] i2c: imx: add runtime pm support to improve the performance

2015-08-31 Thread Gao Pandy
> -Original Message- > From: Heiner Kallweit [mailto:hkallwe...@gmail.com] > Sent: Monday, August 31, 2015 2:14 PM > To: Gao Pan-B54642; w...@the-dreams.de > Cc: linux-i2c@vger.kernel.org; Li Frank-B20596; Duan Fugang-B38611; > u.kleine-koe...@pengutronix.de; ker...@pengutronix.de >

[PATCH 4/6] i2c: designware: Make dw_readl() and dw_writel() static

2015-08-31 Thread Jarkko Nikula
dw_readl() and dw_writel() are not used outside of i2c-designware-core and they are not exported so make them static and remove their forward declaration. Signed-off-by: Jarkko Nikula --- drivers/i2c/busses/i2c-designware-core.c | 4 ++--

[PATCH 6/6] i2c: designware: Move common probe code into i2c_dw_probe()

2015-08-31 Thread Jarkko Nikula
There is some code duplication in i2c-designware-platdrv and i2c-designware-pcidrv probe functions. What is even worse that duplication requires i2c_dw_xfer(), i2c_dw_func() and i2c_dw_isr() i2c-designware-core functions to be exported. Therefore move common code into new i2c_dw_probe() and make

[PATCH 5/6] i2c: designware: Rename platform driver probe and PM functions

2015-08-31 Thread Jarkko Nikula
Make it easier to distinguish between i2c-designware-platdrv and i2c-designware-core functions and to be consistent with i2c-designware-pcidrv. Signed-off-by: Jarkko Nikula --- drivers/i2c/busses/i2c-designware-platdrv.c | 24 1 file

[PATCH 3/6] i2c: designware: Remove unused functions

2015-08-31 Thread Jarkko Nikula
i2c_dw_is_enabled() became unused by the commit be58eda775c8 ("i2c: designware-pci: Cleanup driver power management") and i2c_dw_enable() by the commit 3a48d1c08fe0 ("i2c: prevent spurious interrupt on Designware controllers"). Signed-off-by: Jarkko Nikula ---

[PATCH 0/6] i2c: designware: Code duplication removal and cleanups

2015-08-31 Thread Jarkko Nikula
It bothered to me to see "static struct i2c_algorithm i2c_dw_algo {}" defined twice both in i2c-designware-pcidrv.c and i2c-designware-platdrv.c and so many exported i2c-designware-core functions. It turned out some of them became unused or are local and there were also duplicated probe code that

[PATCH 1/6] i2c: designware: Remove interrupt clearing from i2c_dw_pci_probe()

2015-08-31 Thread Jarkko Nikula
There is no need to clear interrupts in i2c_dw_pci_probe() since only place where interrupts are unmasked is i2c_dw_xfer_init() and there interrupts are always cleared after commit 2a2d95e9d6d2 ("i2c: designware: always clear interrupts before enabling them"). This allows to cleanup the code and