Re: [PATCH] i2c: designware: Add support for 16bit register access

2012-03-14 Thread Stefan Roese
Hi Bhupesh, On Wednesday 14 March 2012 04:29:23 Bhupesh SHARMA wrote: -Original Message- From: Stefan Roese [mailto:s...@denx.de] Sent: Tuesday, March 13, 2012 9:24 PM To: linux-i2c@vger.kernel.org Cc: spear-devel; ben-li...@fluff.org Subject: [PATCH] i2c: designware: Add

RE: [PATCH] i2c: designware: Add support for 16bit register access

2012-03-14 Thread Bhupesh SHARMA
Hi Stefan, -Original Message- From: Stefan Roese [mailto:s...@denx.de] Sent: Wednesday, March 14, 2012 1:28 PM To: Bhupesh SHARMA Cc: linux-i2c@vger.kernel.org; spear-devel; ben-li...@fluff.org Subject: Re: [PATCH] i2c: designware: Add support for 16bit register access Hi

Re: [PATCH] i2c multiplexer driver for Proliant microserver N36L

2012-03-14 Thread Eddi De Pieri
Hi Thomas, With the updated patch and the modified sensors-detect I have been able to probe all ports and have not encountered the power issue again. If no further issues are identified I will seperate the patch into stages and submit for review. I confirm that your patch works well on my

[DEBUG PATCH] Print a message when a spurious i2c SCL timeout occurs.

2012-03-14 Thread Ville Syrjälä
A quick hack to verify that the fix works as intended... Do not apply. --- drivers/i2c/algos/i2c-algo-bit.c |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/drivers/i2c/algos/i2c-algo-bit.c b/drivers/i2c/algos/i2c-algo-bit.c index d25112e..3f547b5 100644 ---

[PATCH] i2c-algo-bit: Fix spurious SCL timeouts under heavy load

2012-03-14 Thread Ville Syrjälä
When the system is under heavy load, there can be a significant delay between the getscl() and time_after() calls inside sclhi(). That delay may cause the time_after() check to trigger after SCL has gone high, causing sclhi() to return -ETIMEDOUT. To fix the problem, double check that SCL is

Re: [PATCH] i2c: designware: Add support for 16bit register access

2012-03-14 Thread Jean Delvare
On Wed, 14 Mar 2012 16:19:22 +0800, Bhupesh SHARMA wrote: -Original Message- From: Stefan Roese [mailto:s...@denx.de] Sent: Wednesday, March 14, 2012 1:28 PM To: Bhupesh SHARMA Cc: linux-i2c@vger.kernel.org; spear-devel; ben-li...@fluff.org Subject: Re: [PATCH] i2c: designware:

RE: [PATCH] i2c: designware: Add support for 16bit register access

2012-03-14 Thread Bhupesh SHARMA
-Original Message- From: Jean Delvare [mailto:kh...@linux-fr.org] Sent: Wednesday, March 14, 2012 2:14 PM To: Bhupesh SHARMA Cc: Stefan Roese; linux-i2c@vger.kernel.org; spear-devel; ben- li...@fluff.org Subject: Re: [PATCH] i2c: designware: Add support for 16bit register access

mc13xxx: add I2C support (now with regmap), V3

2012-03-14 Thread Marc Reilly
Hi, This series (against mfd-2.6/for-next) changes the mc13xxx driver to use regmap and adds I2C support. It generally goes about this the same way as the previous 2 versions, but now uses regmap. I am unable to test SPI functionality, but the I2C stuff works. It would be great if someone

[PATCH v3 1/6] regmap: add support for 7_25 format

2012-03-14 Thread Marc Reilly
This adds support for devices with 7 address bits and 25 data bits. The initial intended user for this are the mc13xxx mfds in spi mode. (The 25th data bit is actually a dummy bit) Signed-off-by: Marc Reilly m...@cpdesign.com.au --- drivers/base/regmap/regmap.c | 11 +++ 1 files

[PATCH v3 5/6] mfd: mc13xxx-core: Move spi specific code into separate module.

2012-03-14 Thread Marc Reilly
All spi specific code is moved into a new module. The mc13xxx struct moves to a new local include file by necessity. A new config choice selects the SPI bus type support and by default is value of SPI_MASTER to remain compatible with existing configs. Signed-off-by: Marc Reilly

[PATCH v3 4/6] mfd: mc13xxx-core: use regmap for register access

2012-03-14 Thread Marc Reilly
This change converts the mc13xxx core to use regmap rather than direct spi r/w. The spidev member of mc13xxx struct becomes redundant and is removed. Extra debugging aids are added to mc13xxx_reg_rmw. Mutex init is moved to before regmap init. Signed-off-by: Marc Reilly m...@cpdesign.com.au ---

[PATCH v3 2/6] regmap: Add support for device with 24 data bits.

2012-03-14 Thread Marc Reilly
Add support for devices with 24 data bits. Signed-off-by: Marc Reilly m...@cpdesign.com.au --- drivers/base/regmap/regmap.c | 23 +++ 1 files changed, 23 insertions(+), 0 deletions(-) diff --git a/drivers/base/regmap/regmap.c b/drivers/base/regmap/regmap.c index

[PATCH v3 3/6] mfd: mc13xxx-core: Prepare for separate spi and i2c backends.

2012-03-14 Thread Marc Reilly
This patch abstracts the bus specific operations from the driver core. Generic init and cleanup is consolidated into mc13xxx_common_*. spi specific functions are renamed to reflect such. (The irq member of the mc13xxx struct is no longer redundant, it's used to store the irq for cleanup time).

[PATCH v3 6/6] mfd: mc13xxx: Add i2c driver

2012-03-14 Thread Marc Reilly
Adds support for mc13xxx family ICs connected via i2c. Signed-off-by: Marc Reilly m...@cpdesign.com.au --- drivers/mfd/Kconfig |8 +++- drivers/mfd/Makefile |1 + drivers/mfd/mc13xxx-i2c.c | 128 + 3 files changed, 136

Re: [PATCH v3 6/6] mfd: mc13xxx: Add i2c driver

2012-03-14 Thread Fabio Estevam
Hi Marc, On Wed, Mar 14, 2012 at 5:43 PM, Marc Reilly m...@cpdesign.com.au wrote: + +static const struct i2c_device_id mc13xxx_i2c_device_id[] = { +       { +               .name = mc13783, +               .driver_data = MC13XXX_ID_MC13783 mc13783 does not have i2c interface. -- To