On Tue, Apr 17, 2012 at 11:39 PM, Wolfram Sang w.s...@pengutronix.de wrote:
From: Jonas Aaberg jonas.ab...@stericsson.com
Turn off the clock and regulator to the I2C block using runtime
PM.
Cc: Magnus Damm magnus.d...@gmail.com
Cc: Rafael J. Wysocki r...@sisk.pl
Cc: Mark Brown
Hi Kevin,
Hi Kevin,
Thanks for your review,
On Tue, Apr 17, 2012 at 7:15 PM, Kevin Hilman khil...@ti.com wrote:
Shubhrajyoti D shubhrajy...@ti.com writes:
Currently i2c register restore is done always.
Adding conditional restore.
The i2c register restore is done only if the context is
Hi Andriy,
On Tue, 17 Apr 2012 23:03:16 +0300, Andriy Gapon wrote:
on 17/04/2012 14:18 Jean Delvare said the following:
I am attaching two patches, one for DDR2, one for DDR3, please give
them a try.
Thanks a lot!
I am able to test only the DDR2 part at the moment.
With the patch I am
On Wed, Feb 29, 2012 at 07:45:23PM +0100, Wolfram Sang wrote:
Hi,
On Wed, Feb 29, 2012 at 06:39:21PM +0800, Zhao Chenhui wrote:
When entering deep sleep, the value in the registers I2CFDR and
I2CDFSRR are lost. This causes I2C access to fail after resuming.
Add suspend/resume
Hi,
We certainly don't want the policy to be against the common practice
of the community. If it is we can consider changing our policy.
Nice, thanks for being open to discussion!
However I can't find a clear message stating the consensus of what the
Linux kernel community think of adding
On Tue, Mar 27, 2012 at 11:10:26AM +0200, Karol Lewandowski wrote:
Changes since v1:
- Dropped reduntant i2c-octeon change
i2c controller drivers used to assume bus number 0 when none (-1) was
specified.
This worked on non-device tree systems, where one could explicitly
specify bus
On Wed, Mar 21, 2012 at 08:11:51PM +0100, Karol Lewandowski wrote:
Use standard of_match_ptr() to avoid defining variable unused
in non device tree builds.
Signed-off-by: Karol Lewandowski k.lewando...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
Acked-by: Grant Likely
On Wed, Apr 18, 2012 at 09:33:19AM +0200, Stefan Roese wrote:
The STM SPEAr platform can only access the i2c controller register
via 16bit read/write functions. This patch adds support to
automatically detect this 16bit access mode.
Signed-off-by: Stefan Roese s...@denx.de
Thanks for the
On 17.04.2012 19:31, Wolfram Sang wrote:
Hi,
Hi Wolfram!
On Wed, Mar 21, 2012 at 08:11:52PM +0100, Karol Lewandowski wrote:
Reorganize driver a bit to better handle device tree-based systems:
- move machine type to driver's private structure instead of
quering platform device
On Wednesday 18 April 2012 13:24:26 Wolfram Sang wrote:
snip
@@ -254,7 +265,13 @@ int i2c_dw_init(struct dw_i2c_dev *dev)
/* Configure register endianess access */
reg = dw_readl(dev, DW_IC_COMP_TYPE);
if (reg == ___constant_swab32(DW_IC_COMP_TYPE_VALUE)) {
-
The STM SPEAr platform can only access the i2c controller register
via 16bit read/write functions. This patch adds support to
automatically detect this 16bit access mode.
Signed-off-by: Stefan Roese s...@denx.de
---
v3:
- Changed multiple if statements into one if/elseif/etc statement
to remove
Hi,
Reorganize driver a bit to better handle device tree-based systems:
- move machine type to driver's private structure instead of
quering platform device variants in runtime
- replace s3c24xx_i2c_type enum with unsigned int that holds
bitmask with revision-specific quirks
Optional properties:
+ - gpios: The order of the gpios should be the following: SDA, SCL.
+The gpio specifier depends on the gpio controller. Required in all
cases
+except when samsung,i2c-no-gpio is also specified.
+ - samsung,i2c-no-gpio: input/output lines of the
On Wed, Apr 18, 2012 at 03:01:41PM +0200, Stefan Roese wrote:
The STM SPEAr platform can only access the i2c controller register
via 16bit read/write functions. This patch adds support to
automatically detect this 16bit access mode.
Signed-off-by: Stefan Roese s...@denx.de
Even on second
Datta, Shubhrajyoti shubhrajy...@ti.com writes:
Hi Kevin,
Hi Kevin,
Thanks for your review,
On Tue, Apr 17, 2012 at 7:15 PM, Kevin Hilman khil...@ti.com wrote:
Shubhrajyoti D shubhrajy...@ti.com writes:
Currently i2c register restore is done always.
Adding conditional restore.
The
Hi Paul,
Of course, if you think it is cramping your SH device tree style then
we can easily add a renesas-shmobile-iic entry as well.
I obviously don't mind if you wish to use the rmobile naming convention
going forward, as the new parts have obviously dropped with the shmobile
naming
On Wednesday 18 April 2012 16:00:11 Wolfram Sang wrote:
On Wed, Apr 18, 2012 at 03:01:41PM +0200, Stefan Roese wrote:
The STM SPEAr platform can only access the i2c controller register
via 16bit read/write functions. This patch adds support to
automatically detect this 16bit access mode.
On Mon, Apr 02, 2012 at 11:23:02AM +0530, Alok Chauhan wrote:
NACK interrupt generated before I2C controller generates
the STOP condition on bus. In Software, because of this
reset of controller is happening before I2C controller could
complete STOP condition. So wait for some time before
I'll repost the driver with your fix on positive feedback from you.
Thanks for tracking this down.
Ben, is there any chance to get this driver into next?
I think sending a new series would be good. It depends a bit on the amount
of donated tags (Tested-by, especially) if it will make it
On Wed, Apr 18, 2012 at 6:33 PM, Wolfram Sang w.s...@pengutronix.de wrote:
Hi,
We certainly don't want the policy to be against the common practice
of the community. If it is we can consider changing our policy.
Nice, thanks for being open to discussion!
However I can't find a clear
On Mon, Mar 26, 2012 at 02:55:23PM +0900, Tomoya MORINAGA wrote:
Signed-off-by: Tomoya MORINAGA tomoya.r...@gmail.com
Applied.
--
Pengutronix e.K. | Wolfram Sang|
Industrial Linux Solutions | http://www.pengutronix.de/ |
On Mon, Mar 26, 2012 at 02:55:25PM +0900, Tomoya MORINAGA wrote:
Currently, during i2c works alone, wait-event timeout is not occurred.
However, as CPU load increases, timeout occurs frequently.
So, I modified like this patch.
Modifying like this patch, I've never seen the timeout event with
On Mon, Mar 26, 2012 at 02:55:24PM +0900, Tomoya MORINAGA wrote:
Signed-off-by: Tomoya MORINAGA tomoya.r...@gmail.com
Woha, that's copypaste code all over. May I ask to refactor this?
Something like:
rtn = pch_..._wait_for_checked_xfer();
if (rtn)
return rtn;
- if (i2c_data == NULL) {
- dev_err(i2c-dev, no I2C frequency data\n);
+ /*
+* clock-rate is a legacy binding, the official binding is
+* clock-frequency. Try the official one first and then
+* fall back if it doesn't exist.
+*/
+ data =
On 04/18/2012 08:16 AM, Wolfram Sang wrote:
- if (i2c_data == NULL) {
- dev_err(i2c-dev, no I2C frequency data\n);
+ /*
+* clock-rate is a legacy binding, the official binding is
+* clock-frequency. Try the official one first and then
+* fall
On 18.04.2012 15:46, Wolfram Sang wrote:
Optional properties:
+ - gpios: The order of the gpios should be the following: SDA, SCL.
+The gpio specifier depends on the gpio controller. Required in all
cases
+except when samsung,i2c-no-gpio is also specified.
+ -
On Wed, Apr 04, 2012 at 10:34:37AM +0200, Roland Stigge wrote:
In the driver's suspend function, clk_enable() was used instead of
clk_disable(). This is corrected with this patch.
Signed-off-by: Roland Stigge sti...@antcom.de
Reviewed-by: Arnd Bergmann a...@arndb.de
CC:
On Wed, Apr 04, 2012 at 10:34:38AM +0200, Roland Stigge wrote:
As a precondition for device tree conversion, the platforms using i2c-pnx.c
are
converted to using mem and irq resources instead of platform data.
Signed-off-by: Roland Stigge sti...@antcom.de
Reviewed-by: Arnd Bergmann
On Wed, Apr 04, 2012 at 10:34:39AM +0200, Roland Stigge wrote:
The platforms using i2c-pnx.c both defined a duplicated i2c.h (used nowhere
else). This patch removes those and integrates the contents into the driver
itself.
Signed-off-by: Roland Stigge sti...@antcom.de
Reviewed-by: Arnd
On Wed, Apr 04, 2012 at 10:34:40AM +0200, Roland Stigge wrote:
This patch adds device tree support to the pnx-i2c driver by using platform
resources for memory region and irq and removing dependency on mach includes.
The following platforms are affected:
* PNX
* LPC31xx (WIP)
* LPC32xx
On 04/18/2012 08:27 AM, Wolfram Sang wrote:
On Mon, Apr 02, 2012 at 11:23:02AM +0530, Alok Chauhan wrote:
NACK interrupt generated before I2C controller generates
the STOP condition on bus. In Software, because of this
reset of controller is happening before I2C controller could
complete STOP
Applied with Stephen's ACK and slightly reworded comment and commit msg.
Wondering a bit that you want it for 3.5, not for 3.4. Looks like a
bugfix to me.
Yes, applying this to 3.4 would make sense. When I said for 3.5
earlier, I meant I'd like it to at least get into 3.5 not later.
32 matches
Mail list logo
