Re: [PATCH 5/5] i2c: riic: add driver

2013-12-18 Thread Geert Uytterhoeven
CC devicet...@vger.kernel.org for the bindings part. On Tue, Dec 17, 2013 at 10:44 PM, Wolfram Sang w...@the-dreams.de wrote: From: Wolfram Sang w...@sang-engineering.com Tested with a r7s72100 genmai board acessing an eeprom. Signed-off-by: Wolfram Sang w...@sang-engineering.com ---

Re: [PATCH 2/5] arm: shmobile: r7s72100: add i2c clocks

2013-12-18 Thread Sergei Shtylyov
Hello. On 18-12-2013 1:44, Wolfram Sang wrote: From: Wolfram Sang w...@sang-engineering.com Tested with RIIC2 on a genmai board. Others untested but hopefully trivial enough to be added. Signed-off-by: Wolfram Sang w...@sang-engineering.com Acked-by: Magnus Damm d...@opensource.se ---

Re: [PATCH 4/5] arm: shmobile: genmai: adapt dts to use native i2c driver

2013-12-18 Thread Sergei Shtylyov
Hello. On 18-12-2013 1:44, Wolfram Sang wrote: From: Wolfram Sang w...@sang-engineering.com Switch from the gpio-driver to the shiny new native driver. Tested by accessing the eeprom on the genmai board. Signed-off-by: Wolfram Sang w...@sang-engineering.com Acked-by: Magnus Damm

Re: [PATCH 2/5] arm: shmobile: r7s72100: add i2c clocks

2013-12-18 Thread Wolfram Sang
@@ -173,6 +179,10 @@ static struct clk_lookup lookups[] = { CLKDEV_CON_ID(mtu2_fck, mstp_clks[MSTP33]), /* ICK */ +CLKDEV_DEV_ID(fcfee000.i2c, mstp_clks[MSTP97]), +CLKDEV_DEV_ID(fcfee400.i2c, mstp_clks[MSTP96]), +CLKDEV_DEV_ID(fcfee800.i2c, mstp_clks[MSTP95]), +

Re: [PATCH 2/5] arm: shmobile: r7s72100: add i2c clocks

2013-12-18 Thread Wolfram Sang
On Wed, Dec 18, 2013 at 03:53:45PM +0400, Sergei Shtylyov wrote: On 18-12-2013 15:43, Wolfram Sang wrote: @@ -173,6 +179,10 @@ static struct clk_lookup lookups[] = { CLKDEV_CON_ID(mtu2_fck, mstp_clks[MSTP33]), /* ICK */ + CLKDEV_DEV_ID(fcfee000.i2c, mstp_clks[MSTP97]), +

Re: [PATCH 2/5] arm: shmobile: r7s72100: add i2c clocks

2013-12-18 Thread Simon Horman
On Wed, Dec 18, 2013 at 01:15:42PM +0100, Wolfram Sang wrote: On Wed, Dec 18, 2013 at 03:53:45PM +0400, Sergei Shtylyov wrote: On 18-12-2013 15:43, Wolfram Sang wrote: @@ -173,6 +179,10 @@ static struct clk_lookup lookups[] = { CLKDEV_CON_ID(mtu2_fck, mstp_clks[MSTP33]),

Re: [PATCH 2/5] arm: shmobile: r7s72100: add i2c clocks

2013-12-18 Thread Sergei Shtylyov
Hello. On 18-12-2013 17:49, Simon Horman wrote: @@ -173,6 +179,10 @@ static struct clk_lookup lookups[] = { CLKDEV_CON_ID(mtu2_fck, mstp_clks[MSTP33]), /* ICK */ + CLKDEV_DEV_ID(fcfee000.i2c, mstp_clks[MSTP97]), + CLKDEV_DEV_ID(fcfee400.i2c, mstp_clks[MSTP96]), +

Re: [PATCH 2/5] arm: shmobile: r7s72100: add i2c clocks

2013-12-18 Thread Magnus Damm
On Wed, Dec 18, 2013 at 11:02 PM, Sergei Shtylyov sergei.shtyl...@cogentembedded.com wrote: Hello. On 18-12-2013 17:49, Simon Horman wrote: @@ -173,6 +179,10 @@ static struct clk_lookup lookups[] = { CLKDEV_CON_ID(mtu2_fck, mstp_clks[MSTP33]), /* ICK */ +

Re: [PATCH 2/5] arm: shmobile: r7s72100: add i2c clocks

2013-12-18 Thread Sergei Shtylyov
Hello. On 18-12-2013 18:44, Magnus Damm wrote: @@ -173,6 +179,10 @@ static struct clk_lookup lookups[] = { CLKDEV_CON_ID(mtu2_fck, mstp_clks[MSTP33]), /* ICK */ + CLKDEV_DEV_ID(fcfee000.i2c, mstp_clks[MSTP97]), + CLKDEV_DEV_ID(fcfee400.i2c, mstp_clks[MSTP96]),

Re: [PATCH 2/2] i2c: exynos5: configure fifo_depth based on HSI2C module version

2013-12-18 Thread Tomasz Figa
On Tuesday 10 of December 2013 10:26:40 Naveen Krishna Ch wrote: Hello Tomasz, On 9 December 2013 22:01, Tomasz Figa t.f...@samsung.com wrote: Hi Naveen, On Friday 22 of November 2013 11:44:11 Naveen Krishna Chatradhi wrote: fifo_depth of the HSI2C is not constant Exynos5420

Re: [PATCH 2/5] arm: shmobile: r7s72100: add i2c clocks

2013-12-18 Thread Wolfram Sang
I am unsure of the historical reason for this but it does seem to be consistent. Okay, I'll follow that. signature.asc Description: Digital signature

[PATCH V2 0/5] arm: shmobile: r7s72100: add native i2c support

2013-12-18 Thread Wolfram Sang
Here is a series to support the I2C core of the r7s72100 natively. It has been tested with a genmai board where an eeprom is connected. The series can be found here: git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git renesas/riic It is based on the latest r7s72100 topic branch from

[PATCH V2 3/5] arm: shmobile: r7s72100: add nodes for i2c controllers to dtsi

2013-12-18 Thread Wolfram Sang
From: Wolfram Sang w...@sang-engineering.com I decided to put the pinmuxing into the dtsi file since there is only one pinmux posiibility which one probably wants to have when using the bus. Signed-off-by: Wolfram Sang w...@sang-engineering.com Acked-by: Magnus Damm d...@opensource.se ---

[PATCH V2 2/5] arm: shmobile: r7s72100: add i2c clocks

2013-12-18 Thread Wolfram Sang
From: Wolfram Sang w...@sang-engineering.com Tested with RIIC2 on a genmai board. Others untested but hopefully trivial enough to be added. Signed-off-by: Wolfram Sang w...@sang-engineering.com Acked-by: Magnus Damm d...@opensource.se --- V2: adapt to established sorting

[PATCH V2 1/5] pinctrl: r7s72100: add riic groups

2013-12-18 Thread Wolfram Sang
From: Wolfram Sang w...@sang-engineering.com Tested RIIC2 on a genmai board. Other riic groups are untested but seem trivial enough to be added. Signed-off-by: Wolfram Sang w...@sang-engineering.com Acked-by: Magnus Damm d...@opensource.se --- V2: keep sorting alphabetical Note: With the

[PATCH V2 4/5] arm: shmobile: genmai: adapt dts to use native i2c driver

2013-12-18 Thread Wolfram Sang
From: Wolfram Sang w...@sang-engineering.com Switch from the gpio-driver to the shiny new native driver. Tested by accessing the eeprom on the genmai board. Signed-off-by: Wolfram Sang w...@sang-engineering.com Acked-by: Magnus Damm d...@opensource.se --- V2: fixed the eeprom label

[PATCH V2 5/5] i2c: riic: add driver

2013-12-18 Thread Wolfram Sang
From: Wolfram Sang w...@sang-engineering.com Tested with a r7s72100 genmai board acessing an eeprom. Signed-off-by: Wolfram Sang w...@sang-engineering.com --- V2: fixed the name typo in the binding docs Documentation/devicetree/bindings/i2c/i2c-riic.txt | 29 ++ drivers/i2c/busses/Kconfig

Re: [PATCH V2 1/5] pinctrl: r7s72100: add riic groups

2013-12-18 Thread Wolfram Sang
On Wed, Dec 18, 2013 at 10:31:57PM +0100, Wolfram Sang wrote: From: Wolfram Sang w...@sang-engineering.com Tested RIIC2 on a genmai board. Other riic groups are untested but seem trivial enough to be added. Signed-off-by: Wolfram Sang w...@sang-engineering.com Acked-by: Magnus Damm

Re: [PATCH V2 5/5] i2c: riic: add driver

2013-12-18 Thread Laurent Pinchart
Hi Wolfram, Thank you for the patch. As this patch adds DT bindings, please remember to CC the devicetree mailing list (which I have CC'ed on this reply). On Wednesday 18 December 2013 22:32:01 Wolfram Sang wrote: From: Wolfram Sang w...@sang-engineering.com Tested with a r7s72100 genmai