Re: [PATCH v2 07/10] mfd: cros_ec: cleanup: Remove EC wrapper functions

2014-07-03 Thread Lee Jones
On Wed, 18 Jun 2014, Doug Anderson wrote: From: Bill Richardson wfric...@chromium.org Remove the three wrapper functions that talk to the EC without passing all the desired arguments and just use the underlying communication function that passes everything in a struct intead. This is

Re: [PATCH v2 09/10] mfd: cros_ec: ec_dev-cmd_xfer() returns number of bytes received from EC

2014-07-03 Thread Lee Jones
On Wed, 18 Jun 2014, Doug Anderson wrote: From: Bill Richardson wfric...@chromium.org When communicating with the EC, the cmd_xfer() function should return the number of bytes it received from the EC, or negative on error. Signed-off-by: Bill Richardson wfric...@chromium.org

Re: [PATCH v2] i2c: busses: i2c-pxa.c: Fix for possible null pointer dereferenc

2014-07-03 Thread Wolfram Sang
Hi Rickard, hi Jingoo, I also trust Wolfram. He is one of the most important and active person for Linux kernel. Oh, thanks. I'm flattered :) Wolfram may mean devm_ioremap_resource(), not devm_ioremap(). Yes, you are right. Sorry for missing this detail when suggesting an example to convert

Re: [PATCH/RFC V8 1/1] clk: Support for clock parents and rates assigned from device tree

2014-07-03 Thread Sylwester Nawrocki
On 18/06/14 17:29, Sylwester Nawrocki wrote: This patch adds helper functions to configure clock parents and rates as specified through 'assigned-clock-parents', 'assigned-clock-rates' DT properties for a clock provider or clock consumer device. The helpers are now being called by the bus code

Re: [PATCH v2] i2c: busses: i2c-pxa.c: Fix for possible null pointer dereferenc

2014-07-03 Thread Rickard Strandqvist
2014-07-03 10:41 GMT+02:00 Wolfram Sang w...@the-dreams.de: Hi Rickard, hi Jingoo, I also trust Wolfram. He is one of the most important and active person for Linux kernel. Oh, thanks. I'm flattered :) Wolfram may mean devm_ioremap_resource(), not devm_ioremap(). Yes, you are right.

[PATCH v3] i2c: busses: i2c-pxa.c: Fix for possible null pointer dereferenc

2014-07-03 Thread Rickard Strandqvist
After discussion with especially Wolfram and Jingoo it was decided to convert the code to use the Managed Device Resource. I lack this kind of hardware so preferably should someone do a HW test. Rickard Strandqvist (1): i2c: busses: i2c-pxa.c: Fix for possible null pointer dereferenc

[PATCH v3] i2c: busses: i2c-pxa.c: Fix for possible null pointer dereferenc

2014-07-03 Thread Rickard Strandqvist
Fix for possible null pointer dereferenc, and there is a risk for memory leak if something unexpected happens and the function returns. It now use Managed Device Resource instead. Signed-off-by: Rickard Strandqvist rickard_strandqv...@spectrumdigital.se --- drivers/i2c/busses/i2c-pxa.c | 37

Re: [PATCH v3] i2c: busses: i2c-pxa.c: Fix for possible null pointer dereferenc

2014-07-03 Thread Jingoo Han
On Friday, July 04, 2014 5:19 AM, Rickard Strandqvist wrote: Fix for possible null pointer dereferenc, and there is a risk for memory leak if something unexpected s/dereferenc/dereference The columns of this commit is too long. Please keep about 80 columns. happens and the function