[PATCH] i2c: s3c2410: Don't enable PM runtime on the adapter device

2015-04-16 Thread Charles Keepax
Commit 523c5b89640e (i2c: Remove support for legacy PM) removed the PM ops from the bus type, which causes the pm operations on the s3c2410 adapter device to fail (-ENOSUPP in rpm_callback). The adapter device doesn't get bound to a driver and as such can't have its own pm_runtime callbacks.

Re: [PATCH V3 2/6] i2c: qup: Add V2 tags support

2015-04-16 Thread Ivan T. Ivanov
Hi Sricharan, On Wed, 2015-04-15 at 20:14 +0530, Sricharan R wrote: +#define QUP_I2C_MX_CONFIG_DURING_RUN BIT(31) Could you explain what is this for? This is a new feature in the V2 version of the controller, to support multiple i2c sub transfers

Re: [PATCH v1] HID: bug fixes in hid-cp2112 driver

2015-04-16 Thread Ellen Wang
[Sorry. Thunderbird did some weird stuff to my message. Here it is again.] Thanks for the quick reply. On 04/16/2015 12:41 AM, Wolfram Sang wrote: On Wed, Apr 15, 2015 at 05:22:26PM -0700, Ellen Wang wrote: 1. cp2112_xfer() byte swaps smbus words incorrectly: While i2c is by and large big

Re: [PATCH v1] HID: bug fixes in hid-cp2112 driver

2015-04-16 Thread Wolfram Sang
On Wed, Apr 15, 2015 at 05:22:26PM -0700, Ellen Wang wrote: 1. cp2112_xfer() byte swaps smbus words incorrectly: While i2c is by and large big endian, smbus transactions are little endian. This only affects word operands. Essentially, all occurences of be16 in cp2112_xfer() are now le16.

Re: [PATCH V3 2/6] i2c: qup: Add V2 tags support

2015-04-16 Thread Sricharan R
Hi Ivan, On 04/16/2015 02:06 PM, Ivan T. Ivanov wrote: Hi Sricharan, On Wed, 2015-04-15 at 20:14 +0530, Sricharan R wrote: +#define QUP_I2C_MX_CONFIG_DURING_RUN BIT(31) Could you explain what is this for? This is a new feature in the V2 version of the controller, to

Re: [PATCH] i2c: s3c2410: Don't enable PM runtime on the adapter device

2015-04-16 Thread Charles Keepax
On Thu, Apr 16, 2015 at 12:39:43PM +0200, Lars-Peter Clausen wrote: On 04/16/2015 12:33 PM, Sylwester Nawrocki wrote: On 16/04/15 12:10, Charles Keepax wrote: Commit 523c5b89640e (i2c: Remove support for legacy PM) removed the PM ops from the bus type, which causes the pm operations on the

[PATCH v2] i2c: Mark adapter devices with pm_runtime_no_callbacks

2015-04-16 Thread Charles Keepax
Commit 523c5b89640e (i2c: Remove support for legacy PM) removed the PM ops from the bus type, which causes the pm operations on the s3c2410 adapter device to fail (-ENOSUPP in rpm_callback). The adapter device doesn't get bound to a driver and as such can't have its own pm_runtime callbacks.

Re: [PATCH] i2c: s3c2410: Don't enable PM runtime on the adapter device

2015-04-16 Thread Sylwester Nawrocki
On 16/04/15 12:10, Charles Keepax wrote: Commit 523c5b89640e (i2c: Remove support for legacy PM) removed the PM ops from the bus type, which causes the pm operations on the s3c2410 adapter device to fail (-ENOSUPP in rpm_callback). The adapter device doesn't get bound to a driver and as such

Re: [PATCH] i2c: s3c2410: Don't enable PM runtime on the adapter device

2015-04-16 Thread Lars-Peter Clausen
On 04/16/2015 12:33 PM, Sylwester Nawrocki wrote: On 16/04/15 12:10, Charles Keepax wrote: Commit 523c5b89640e (i2c: Remove support for legacy PM) removed the PM ops from the bus type, which causes the pm operations on the s3c2410 adapter device to fail (-ENOSUPP in rpm_callback). The adapter

Re: [PATCH v2] i2c: Mark adapter devices with pm_runtime_no_callbacks

2015-04-16 Thread Beata Michalska
On 04/16/2015 02:05 PM, Charles Keepax wrote: Commit 523c5b89640e (i2c: Remove support for legacy PM) removed the PM ops from the bus type, which causes the pm operations on the s3c2410 adapter device to fail (-ENOSUPP in rpm_callback). The adapter device doesn't get bound to a driver and as

[PATCH 0/2] i2c: rework last users of 2.4 style attach_adapter

2015-04-16 Thread Wolfram Sang
The attach_adapter mechanism of the I2C framework is deprecated for years. There are two users left; drivers for old Macintosh computers. I got the idea of replacing this mechanism with a custom one with the help of deferred probing. Because I don't have the hardware, I modified the windtunnel

[PATCH 1/2] macintosh: therm_windtunnel: drop using attach adapter

2015-04-16 Thread Wolfram Sang
As we now have deferred probing, we can use a custom mechanism and finally get rid of the legacy interface from the i2c core. Signed-off-by: Wolfram Sang w...@the-dreams.de --- drivers/macintosh/therm_windtunnel.c | 25 +++-- 1 file changed, 23 insertions(+), 2 deletions(-)

Re: [V2 1/2] i2c: brcmstb: Add Broadcom settop SoC i2c controller driver

2015-04-16 Thread Kamal Dasu
On Tue, Apr 14, 2015 at 4:39 PM, Ray Jui r...@broadcom.com wrote: Hi Kamal, + bcm-kernel-feedback-list bcm-kernel-feedback-l...@broadcom.com On 4/14/2015 6:47 AM, Wolfram Sang wrote: On Thu, Apr 02, 2015 at 04:01:05PM -0400, Kamal Dasu wrote: Adding support for i2c controller driver for

Re: [V2 1/2] i2c: brcmstb: Add Broadcom settop SoC i2c controller driver

2015-04-16 Thread Kamal Dasu
Rajeev, Thanks for the review. Answers inline. Kamal On Wed, Apr 15, 2015 at 3:21 AM, rajeev kumar rajeevkumar.li...@gmail.com wrote: On Fri, Apr 3, 2015 at 1:31 AM, Kamal Dasu kdasu.k...@gmail.com wrote: Adding support for i2c controller driver for Broadcom settop SoCs. Signed-off-by:

[PATCH] omap: i2c: Add calls for pinctrl state select

2015-04-16 Thread pascal . huerst
From: Pascal Huerst pascal.hue...@gmail.com This adds calls to pinctrl subsystem in order to switch pin states on suspend/resume if you provide a sleep state in DT. --- drivers/i2c/busses/i2c-omap.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/i2c/busses/i2c-omap.c

[PATCH -next] i2c: remove duplicated include from i2c-digicolor.c

2015-04-16 Thread weiyj_lk
From: Wei Yongjun yongjun_...@trendmicro.com.cn Remove duplicated include. Signed-off-by: Wei Yongjun yongjun_...@trendmicro.com.cn --- drivers/i2c/busses/i2c-digicolor.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/i2c/busses/i2c-digicolor.c b/drivers/i2c/busses/i2c-digicolor.c

Re: [PATCH -next] i2c: remove duplicated include from i2c-digicolor.c

2015-04-16 Thread Wolfram Sang
On Thu, Apr 16, 2015 at 09:10:12PM +0800, weiyj...@163.com wrote: From: Wei Yongjun yongjun_...@trendmicro.com.cn Remove duplicated include. Signed-off-by: Wei Yongjun yongjun_...@trendmicro.com.cn Yes, but please sort the includes to prevent this from happening again in the future.

[PATCH 2/2] sound: ppc: keywest: drop using attach adapter

2015-04-16 Thread Wolfram Sang
As we now have deferred probing, we can use a custom mechanism and finally get rid of the legacy interface from the i2c core. Signed-off-by: Wolfram Sang w...@the-dreams.de --- sound/ppc/keywest.c | 23 +++ 1 file changed, 19 insertions(+), 4 deletions(-) diff --git

Re: [V2 1/2] i2c: brcmstb: Add Broadcom settop SoC i2c controller driver

2015-04-16 Thread rajeev kumar
On Thu, Apr 16, 2015 at 9:40 PM, Kamal Dasu kdasu.k...@gmail.com wrote: Rajeev, Thanks for the review. Answers inline. Kamal On Wed, Apr 15, 2015 at 3:21 AM, rajeev kumar rajeevkumar.li...@gmail.com wrote: On Fri, Apr 3, 2015 at 1:31 AM, Kamal Dasu kdasu.k...@gmail.com wrote: Adding

Need some guidance on i2c-ocores driver

2015-04-16 Thread York Sun
Julia and other experts, I am seeking for help on my device driver. I am working on a module driver for a FPGA design with open core I2C controller memory-mapped to BAR2. I have searched up and down and found only one driver (drivers/mfd/timberdale.c) with similar implementation. Following