Re: [PATCH 0/9] i2c: add generic support for timing parameters in DT
On Thu, Dec 03, 2015 at 04:51:30PM +0100, Wolfram Sang wrote: > Here is a patch series adding better DT support for timing parameters like the > raise time or the fall time which are generic for the I2C subsystem. There is > a > core function for parsing and an implementation for the RCar driver how to use > it. > > I added people of the designware and rk3x driver to CC because they might be > interested in this new function. They provided the basis for this series, so > it > should be easy to convert them. > > Please have a look, test, comment... > > Thanks, > > Wolfram > > > Changes since RFC: > * better tested > * added documentation for the new function and the new struct > * reworded some commit messages slightly > * moved the new property in the dtsi above the "status" property > > > Wolfram Sang (9): > i2c: document generic DT bindings for timing parameters > i2c: add generic routine to parse DT for timing information > i2c: rcar: refactor probe function a little > i2c: rcar: switch to i2c generic dt parsing > i2c: rcar: honor additional i2c timings from DT I have marked the integration patches (below) as deferred pending acceptance of the driver changes (above). Please repost the former once the latter have been accepted (by you :). > ARM: shmobile: r8a7790: dtsi: add internal delay for i2c IPs > ARM: shmobile: r8a7791: dtsi: add internal delay for i2c IPs > ARM: shmobile: r8a7794: dtsi: add internal delay for i2c IPs > arm64: renesas: r8a7795: add internal delay for i2c IPs > > Documentation/devicetree/bindings/i2c/i2c-rcar.txt | 4 ++ > Documentation/devicetree/bindings/i2c/i2c.txt | 31 -- > arch/arm/boot/dts/r8a7790.dtsi | 4 ++ > arch/arm/boot/dts/r8a7791.dtsi | 6 ++ > arch/arm/boot/dts/r8a7794.dtsi | 6 ++ > arch/arm64/boot/dts/renesas/r8a7795.dtsi | 7 +++ > drivers/i2c/busses/i2c-rcar.c | 67 > +++--- > drivers/i2c/i2c-core.c | 50 > include/linux/i2c.h| 22 +++ > 9 files changed, 158 insertions(+), 39 deletions(-) > > -- > 2.1.4 > -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [Patch V1] i2c: imx: init bus recovery info before adding i2c adapter
Hi Wolfram, Sorry for it. I have sent out an i2c runtime patch which was acked by Uwe Kleine. I thought it would be accepted, so I sent out this one based on that one. Best Regards Gao Pan > -Original Message- > From: Wolfram Sang [mailto:w...@the-dreams.de] > Sent: Sunday, December 06, 2015 3:08 AM > To: Gao Pan-B54642 > Cc: u.kleine-koe...@pengutronix.de; linux-i2c@vger.kernel.org; Li > Frank-B20596; > Duan Fugang-B38611; ker...@pengutronix.de > Subject: Re: [Patch V1] i2c: imx: init bus recovery info before adding i2c > adapter > > On Fri, Dec 04, 2015 at 05:33:14PM +0800, Gao Pan wrote: > > During driver probe, i2c_imx_init_recovery_info() must come before > > i2c_add_numbered_adapter(), because the get/set_scl() functions are > > assigned in i2c_register_adapter() under the conditon that bus > > recover_info are initialized. Otherwise, get/set_scl() function > > pointers never get assigned. > > > > In such case, when i2c_generic_gpio_recovery() is used for bus > > recovery, there will be kernel crash because bri->set_scl is NULL. > > > > The solution to this bug is moving i2c_imx_init_recovery_info() before > > i2c_register_adapter(). > > > > Signed-off-by: Gao Pan > > Signed-off-by: Fugang Duan > > Makes sense, but I can't apply this one. What is it based on? --- Begin Message --- Hello, On Mon, Nov 30, 2015 at 03:42:15AM +, Gao Pandy wrote: > Ping... The things I pointed out were fixed. I didn't test it, but the patch looks reasonable. I'd say it's ready to cook in next until the merge window opens next time. If you want to interpret this as an Ack, feel free to do this. Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König| Industrial Linux Solutions | http://www.pengutronix.de/ | --- End Message ---
Re: [PATCH v2 00/16] intel-lpss: support non-ACPI platforms
On Monday, November 30, 2015 05:11:28 PM Andy Shevchenko wrote: > This series includes few logical sets that bring a support of non-ACPI > platforms for Intel Skylake. > > First part is a refactoring of built-in device properties support: > - keep single value inside the structure > - provide helper macros to define built-in properties > - fall back to secondary fwnode if primary has no asked property > > Second is a propagating built-in device properties in platform core. > > Third one is modifications to MFD code and intel-lpss.c driver in particular > to define and pass built-in properties to the individual drivers. > > And last part is a fix for I2C bug found on Lenovo Yoga hardware and a first > converted user. > > Built-in device properties is an alternative to platform data. It provides a > unified API that drivers can use to cover all cases at once: DT, ACPI, and > built-in properties. > > With this series applied a platform data can be considered obsolete. Moreover, > built-in device properties allow to adjust the existing configuration, for > example, in cases when ACPI values are wrong on some platforms. > > The series has been tested on available hardware and doesn't break current > behaviour. But we ask people who have the affected hardware to apply the > series > on your side and check with Lenovo hardware. > > Changelog v2: > - fix isuues found by kbuild bot (kbuild) > - append a patch to propagate device properties in polatform code (Arnd) > - update few existing and add couple of new patches due to above > - check with kmemleak > > Andy Shevchenko (9): > device property: always check for fwnode type > device property: rename helper functions > device property: refactor built-in properties support > device property: keep single value inplace > device property: improve readability of macros > device property: return -EINVAL when property isn't found in ACPI > device property: Fallback to secondary fwnode if primary misses the > property > mfd: core: propagate device properties to sub devices drivers > mfd: intel-lpss: Pass HSUART configuration via properties > > Heikki Krogerus (1): > device property: helper macros for property entry creation > > Mika Westerberg (6): > device property: Take a copy of the property set > driver core: platform: Add support for built-in device properties > driver core: Do not overwrite secondary fwnode with NULL if it is set > mfd: intel-lpss: Add support for passing device properties > mfd: intel-lpss: Pass SDA hold time to I2C host controller driver > i2c: designware: Convert to use unified device property API I'm going to queue up this series for v4.5. If there are any problems with it or objections from anyone, please let me know. Thanks, Rafael -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
