Re: [PATCH][resend] iMX/MXC support for I2C

2008-12-03 Thread Ben Dooks
On Wed, Dec 03, 2008 at 12:17:58PM +0100, Guennadi Liakhovetski wrote: The good news is - I was able to get this driver running on i.MX31 - somewhat... Now the comments: On Tue, 2 Dec 2008, Darius wrote: Commenting would have been easier, if you had inlined your patch... From [EMAIL

Re: [PATCH][resend] iMX/MXC support for I2C

2008-12-03 Thread Ben Dooks
On Wed, Dec 03, 2008 at 10:19:32PM +0100, Guennadi Liakhovetski wrote: On Wed, 3 Dec 2008, Darius wrote: Guennadi Liakhovetski wrote: + +static int i2c_imx_trx_complete(struct imx_i2c_struct *i2c_imx) +{ + int result; + + result =

Re: [PATCH][resend] iMX/MXC support for I2C

2008-12-03 Thread Ben Dooks
On Wed, Dec 03, 2008 at 09:58:10PM +0100, Guennadi Liakhovetski wrote: Hi Darius, it would be better, if you didn't drop my email from cc, thanks. On Wed, 3 Dec 2008, Darius wrote: Guennadi Liakhovetski wrote: One more thing: you also want to do something like this

Re: GPIO: Fix probe() error return in gpio driver probes

2008-12-14 Thread Ben Dooks
On Fri, Dec 12, 2008 at 03:24:27PM +, Ben Dooks wrote: A number of drivers in drivers/gpio return -ENODEV when confronted with missing setup parameters such as the platform data. However, returning -ENODEV causes the driver layer to silently ignore the driver as it assumes the probe did

Re: GPIO: Fix probe() error return in gpio driver probes

2008-12-15 Thread Ben Dooks
On Mon, Dec 15, 2008 at 08:46:00AM +0100, Jean Delvare wrote: On Sun, 14 Dec 2008 16:11:17 -0800, David Brownell wrote: On Sunday 14 December 2008, Ben Dooks wrote: Has anyone reveiwed this patch? Are there any comments, or can this be commited at somepoint (even if it is during the next

Re: [PATCH 4/28] drivers/ide: Drop return value from platform_driver remove functions

2008-12-16 Thread Ben Dooks
On Wed, Dec 10, 2008 at 05:27:56PM +0100, Julia Lawall wrote: From: Julia Lawall ju...@diku.dk The return value of the remove function of a driver structure, and thus of a platform_driver structure, is ultimately ignored, and is thus unnecessary. This patch removes the return value for the

Please pull bjdoo ks' i2c-fixes

2008-12-16 Thread Ben Dooks
The following changes since commit 1bda71282ded6a2e09a2db7c8884542fb46bfd4f: Linus Torvalds (1): Merge branch 'for-linus' of git://git.kernel.org/.../ieee1394/linux1394-2.6 are available in the git repository at: git://aeryn.fluff.org.uk/bjdooks/linux.git i2c-fixes Ben Dooks (1

Re: [PATCH v2] iMX/MXC support for I2C

2008-12-16 Thread Ben Dooks
On Mon, Dec 08, 2008 at 12:08:01PM +0200, Darius wrote: From: Darius Augulis augulis.dar...@gmail.com Implementation of I2C Adapter/Algorithm Driver for I2C Bus integrated in Freescale's i.MX/MXC processors. Tested only on MX1, but should work on MX2 and MX3 too, because all three

Re: [PATCH 10/12] i2c-omap: convert 'rev1' flag to generic 'rev' u8

2008-12-16 Thread Ben Dooks
On Tue, Dec 16, 2008 at 09:59:59PM +, Ben Dooks wrote: On Fri, Nov 28, 2008 at 05:34:57PM -0800, Tony Lindgren wrote: From: Paul Walmsley p...@pwsan.com i2c-omap discriminates only between revision 1 or greater than revision 1. A following patch introduces code that must also

Re: Dynamically-allocated i2c_device_id vs MODULE_DEVICE_TABLE

2009-01-24 Thread Ben Dooks
On Fri, Jan 23, 2009 at 03:03:19PM -0600, Timur Tabi wrote: I currently have this in my code: static const struct i2c_device_id cs4270_id[] = { {cs4270, 0}, {} }; MODULE_DEVICE_TABLE(i2c, cs4270_id); static struct i2c_driver cs4270_i2c_driver = { .driver = {

Re: [PATCH] I2C: OMAP: Include OMAP_I2C_SYSC_REG in save and restore

2009-02-02 Thread Ben Dooks
On Fri, Jan 23, 2009 at 12:24:45PM +0530, Pakaravoor, Jagadeesh wrote: From: Jagadeesh Bhaskar Pakaravoor j-pakarav...@ti.com Save and restore should include OMAP_I2C_SYSC_REG. is this necessary for inclusion as a bugfix, or can it wait for a merge window? -- Ben (b...@fluff.org,

Re: [PATCH 1/2] i2c: add reset sysfs entry for adapters.

2009-02-09 Thread Ben Dooks
On Fri, Feb 06, 2009 at 04:23:17PM +0100, Rodolfo Giometti wrote: It could happen that an i2c adapter may lock the bus due due electrical problems, so the user may recover this stale state by using: $ echo 1 /sys/class/i2c-adapter/i2c-0/reset Signed-off-by: Rodolfo Giometti

Re: [PATCH] i2c-mpc: do not allow interruptions when waiting for I2C to complete

2009-02-10 Thread Ben Dooks
On Tue, Feb 10, 2009 at 10:21:04AM -0600, Timur Tabi wrote: Jean Delvare wrote: To the best of my knowledge i2c-mpc falls into the embedded platforms category and is thus under Ben's responsibility. I don't see his Signed-off-by on any patch to i2c-mpc.c for the past three years (at

Re: [PATCH 3/4] imxmmc: add MX1 support

2009-03-25 Thread Ben Dooks
On Wed, Mar 25, 2009 at 12:59:29PM +0100, Wolfram Sang wrote: Regarding the I2C-driver, I will try to clean up things as I see them. Is there some reason why Jean or the I2C mailing list couldn't have been sent this driver instead of just Ben (or was it, and they didn't respond)? It

Re: what is in bjdooks' i2c-for-2630 tree

2009-03-27 Thread Ben Dooks
On Fri, Mar 27, 2009 at 06:25:22PM +, Mark Brown wrote: On Fri, Mar 27, 2009 at 11:02:10AM +, Ben Dooks wrote: The following changes since commit 8e0ee43bc2c3e19db56a4adaa9a9b04ce885cd84: Linus Torvalds (1): Linux 2.6.29 are available in the git repository

Re: [patch 1/5] i2c: xtensa s6000 i2c driver

2009-03-31 Thread Ben Dooks
On Tue, Mar 31, 2009 at 11:52:58PM +0100, Ben Dooks wrote: On Mon, Mar 23, 2009 at 04:05:14PM +0100, Daniel Gl??ckner wrote: From: Oskar Schirmer o...@emlix.com Support for the s6000 on-chip i2c controller. Signed-off-by: Oskar Schirmer o...@emlix.com Signed-off-by: Daniel Gl??ckner

Re: [patch 1/5] i2c: xtensa s6000 i2c driver

2009-03-31 Thread Ben Dooks
On Mon, Mar 23, 2009 at 04:05:14PM +0100, Daniel Gl??ckner wrote: From: Oskar Schirmer o...@emlix.com Support for the s6000 on-chip i2c controller. Signed-off-by: Oskar Schirmer o...@emlix.com Signed-off-by: Daniel Gl??ckner d...@emlix.com Not going to merge this on my first pull request

Please pull bjdooks' i2c tree

2009-03-31 Thread Ben Dooks
The following changes since commit 8e0ee43bc2c3e19db56a4adaa9a9b04ce885cd84: Linus Torvalds (1): Linux 2.6.29 are available in the git repository at: git://aeryn.fluff.org.uk/bjdooks/linux.git i2c-for-2630 Ben Dooks (1): i2c-s3c2410: sda_delay should be in ns, not clock ticks

pull request for bjdooks' i2c tree

2009-04-07 Thread Ben Dooks
a double free in nfs_parse_mount_options() are available in the git repository at: git://aeryn.fluff.org.uk/bjdooks/linux.git i2c-for-2630-v2 Ben Dooks (1): i2c-s3c2410: sda_delay should be in ns, not clock ticks Daniel Silverstone (1): i2c-s3c2410: Simplify bus frequency

Re: [PATCH] i2c-cpm: Pass dev ptr to dma_*_coherent rather than NULL

2009-04-22 Thread Ben Dooks
On Tue, Apr 21, 2009 at 10:11:51AM -0500, Kumar Gala wrote: On Apr 21, 2009, at 7:49 AM, Mark Ware wrote: Recent DMA changes result in a BUG() when NULL is passed to dma_alloc_coherent in place of a device. Signed-off-by: Mark Ware mw...@elphinstone.net --- This patch fixes the BUG()

Re: [PATCH] i2c-cpm: Pass dev ptr to dma_*_coherent rather than NULL

2009-05-03 Thread Ben Dooks
On Wed, Apr 29, 2009 at 08:43:14AM -0500, Kumar Gala wrote: On Apr 22, 2009, at 4:56 PM, Ben Dooks wrote: On Tue, Apr 21, 2009 at 10:11:51AM -0500, Kumar Gala wrote: On Apr 21, 2009, at 7:49 AM, Mark Ware wrote: Recent DMA changes result in a BUG() when NULL is passed

Re: pxa i2c unit busy caused unrecoverable phone hang problem

2009-05-03 Thread Ben Dooks
On Mon, Apr 27, 2009 at 11:32:26PM +0800, ?? wrote: Hi, As a compromise,we hope make the phone system free to run even the i2c subsystem become busy already.Then there maybe time to choose some useful way to solve that. The console can not input when phone hang now. So we try to make

i2c fixes for 2.6.30-rc5

2009-05-03 Thread Ben Dooks
Currently, I've got the following in my tree, if anyone thinks i've missed anything, then let me know before the end of Tuesday (5th) and I'll add it to the pull request. The following changes since commit 091438dd5668396328a3419abcbc6591159eb8d1: Linus Torvalds (1): Linux 2.6.30-rc4

Re: [PATCH] ST DDC I2C bus driver v1

2009-05-05 Thread Ben Dooks
On Tue, May 05, 2009 at 01:52:22PM +0200, Linus Walleij wrote: This adds support for the ST Microelectronic DDC I2C bus driver. This bus is used in the U300 architecture recently added to RMK:s ARM tree. (Patch based on 2.6.30-rc4.) Signed-off-by: Linus Walleij linus.wall...@stericsson.com

Re: [PATCH] Use resource_size macro

2009-05-11 Thread Ben Dooks
On Wed, May 06, 2009 at 10:39:27PM +0200, Linus Walleij wrote: From: root r...@fecusia.(none) This replace all instances in the i2c busses tree of res-end - res-start + 1 with the handy macro resource_size(res) from ioport.h (coming in from platform_device.h). This was created with a

Re: [PATCH 0/1] ST DDC I2C U300 bus driver v2

2009-05-11 Thread Ben Dooks
On Fri, May 08, 2009 at 02:36:30PM +0200, Linus Walleij wrote: 2009/5/8 Jean Delvare kh...@linux-fr.org: No reply means yes I assume :-) Wrong assumption. No reply means we are busy. In other words: be patient. Aw sorry man. I still need to learn patience, I know. Doesn't the

Re: [PATCH] i2c-cpm: Pass dev ptr to dma_*_coherent rather than NULL

2009-05-11 Thread Ben Dooks
On Mon, May 11, 2009 at 02:28:50PM +1000, Mark Ware wrote: Ben Dooks wrote: On Wed, Apr 29, 2009 at 08:43:14AM -0500, Kumar Gala wrote: On Apr 22, 2009, at 4:56 PM, Ben Dooks wrote: On Tue, Apr 21, 2009 at 10:11:51AM -0500, Kumar Gala wrote: On Apr 21, 2009, at 7:49 AM, Mark Ware wrote

Please pull bjdooks' i2c-fixes

2009-05-11 Thread Ben Dooks
The following changes since commit 091438dd5668396328a3419abcbc6591159eb8d1: Linus Torvalds (1): Linux 2.6.30-rc4 are available in the git repository at: git://aeryn.fluff.org.uk/bjdooks/linux.git i2c-for-2630-rc5 Mark Brown (1): i2c: Enable i2c-s3c2410 for S3C64XX too Mark

Re: [PATCH 1/1] MFD: Add U300 AB3100 core support v2

2009-05-19 Thread Ben Dooks
On Mon, May 18, 2009 at 10:40:24PM +0200, Linus Walleij wrote: This adds a core driver for the AB3100 mixed-signal circuit found in the ST-Ericsson U300 series platforms. This driver is a singleton proxy for all accesses to the AB3100 sub-drivers which will be merged on top of this one, RTC,

Re: [PATCH 1/1] ST DDC I2C U300 bus driver v2

2009-05-19 Thread Ben Dooks
On Wed, May 06, 2009 at 03:18:07PM +0200, Linus Walleij wrote: This adds support for the ST Microelectronics DDC I2C bus driver. This bus is used in the U300 architecture recently added to RMK:s ARM tree. Signed-off-by: Linus Walleij linus.wall...@stericsson.com Reviewed-by: Ben Dooks ben

Re: [PATCH 1/1] MFD: Add U300 AB3100 core support v3

2009-05-19 Thread Ben Dooks
, regulators, battery and system power control, vibrator, LEDs, and an ALSA codec. Signed-off-by: Linus Walleij linus.wall...@stericsson.com Reviewed-by: Mike Rapoport m...@compulab.co.il Reviewed-by: Samuel Ortiz sa...@linux.intel.com Reviewed-by: Ben Dooks ben-li...@fluff.org --- drivers

Re: [PATCH v2] i2c-mpc: generate START condition after STOP caused by read i2c_msg

2009-05-26 Thread Ben Dooks
On Tue, May 26, 2009 at 01:30:21PM +0200, Esben Haabendal wrote: On Tue, May 19, 2009 at 7:22 AM, Esben Haabendal e...@doredevelopment.dk wrote: This fixes MAL (arbitration lost) bug caused by illegal use of RSTA (repeated START) after STOP condition generated after last byte of reads.

Re: [PATCH] i2c: driver for the Synopsys DesignWare I2C controller

2009-05-26 Thread Ben Dooks
On Tue, May 19, 2009 at 12:23:25PM +0300, Baruch Siach wrote: Please provide an actual description here. A brief subject isn't enough! Signed-off-by: Baruch Siach bar...@tkos.co.il --- drivers/i2c/busses/Kconfig |9 + drivers/i2c/busses/Makefile |1 +

Re: [PATCH 0/3] Blackfin I2C updates for 2.6.31

2009-06-01 Thread Ben Dooks
On Wed, May 27, 2009 at 02:20:07AM -0400, Mike Frysinger wrote: Fixes for bugs in the Blackfin on-chip I2C controller. do you have somewhere I can pull this from (with the corrections from review)? Frank Shew (1): Blackfin I2C/TWI Drivers: fix bug - not work well on BF537 Michael

Re: [PATCH] i2c: driver for the Synopsys DesignWare I2C controller

2009-06-01 Thread Ben Dooks
On Sun, May 31, 2009 at 08:23:45AM +0300, Baruch Siach wrote: Hi Linus, On Thu, May 28, 2009 at 09:32:37AM +0200, Linus Walleij wrote: 2009/5/28 Baruch Siach bar...@tkos.co.il: +static int dw_i2c_probe(struct platform_device *pdev) Can you tag this with __init? OK.

Re: [PATCH v2] i2c-mpc: generate START condition after STOP caused by read i2c_msg

2009-06-02 Thread Ben Dooks
On Thu, May 28, 2009 at 10:15:22PM +0200, Esben Haabendal wrote: On Thu, May 28, 2009 at 9:31 PM, Grant Likely grant.lik...@secretlab.ca wrote: On Tue, May 26, 2009 at 5:30 AM, Esben Haabendal wrote: On Tue, May 19, 2009 at 7:22 AM, Esben Haabendal wrote: This fixes MAL (arbitration lost)

Re: [Uclinux-dist-devel] [PATCH 0/3] Blackfin I2C updates for 2.6.31

2009-06-02 Thread Ben Dooks
On Mon, Jun 01, 2009 at 07:37:30PM -0400, Mike Frysinger wrote: On Mon, Jun 1, 2009 at 18:49, Ben Dooks wrote: On Wed, May 27, 2009 at 02:20:07AM -0400, Mike Frysinger wrote: Fixes for bugs in the Blackfin on-chip I2C controller. do you have somewhere I can pull this from

Re: [PATCH, RFC] Freescale STMP: i2c driver

2009-06-08 Thread Ben Dooks
On Wed, Jun 03, 2009 at 11:59:15PM +0400, dmitry pervushin wrote: Hello Ben i2c people, Here is the patch to support I2C bus on Freescale STMP378x platform; any comments are welcome Signed-off-by: Dmitrij Frasenyak d.frasen...@embeddedalley.com should really have a from Dmitrij Frasenyak

Re: [PATCH 0/1] ST DDC I2C U300 bus driver v3

2009-06-08 Thread Ben Dooks
On Wed, Jun 03, 2009 at 04:24:07PM +0200, Linus Walleij wrote: With the merge window coming up and all it would be great to know if this one need any major rewrite or if it's ripe for merge now... IIRC, it looks ok, will give these a check when I put them all into a tree in the next day or so.

Re: [PATCH] i2c: driver for the Synopsys DesignWare I2C controller

2009-06-13 Thread Ben Dooks
Notes: 1) failed to fix resource_size() 2) No explanation over use of static in loop Please sort these out and post a new patch. -- Ben (b...@fluff.org, http://www.fluff.org/) 'a smiley only costs 4 bytes' -- To unsubscribe from this list: send the line unsubscribe linux-i2c in the body of

Re: [PATCH] I2C: ocores can add I2C devices to the bus

2009-06-13 Thread Ben Dooks
On Tue, Jun 02, 2009 at 07:52:40PM +0200, Richard Rjfors wrote: There is sometimes a need for the ocores driver to add devices to the bus when installed. i2c_register_board_info can not always be used, because the I2C devices are not known at an early state, they could for instance be

Re: [PATCH] I2C: ocores can add I2C devices to the bus

2009-06-13 Thread Ben Dooks
On Sat, Jun 13, 2009 at 10:38:30AM +0100, Ben Dooks wrote: On Tue, Jun 02, 2009 at 07:52:40PM +0200, Richard Rjfors wrote: There is sometimes a need for the ocores driver to add devices to the bus when installed. i2c_register_board_info can not always be used, because the I2C

Re: [PATCH 1/1] ST DDC I2C U300 bus driver v3

2009-06-13 Thread Ben Dooks
Hi, any chance of reposting with the From: and the Signed-off-by: matching please. -- Ben (b...@fluff.org, http://www.fluff.org/) 'a smiley only costs 4 bytes' -- To unsubscribe from this list: send the line unsubscribe linux-i2c in the body of a message to majord...@vger.kernel.org More

Please pull bjdooks' i2c tree

2009-06-13 Thread Ben Dooks
): i2c: OMAP2/3: Fix scll/sclh calculations i2c: OMAP3: Better noise suppression for fast/standard modes Ben Dooks (1): i2c-s3c2410: move to using platform idtable to match devices Frank Shew (1): i2c: Blackfin TWI: fix transfer errors with repeat start Michael Hennerich (2

Re: [PATCH] i2c-bfin-twi: pull in io.h for ioremap()

2009-06-14 Thread Ben Dooks
applied, will push out in the next day or so. -- Ben (b...@fluff.org, http://www.fluff.org/) 'a smiley only costs 4 bytes' -- To unsubscribe from this list: send the line unsubscribe linux-i2c in the body of a message to majord...@vger.kernel.org More majordomo info at

current state of next i2c merge

2009-06-14 Thread Ben Dooks
repository at: git://aeryn.fluff.org.uk/bjdooks/linux.git next-i2c Ben Dooks (1): i2c-s3c2410: use resource_size() Linus Walleij (2): i2c: ST DDC I2C U300 bus driver v3 i2c: Use resource_size macro Mike Frysinger (1): i2c-bfin-twi: pull in io.h for ioremap() drivers/i2c/busses

Re: [PATCH, RFC] Freescale STMP: i2c driver

2009-06-15 Thread Ben Dooks
any chance of an reply or update driver for inclusion? -- Ben (b...@fluff.org, http://www.fluff.org/) 'a smiley only costs 4 bytes' -- To unsubscribe from this list: send the line unsubscribe linux-i2c in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [PATCH, RFC] Freescale STMP: i2c driver

2009-06-21 Thread Ben Dooks
On Tue, Jun 16, 2009 at 08:31:53PM +0400, dmitry pervushin wrote: On Mon, 2009-06-15 at 09:19 +0100, Ben Dooks wrote: any chance of an reply or update driver for inclusion? Here it is: From: Dmitrij Frasenyak d.frasen...@embeddedalley.com Signed-off-by: dmitry pervushin dpervus

Please pull bjdooks' i2c tree

2009-06-21 Thread Ben Dooks
The following changes since commit f234012f52a37e48f2330e1ca2df69800e797c3b: Linus Torvalds (1): Merge branch 'for-linus' of git://git.kernel.org/.../drzeus/mmc are available in the git repository at: git://aeryn.fluff.org.uk/bjdooks/linux.git next-i2c Michael Trimarchi (1):

Please pull bjdooks' i2c-next tree

2009-06-23 Thread Ben Dooks
If possible, is there an oportunity to get this last pull before the end of the merge window done to add the Synopsys Designware controller driver? The following changes since commit d888a4c76c51092993643f8992bf55b3c28da483: Linus Torvalds (1): Merge branch 'for-linus' of

Re: [PATCH 1/2] don't add i2c_imx_driver's probe function to the driver struct

2009-07-14 Thread Ben Dooks
-by: Uwe Kleine-K?nig u.kleine-koe...@pengutronix.de Cc: Sascha Hauer s.ha...@pengutronix.de Cc: Wolfram Sang w.s...@pengutronix.de Cc: Guennadi Liakhovetski g.liakhovet...@gmx.de Cc: Darius Augulis augulis.dar...@gmail.com Cc: Ben Dooks ben-li...@fluff.org Acked-by: Wolfram Sang w.s

Re: I2C device board info

2009-07-18 Thread Ben Dooks
-by: Ben Dooks ben-li...@fluff.org --- arch/arm/mach-realview/core.c |3 +-- arch/arm/mach-versatile/core.c |3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/arch/arm/mach-realview/core.c b/arch/arm/mach-realview/core.c index ab615e7..dc3519c 100644 --- a/arch/arm

Re: [PATCH] i2c-au1550: dev_pm_ops conversion.

2009-07-20 Thread Ben Dooks
On Mon, Jul 20, 2009 at 08:47:41PM +0200, Manuel Lauss wrote: Signed-off-by: Manuel Lauss manuel.la...@gmail.com --- Run-tested on Au1200. drivers/i2c/busses/i2c-au1550.c | 23 ++- 1 files changed, 10 insertions(+), 13 deletions(-) diff --git

Re: [PATCH] I2C: OMAP3: PM: (re)init for every transfer to support off-mode

2009-07-29 Thread Ben Dooks
On Tue, Jul 21, 2009 at 04:09:03PM -0700, Kevin Hilman wrote: From: Rajendra Nayak rna...@ti.com Because of OMAP off-mode, powerdomain can go off when I2C is idle. Save enough state, and do a re-init for each transfer. Additional save/restore state added by Jagadeesh Bhaskar Pakaravoor

Re: [PATCH] i2c-au1550: dev_pm_ops conversion.

2009-07-29 Thread Ben Dooks
On Tue, Jul 21, 2009 at 07:02:58AM +0200, Manuel Lauss wrote: Hi Ben, On Mon, Jul 20, 2009 at 11:06 PM, Ben Dooksben-li...@fluff.org wrote: + +static struct dev_pm_ops au1xpsc_smbus_pmops = { + ? ? .resume ? ? ? ? = i2c_au1550_resume, + ? ? .suspend ? ? ? ?= i2c_au1550_suspend, +};

Re: [RESUBMIT][PATCH-v2][RFC] OMAP4: I2C Support for OMAP4430

2009-07-29 Thread Ben Dooks
On Fri, Jul 24, 2009 at 04:40:02PM +0530, Syed Rafiuddin wrote: Hi Ben, This patch adds OMAP4 support to the I2C driver. All I2C register addresses are different between OMAP1/2/3 and OMAP4. In order to not have #ifdef's at various places in code, as well as to support multi-OMAP

Please pull bjdooks' i2c-fixes

2009-07-29 Thread Ben Dooks
The following changes since commit f5886c7f96f2542382d3a983c5f13e03d7fc5259: Catalin Marinas (1): kmemleak: Protect the seq start/next/stop sequence by rcu_read_lock() are available in the git repository at: git://aeryn.fluff.org.uk/bjdooks/linux.git i2c-fixes-rc4 Magnus Damm (1):

Re: [PATCH 1/3] [OMAP:I2C]Bug in reading the RXSTAT/TXSTAT values from the I2C_BUFFSTAT register

2009-07-29 Thread Ben Dooks
On Tue, Jul 21, 2009 at 10:14:06AM -0500, Sonasath, Moiz wrote: Fix bug in reading the I2C_BUFFSTAT register for getting byte count on RX/TX interrupt. On Interrupt: I2C_STAT[RDR], read 'RXSTAT' from I2C_BUFFSTAT[8-13] On Interrupt: I2C_STAT[XDR] read 'TXSTAT' from

Re: About a suspicious msleep during doxfer in s3c2410 i2c bus driver

2009-07-30 Thread Ben Dooks
On Wed, Jul 22, 2009 at 05:06:40PM +0100, Mark Brown wrote: On Thu, Jul 23, 2009 at 12:58:52AM +0900, Dongsoo Kim wrote: 2009. 07. 22, ?? 9:43, Mark Brown ??: My *recollection* is that this is mostly there for multi-master configurations. I wish I could answer clearly about

Re: About a suspicious msleep during doxfer in s3c2410 i2c bus driver

2009-08-03 Thread Ben Dooks
On Fri, Jul 31, 2009 at 10:05:00AM +0200, Peter Korsgaard wrote: Ben == Ben Dooks ben-li...@fluff.org writes: Hi, It wasn't for the client devices, it was for issues with synchronisation with the controller hardware. I'm just going on the basis of recollections of previous

Re: [RESUBMIT][PATCH-v2][RFC] OMAP4: I2C Support for OMAP4430

2009-08-20 Thread Ben Dooks
On Tue, Aug 18, 2009 at 03:35:31PM +0530, Syed Rafiuddin wrote: Ben, On Fri, Jul 24, 2009 at 04:40:02PM +0530, Syed Rafiuddin wrote: Hi Ben, This patch adds OMAP4 support to the I2C driver. All I2C register addresses are different between OMAP1/2/3 and OMAP4. In order to not

Re: [PATCH 0/3] i2c-omap: I2C clean-up patch

2009-08-20 Thread Ben Dooks
On Thu, Aug 20, 2009 at 11:21:13AM -0500, Moiz Sonasath wrote: This patch includes the following fixes: -Fix I2C status ACK -ACK pending [R/X]DR and [R/X]RDY interrupts in the error/completeion path -Enable workaround for Errata 1.153 based on I2C IP block ok, will add these to my fixes tree.

maintainer away (22nd-26th August)

2009-08-20 Thread Ben Dooks
I'm away, and away from modern conveniences such as Internet connections until the 26th August. -- Ben (b...@fluff.org, http://www.fluff.org/) 'a smiley only costs 4 bytes' -- To unsubscribe from this list: send the line unsubscribe linux-i2c in the body of a message to

Please pull bjdooks' i2c-fixes

2009-08-20 Thread Ben Dooks
The following changes since commit 64f1607ffbbc772685733ea63e6f7f4183df1b16: Linus Torvalds (1): Linux 2.6.31-rc6 are available in the git repository at: git://aeryn.fluff.org.uk/bjdooks/linux.git i2c-fixes-rc6 Linus Walleij (1): i2c-stu300: I2C STU300 stability updates Moiz

Please pull bjdooks' i2c tree

2009-09-19 Thread Ben Dooks
The following changes since commit 78f28b7c555359c67c2a0d23f7436e915329421e: Linus Torvalds (1): Merge branch 'x86-platform-for-linus' of git://git.kernel.org/.../tip/linux-2.6-tip are available in the git repository at: git://aeryn.fluff.org.uk/bjdooks/linux.git next-i2c Mikael

Re: [PATCH] i2c: Add support for Xilinx XPS IIC Bus Interface

2009-09-22 Thread Ben Dooks
On Mon, Sep 21, 2009 at 03:56:11PM +0200, Richard Röjfors wrote: This patch adds support for the Xilinx XPS IIC Bus Interface. The driver uses the dynamic mode, supporting to put several I2C messages in the FIFO to reduce the number of interrupts. It has the same feature as ocores, it can

Archive of list couple of weeks

2009-10-07 Thread Ben Dooks
I've lost the list postings from pre 16th September and was wondering if anyone has it in mbox format that they could send me please. If there is anything important that needs applying, then please re-send with a CC: to ben-li...@fluff.org and I will look at building a new git before the weekend.

Re: FW: [PATCH 10/16] i2c-designware: Do dw_i2c_pump_msg's jobs in the interrutp handler

2009-10-13 Thread Ben Dooks
On Tue, Oct 13, 2009 at 05:05:05PM -0500, Olivares, Ricardo Perez wrote: -Original Message- From: linux-i2c-ow...@vger.kernel.org [mailto:linux-i2c-ow...@vger.kernel.org] On Behalf Of Shinya Kuribayashi Sent: Monday, October 12, 2009 9:52 PM To: bar...@tkos.co.il;

Re: [PATCH 07/16] i2c-designware: Set a clock name to DesignWare I2C clock source

2009-10-13 Thread Ben Dooks
On Tue, Oct 13, 2009 at 11:50:49AM +0900, Shinya Kuribayashi wrote: This driver is originally prepared for the ARM kernel where rich and well-maintained clkdev clock framework is available, and clock name might not be strictly required. ARM's clkdev does slightly fuzzy matching where it

Re: [PATCH 2/2] i2c-bfin-twi: add debug output for error status

2009-10-13 Thread Ben Dooks
On Wed, Oct 07, 2009 at 11:38:16PM -0400, Mike Frysinger wrote: From: Michael Hennerich michael.henner...@analog.com Add some debug() code to decode the error register. are you sure you want such verbose debug, if someone issues a bus-scan then you'll be in for a treat of debuggyness.

Re: Archive of list couple of weeks

2009-10-13 Thread Ben Dooks
On Thu, Oct 08, 2009 at 08:53:45AM +0200, Jean Delvare wrote: On Wed, 7 Oct 2009 22:13:50 +0100, Ben Dooks wrote: On Wed, Oct 07, 2009 at 10:00:46PM +0100, Ben Dooks wrote: I've lost the list postings from pre 16th September and was wondering meant _post_ 16th September... Yes, I'll

Re: [PATCH V1 1/3] i2c: imx: check busy bit when START/STOP

2009-10-29 Thread Ben Dooks
Does anyone have any comments on these, or shall I look at merging them as fixes? -- Ben (b...@fluff.org, http://www.fluff.org/) 'a smiley only costs 4 bytes' -- To unsubscribe from this list: send the line unsubscribe linux-i2c in the body of a message to majord...@vger.kernel.org More

Re: [PATCH 1/3] i2c-powermac: Include the i2c_adpater in struct pmac_i2c_bus

2009-10-29 Thread Ben Dooks
They look ok, anyone else got any objections to putting in -next? -- Ben (b...@fluff.org, http://www.fluff.org/) 'a smiley only costs 4 bytes' -- To unsubscribe from this list: send the line unsubscribe linux-i2c in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [PATCH 1/2] [ARM] i2c/pxa: remove unused macro

2009-11-03 Thread Ben Dooks
On Tue, Nov 03, 2009 at 08:03:19PM +0100, Uwe Kleine-K??nig wrote: Commit beea494 ([ARM] Remove EEPROM slave emulation from i2c-pxa driver.) removed all uses of eedbg, so the definition can go, too. I belive Russell is trying to sort out the code that was using this so I would like

Re: [PATCH 1/2] [ARM] i2c/pxa: remove unused macro

2009-11-03 Thread Ben Dooks
On Tue, Nov 03, 2009 at 09:01:15PM +, Russell King wrote: On Tue, Nov 03, 2009 at 08:03:19PM +0100, Uwe Kleine-K?nig wrote: Commit beea494 ([ARM] Remove EEPROM slave emulation from i2c-pxa driver.) Oh great. Some people may remember the LX code that I submitted to the mailing

Re: i2c-pnx driver issues

2009-11-11 Thread Ben Dooks
On Wed, Nov 11, 2009 at 01:21:45AM +0100, Kevin Wells wrote: Sorry - I've resent with a more meaningful subject (than 'welcome')! Hi, gah, please word-wrap your lines to less than 77 characters per line, it makes it awfully difficult to read them on mailers in terminals. We use the

Re: i2c-pnx driver issues

2009-11-12 Thread Ben Dooks
On Thu, Nov 12, 2009 at 12:37:36AM +0100, Kevin Wells wrote: Thanks Ben, I've submitted the changes as 4 individual patches. We also have some other enhancements for this driver coming up soon, but these 4 patches fix critical issues in the current pnx driver. ok, will look at applying

Re: [PATCH v2 21/22] i2c-designware: Tx abort cleanups

2009-11-14 Thread Ben Dooks
On Thu, Nov 12, 2009 at 01:29:46PM +0900, Shinya Kuribayashi wrote: Baruch, Shinya Kuribayashi wrote: * ABRT_MASTER_DIS: Fix a typo. * i2c_dw_handle_tx_abort: Return an appropriate error number depending on abort_source. * i2c_dw_xfer: Add a missing abort_source initialization.

Re: [PATCH 4/4] i2c : Map I2C adapter number to platform ID number

2009-11-16 Thread Ben Dooks
On Thu, Nov 12, 2009 at 12:34:17AM +0100, Kevin Wells wrote: Map I2C adapter number to platform ID number Signed-off-by: Kevin Wells kevin.we...@nxp.com I've queued this onto i2c-next-misc ready for the next kernel merge window, as it isn't really a bugfix. The rest are on i2c-fixes-pnx and

[PULL] please pull bjdooks' i2c-pnx-fixes branch

2009-11-19 Thread Ben Dooks
The following changes since commit 648f4e3e50c4793d9dbf9a09afa193631f76fa26: Linus Torvalds (1): Linux 2.6.32-rc8 are available in the git repository at: git://git.fluff.org/bjdooks/linux i2c-pnx-fixes Kevin Wells (3): i2c: i2c-pnx: Limit minimum jiffie timeout to 2 i2c:

Re: [PATCH 1/2] ARM: PNX4008: fix i2c-pnx.c build errors

2009-11-20 Thread Ben Dooks
On Fri, Nov 20, 2009 at 11:03:29AM +, Russell King - ARM Linux wrote: ... caused by a missing include. hi, thought this was fixed by the last fix set I sent which went in post 2.6.32-rc8. Signed-off-by: Russell King rmk+ker...@arm.linux.org.uk --- drivers/i2c/busses/i2c-pnx.c |1 +

Re: [PATCH] ARM: PNX4008: i2c-pnx: use the same dev_id for request_irq and free_irq

2009-11-21 Thread Ben Dooks
...@arm.linux.org.uk If you want to merge this via your current pnx work, then have my ack to this, otherwise let me know and i'll add it to i2c-fixes. Acked-by: Ben Dooks ben-li...@fluff.org --- drivers/i2c/busses/i2c-pnx.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git

Re: [PATCH v2] i2c-designware updates

2009-11-23 Thread Ben Dooks
On Fri, Nov 06, 2009 at 09:42:30PM +0900, Shinya Kuribayashi wrote: Hi Baruch and Ben, here's v2 patchset of DesignWare I2C driver (i2c-designware.c). I did all test I can do for now (including arbitration tests), and fixed more issues left in the v1 patchset. I think now the driver is in

Please pull bjdooks' i2c tree

2009-12-08 Thread Ben Dooks
The following changes since commit 6035ccd8e9e40bb654fbfdef325902ab531679a5: Linus Torvalds (1): Merge branch 'for-2.6.33' of git://git.kernel.dk/linux-2.6-block are available in the git repository at: git://git.fluff.org/bjdooks/linux.git next-i2c Kevin Wells (1): i2c-pnx:

Re: [PATCH 3/4] i2c-bfin-twi: remove redundant retry

2009-12-23 Thread Ben Dooks
On Mon, Dec 21, 2009 at 09:28:32AM -0500, Mike Frysinger wrote: From: Sonic Zhang sonic.zh...@analog.com Failed to apply, not had a look at why. Signed-off-by: Sonic Zhang sonic.zh...@analog.com Signed-off-by: Mike Frysinger vap...@gentoo.org --- drivers/i2c/busses/i2c-bfin-twi.c | 20

Please pull bjdooks' i2c-fixes

2009-12-23 Thread Ben Dooks
The following changes since commit c9f937e4a3f4ebf9924ec21d80632e5eb61d949c: Linus Torvalds (1): Merge branch 'upstream-linus' of git://git.kernel.org/.../jgarzik/libata-dev are available in the git repository at: git://git.fluff.org/bjdooks/linux.git i2c-fixes Cory Maccarrone (1):

Re: [PATCH v2 0/2] I2C driver support for Nomadik/Ux500

2010-01-10 Thread Ben Dooks
On Fri, Jan 08, 2010 at 04:00:24PM +0530, srinidhi kasagar wrote: This is the v2 version of the patch which adds support for the ST-Ericsson's I2C block found in U8500/Nomadik 8815 platforms. --- Changelog v1-v2 - file rename from i2c-nmk.c to i2c-nomadik.c (Jean Delvare) - remove the

Re: [PATCH 0/3] i2c-designware: Allow mixed endianness

2010-01-13 Thread Ben Dooks
On Thu, Jan 14, 2010 at 09:40:53AM +0900, Shinya Kuribayashi wrote: Jean-Hugues Deschenes wrote: Here is patchset for the i2c-designware driver, allowing little endian machines to use the DW IP instantiated in big endian and vice versa. In the commit ed5e1dd5 (i2c-designware: Consolidate to

Re: [PATCH 2/3] Check component type register

2010-01-13 Thread Ben Dooks
On Wed, Jan 13, 2010 at 02:32:26PM -0500, Jean-Hugues Deschenes wrote: Designware component type register is checked before attaching to the device. --- drivers/i2c/busses/i2c-designware.c | 11 +++ 1 file changed, 11 insertions(+) Index:

Re: [PATCH 0/3] i2c-designware: Allow mixed endianness

2010-01-13 Thread Ben Dooks
On Wed, Jan 13, 2010 at 10:06:31PM -0500, Jean-Hugues Deschenes wrote: In the commit ed5e1dd5 (i2c-designware: Consolidate to use 32-bit word accesses), I tried to sort out the I/O endian issue, but it seems doesn't work for your environment, R/W data is swapped :-( I think this one

Re: [PATCH] i2c: Renesas SDK7786 FPGA I2C/SMBus support.

2010-01-14 Thread Ben Dooks
On Thu, Jan 14, 2010 at 09:19:35PM +0900, Paul Mundt wrote: This adds a simple driver for the SMBus interfaces in the SDK7786 FPGA. At present this includes 2 identically implemented blocks, one for wrangling control from the CPU I2C for the RTC, and a secondary one for PCI Express. As this

Re: [PATCH v2 2/3] i2c-designware: Check component type register

2010-01-24 Thread Ben Dooks
On Tue, Jan 19, 2010 at 09:02:36AM -0500, Jean-Hugues Deschenes wrote: Designware component type register is checked before attaching to the device. Signed-off-by: Jean-Hugues Deschenes jean-hugues.desche...@octasic.com --- drivers/i2c/busses/i2c-designware.c | 11 +++ 1 file

Re: [PATCH v2 0/3] i2c-designware: Allow mixed endianness

2010-01-24 Thread Ben Dooks
- rename i2c_dw_(read|write)l to dw_(read|write)l (Shinya Kuribayashi) - rename dw_(read|write)l's addr argument to offset (Shinya Kuribayashi) - replace (if constant == x) with (if x == constant) (Ben Dooks) --- Signed-off-by: Jean-Hugues Deschenes jean-hugues.desche...@octasic.com

Re: [PATCH RESEND 1/1] i2c: Add support for Xilinx XPS IIC Bus Interface

2010-01-24 Thread Ben Dooks
On Tue, Jan 19, 2010 at 05:01:16PM +0100, Richard R?jfors wrote: This patch adds support for the Xilinx XPS IIC Bus Interface. The driver uses the dynamic mode, supporting to put several I2C messages in the FIFO to reduce the number of interrupts. It has the same feature as ocores, it can

Re: [PATCH 2/3] I2C: Add driver for Cavium OCTEON I2C ports.

2010-01-24 Thread Ben Dooks
On Thu, Jan 07, 2010 at 11:54:20AM -0800, David Daney wrote: From: Rade Bozic rade.bozic@nsn.com Signed-off-by: Rade Bozic rade.bozic@nsn.com Signed-off-by: David Daney dda...@caviumnetworks.com --- drivers/i2c/busses/Kconfig | 10 + drivers/i2c/busses/Makefile |1 +

Re: [PATCH v2 2/2] i2c: Add support for Ux500/Nomadik I2C controller

2010-01-24 Thread Ben Dooks
On Fri, Jan 08, 2010 at 04:02:55PM +0530, srinidhi kasagar wrote: This adds support for the ST-Ericsson's I2C block found in Ux500 and Nomadik 8815 platforms. Please re-wrap, it could lose at-least one line. Signed-off-by: srinidhi kasagar srinidhi.kasa...@stericsson.com Acked-by: Andrea

Re: [PATCH v2 1/3] i2c-mpc: use __devinit[data] for initialization functions and data

2010-01-26 Thread Ben Dooks
On Mon, Jan 25, 2010 at 09:55:04PM +0100, Wolfgang Grandegger wrote: From: Wolfgang Grandegger w...@denx.de __devinit[data] has not yet been used for all initialization functions and data. To avoid truncating lines, the struct mpc_i2c_match_data has been renamed to mpc_i2c_data, which is

Re: [PATCH] MAINTAINERS: add i2c tree for embedded platforms

2010-01-26 Thread Ben Dooks
On Mon, Jan 25, 2010 at 11:10:55AM +0100, Jean Delvare wrote: On Mon, 25 Jan 2010 10:20:34 +0100, Uwe Kleine-K??nig wrote: Signed-off-by: Uwe Kleine-K??nig u.kleine-koe...@pengutronix.de Cc: Ben Dooks ben-li...@fluff.org --- Hello, I wonder if it makes sence to split the I2C

Re: [PATCH RESEND 1/1] i2c: Add support for Xilinx XPS IIC Bus Interface

2010-01-26 Thread Ben Dooks
On Sun, Jan 24, 2010 at 06:33:20PM +0100, Richard R?jfors wrote: Hi Ben, Thanks for the feedback! Comments below... On 1/24/10 4:49 PM, Ben Dooks wrote: On Tue, Jan 19, 2010 at 05:01:16PM +0100, Richard R?jfors wrote: This patch adds support for the Xilinx XPS IIC Bus Interface

Re: [PATCH RESEND 1/1] i2c: Add support for Xilinx XPS IIC Bus Interface

2010-01-26 Thread Ben Dooks
On Sun, Jan 24, 2010 at 07:15:26PM +0100, Wolfram Sang wrote: + * i2c-xiic.c the directory path to the file would have been nice. Will update Ben, are you sure? Those filenames (especially with directories) easily go stale when reorganizing the tree. I said nice, not esential.

  1   2   3   4   >