Re: [PATCH] i2c: at91: document clock properties

On Tue, Dec 17, 2013 at 04:54:04PM +0100, Boris BREZILLON wrote: Document the clock properties required by the at91 i2c bus driver. Signed-off-by: Boris BREZILLON b.brezil...@overkiz.com Acked-by: Ludovic Desroches ludovic.desroc...@atmel.com --- Documentation/devicetree/bindings/i2c/i2c

Re: [PATCH 04/17] i2c: i2c-at91: deprecate class based instantiation

On Mon, Feb 10, 2014 at 11:03:58AM +0100, Wolfram Sang wrote: Warn users that class based instantiation is going away soon in favour of more robust probing and faster bootup times. Signed-off-by: Wolfram Sang w...@the-dreams.de Cc: Ludovic Desroches ludovic.desroc...@atmel.com Acked

Re: [PATCH] i2c:at91: Add device tree property to set clock-frequency

frequency will default to the previously used define of 100KHz. Signed-off-by: Marek Roszko mark.ros...@gmail.com Acked-by: Ludovic Desroches ludovic.desroc...@atmel.com --- Documentation/devicetree/bindings/i2c/i2c-at91.txt |2 ++ drivers/i2c/busses/i2c-at91.c | 10

Re: [PATCH v2] i2c:at91: Add device tree property to set clock-frequency

of 100KHz. Signed-off-by: Marek Roszko mark.ros...@gmail.com Acked-by: Ludovic Desroches ludovic.desroc...@atmel.com Thanks --- v2: -fixed return code usage and check to not compare agaisnt less than zero --- Documentation/devicetree/bindings/i2c/i2c-at91.txt |2 ++ drivers/i2c

Re: [PATCH 02/16] i2c: i2c-at91: Drop class based scanning to improve bootup time

the DEPRECATED flag, so the core can inform users that the behaviour finally changed now. After another transition period, this flag can go, too. Signed-off-by: Wolfram Sang w...@the-dreams.de Acked-by: Ludovic Desroches ludovic.desroc...@atmel.com Thanks --- drivers/i2c/busses/i2c-at91

Re: [PATCH 1/2] drivers/i2c/busses: use correct type for dma_map/unmap

On Mon, Jul 21, 2014 at 11:42:03AM +0200, Wolfram Sang wrote: dma_{un}map_* uses 'enum dma_data_direction' not 'enum dma_transfer_direction'. Signed-off-by: Wolfram Sang w...@the-dreams.de Acked-by: Ludovic Desroches ludovic.desroc...@atmel.com Thanks Wolfram. --- drivers/i2c/busses/i2c

Re: [PATCH] i2c:at91: add bound checking on smbus block length bytes

good, no objection to include this patch. Only one comment: s/recieved/received otherwise Acked-By: Ludovic Desroches ludovic.desroc...@atmel.com Sorry for the delay. Ludovic -- To unsubscribe from this list: send the line unsubscribe linux-i2c in the body of a message to majord...@vger.kernel.org

Re: [PATCH] i2c:at91: Fix a race condition during signal handling in at91_do_twi_xfer.

. Signed-off-by: Simon Lindgren si...@aqwary.com Acked-by: Ludovic Desroches ludovic.desroc...@atmel.com Thanks for this fix. --- drivers/i2c/busses/i2c-at91.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/i2c/busses/i2c-at91.c b/drivers/i2c/busses/i2c-at91.c

Re: [PATCH 1/3] i2c/at91: add support for runtime PM

Hi Wenyou, On Mon, Oct 20, 2014 at 11:42:12AM +0800, Wenyou Yang wrote: Drivers should put the device into low power states proactively whenever the device is not in use. Thus implement support for runtime PM and use the autosuspend feature to make sure that we can still perform well in case

Re: [PATCH 2/3] i2c/at91: add support for system PM

On Mon, Oct 20, 2014 at 11:42:13AM +0800, Wenyou Yang wrote: Signed-off-by: Wenyou Yang wenyou.y...@atmel.com Acked by: Ludovic Desroches ludovic.desroc...@atmel.com --- drivers/i2c/busses/i2c-at91.c | 30 ++ 1 file changed, 30 insertions(+) diff --git

Re: [PATCH 3/3] i2c/at91: adopt pinctrl support

to optimize energy usage for the pins both for the suspend/resume cycle Signed-off-by: Wenyou Yang wenyou.y...@atmel.com Acked by: Ludovic Desroches ludovic.desroc...@atmel.com --- drivers/i2c/busses/i2c-at91.c | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git

Re: [PATCH 2/3] i2c/at91: add support for system PM

Adding Kevin in the CC list since he had some comments about the PM runtime support for the SPI driver. On Mon, Oct 20, 2014 at 02:42:42PM +0200, Ludovic Desroches wrote: On Mon, Oct 20, 2014 at 11:42:13AM +0800, Wenyou Yang wrote: Signed-off-by: Wenyou Yang wenyou.y...@atmel.com Acked

Re: [PATCH 1/3] i2c/at91: add support for runtime PM

Adding Kevin in the CC list since he had some comments about the PM runtime support for the SPI driver. On Mon, Oct 20, 2014 at 02:39:14PM +0200, Ludovic Desroches wrote: Hi Wenyou, On Mon, Oct 20, 2014 at 11:42:12AM +0800, Wenyou Yang wrote: Drivers should put the device into low power

Re: [PATCH v2] i2c:at91: add bound checking on SMBus block length bytes

the RXRDY interrupt. Tested agaisnt a SMBus compliant battery. Signed-off-by: Marek Roszko mark.ros...@gmail.com Acked-by: Ludovic Desroches ludovic.desroc...@atmel.com --- Change from v1: fixed typo in commit message reworded message slightly to be specifically say length byte drivers/i2c

Re: [PATCH v2] i2c:at91: add bound checking on SMBus block length bytes

Hi, On Thu, Oct 23, 2014 at 09:28:55AM -0400, Mark Roszko wrote: Hi Ludovic, Wolfram took in the patch quietly awhile back. It's in the 3.17 kernel and backported to some of the older trees. https://github.com/torvalds/linux/commit/75b81f339c6af43f6f4a1b3eabe0603321dade65 Great, sorry for

Re: [PATCH v3 0/3] i2c/at91: add support PM functions

For the whole serie Acked-by: Ludovic Desroches ludovic.desroc...@atmel.com On Fri, Oct 24, 2014 at 02:50:14PM +0800, Wenyou Yang wrote: Hi Wolfram, The patches is to add the PM functions support for the at91 i2c controller. It is based on the i2c/for-next branch of git://git.kernel.org

[PATCH] i2c: at91: introduce probe deferring

Return probe defer if requesting a dma channel without a dma controller probed. Signed-off-by: Ludovic Desroches ludovic.desroc...@atmel.com --- drivers/i2c/busses/i2c-at91.c | 22 -- 1 file changed, 16 insertions(+), 6 deletions(-) diff --git a/drivers/i2c/busses/i2c-at91.c

Re: [PATCH] i2c: at91: introduce probe deferring

On Wed, Nov 19, 2014 at 10:47:15AM +0100, Arnd Bergmann wrote: On Wednesday 19 November 2014 10:16:47 Wolfram Sang wrote: On Fri, Nov 14, 2014 at 02:47:59PM +0100, Ludovic Desroches wrote: Return probe defer if requesting a dma channel without a dma controller probed. Signed-off

[PATCH 1/2] i2c: at91: remove legacy DMA support

From: Arnd Bergmann a...@arndb.de Since at91sam9g45 is now DT-only, all DMA capable users of this driver are using the DT case, and the legacy support can be removed. Signed-off-by: Arnd Bergmann a...@arndb.de Signed-off-by: Ludovic Desroches ludovic.desroc...@atmel.com --- Hi, I have split

[PATCH 2/2] i2c: at91: enable probe deferring on dma channel request

If dma controller is not probed, defer i2c probe. Signed-off-by: Ludovic Desroches ludovic.desroc...@atmel.com --- Arnd, It's a combination of the first patch I sent and yours. As you said that my patch looks wrong but actually it's ok I didn't dare to add your signed-off-by. drivers/i2c

Re: [PATCH] i2c: at91: fixup return type of wait_for_completion_timeout

On Sun, Feb 08, 2015 at 11:12:07AM -0500, Nicholas Mc Guire wrote: Return type of wait_for_completion_timeout is unsigned long not int. This patch adds a timeout variable of appropriate type and fixes up the assignment. Signed-off-by: Nicholas Mc Guire hof...@osadl.org Acked-by: Ludovic

Re: [RFC 02/11] i2c: add quirk checks to core

Hi Wolfram, On Fri, Jan 09, 2015 at 06:21:32PM +0100, Wolfram Sang wrote: Let the core do the checks if HW quirks prevent a transfer. Saves code from drivers and adds consistency. Signed-off-by: Wolfram Sang w...@the-dreams.de --- drivers/i2c/i2c-core.c | 53

Re: [PATCH] at91: i2c-at91: improve time-out handling

Hi Douglas, On Thu, Jan 01, 2015 at 01:02:13PM -0500, Douglas Gilbert wrote: With lk 3.19.0-rc2 and a at91sam9g25 (9x5) based system I connected a NXP SC16IS750 I2C to serial bridge. After routing the 750's IRQ back to the sc16is7xx driver and some simple successful test, it was time for some

Re: [RFC V2 03/12] i2c: at91: make use of the new infrastructure for quirks

Hi Wolfram, On Sun, Mar 08, 2015 at 09:28:45AM +0100, Wolfram Sang wrote: On Wed, Feb 25, 2015 at 05:01:54PM +0100, Wolfram Sang wrote: From: Wolfram Sang wsa+rene...@sang-engineering.com Signed-off-by: Wolfram Sang wsa+rene...@sang-engineering.com Hi Ludovic, if you have a few

Re: [RFC V2 03/12] i2c: at91: make use of the new infrastructure for quirks

Hi Wolfram, You can add my Acked-by and Tested-By: Ludovic Desroches ludovic.desroc...@atmel.com Tested on sama5d3, some problems with at24 eeprom on sama5d4 but it doesn't come from the i2c quirks patch series. Regards Ludovic On Sun, Mar 08, 2015 at 09:28:45AM +0100, Wolfram Sang wrote

Re: [PATCH 1/1] i2c: at91: fix code checker warnings

On Thu, Jun 11, 2015 at 11:16:32AM +0200, Cyrille Pitchen wrote: buf_len is a size_t, so unsigned but was tested with '= 0'. Signed-off-by: Cyrille Pitchen cyrille.pitc...@atmel.com Acked-by: Ludovic Desroches ludovic.desroc...@atmel.com Thanks --- drivers/i2c/busses/i2c-at91.c | 6

Re: [PATCH 3/3] i2c: at91: add support to FIFOs

Hi Cyrille, Some comments otherwise Acked-by: Ludovic Desroches ludovic.desroc...@atmel.com On Fri, May 29, 2015 at 03:50:10PM +0200, Cyrille Pitchen wrote: When FIFOs are available and enabled, the driver now configures the Atmel eXtended DMA Controller to perform word accesses instead

Re: [PATCH 1/3] i2c: at91: add support for new alternative command mode

Hi Cyrille, Some remarks, questions below. On Fri, May 29, 2015 at 03:50:08PM +0200, Cyrille Pitchen wrote: The alternative command mode was introduced to simplify the transmission of STOP conditions and to solve timing and latency issues around them. This mode relies on a new register, the

Re: [PATCH 2/3] i2c: at91: print hardware version

On Fri, May 29, 2015 at 03:50:09PM +0200, Cyrille Pitchen wrote: The probe() function now prints the hardware version of the I2C controller Signed-off-by: Cyrille Pitchen cyrille.pitc...@atmel.com Acked-by: Ludovic Desroches ludovic.desroc...@atmel.com --- drivers/i2c/busses/i2c-at91.c | 4

Re: [PATCH v3 0/6] i2c: at91: add support to FIFOs and alternative command

Hi Cyrille, For the whole serie: Acked-by: Ludovic Desroches ludovic.desroc...@atmel.com If you send a new version, could you add stable in Cc to patch 3/6: Cc: sta...@vger.kernel.org #3.10 and later If not, Wolfram could you do it please? Thanks Ludovic On Tue, Jun 02, 2015 at 03:18:30PM

Re: [PATCH v3 0/6] i2c: at91: add support to FIFOs and alternative command

On Wed, Jun 03, 2015 at 12:36:28AM +0900, Wolfram Sang wrote: If you send a new version, could you add stable in Cc to patch 3/6: No need to send a new version just because of an additional ack. I can apply that. However... Cc: sta...@vger.kernel.org #3.10 and later If not, Wolfram

[PATCH v2 2/2] i2c: at91: manage unexpected RXRDY flag when starting a transfer

-off-by: Ludovic Desroches <ludovic.desroc...@atmel.com> Fixes: 93563a6a71bb ("i2c: at91: fix a race condition when using the DMA controller") Reported-by: Peter Rosin <p...@lysator.liu.se> Tested-by: Peter Rosin <p...@lysator.liu.se> Cc: sta...@vger.kernel.org #4.1 --- d

[PATCH v2 1/2] i2c: at91: fix write transfers by clearing pending interrupt first

ce condition when using the DMA controller") Reported-by: Peter Rosin <p...@lysator.liu.se> Signed-off-by: Ludovic Desroches <ludovic.desroc...@atmel.com> Tested-by: Peter Rosin <p...@lysator.liu.se> Cc: sta...@vger.kernel.org #4.1 --- drivers/i2c/busses/i2c-at91.c | 58 ++

[PATCH v3] i2c: at91: manage unexpected RXRDY flag when starting a transfer

-off-by: Ludovic Desroches <ludovic.desroc...@atmel.com> Fixes: 93563a6a71bb ("i2c: at91: fix a race condition when using the DMA controller") Reported-by: Peter Rosin <p...@lysator.liu.se> Tested-by: Peter Rosin <p...@lysator.liu.se> Cc: sta...@vger.kernel.org #4.1 --- C

Re: [PATCH] i2c: at91: fix write transfers by clearing pending interrupt first

Hi Peter, On Fri, Oct 16, 2015 at 11:08:42AM +0200, Peter Rosin wrote: > On 2015-10-16 01:47, Peter Rosin wrote: > > On 2015-10-14 07:43, Ludovic Desroches wrote: > >> On Tue, Oct 13, 2015 at 08:01:34PM +0200, Peter Rosin wrote: > >>> On 2015-10-13 18:47, Cyrille

Re: [PATCH] i2c: at91: fix write transfers by clearing pending interrupt first

On Tue, Oct 13, 2015 at 08:01:34PM +0200, Peter Rosin wrote: > On 2015-10-13 18:47, Cyrille Pitchen wrote: > > Le 13/10/2015 17:19, Peter Rosin a écrit : > >> On 2015-10-13 16:21, Ludovic Desroches wrote: > >>> From: Cyrille Pitchen <cyrille.pitc...@atmel.com&

Re: [PATCH] i2c: at91: fix write transfers by clearing pending interrupt first

On Wed, Oct 21, 2015 at 09:42:40AM +0200, Peter Rosin wrote: > On 2015-10-21 09:21, Peter Rosin wrote: > > On 2015-10-20 15:27, Ludovic Desroches wrote: > >> On Mon, Oct 19, 2015 at 12:49:03PM +0200, Peter Rosin wrote: > >>> On 2015-10-19 10:51, Ludovic De

Re: [PATCH] i2c: at91: fix write transfers by clearing pending interrupt first

On Mon, Oct 19, 2015 at 12:49:03PM +0200, Peter Rosin wrote: > On 2015-10-19 10:51, Ludovic Desroches wrote: > > Hi Peter, > > > > On Fri, Oct 16, 2015 at 11:08:42AM +0200, Peter Rosin wrote: > >> On 2015-10-16 01:47, Peter Rosin wrote: > >>> On

[PATCH] i2c: at91: fix write transfers by clearing pending interrupt first

ce condition when using the DMA controller") Reported-by: Peter Rosin <p...@lysator.liu.se> Signed-off-by: Ludovic Desroches <ludovic.desroc...@atmel.com> Cc: sta...@vger.kernel.org #4.1 --- drivers/i2c/busses/i2c-at91.c | 58 +-- 1 file chan

[PATCH 1/2] i2c: at91: add DT property for the HOLD field of TWIHS_CWGR

eld. Signed-off-by: Wenyou Yang <wenyou.y...@atmel.com> Signed-off-by: Ludovic Desroches <ludovic.desroc...@atmel.com> --- drivers/i2c/busses/i2c-at91.c | 16 +--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/drivers/i2c/busses/i2c-at91.c b/drivers/i2c/bus

[PATCH 2/2] i2c: at91: update documentation for new "atmel,twd-hold-cycles" property

From: Wenyou Yang <wenyou.y...@atmel.com> Add a DT property "atmel,twd-hold-cycles" to specify the HOLD field of TWIHS_CWGR register to increase the TWD hold time. Signed-off-by: Wenyou Yang <wenyou.y...@atmel.com> Signed-off-by: Ludovic Desroches <ludovic.desroc...@atme

[PATCH v2 3/4] ARM: at91/dt: sama5d4: update i2c compatible string

A new compatible string has been introduced: atmel,sama5d4-i2c. It allows to use the i2c-sda-hold-time-ns property if needed. Signed-off-by: Ludovic Desroches <ludovic.desroc...@atmel.com> --- arch/arm/boot/dts/sama5d4.dtsi | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff

[PATCH v2 4/4] ARM: at91/dt: sama5d2 Xplained: pmic needs a specific sda hold time

Data have to be held longer for the PMIC device. The ACT8945A datasheet claims that minimum SDA data hold time is about 300 ns. Signed-off-by: Ludovic Desroches <ludovic.desroc...@atmel.com> --- arch/arm/boot/dts/at91-sama5d2_xplained.dts | 1 + 1 file changed, 1 insertion(+) diff --git

[PATCH v2 2/4] i2c: at91: update bindings documention

The i2c-sda-hold-time-ns property is supported from atmel,sama5d4-i2c. Signed-off-by: Ludovic Desroches <ludovic.desroc...@atmel.com> Acked-by: Rob Herring <r...@kernel.org> --- Documentation/devicetree/bindings/i2c/i2c-at91.txt | 5 - 1 file changed, 4 insertions(+), 1 delet

Re: [PATCH v2 1/4] i2c: at91: add upport for the HOLD field

Sorry forget this one, I have sent an old version. On Thu, Dec 03, 2015 at 10:53:51AM +0100, Ludovic Desroches wrote: > The hold field allows to configure the data hold time which can be set > with the help of the generic binding 'i2c-sda-hold-time-ns'. This > feature has been i

[PATCH v2 1/4] i2c: at91: add support for the HOLD field

The hold field allows to configure the data hold time which can be set with the help of the generic binding 'i2c-sda-hold-time-ns'. This feature has been introduced with SAMA5D4 SoC family. Signed-off-by: Ludovic Desroches <ludovic.desroc...@atmel.com> --- drivers/i2c/busses/i2c-at91.

[PATCH v2 1/4] i2c: at91: add upport for the HOLD field

The hold field allows to configure the data hold time which can be set with the help of the generic binding 'i2c-sda-hold-time-ns'. This feature has been introduced with SAMA5D4 SoC family. Signed-off-by: Ludovic Desroches <ludovic.desroc...@atmel.com> --- drivers/i2c/busses/i2c-at91.

[PATCH v2 0/4] i2c: at91: add support for SDA HOLD

Changes: - from v1: - fix typos, - change MAX_HOLD macro to follow Nicolas' advice, - make it clear that sama5d2 also support i2c-sda-hold-time-ns. Ludovic Desroches (4): i2c: at91: add support for the HOLD field i2c: at91: update bindings documention ARM: at91/dt: sama5d4: update i2c

[PATCH 1/4] i2c: at91: add upport for the HOLD field

The hold field allows to configure the data hold time which can be set with the help of the generic binding 'i2c-sda-hold-time-ns'. This feature has been introduced with SAMA5D4 SoC family. Signed-off-by: Ludovic Desroches <ludovic.desroc...@atmel.com> --- drivers/i2c/busses/i2c-at91.

[PATCH 3/4] ARM: at91/dt: sama5d4: update i2c compatible string

A new compatible string has been introduced: atmel,sama5d4-i2c. It allows to use the i2c-sda-hold-time-ns property if needed. Signed-off-by: Ludovic Desroches <ludovic.desroc...@atmel.com> --- arch/arm/boot/dts/sama5d4.dtsi | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff

[PATCH 2/4] i2c: at91: update bindings documention

The i2c-sda-hold-time-ns property is supported from atmel,sama5d4-i2c. Signed-off-by: Ludovic Desroches <ludovic.desroc...@atmel.com> --- Documentation/devicetree/bindings/i2c/i2c-at91.txt | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bi

[PATCH 4/4] ARM: at91/dt: sama5d2 Xplained: pmic needs a specific sda hold time

Data have to been hold longer for the PMIC device. Signed-off-by: Ludovic Desroches <ludovic.desroc...@atmel.com> --- arch/arm/boot/dts/at91-sama5d2_xplained.dts | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/boot/dts/at91-sama5d2_xplained.dts b/arch/arm/boot/dt

Re: [PATCH 1/3] i2c: at91: add setting HOLD field of TWIHS_CWGR via DT

On Mon, Nov 30, 2015 at 04:13:20PM +0100, Wolfram Sang wrote: > On Tue, Nov 24, 2015 at 02:47:40PM +0100, Ludovic Desroches wrote: > > From: Wenyou Yang <wenyou.y...@atmel.com> > > > > Add the HOLD field management. Some i2c devices need a longer data hold > > t

[PATCH 3/3] ARM: dts: at91: specify DT property "atmel,twd-hold-cycles"

From: Wenyou Yang Specify the device tree property "atmel,twd-hold-cycles" to 25 to adapt to the PMIC ACT8945A. Signed-off-by: Wenyou Yang --- arch/arm/boot/dts/at91-sama5d2_xplained.dts | 1 + 1 file changed, 1 insertion(+) diff --git

[PATCH 1/3] i2c: at91: add setting HOLD field of TWIHS_CWGR via DT

hold-cycles". Signed-off-by: Wenyou Yang <wenyou.y...@atmel.com> Signed-off-by: Ludovic Desroches <ludovic.desroc...@atmel.com> --- drivers/i2c/busses/i2c-at91.c | 14 +++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/drivers/i2c/busses/i2c-at91.c b/drivers

[PATCH 2/3] i2c: at91: add DT property "atmel,twd-hold-cycles" to binding

From: Wenyou Yang <wenyou.y...@atmel.com> Add a DT property "atmel,twd-hold-cycles" to specify the HOLD filed of TWIHS_CWGR register to increase the TWD hold time. Signed-off-by: Wenyou Yang <wenyou.y...@atmel.com> Signed-off-by: Ludovic Desroches <ludovic.desroc...@atme