Re: [RFC v2 2/4] dt-bindings: i2c: mux: demux-pinctrl: add bindings

2016-01-06 Thread Geert Uytterhoeven
. It contains various i2c clients > for snippet > +HDMI, so the bus is named "i2c-hdmi": > + > + i2chdmi: i2c@8 { Would it make sense to call the node "i2c-bus@8"? > + > + compatible = "i2c-demux-pinctrl"; > + i

Re: [RFC v2 3/4] i2c: mux: demux-pinctrl: add driver

2016-01-06 Thread Geert Uytterhoeven
ct i2c_demux_pinctrl_priv { > + int cur_chan; > + int num_chan; This is always positive, so you can make num_chan and a few loop counters unsigned. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org

Re: [RFC v2 1/4] of: make of_mutex public

2016-01-06 Thread Geert Uytterhoeven
ristate, you want to add an EXPORT_SYMBOL_GPL(), too. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalist

Re: [RFC 0/3] i2c: rcar: adapt PM usage to multi master case

2015-12-16 Thread Geert Uytterhoeven
e > implementation. > > This series is RFC because I want to do some more regression testing. The > actual functionality works fine here on my Lager board. Thanks, looks good to me. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyon

Re: [PATCH] i2c: rcar: disable runtime PM correctly in slave mode

2015-12-16 Thread Geert Uytterhoeven
k won't be enabled at all. Hence I think you should add just add additional pm_runtime_get_sync()/ pm_runtime_put() calls in the driver's probe() and remove() methods if multi-master mode is enabled. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux

Re: [PATCH] i2c: rcar: disable runtime PM correctly in slave mode

2015-12-16 Thread Geert Uytterhoeven
Hi Wolfram, On Wed, Dec 16, 2015 at 5:06 PM, Wolfram Sang <w...@the-dreams.de> wrote: > On Wed, Dec 16, 2015 at 04:55:28PM +0100, Geert Uytterhoeven wrote: >> On Wed, Dec 16, 2015 at 4:43 PM, Wolfram Sang <w...@the-dreams.de> wrote: >> > I have another case, may I a

Re: [RFC 5/9] i2c: rcar: honor additional i2c timings from DT

2015-11-27 Thread Geert Uytterhoeven
y_ns; > + round = (ick + 50) / 100 * sum; If you're sure it cannot overflow, doing the "* sum" before the division improves accuracy. > round = (round + 500) / 1000; You can use DIV_ROUND_CLOSEST everywhere, e.g. round = DIV_ROUND_CLOSEST(round, 1000) G

Re: [PATCH] i2c: rcar: Revert the latest refactoring series

2015-11-02 Thread Geert Uytterhoeven
-i2c-rcar e653.i2c: error -16 : 0 -i2c-rcar e653.i2c: error -16 : 0 -i2c-rcar e653.i2c: error -16 : 0 -i2c-rcar e653.i2c: error -16 : 0 -i2c-rcar e653.i2c: error -16 : 0 -i2c-rcar e653.i2c: error -16 : 0 -i2c-rcar e6530000.i2c: error -16 : 0 -i2c-rcar e653.i2c: error

Re: [PATCH v2] i2c: rcar: make sure clocks are on when doing hw init

2015-10-30 Thread Geert Uytterhoeven
s only occurred once, I don't know how to reproduce it. Do you still have the kernel binary, so you can see where exactly the crash happened? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversa

Re: [PATCH] i2c: rcar: call rcar_i2c_init() after pm_runtime_get_sync()

2015-10-29 Thread Geert Uytterhoeven
io); > > - rcar_i2c_init(priv); > - > irq = platform_get_irq(pdev, 0); > init_waitqueue_head(>wait); Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conver

Re: [PATCH] i2c: rcar: make sure clocks are on when doing hw init

2015-10-29 Thread Geert Uytterhoeven
init_waitqueue_head(>wait); > @@ -634,7 +637,6 @@ static int rcar_i2c_probe(struct platform_device *pdev) > return ret; pm_runtime_disable() in error path? > } Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Lin

Re: [PATCH v2 0/2] i2c: uniphier: add two I2C controller drivers for UniPhier SoC platform

2015-10-26 Thread Geert Uytterhoeven
doesn't make much sense to CC everybody who ever made a minor edit to an affected file. If checkpatch comes up with more than 5 names, this should ring a bell. Thanks! Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-

Re: [GIT PULL] On-demand device probing

2015-10-24 Thread Geert Uytterhoeven
while people still stumble on obscure subsystems and drivers not supporting probe deferral. Usually they don't fail with a big bang, so everything seems fine. E.g. last week's "of_mdiobus_register_phy() and deferred probe" (https://lkml.org/lkml/2015/10/22/377). Gr{oetje,eeting}s,

Re: [PATCH 5/9] i2c: rcar: init new messages in irq

2015-10-23 Thread Geert Uytterhoeven
gt;funcs->cursor_set) { ret = crtc->funcs->cursor_set(crtc, NULL, 0, 0, 0); if (ret) Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations

Re: [GIT PULL] On-demand device probing

2015-10-21 Thread Geert Uytterhoeven
rollers are > enumerated in a special way. What does "in a special way" mean? Can you please be more specific? Can you have interrupt controllers that depend on clocks, pin controllers, and PM domains? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There'

Re: [GIT PULL] On-demand device probing

2015-10-19 Thread Geert Uytterhoeven
deferred messages up to > that point, and secondly printing the reason why the remaining > deferrals are happening. > > That should be a small number of new lines plus a one-line change > in subsystems and drivers. Apart from the extra round we probably can't get rid of, that sounds OK to

[PATCH] i2c: rcar: Remove obsolete platform data support

2015-10-07 Thread Geert Uytterhoeven
Since commit 4baadb9e05c68962 ("ARM: shmobile: r8a7778: remove obsolete setup code"), Renesas R-Car SoCs are only supported in generic DT-only ARM multi-platform builds. The driver doesn't need to use platform data anymore, hence remove platform data configuration. Signed-off

Re: [PATCH 08/10] i2c: support 10 bit and slave addresses in sysfs 'new_device'

2015-08-10 Thread Geert Uytterhoeven
0x64 +on bus 1: - # echo slave-24c02 0x64 /sys/bus/i2c/devices/i2c-1/new_device + # echo slave-24c02 0x1064 /sys/bus/i2c/devices/i2c-1/new_device Does 0x64 still work? It's an ABI since v4.1. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots

Re: [PATCH 2/5] i2c: emev2: add binding documentation

2015-07-07 Thread Geert Uytterhoeven
; + clock-names = sclk; + }; Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I

Re: [PATCH 0/5] enable I2C on Renesas EMEV2 and KZM9D board

2015-07-07 Thread Geert Uytterhoeven
:) My idea was to start simple and improve incrementally, so e.g. clock handling was broken, so clocks are always on for starters. Major changes include: Thanks for your series! Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge

Re: [PATCH 2/5] i2c: emev2: add binding documentation

2015-07-07 Thread Geert Uytterhoeven
IIC0_INT IIC #0 interrupt Edge 65 IIC1 IIC1_INT IIC #1 interrupt Edge OK, verified using R19UH0036EJ1600_1chip.pdf (which is newer, Google is your friend). Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org

Re: [RFC 2/3] i2c: mux: demux-pinctrl: add driver

2015-07-01 Thread Geert Uytterhoeven
{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say programmer or something like

Re: [RFC 3/3] ARM: shmobile: r8a7790: rework dts to use i2c demuxer

2015-07-01 Thread Geert Uytterhoeven
; + i2c9 = gpioi2c; i2csuffix or prefixi2c? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking

[PATCH] i2c: I2C_MT65XX should depend on HAS_DMA

2015-06-26 Thread Geert Uytterhoeven
If NO_DMA=y: ERROR: dma_unmap_single [drivers/i2c/busses/i2c-mt65xx.ko] undefined! ERROR: dma_mapping_error [drivers/i2c/busses/i2c-mt65xx.ko] undefined! ERROR: dma_map_single [drivers/i2c/busses/i2c-mt65xx.ko] undefined! Add a dependency on HAS_DMA to fix this. Signed-off-by: Geert

Re: [PATCH v2 0/2] Fix OF match for adxl34x driver

2015-05-23 Thread Geert Uytterhoeven
Hi Dmitry, On Sat, May 23, 2015 at 1:32 AM, Dmitry Torokhov dmitry.torok...@gmail.com wrote: On Thu, May 21, 2015 at 01:42:24PM +0200, Geert Uytterhoeven wrote: This is a resent of a series by Laurent Pinchart to fix OF matching for the adxl34x driver. Applied and sorry for the delay

[PATCH v2 2/2] input: adxl34x: Add OF match support

2015-05-21 Thread Geert Uytterhoeven
is backward-compatible with the ADXL345 with differences handled by runtime detection of the device model. Signed-off-by: Laurent Pinchart laurent.pinchart+rene...@ideasonboard.com Reviewed-by: Wolfram Sang wsa+rene...@sang-engineering.com Signed-off-by: Geert Uytterhoeven geert+rene...@glider.be --- v2

[PATCH v2 1/2] DT: i2c: Deprecate adi,adxl34x compatible string

2015-05-21 Thread Geert Uytterhoeven
-off-by: Laurent Pinchart laurent.pinchart+rene...@ideasonboard.com Acked-by: Wolfram Sang w...@the-dreams.de Signed-off-by: Geert Uytterhoeven geert+rene...@glider.be --- v2: - Add Acked-by. Documentation/devicetree/bindings/i2c/trivial-devices.txt | 3 +-- 1 file changed, 1 insertion(+), 2

[PATCH v2 0/2] Fix OF match for adxl34x driver

2015-05-21 Thread Geert Uytterhoeven
| 21 + 2 files changed, 22 insertions(+), 2 deletions(-) -- 1.9.1 Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people

Re: I2C device tree driver compatible strings

2015-04-12 Thread Geert Uytterhoeven
CC linux-i2c On Sat, Apr 11, 2015 at 9:36 PM, Jakub Kiciński moorr...@wp.pl wrote: Hello, sc16is7xx declares two device id tables, one with OF ids: static const struct of_device_id __maybe_unused sc16is7xx_dt_ids[] = { { .compatible = nxp,sc16is740,.data = sc16is74x_devtype,

Re: [PATCH v2 2/4] Documentation: i2c: describe the new slave mode

2015-04-01 Thread Geert Uytterhoeven
. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say programmer or something like

Re: [PATCH 2/3] Documentation: i2c: describe the new slave mode

2015-03-12 Thread Geert Uytterhoeven
+automatically ACK when detecting its slave address, so there is no option to their slave addresses +NACK it. For those reasons, this API does not support NACK in the address NACK them. +phase. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32

Re: [PATCH 0/3] i2c: slave: API updates

2015-03-12 Thread Geert Uytterhoeven
, finally, the documentation is here. Please let me know what you think! Nice work, thanks! Besides the minor spelling/grammar comments, you can add my Acked-by: Geert Uytterhoeven geert+rene...@glider.be Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots

ARM: shmobile: koelsch: da9210/da9063 interrupt storm (was: Re: [PATCH 3/4] ARM: shmobile: koelsch: Add DA9063 PMIC device node for system restart)

2015-02-17 Thread Geert Uytterhoeven
On Mon, Dec 22, 2014 at 2:21 PM, Geert Uytterhoeven ge...@linux-m68k.org wrote: On Sun, Dec 21, 2014 at 11:52 AM, Simon Horman ho...@verge.net.au wrote: On Tue, Dec 09, 2014 at 12:22:48PM +0100, Geert Uytterhoeven wrote: Add a minimal device node for the DA9063 PMIC, which is connected to i2c6

Re: [PATCH v2 1/2] DT: i2c: Deprecate adi,adxl34x compatible string

2015-01-15 Thread Geert Uytterhoeven
,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say programmer or something like

Re: [PATCH v2 1/2] DT: i2c: Deprecate adi,adxl34x compatible string

2015-01-15 Thread Geert Uytterhoeven
On Thu, Jan 15, 2015 at 6:43 PM, Wolfram Sang w...@the-dreams.de wrote: On Thu, Jan 15, 2015 at 06:32:31PM +0100, Geert Uytterhoeven wrote: On Thu, Jan 15, 2015 at 6:02 PM, Wolfram Sang w...@the-dreams.de wrote: --- a/Documentation/devicetree/bindings/i2c/trivial-devices.txt +++ b

Re: [PATCH v2 2/2] input: adxl34x: Add OF match support

2015-01-15 Thread Geert Uytterhoeven
the adi,adxl346 entry as the ADXL346 is backward-compatible with the ADXL345 with differences handled by runtime detection of the device model. Thanks! Signed-off-by: Laurent Pinchart laurent.pinchart+rene...@ideasonboard.com Acked-by: Geert Uytterhoeven geert+rene...@glider.be --- a/drivers

Re: [PATCH v2 1/2] DT: i2c: Deprecate adi,adxl34x compatible string

2015-01-15 Thread Geert Uytterhoeven
and adi,adxl345, in that order. Signed-off-by: Laurent Pinchart laurent.pinchart+rene...@ideasonboard.com Acked-by: Geert Uytterhoeven geert+rene...@glider.be Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org

Re: [PATCH] input: adxl34x: Add OF match support

2015-01-15 Thread Geert Uytterhoeven
with that? Sounds fine to me. Thanks! Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say

Re: [PATCH v2 2/2] input: adxl34x: Add OF match support

2015-01-15 Thread Geert Uytterhoeven
is the problem that we are solving here? Because there's no guarantee that the driver actually supports all adi,adxl34x with x = 0..9, some of which don't exist yet. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org

Re: [PATCH] input: adxl34x: Add OF match support

2015-01-15 Thread Geert Uytterhoeven
, it's not clear to me. I Googled a bit, but no luck. So they'll have to live with adxl345, too ;-) 2) also add 34x as a compatible but mark it as deprecateed 3) delete 34x from trivial devices OK. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots

Re: [PATCH] input: adxl34x: Add OF match support

2015-01-06 Thread Geert Uytterhoeven
Hi Laurent, Wolfram, On Thu, Dec 18, 2014 at 8:23 PM, Laurent Pinchart laurent.pinch...@ideasonboard.com wrote: On Thursday 18 December 2014 14:03:18 Geert Uytterhoeven wrote: On Thu, Dec 18, 2014 at 1:49 PM, Laurent Pinchart wrote: There are three compatible strings defined for the ADXL345

Re: [PATCH 3/4] ARM: shmobile: koelsch: Add DA9063 PMIC device node for system restart

2014-12-22 Thread Geert Uytterhoeven
Hi Simon, On Sun, Dec 21, 2014 at 11:52 AM, Simon Horman ho...@verge.net.au wrote: On Tue, Dec 09, 2014 at 12:22:48PM +0100, Geert Uytterhoeven wrote: Add a minimal device node for the DA9063 PMIC, which is connected to i2c6. This allows the system to be restarted when the watchdog timer times

Re: [PATCH] input: adxl34x: Add OF match support

2014-12-18 Thread Geert Uytterhoeven
the adxl entries to that file... Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say programmer

Re: [PATCH] i2c: sh_mobile: I2C_SH_MOBILE should depend on HAS_DMA

2014-12-17 Thread Geert Uytterhoeven
Hi Wolfram, On Wed, Dec 17, 2014 at 7:58 AM, Wolfram Sang w...@the-dreams.de wrote: On Mon, Dec 15, 2014 at 02:37:04PM +0100, Geert Uytterhoeven wrote: If NO_DMA=y: drivers/built-in.o: In function `sh_mobile_i2c_dma_unmap': i2c-sh_mobile.c:(.text+0x60de42): undefined reference

Re: [PATCH] i2c: sh_mobile: I2C_SH_MOBILE should depend on HAS_DMA

2014-12-17 Thread Geert Uytterhoeven
Hi Wolfram, On Wed, Dec 17, 2014 at 9:39 AM, Wolfram Sang w...@the-dreams.de wrote: On Wed, Dec 17, 2014 at 09:04:52AM +0100, Geert Uytterhoeven wrote: On Wed, Dec 17, 2014 at 7:58 AM, Wolfram Sang w...@the-dreams.de wrote: On Mon, Dec 15, 2014 at 02:37:04PM +0100, Geert Uytterhoeven wrote

Re: [PATCH 2/5] i2c: sh_mobile: add DMA support

2014-12-15 Thread Geert Uytterhoeven
from subsys_initcall() to module_init(), in the hope the i2c client driver will be initialized after the DMA engine. This is being discussed in the thread you quoted above. I hope this explains the problem well. Thanks! Gr{oetje,eeting}s, Geert -- Geert

Re: [PATCH 2/5] i2c: sh_mobile: add DMA support

2014-12-15 Thread Geert Uytterhoeven
, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say programmer or something like that. -- Linus

[PATCH] i2c: sh_mobile: I2C_SH_MOBILE should depend on HAS_DMA

2014-12-15 Thread Geert Uytterhoeven
:(.text+0x60df2e): undefined reference to `dma_mapping_error' Signed-off-by: Geert Uytterhoeven ge...@linux-m68k.org --- drivers/i2c/busses/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig index c1351d9fb35bbc8d..f08dd20f625c184d

Re: [PATCH 0/4] ARM: shmobile: koelsch: Add DA9063 watchdog restart support

2014-12-10 Thread Geert Uytterhoeven
Hi Simon, On Wed, Dec 10, 2014 at 1:33 AM, Simon Horman ho...@verge.net.au wrote: On Tue, Dec 09, 2014 at 12:22:45PM +0100, Geert Uytterhoeven wrote: This patch series add restart support for r8a7791/koelsch through the watchdog in the DA9063 PMIC. Restart can be triggered in two ways: 1

Re: [RFC 0/2] i2c: sh_mobile: don't regress on deferred probing

2014-12-10 Thread Geert Uytterhoeven
implementation, perhaps I should port it to spi-rspi and spi-sh-msiof, too? Let's wait and see for other comments... Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call

[PATCH 1/4] watchdog: da9063: Add restart handler support

2014-12-09 Thread Geert Uytterhoeven
patch from the BSP by Hisashi Nakamura hisashi.nakamura...@renesas.com. Signed-off-by: Geert Uytterhoeven geert+rene...@glider.be --- Tested on r8a7791/koelsch --- drivers/watchdog/da9063_wdt.c | 32 +++- 1 file changed, 31 insertions(+), 1 deletion(-) diff --git a/drivers

[PATCH 4/4] ARM: shmobile: Enable DA9063 watchdog in multiplatform defconfig

2014-12-09 Thread Geert Uytterhoeven
This allows to restart koelsch on watchdog timeout or manual system restart request. Signed-off-by: Geert Uytterhoeven geert+rene...@glider.be --- Restart by watchdog timeout is working now. Manual system restart depends on [PATCH 1/4] watchdog: da9063: Add restart handler support. --- arch/arm

[PATCH 2/4] DT: i2c: Add devices handled by the da9063 MFD driver

2014-12-09 Thread Geert Uytterhoeven
This allows checkpatch to validate more DTSes. Signed-off-by: Geert Uytterhoeven geert+rene...@glider.be Cc: devicet...@vger.kernel.org --- Documentation/devicetree/bindings/i2c/trivial-devices.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/i2c/trivial

[PATCH 0/4] ARM: shmobile: koelsch: Add DA9063 watchdog restart support

2014-12-09 Thread Geert Uytterhoeven
(based on i2c/next), - Patches 3 and 4 are intended for the shmobile tree (based on renesas-devel-20141209-v3.18). This was tested on r8a7791/koelsch. I expect this restart method to be usable on r8a7791/lager and r8a7794/alt, too. Thanks! Geert Uytterhoeven (4): watchdog: da9063: Add restart

Re: [PATCH] i2c: sh_mobile: use proper device for mapping DMA memory

2014-11-19 Thread Geert Uytterhoeven
On Wed, Nov 19, 2014 at 1:43 PM, Wolfram Sang w...@the-dreams.de wrote: From: Wolfram Sang wsa+rene...@sang-engineering.com It should be the DMA device, not the platform device. Signed-off-by: Wolfram Sang wsa+rene...@sang-engineering.com Acked-by: Geert Uytterhoeven geert+rene...@glider.be

Re: [PATCH 3/3] i2c: core: Map OF IRQ at probe time

2014-11-17 Thread Geert Uytterhoeven
,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say programmer or something like

[PATCH 1/2] DT: i2c: Add more devices handled by the rtc-rs5c372 driver

2014-11-14 Thread Geert Uytterhoeven
This allows checkpatch to validate more DTSes. Signed-off-by: Geert Uytterhoeven geert+rene...@glider.be --- Documentation/devicetree/bindings/i2c/trivial-devices.txt | 5 + 1 file changed, 5 insertions(+) diff --git a/Documentation/devicetree/bindings/i2c/trivial-devices.txt b

[PATCH 2/2] DT: i2c: Add more devices handled by the adxl34x-i2c driver

2014-11-14 Thread Geert Uytterhoeven
This allows checkpatch to validate more DTSes. Signed-off-by: Geert Uytterhoeven geert+rene...@glider.be --- Documentation/devicetree/bindings/i2c/trivial-devices.txt | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Documentation/devicetree/bindings/i2c/trivial-devices.txt b/Documentation

Re: [PATCH 1/5] ARM: shmobile: kzm9g legacy: Set i2c clks_per_count to 2

2014-11-12 Thread Geert Uytterhoeven
On Wed, Nov 12, 2014 at 9:53 AM, Geert Uytterhoeven ge...@linux-m68k.org wrote: i2c_shmobile support.) in v2.6.37. Without this fix i2c may not operate correctly on the sh73a0/kzm9g. Thanks, that's correct. git tag --contains b028f94b76319e1b8 says v2.6.38. Not that you're gonna

Re: [PATCH 1/5] ARM: shmobile: kzm9g legacy: Set i2c clks_per_count to 2

2014-11-12 Thread Geert Uytterhoeven
Hi Simon, On Wed, Nov 12, 2014 at 2:44 AM, Simon Horman ho...@verge.net.au wrote: On Fri, Nov 07, 2014 at 06:24:21AM +0100, Wolfram Sang wrote: On Thu, Nov 06, 2014 at 12:52:06PM +0100, Geert Uytterhoeven wrote: On sh73a0/kzm9g-legacy, probing of the i2c masters fails with: i2c

[PATCH 0/5] ARM: shmobile: sh73a0/r8a73a4: i2c-sh_mobile fixes

2014-11-06 Thread Geert Uytterhoeven
documentation to list the various SoC-specific compatible properties, to allow checkpatch to validate DTSes. This was tested on sh73a0/kzm9g (both legacy and reference). This was not tested on r8a73a4/ape6evm due to lack of hardware. Geert Uytterhoeven (5): ARM: shmobile: kzm9g legacy: Set i2c

[PATCH 1/5] ARM: shmobile: kzm9g legacy: Set i2c clks_per_count to 2

2014-11-06 Thread Geert Uytterhoeven
at 104 MHz) divided by two. Hence i2c_sh_mobile_platform_data.clks_per_count should be set to two. Now probing succeeds, and i2c works: i2c-sh_mobile i2c-sh_mobile.0: I2C adapter 0 with bus speed 10 Hz (L/H=0x104/0xe0) Signed-off-by: Geert Uytterhoeven geert+rene...@glider.be --- Note

[PATCH 4/5] ARM: shmobile: sh73a0 dtsi: Add SoC-specific IIC compatible properties

2014-11-06 Thread Geert Uytterhoeven
failed with error -22 Add the SoC-specific compatible property to fix this. Signed-off-by: Geert Uytterhoeven geert+rene...@glider.be --- arch/arm/boot/dts/sh73a0.dtsi | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/arch/arm/boot/dts/sh73a0.dtsi b/arch/arm/boot/dts

[PATCH 2/5] i2c: sh_mobile: Add support for r8a73a4 and sh73a0

2014-11-06 Thread Geert Uytterhoeven
in section I2C Bus Interface (IIC), subsection Transfer Rate of the datasheets. Signed-off-by: Geert Uytterhoeven geert+rene...@glider.be --- drivers/i2c/busses/i2c-sh_mobile.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/drivers/i2c/busses/i2c-sh_mobile.c b

[PATCH 3/5] i2c: sh_mobile: Document SoC-specific bindings

2014-11-06 Thread Geert Uytterhoeven
Explicitly list the various SoC-specific compatible properties. This allows checkpatch to validate DTSes. Signed-off-by: Geert Uytterhoeven geert+rene...@glider.be --- Documentation/devicetree/bindings/i2c/i2c-sh_mobile.txt | 9 + 1 file changed, 9 insertions(+) diff --git

[PATCH 5/5] ARM: shmobile: r8a73a4 dtsi: Add SoC-specific IIC compatible properties

2014-11-06 Thread Geert Uytterhoeven
The IIC nodes used the generic compatible properties only. This may cause the driver to fail when using Standard Speed on IIC masters where the operational clock is driven by the 130 MHz HP clock. Add the SoC-specific compatible property to fix this. Signed-off-by: Geert Uytterhoeven geert+rene

Re: [PATCH 1/5] ARM: shmobile: kzm9g legacy: Set i2c clks_per_count to 2

2014-11-06 Thread Geert Uytterhoeven
is different. It doesn't use absolute tLOW, tHIGH, and tF values, but only the duty cycle of the clock. It's similar in the R-Car Gen2 docs. Except that on Gen2, there's no mention of using a duty cycle of 5/3 for High Speed like on AG5. Gr{oetje,eeting}s, Geert -- Geert

Re: [RFC 1/3] i2c: sh_mobile: add DMA support

2014-11-03 Thread Geert Uytterhoeven
, dir == DMA_MEM_TO_DEV ? tx : rx) directly instead of using the dma_request_slave_channel_compat() wrapper. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call

Re: [RFC 3/3] ARM: shmobile: r8a7791: add DMA nodes for IIC

2014-11-03 Thread Geert Uytterhoeven
On Fri, Oct 31, 2014 at 11:51 AM, Wolfram Sang w...@the-dreams.de wrote: From: Wolfram Sang wsa+rene...@sang-engineering.com Signed-off-by: Wolfram Sang wsa+rene...@sang-engineering.com Acked-by: Geert Uytterhoeven geert+rene...@glider.be Gr{oetje,eeting}s, Geert

Re: [RFC 2/3] ARM: shmobile: r8a7790: add DMA nodes for IIC

2014-11-03 Thread Geert Uytterhoeven
On Fri, Oct 31, 2014 at 11:51 AM, Wolfram Sang w...@the-dreams.de wrote: From: Wolfram Sang wsa+rene...@sang-engineering.com Signed-off-by: Wolfram Sang wsa+rene...@sang-engineering.com Acked-by: Geert Uytterhoeven geert+rene...@glider.be Gr{oetje,eeting}s, Geert

Re: [RFC 4/4] ARM: shmobile: r8a7790: adapt DTS for I2C slave support

2014-09-12 Thread Geert Uytterhoeven
? [*] Are there bindings for other masters on an i2c bus? Just my 0.02€ (as long as those coins still exist). Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I

Re: [RFC 4/4] ARM: shmobile: r8a7790: adapt DTS for I2C slave support

2014-09-12 Thread Geert Uytterhoeven
, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say programmer or something like

Re: [PATCH 2/2] extcon: sm5502: EXTCON_SM5502 should depend on I2C

2014-08-21 Thread Geert Uytterhoeven
{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say programmer or something like

[PATCH 1/2] regmap: Add eplicit dependencies to catch select misuse

2014-08-17 Thread Geert Uytterhoeven
Add explicit dependencies for the various regmap modules, so Kconfig will print a warning message when another module selects a regmap module without fulfilling its dependencies. Without this, it's much more difficult to find out which module did the offending select. Signed-off-by: Geert

[PATCH 2/2] extcon: sm5502: EXTCON_SM5502 should depend on I2C

2014-08-17 Thread Geert Uytterhoeven
‘i2c_transfer’ Signed-off-by: Geert Uytterhoeven ge...@linux-m68k.org --- drivers/extcon/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/extcon/Kconfig b/drivers/extcon/Kconfig index 6f2f4727de2c..764f3a113e0a 100644 --- a/drivers/extcon/Kconfig +++ b/drivers/extcon/Kconfig

Re: ARM: shmobile: i2cm vs. iicn DT nodes and pinmux

2014-08-13 Thread Geert Uytterhoeven
Hi Wolfram, On Tue, Aug 12, 2014 at 11:47 PM, Wolfram Sang w...@the-dreams.de wrote: On Tue, Aug 12, 2014 at 03:11:18PM +0200, Geert Uytterhoeven wrote: On r8a7790, DT device nodes and C/DT pinmux data for IICn are called iicn, with DT aliases from i2cm to the iicn DT nodes. On r8a7791, DT

[PATCH] ARM: shmobile: koelsch: Remove non-existent i2c6 pinmux

2014-08-12 Thread Geert Uytterhoeven
1d41f36a68c0f4e9b01d563ce33bab5201858b54 (ARM: shmobile: koelsch dts: Add VDD MPU regulator for DVFS) Signed-off-by: Geert Uytterhoeven geert+rene...@glider.be --- arch/arm/boot/dts/r8a7791-koelsch.dts | 7 --- 1 file changed, 7 deletions(-) diff --git a/arch/arm/boot/dts/r8a7791-koelsch.dts b/arch/arm/boot/dts

Re: [PATCH 00/11] i2c: rcar: cleanup series

2014-05-28 Thread Geert Uytterhoeven
Acked-by: Geert Uytterhoeven ge...@linux-m68k.org Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just

Re: [RFC] i2c: sh_mobile: WIP! Fix clock calculation for newer SoCs

2014-05-01 Thread Geert Uytterhoeven
; Missing cast (int)match-data? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say programmer

Re: [PATCH 2/6] i2c: sh_mobile: improve error handling

2014-04-30 Thread Geert Uytterhoeven
()? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say programmer or something like

Re: [PATCH 4/6] i2c: sh_mobile: add devicetree documentation

2014-04-30 Thread Geert Uytterhoeven
Hi Wolfram, CC devicetree On Thu, May 1, 2014 at 12:21 AM, Wolfram Sang w...@the-dreams.de wrote: From: Wolfram Sang wsa+rene...@sang-engineering.com Reported-by: Geert Uytterhoeven geert+rene...@glider.be Signed-off-by: Wolfram Sang wsa+rene...@sang-engineering.com --- .../devicetree

Re: [PATCH 5/6] i2c: sh_mobile: devm conversion, low hanging fruits

2014-04-30 Thread Geert Uytterhoeven
Reviewed-by: Geert Uytterhoeven ge...@linux-m68k.org Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just

Re: [PATCH 6/6] i2c: sh_mobile: devm conversion, irq setup

2014-04-30 Thread Geert Uytterhoeven
variables to proper types. Signed-off-by: Wolfram Sang wsa+rene...@sang-engineering.com Reviewed-by: Geert Uytterhoeven ge...@linux-m68k.org Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations

Re: [PATCH 22/33] ARM: shmobile: Use r8a7740 suffix for i2c, mmcif, fsi2 compat strings

2014-04-23 Thread Geert Uytterhoeven
doesn't seem to have any bindings documented under Documentation/devicetree/bindings/? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker

Re: [PATCH 22/33] ARM: shmobile: Use r8a7740 suffix for i2c, mmcif, fsi2 compat strings

2014-04-23 Thread Geert Uytterhoeven
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say programmer or something like that. -- Linus Torvalds

Re: Build regressions/improvements in v3.14-rc7

2014-03-18 Thread Geert Uytterhoeven
On Tue, Mar 18, 2014 at 9:47 AM, Geert Uytterhoeven ge...@linux-m68k.org wrote: JFYI, when comparing v3.14-rc7[1] to v3.14-rc6[3], the summaries are: - build errors: +5/-13 Ignoring randconfig failures that are not really new: + /scratch/kisskb/src/drivers/i2c/busses/i2c-cpm.c: error

[PATCH trivial 09/16] i2c: Spelling s/than/that/

2014-03-11 Thread Geert Uytterhoeven
From: Geert Uytterhoeven geert+rene...@linux-m68k.org Signed-off-by: Geert Uytterhoeven geert+rene...@linux-m68k.org Cc: Wolfram Sang w...@the-dreams.de Cc: linux-i2c@vger.kernel.org --- Documentation/i2c/functionality |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH 3/6] i2c: rcar: do not print error if device nacks transfer

2014-02-16 Thread Geert Uytterhoeven
:( Do you know at which i2c client device it stalls? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I

Re: [PATCH V2 2/5] arm: shmobile: r7s72100: add i2c clocks

2013-12-26 Thread Geert Uytterhoeven
fcfee800.i2c: registered with 40Hz bus speed After: i2c-riic fcfee800.i2c: missing controller clock i2c-riic: probe of fcfee800.i2c failed with error -2 Am I missing some other patch? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32

Re: [PATCH V2 2/5] arm: shmobile: r7s72100: add i2c clocks

2013-12-26 Thread Geert Uytterhoeven
On Thu, Dec 26, 2013 at 10:25 PM, Wolfram Sang w...@the-dreams.de wrote: On Thu, Dec 26, 2013 at 10:20:23PM +0100, Geert Uytterhoeven wrote: On Tue, Dec 24, 2013 at 3:48 AM, Simon Horman ho...@verge.net.au wrote: On Wed, Dec 18, 2013 at 10:31:58PM +0100, Wolfram Sang wrote: From: Wolfram

Re: [PATCH V2 2/5] arm: shmobile: r7s72100: add i2c clocks

2013-12-26 Thread Geert Uytterhoeven
On Thu, Dec 26, 2013 at 10:34 PM, Geert Uytterhoeven ge...@linux-m68k.org wrote: Note that after dropping these lines: CLKDEV_DEV_ID(fcfee000.i2c, mstp_clks[MSTP97]), CLKDEV_DEV_ID(fcfee400.i2c, mstp_clks[MSTP96]), CLKDEV_DEV_ID(fcfee800.i2c, mstp_clks[MSTP95

Re: [PATCH 5/5] i2c: riic: add driver

2013-12-18 Thread Geert Uytterhoeven
; + clock-frequency = 10; + #address-cells = 1; + #size-cells = 0; + }; Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people

Re: [PATCH -next] [media] altera-stapl should depend on HAS_IOPORT

2012-09-16 Thread Geert Uytterhoeven
On Sun, Sep 16, 2012 at 11:21 AM, Geert Uytterhoeven ge...@linux-m68k.org wrote: On s390: drivers/misc/altera-stapl/altera-lpt.c: In function 'byteblaster_write': drivers/misc/altera-stapl/altera-lpt.c:34:2: error: implicit declaration of function 'outb' [-Werror=implicit-function

Re: [PATCH] i2c: I2C_ELEKTOR should depend on HAS_IOPORT

2011-08-29 Thread Geert Uytterhoeven
On Wed, Aug 17, 2011 at 11:39, Jean Delvare kh...@linux-fr.org wrote: On Tue, 16 Aug 2011 21:14:42 +0200, Geert Uytterhoeven wrote: On Tue, Aug 16, 2011 at 19:50, Jean Delvare kh...@linux-fr.org wrote: On Mon,  8 Aug 2011 13:20:46 +0200, Geert Uytterhoeven wrote: drivers/i2c/busses/i2c

Re: [PATCH] i2c: I2C_ELEKTOR should depend on HAS_IOPORT

2011-08-29 Thread Geert Uytterhoeven
Hi Jean, On Mon, Aug 29, 2011 at 09:55, Jean Delvare kh...@linux-fr.org wrote: On Mon, 29 Aug 2011 09:48:17 +0200, Geert Uytterhoeven wrote: On Wed, Aug 17, 2011 at 11:39, Jean Delvare kh...@linux-fr.org wrote: OK, fair enough. Patch applied, thanks. Any chance it will finds its way in 3.1

Re: [PATCH] i2c: I2C_ELEKTOR should depend on HAS_IOPORT

2011-08-16 Thread Geert Uytterhoeven
Hi Jean, On Tue, Aug 16, 2011 at 19:50, Jean Delvare kh...@linux-fr.org wrote: On Mon,  8 Aug 2011 13:20:46 +0200, Geert Uytterhoeven wrote: drivers/i2c/busses/i2c-elektor.c: In function ‘pcf_isa_init’: drivers/i2c/busses/i2c-elektor.c:153: error: implicit declaration of function ‘ioport_map

[PATCH] i2c: I2C_ELEKTOR should depend on HAS_IOPORT

2011-08-08 Thread Geert Uytterhoeven
HAS_IOPORT. Signed-off-by: Geert Uytterhoeven ge...@linux-m68k.org --- drivers/i2c/busses/Kconfig |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig index 646068e..d1fc5cf 100644 --- a/drivers/i2c/busses/Kconfig +++ b

Re: [PATCH -next reresend] i2c: designware-pcidrv depends on PCI

2011-04-09 Thread Geert Uytterhoeven
,                         Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say programmer or something like that.                                 -- Linus

[next] i2c-designware build errors

2011-03-17 Thread Geert Uytterhoeven
-pcidrv.c:338: error: implicit declaration of function 'pci_release_region' i2c-designware-core.c needs to include linux/delay.h CONFIG_I2C_DESIGNWARE_PCI should depend on CONFIG_PCI Gr{oetje,eeting}s,                         Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge

Re: [next] i2c-designware build errors

2011-03-17 Thread Geert Uytterhoeven
On Thu, Mar 17, 2011 at 12:15, Sedat Dilek sedat.di...@googlemail.com wrote: On Thu, Mar 17, 2011 at 11:58 AM, Geert Uytterhoeven ge...@linux-m68k.org wrote: http://kisskb.ellerman.id.au/kisskb/buildresult/4002561/: drivers/i2c/busses/i2c-designware-core.c:321: error: implicit declaration

  1   2   >