Re: [PATCH v4] i2c: designware: Do not require clock when SSCN and FFCN are provided
Hi All, >> The current driver uses input clock source frequency to calculate >> values for [SS|FS]_[HC|LC] registers. However, when booting ACPI, we do not >> currently have a good way to provide the frequency information. >> Instead, we can leverage the SSCN and FFCN ACPI methods, which can be used >> to directly provide these values. So, the clock information should >> no longer be required during probing. >> >> However, since clk can be invalid, additional checks must be done where >> we are making use of it. >> >> Signed-off-by: Mika Westerberg >> Signed-off-by: Suravee Suthikulpanit >> Tested-by: Loc Ho >> --- >> >> Note: This has been tested on AMD Seattle RevB for both DT and ACPI. >> >> Changes from V3 (https://lkml.org/lkml/2015/12/22/596): >> * Add i2c_dw_plat_prepare_clk() per Andy's suggestion >> * Add tested-by Loc Ho. > > The changes from V3 are big enough that I'd appreciate a new Tested-by > tag. I had tested this via this mixes of test cases: a. NO APD driver + this patch ==> HCNT/LCNT as expected b. with APD driver + this patch ==> HCNT/LCNT as expected c. with APD driver + this patch + double the frequency APD driver ==> HCNT/LCNT as expected d. with APD driver + this patch + double the frequency APD driver + comment out the ACPI parameter retrieve ==> HCNT/LCNT changed as expected Therefore, you can add my - Tested-by: Loc Ho -Loc -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v4] i2c: designware: Do not require clock when SSCN and FFCN are provided
Hi, >> The current driver uses input clock source frequency to calculate >> values for [SS|FS]_[HC|LC] registers. However, when booting ACPI, we do not >> currently have a good way to provide the frequency information. >> Instead, we can leverage the SSCN and FFCN ACPI methods, which can be used >> to directly provide these values. So, the clock information should >> no longer be required during probing. >> >> However, since clk can be invalid, additional checks must be done where >> we are making use of it. >> >> Signed-off-by: Mika Westerberg >> Signed-off-by: Suravee Suthikulpanit >> Tested-by: Loc Ho >> --- >> >> Note: This has been tested on AMD Seattle RevB for both DT and ACPI. >> >> Changes from V3 (https://lkml.org/lkml/2015/12/22/596): >> * Add i2c_dw_plat_prepare_clk() per Andy's suggestion >> * Add tested-by Loc Ho. > > The changes from V3 are big enough that I'd appreciate a new Tested-by > tag. > Will let you know when I have moment to give this a try on X-Gene. -Loc -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2 0/2] i2c:dw: Add APM X-Gene ACPI I2C device support
Hi, On Sat, Jan 2, 2016 at 4:54 PM, Rafael J. Wysocki wrote: > On Thursday, December 10, 2015 02:19:15 PM Loc Ho wrote: >> Add APM X-Gene ACPI I2C device support. These patches follow >> the same implementation as AMD I2C driver - changes in ACPI APD >> and Designware I2C drivers. >> >> v2: >> * Spilt the acpi_apd change with defines for AMD and X-Gene I2C's >> >> Signed-off-by: Loc Ho >> --- >> Loc Ho (2): >> acpi:apd: Add APM X-Gene ACPI I2C device support >> i2c:dw: Add APM X-Gene ACPI I2C device support > > Both patches applied, thanks! > Thanks... -Loc -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2] i2c: designware: Do not require clock when SSCN and FFCN are provided
Hi, > The current driver uses input clock source frequency to calculate > values for [SS|FS]_[HC|LC] registers. However, when booting ACPI, we do not > currently have a good way to provide the frequency information. > Instead, we can leverage the SSCN and FFCN ACPI methods, which can be used > to directly provide these values. So, the clock information should > no longer be required during probing. > > However, since clk can be invalid, additional checks must be done where > we are making use of it. > > Signed-off-by: Suravee Suthikulpanit > --- > > Note: This has been tested on AMD Seattle RevB for both DT and ACPI. Tested on X-Gene hardware also. -Loc -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] i2c: designware: Do not require clock when SSCN and FFCN are provided
Hi, > The current driver uses input clock source frequency to calculate > values for [SS|FS]_[HC|LC] registers. However, when booting ACPI, we do not > currently have a good way to provide the frequency information. > Instead, we can leverage the SSCN and FFCN ACPI methods, which can be used > to directly provide these values. > > So, this patch removes the clock requirement when SSCN and FFCN > are provided. > > Signed-off-by: Suravee Suthikulpanit Tested on X-Gene ACPI boot with updated FW and work just fine. -Loc -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2 0/2] i2c:dw: Add APM X-Gene ACPI I2C device support
Hi,
>>
>> On 12/15/2015 07:27 AM, Mika Westerberg wrote:
>> >On Mon, Dec 14, 2015 at 06:53:25PM -0600, Suravee Suthikulanit wrote:
>> >>>I'm not sure if this has been discussed earlier. But after looking at the
>> >>>the acpi_apd driver, all we need is just the platform-specific input clock
>> >>>frequency value used by the drivers/i2c/busses/i2c-designware-core.c:
>> >>>i2c_dw_init() to calculate the values to program into the
>> >>>DW_IC_SS_SCL_HCNT
>> >>>and DW_IC_SS_SCL_LCNT registers.
>> >There is a way to pass *CNT values already from ACPI to the driver -- It
>> >looks for method called FMCN (or SSCN) and retrieves the values from
>> >there if found.
>>
>> Right, I also noticed this afterward. By the way, are FMCN and SSCN
>> documented anywhere in the ACPI spec? I am trying to figure out how to
>> update the ACPI table to add this information for the AMD Seattle (ARM64)
>> platform, and I will also submit a patch to add the new HID for this driver.
>
> No, they are Intel inventions for the Windows I2C driver.
>
> Here is what I know about it:
> SSCN - Standard Mode CNTs
> FMCN - Fast Mode CNTs
>
> They both return a package:
>
> Package() {
> HCNT,
> LCNT,
> SDA_hold_time,
> }
Can we not just add an AML method that will return the operation clock
frequency that the I2C driver can use? If the method doesn't existed,
we will just bail and do nothing or assume what ever default behavior?
-Loc
--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH v2 2/2] i2c:dw: Add APM X-Gene ACPI I2C device support
Enable APM X-Gene ACPI I2C device support by adding the
corresponding ACPI ID. The platform ACPI APD corresponding
change is required to provide the proper clock frequency input.
Signed-off-by: Loc Ho
Acked-by: Mika Westerberg
---
drivers/i2c/busses/i2c-designware-platdrv.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/i2c/busses/i2c-designware-platdrv.c
b/drivers/i2c/busses/i2c-designware-platdrv.c
index 809579e..423371d 100644
--- a/drivers/i2c/busses/i2c-designware-platdrv.c
+++ b/drivers/i2c/busses/i2c-designware-platdrv.c
@@ -117,6 +117,7 @@ static const struct acpi_device_id dw_i2c_acpi_match[] = {
{ "80860F41", 0 },
{ "808622C1", 0 },
{ "AMD0010", 0 },
+ { "APMC0D0F", 0 },
{ }
};
MODULE_DEVICE_TABLE(acpi, dw_i2c_acpi_match);
--
1.7.1
--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH v2 1/2] acpi:apd: Add APM X-Gene ACPI I2C device support
Add APM X-Gene ACPI I2C device support by hooks into existent
ACPI apd driver. To fully enable support, require another
patch to add the X-Gene ACPI node into the DW I2C driver.
Signed-off-by: Loc Ho
---
drivers/acpi/acpi_apd.c | 16 +++-
1 files changed, 15 insertions(+), 1 deletions(-)
diff --git a/drivers/acpi/acpi_apd.c b/drivers/acpi/acpi_apd.c
index a450e7a..d507cf6 100644
--- a/drivers/acpi/acpi_apd.c
+++ b/drivers/acpi/acpi_apd.c
@@ -51,7 +51,7 @@ struct apd_private_data {
const struct apd_device_desc *dev_desc;
};
-#ifdef CONFIG_X86_AMD_PLATFORM_DEVICE
+#if defined(CONFIG_X86_AMD_PLATFORM_DEVICE) || defined(CONFIG_ARM64)
#define APD_ADDR(desc) ((unsigned long)&desc)
static int acpi_apd_setup(struct apd_private_data *pdata)
@@ -71,6 +71,7 @@ static int acpi_apd_setup(struct apd_private_data *pdata)
return 0;
}
+#ifdef CONFIG_X86_AMD_PLATFORM_DEVICE
static struct apd_device_desc cz_i2c_desc = {
.setup = acpi_apd_setup,
.fixed_clk_rate = 13300,
@@ -80,6 +81,14 @@ static struct apd_device_desc cz_uart_desc = {
.setup = acpi_apd_setup,
.fixed_clk_rate = 4800,
};
+#endif
+
+#ifdef CONFIG_ARM64
+static struct apd_device_desc xgene_i2c_desc = {
+ .setup = acpi_apd_setup,
+ .fixed_clk_rate = 1,
+};
+#endif
#else
@@ -132,9 +141,14 @@ static int acpi_apd_create_device(struct acpi_device *adev,
static const struct acpi_device_id acpi_apd_device_ids[] = {
/* Generic apd devices */
+#ifdef CONFIG_X86_AMD_PLATFORM_DEVICE
{ "AMD0010", APD_ADDR(cz_i2c_desc) },
{ "AMD0020", APD_ADDR(cz_uart_desc) },
{ "AMD0030", },
+#endif
+#ifdef CONFIG_ARM64
+ { "APMC0D0F", APD_ADDR(xgene_i2c_desc) },
+#endif
{ }
};
--
1.7.1
--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH v2 0/2] i2c:dw: Add APM X-Gene ACPI I2C device support
Add APM X-Gene ACPI I2C device support. These patches follow the same implementation as AMD I2C driver - changes in ACPI APD and Designware I2C drivers. v2: * Spilt the acpi_apd change with defines for AMD and X-Gene I2C's Signed-off-by: Loc Ho --- Loc Ho (2): acpi:apd: Add APM X-Gene ACPI I2C device support i2c:dw: Add APM X-Gene ACPI I2C device support drivers/acpi/acpi_apd.c | 16 +++- drivers/i2c/busses/i2c-designware-platdrv.c |1 + 2 files changed, 16 insertions(+), 1 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 1/2] acpi:apd: Add APM X-Gene ACPI I2C device support
Hi,
On Wed, Dec 9, 2015 at 10:14 PM, Ken Xue wrote:
> On Wed, 2015-12-09 at 14:03 -0800, Loc Ho wrote:
>> Hi Ken,
>>
>> On Mon, Dec 7, 2015 at 6:49 PM, Ken Xue wrote:
>> >
>> > On Mon, 2015-12-07 at 17:16 -0700, Loc Ho wrote:
>> > > Add APM X-Gene ACPI I2C device support by hooks into existent
>> > > ACPI apd driver. To fully enable support, require another
>> > > patch to add the X-Gene ACPI node into the DW I2C driver.
>> > >
>> > > Signed-off-by: Loc Ho
>> > > ---
>> > > drivers/acpi/acpi_apd.c |8 +++-
>> > > 1 files changed, 7 insertions(+), 1 deletions(-)
>> > >
>> > > diff --git a/drivers/acpi/acpi_apd.c b/drivers/acpi/acpi_apd.c
>> > > index a450e7a..6a9cb8d 100644
>> > > --- a/drivers/acpi/acpi_apd.c
>> > > +++ b/drivers/acpi/acpi_apd.c
>> > > @@ -51,7 +51,7 @@ struct apd_private_data {
>> > > const struct apd_device_desc *dev_desc;
>> > > };
>> > >
>> > > -#ifdef CONFIG_X86_AMD_PLATFORM_DEVICE
>> > > +#if defined(CONFIG_X86_AMD_PLATFORM_DEVICE) || defined(CONFIG_ARM64)
>> > > #define APD_ADDR(desc) ((unsigned long)&desc)
>> > >
>> > > static int acpi_apd_setup(struct apd_private_data *pdata)
>> > > @@ -76,6 +76,11 @@ static struct apd_device_desc cz_i2c_desc = {
>> > > .fixed_clk_rate = 13300,
>> > > };
>> > >
>> > > +static struct apd_device_desc xgene_i2c_desc = {
>> > > + .setup = acpi_apd_setup,
>> > > + .fixed_clk_rate = 1,
>> > > +};
>> > > +
>> > > static struct apd_device_desc cz_uart_desc = {
>> > > .setup = acpi_apd_setup,
>> > > .fixed_clk_rate = 4800,
>> > > @@ -135,6 +140,7 @@ static const struct acpi_device_id
>> > > acpi_apd_device_ids[] = {
>> > > { "AMD0010", APD_ADDR(cz_i2c_desc) },
>> > > { "AMD0020", APD_ADDR(cz_uart_desc) },
>> > > { "AMD0030", },
>> > > + { "APMC0D0F", APD_ADDR(xgene_i2c_desc) },
>> > It is better to split AMD devices and ARM devices with macros:
>> > CONFIG_X86_AMD_PLATFORM_DEVICE and CONFIG_ARM64.
>>
>> This gets pretty ugly to me with define as it would look like this:
>>
>> #if defined(CONFIG_X86_AMD_PLATFORM_DEVICE) || defined(CONFIG_ARM64)
>> #define APD_ADDR(desc) ((unsigned long)&desc)
>>
>> static int acpi_apd_setup(struct apd_private_data *pdata)
>> {
>>.
>> }
>>
>> #ifdef CONFIG_X86_AMD_PLATFORM_DEVICE
>> static struct apd_device_desc cz_i2c_desc = {
>>
>> };
>>
>> static struct apd_device_desc xgene_i2c_desc = {
>> ...
>> };
>> #endif
>>
>> #ifdef CONFIG_ARM64
>> static struct apd_device_desc cz_uart_desc = {
>>
>> };
>> #endif
>>
>> #else
>>
>> #define APD_ADDR(desc) (0UL)
>>
>> #endif /* CONFIG_X86_AMD_PLATFORM_DEVICE */
>>
>> And...
>>
>> #ifdef CONFIG_X86_AMD_PLATFORM_DEVICE
>> { "AMD0010", APD_ADDR(cz_i2c_desc) },
>> { "AMD0020", APD_ADDR(cz_uart_desc) },
>> { "AMD0030", },
>> #endif
>> #ifdef CONFIG_ARM64
>> { "APMC0D0F", APD_ADDR(xgene_i2c_desc) },
>> #endif
>>
>> Sure you want this?
> Yes. Even though it may look like too much macros for just several
> devices now. But I think AMD and other ARM socs may also try to leverage
> APD for more and more ACPI devices.
> It is a good direction that 1)improve efficiency of matching ACPI
> handler 2) split devices and potential hook routines into different
> classes clearly
>
> It also will be more convenient to move ARM devices out of APD if there
> is a new design for ARM ACPI device.
>
Okay... I will generate v2 when ready. One more question, does AMD
ARM64 SoC need it later?
-Loc
--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 1/2] acpi:apd: Add APM X-Gene ACPI I2C device support
Hi Ken,
On Mon, Dec 7, 2015 at 6:49 PM, Ken Xue wrote:
>
> On Mon, 2015-12-07 at 17:16 -0700, Loc Ho wrote:
> > Add APM X-Gene ACPI I2C device support by hooks into existent
> > ACPI apd driver. To fully enable support, require another
> > patch to add the X-Gene ACPI node into the DW I2C driver.
> >
> > Signed-off-by: Loc Ho
> > ---
> > drivers/acpi/acpi_apd.c |8 +++-
> > 1 files changed, 7 insertions(+), 1 deletions(-)
> >
> > diff --git a/drivers/acpi/acpi_apd.c b/drivers/acpi/acpi_apd.c
> > index a450e7a..6a9cb8d 100644
> > --- a/drivers/acpi/acpi_apd.c
> > +++ b/drivers/acpi/acpi_apd.c
> > @@ -51,7 +51,7 @@ struct apd_private_data {
> > const struct apd_device_desc *dev_desc;
> > };
> >
> > -#ifdef CONFIG_X86_AMD_PLATFORM_DEVICE
> > +#if defined(CONFIG_X86_AMD_PLATFORM_DEVICE) || defined(CONFIG_ARM64)
> > #define APD_ADDR(desc) ((unsigned long)&desc)
> >
> > static int acpi_apd_setup(struct apd_private_data *pdata)
> > @@ -76,6 +76,11 @@ static struct apd_device_desc cz_i2c_desc = {
> > .fixed_clk_rate = 13300,
> > };
> >
> > +static struct apd_device_desc xgene_i2c_desc = {
> > + .setup = acpi_apd_setup,
> > + .fixed_clk_rate = 1,
> > +};
> > +
> > static struct apd_device_desc cz_uart_desc = {
> > .setup = acpi_apd_setup,
> > .fixed_clk_rate = 4800,
> > @@ -135,6 +140,7 @@ static const struct acpi_device_id
> > acpi_apd_device_ids[] = {
> > { "AMD0010", APD_ADDR(cz_i2c_desc) },
> > { "AMD0020", APD_ADDR(cz_uart_desc) },
> > { "AMD0030", },
> > + { "APMC0D0F", APD_ADDR(xgene_i2c_desc) },
> It is better to split AMD devices and ARM devices with macros:
> CONFIG_X86_AMD_PLATFORM_DEVICE and CONFIG_ARM64.
This gets pretty ugly to me with define as it would look like this:
#if defined(CONFIG_X86_AMD_PLATFORM_DEVICE) || defined(CONFIG_ARM64)
#define APD_ADDR(desc) ((unsigned long)&desc)
static int acpi_apd_setup(struct apd_private_data *pdata)
{
.
}
#ifdef CONFIG_X86_AMD_PLATFORM_DEVICE
static struct apd_device_desc cz_i2c_desc = {
};
static struct apd_device_desc xgene_i2c_desc = {
...
};
#endif
#ifdef CONFIG_ARM64
static struct apd_device_desc cz_uart_desc = {
};
#endif
#else
#define APD_ADDR(desc) (0UL)
#endif /* CONFIG_X86_AMD_PLATFORM_DEVICE */
And...
#ifdef CONFIG_X86_AMD_PLATFORM_DEVICE
{ "AMD0010", APD_ADDR(cz_i2c_desc) },
{ "AMD0020", APD_ADDR(cz_uart_desc) },
{ "AMD0030", },
#endif
#ifdef CONFIG_ARM64
{ "APMC0D0F", APD_ADDR(xgene_i2c_desc) },
#endif
Sure you want this?
-Loc
--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 2/2] i2c:dw: Add APM X-Gene ACPI I2C device support
Enable APM X-Gene ACPI I2C device support by adding the
corresponding ACPI ID. The platform ACPI APD corresponding
change is required to provide the proper clock frequency input.
Signed-off-by: Loc Ho
---
drivers/i2c/busses/i2c-designware-platdrv.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/i2c/busses/i2c-designware-platdrv.c
b/drivers/i2c/busses/i2c-designware-platdrv.c
index 809579e..423371d 100644
--- a/drivers/i2c/busses/i2c-designware-platdrv.c
+++ b/drivers/i2c/busses/i2c-designware-platdrv.c
@@ -117,6 +117,7 @@ static const struct acpi_device_id dw_i2c_acpi_match[] = {
{ "80860F41", 0 },
{ "808622C1", 0 },
{ "AMD0010", 0 },
+ { "APMC0D0F", 0 },
{ }
};
MODULE_DEVICE_TABLE(acpi, dw_i2c_acpi_match);
--
1.7.1
--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 1/2] acpi:apd: Add APM X-Gene ACPI I2C device support
Add APM X-Gene ACPI I2C device support by hooks into existent
ACPI apd driver. To fully enable support, require another
patch to add the X-Gene ACPI node into the DW I2C driver.
Signed-off-by: Loc Ho
---
drivers/acpi/acpi_apd.c |8 +++-
1 files changed, 7 insertions(+), 1 deletions(-)
diff --git a/drivers/acpi/acpi_apd.c b/drivers/acpi/acpi_apd.c
index a450e7a..6a9cb8d 100644
--- a/drivers/acpi/acpi_apd.c
+++ b/drivers/acpi/acpi_apd.c
@@ -51,7 +51,7 @@ struct apd_private_data {
const struct apd_device_desc *dev_desc;
};
-#ifdef CONFIG_X86_AMD_PLATFORM_DEVICE
+#if defined(CONFIG_X86_AMD_PLATFORM_DEVICE) || defined(CONFIG_ARM64)
#define APD_ADDR(desc) ((unsigned long)&desc)
static int acpi_apd_setup(struct apd_private_data *pdata)
@@ -76,6 +76,11 @@ static struct apd_device_desc cz_i2c_desc = {
.fixed_clk_rate = 13300,
};
+static struct apd_device_desc xgene_i2c_desc = {
+ .setup = acpi_apd_setup,
+ .fixed_clk_rate = 1,
+};
+
static struct apd_device_desc cz_uart_desc = {
.setup = acpi_apd_setup,
.fixed_clk_rate = 4800,
@@ -135,6 +140,7 @@ static const struct acpi_device_id acpi_apd_device_ids[] = {
{ "AMD0010", APD_ADDR(cz_i2c_desc) },
{ "AMD0020", APD_ADDR(cz_uart_desc) },
{ "AMD0030", },
+ { "APMC0D0F", APD_ADDR(xgene_i2c_desc) },
{ }
};
--
1.7.1
--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 0/2] i2c:dw: Add APM X-Gene ACPI I2C device support
Add APM X-Gene ACPI I2C device support. These patches follow the same implementation as AMD I2C driver - changes in ACPI APD and Designware I2C drivers. Signed-off-by: Loc Ho --- Loc Ho (2): acpi:apd: Add APM X-Gene ACPI I2C device support i2c:dw: Add APM X-Gene ACPI I2C device support drivers/acpi/acpi_apd.c |8 +++- drivers/i2c/busses/i2c-designware-platdrv.c |1 + 2 files changed, 8 insertions(+), 1 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
