Re: [PATCH 1/2] i2c: designware: register clkdev during acpi device configuration

On Wed, 2015-10-21 at 13:46 +0300, Mika Westerberg wrote: > You are saying that the original commit a445900c906092 ("i2c: > designware: Add support for AMD I2C controller") actually never worked > because it failed to register the clock with clkdev? In that case it is > not even a regression ;-)

Re: [PATCH 1/2] i2c: designware: register clkdev during acpi device configuration

On Wed, Oct 21, 2015 at 05:50:02PM +0800, Ken Xue wrote: > After apd was accept in kernel V4.1, there is no issue. But between 3.18 > and V4.1, there will be a problem. We care about that because? -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to

Re: [PATCH 1/2] i2c: designware: register clkdev during acpi device configuration

On Wed, Oct 21, 2015 at 04:42:23PM +0800, Ken Xue wrote: > On Wed, 2015-10-21 at 10:28 +0300, Mika Westerberg wrote: > > On Wed, Oct 21, 2015 at 09:11:33AM +0800, Ken Xue wrote: > > > On Tue, 2015-10-20 at 14:17 +0300, Mika Westerberg wrote: > > > > On Tue, Oct 20, 2015 at 02:38:01PM +0800, Ken

Re: [PATCH 1/2] i2c: designware: register clkdev during acpi device configuration

On Wed, 2015-10-21 at 12:25 +0300, Mika Westerberg wrote: > On Wed, Oct 21, 2015 at 04:42:23PM +0800, Ken Xue wrote: > > On Wed, 2015-10-21 at 10:28 +0300, Mika Westerberg wrote: > > > On Wed, Oct 21, 2015 at 09:11:33AM +0800, Ken Xue wrote: > > > > On Tue, 2015-10-20 at 14:17 +0300, Mika

Re: [PATCH 1/2] i2c: designware: register clkdev during acpi device configuration

On Wed, Oct 21, 2015 at 05:37:53PM +0800, Ken Xue wrote: > On Wed, 2015-10-21 at 12:25 +0300, Mika Westerberg wrote: > > On Wed, Oct 21, 2015 at 04:42:23PM +0800, Ken Xue wrote: > > > On Wed, 2015-10-21 at 10:28 +0300, Mika Westerberg wrote: > > > > On Wed, Oct 21, 2015 at 09:11:33AM +0800, Ken

Re: [PATCH 1/2] i2c: designware: register clkdev during acpi device configuration

On Wed, 2015-10-21 at 12:49 +0300, Mika Westerberg wrote: > On Wed, Oct 21, 2015 at 05:37:53PM +0800, Ken Xue wrote: > > On Wed, 2015-10-21 at 12:25 +0300, Mika Westerberg wrote: > > > On Wed, Oct 21, 2015 at 04:42:23PM +0800, Ken Xue wrote: > > > > On Wed, 2015-10-21 at 10:28 +0300, Mika

Re: [PATCH 1/2] i2c: designware: register clkdev during acpi device configuration

On Wed, 2015-10-21 at 10:28 +0300, Mika Westerberg wrote: > On Wed, Oct 21, 2015 at 09:11:33AM +0800, Ken Xue wrote: > > On Tue, 2015-10-20 at 14:17 +0300, Mika Westerberg wrote: > > > On Tue, Oct 20, 2015 at 02:38:01PM +0800, Ken Xue wrote: > > > > DW I2C driver tries to register a clk from

Re: [PATCH 1/2] i2c: designware: register clkdev during acpi device configuration

On Wed, Oct 21, 2015 at 05:50:02PM +0800, Ken Xue wrote: > On Wed, 2015-10-21 at 12:49 +0300, Mika Westerberg wrote: > > On Wed, Oct 21, 2015 at 05:37:53PM +0800, Ken Xue wrote: > > > On Wed, 2015-10-21 at 12:25 +0300, Mika Westerberg wrote: > > > > On Wed, Oct 21, 2015 at 04:42:23PM +0800, Ken

Re: [PATCH 1/2] i2c: designware: register clkdev during acpi device configuration

On Wed, Oct 21, 2015 at 09:11:33AM +0800, Ken Xue wrote: > On Tue, 2015-10-20 at 14:17 +0300, Mika Westerberg wrote: > > On Tue, Oct 20, 2015 at 02:38:01PM +0800, Ken Xue wrote: > > > DW I2C driver tries to register a clk from id->driver_data as an > > > alternative way besides intel lpss. But

[PATCH 1/2] i2c: designware: register clkdev during acpi device configuration

DW I2C driver tries to register a clk from id->driver_data as an alternative way besides intel lpss. But code doesn't register the clk to clkdev. So, devm_clk_get will fail during probe. The patch can fix this issue. Signed-off-by: Ken Xue Signed-off-by: Xiangliang Yu

Re: [PATCH 1/2] i2c: designware: register clkdev during acpi device configuration

On Tue, Oct 20, 2015 at 02:38:01PM +0800, Ken Xue wrote: > DW I2C driver tries to register a clk from id->driver_data as an > alternative way besides intel lpss. But code doesn't register the > clk to clkdev. So, devm_clk_get will fail during probe. > > The patch can fix this issue. Since you

Re: [PATCH 1/2] i2c: designware: register clkdev during acpi device configuration

On Tue, 2015-10-20 at 14:17 +0300, Mika Westerberg wrote: > On Tue, Oct 20, 2015 at 02:38:01PM +0800, Ken Xue wrote: > > DW I2C driver tries to register a clk from id->driver_data as an > > alternative way besides intel lpss. But code doesn't register the > > clk to clkdev. So, devm_clk_get will