Re: [PATCH v2 0/2] i2c:dw: Add APM X-Gene ACPI I2C device support

2016-01-04 Thread Ben Dooks
On 23/12/15 09:34, Ken Xue wrote: > On Tue, 2015-12-15 at 16:59 +0200, Mika Westerberg wrote: >> On Tue, Dec 15, 2015 at 08:52:19AM -0600, Suravee Suthikulpanit wrote: > During test, I2C bus should run in different "ConnectionSpeed" of > device. > > That means windows driver can modify I2C bus

Re: [PATCH v2 0/2] i2c:dw: Add APM X-Gene ACPI I2C device support

2016-01-03 Thread Loc Ho
Hi, On Sat, Jan 2, 2016 at 4:54 PM, Rafael J. Wysocki wrote: > On Thursday, December 10, 2015 02:19:15 PM Loc Ho wrote: >> Add APM X-Gene ACPI I2C device support. These patches follow >> the same implementation as AMD I2C driver - changes in ACPI APD >> and Designware I2C

Re: [PATCH v2 0/2] i2c:dw: Add APM X-Gene ACPI I2C device support

2016-01-02 Thread Rafael J. Wysocki
On Thursday, December 10, 2015 02:19:15 PM Loc Ho wrote: > Add APM X-Gene ACPI I2C device support. These patches follow > the same implementation as AMD I2C driver - changes in ACPI APD > and Designware I2C drivers. > > v2: > * Spilt the acpi_apd change with defines for AMD and X-Gene I2C's > >

Re: [PATCH v2 0/2] i2c:dw: Add APM X-Gene ACPI I2C device support

2015-12-23 Thread Ken Xue
On Tue, 2015-12-15 at 16:59 +0200, Mika Westerberg wrote: > On Tue, Dec 15, 2015 at 08:52:19AM -0600, Suravee Suthikulpanit wrote: > > > > > > On 12/15/2015 07:27 AM, Mika Westerberg wrote: > > >On Mon, Dec 14, 2015 at 06:53:25PM -0600, Suravee Suthikulanit wrote: > > >>>I'm not sure if this has

Re: [PATCH v2 0/2] i2c:dw: Add APM X-Gene ACPI I2C device support

2015-12-23 Thread Mika Westerberg
On Wed, Dec 23, 2015 at 05:34:01PM +0800, Ken Xue wrote: > 1) Regarding > https://msdn.microsoft.com/en-us/library/windows/hardware/dn919852(v=vs.85).aspx > , Window I2C driver should pass MITT test. There are 5 I2C devices > connect to one I2C bus for test. And those devices defined different >

Re: [PATCH v2 0/2] i2c:dw: Add APM X-Gene ACPI I2C device support

2015-12-23 Thread Ken Xue
On Wed, 2015-12-23 at 11:52 +0200, Mika Westerberg wrote: > On Wed, Dec 23, 2015 at 05:34:01PM +0800, Ken Xue wrote: > > 1) Regarding > > https://msdn.microsoft.com/en-us/library/windows/hardware/dn919852(v=vs.85).aspx > > , Window I2C driver should pass MITT test. There are 5 I2C devices > >

Re: [PATCH v2 0/2] i2c:dw: Add APM X-Gene ACPI I2C device support

2015-12-23 Thread Mika Westerberg
On Wed, Dec 23, 2015 at 10:02:04AM +, Zheng, Ivan wrote: > Why/how can Linux driver make use of such non-ACPI defined methods? What do you mean exactly? I added support for these (well, SSCN and FMCN) because I found out that some vendors include such methods with their BIOS implementation.

Re: [PATCH v2 0/2] i2c:dw: Add APM X-Gene ACPI I2C device support

2015-12-23 Thread Mika Westerberg
On Wed, Dec 23, 2015 at 05:59:49PM +0800, Ken Xue wrote: > On Wed, 2015-12-23 at 11:52 +0200, Mika Westerberg wrote: > > On Wed, Dec 23, 2015 at 05:34:01PM +0800, Ken Xue wrote: > > > 1) Regarding > > > https://msdn.microsoft.com/en-us/library/windows/hardware/dn919852(v=vs.85).aspx > > > , Window

RE: [PATCH v2 0/2] i2c:dw: Add APM X-Gene ACPI I2C device support

2015-12-23 Thread Zheng, Ivan
...@rjwysocki.net; l...@kernel.org; linux-i2c@vger.kernel.org; linux-a...@vger.kernel.org; linux-arm-ker...@lists.infradead.org; j...@redhat.com; patc...@apm.com; Hurwitz, Sherry; Duran, Leo; Hanjun Guo; Al Stone; Zheng, Ivan; Yu, Xiangliang Subject: Re: [PATCH v2 0/2] i2c:dw: Add APM X-Gene ACPI I2C device

Re: [PATCH v2 0/2] i2c:dw: Add APM X-Gene ACPI I2C device support

2015-12-23 Thread Mika Westerberg
On Wed, Dec 23, 2015 at 11:24:44AM +, Zheng, Ivan wrote: > I'm a BIOS engineer and my point is that such non-ACPI defined methods > rely on BIOS implementation, so how the generic I2C driver works on a > platform without such methods? Should the vendor implement their own > driver in such

RE: [PATCH v2 0/2] i2c:dw: Add APM X-Gene ACPI I2C device support

2015-12-23 Thread Zheng, Ivan
; Suthikulpanit, Suravee; Loc Ho; r...@rjwysocki.net; l...@kernel.org; linux-i2c@vger.kernel.org; linux-a...@vger.kernel.org; linux-arm-ker...@lists.infradead.org; j...@redhat.com; patc...@apm.com; Hurwitz, Sherry; Duran, Leo; Hanjun Guo; Al Stone; Yu, Xiangliang Subject: Re: [PATCH v2 0/2] i2c:dw: Add

Re: [PATCH v2 0/2] i2c:dw: Add APM X-Gene ACPI I2C device support

2015-12-16 Thread Jarkko Nikula
On 12/16/2015 11:04 AM, Mika Westerberg wrote: On Tue, Dec 15, 2015 at 11:20:03AM -0800, Loc Ho wrote: Can we not just add an AML method that will return the operation clock frequency that the I2C driver can use? If the method doesn't existed, we will just bail and do nothing or assume what

Re: [PATCH v2 0/2] i2c:dw: Add APM X-Gene ACPI I2C device support

2015-12-16 Thread Mika Westerberg
On Tue, Dec 15, 2015 at 11:20:03AM -0800, Loc Ho wrote: > Can we not just add an AML method that will return the operation clock > frequency that the I2C driver can use? If the method doesn't existed, > we will just bail and do nothing or assume what ever default behavior? Why would you add yet

Re: [PATCH v2 0/2] i2c:dw: Add APM X-Gene ACPI I2C device support

2015-12-15 Thread Loc Ho
Hi, >> >> On 12/15/2015 07:27 AM, Mika Westerberg wrote: >> >On Mon, Dec 14, 2015 at 06:53:25PM -0600, Suravee Suthikulanit wrote: >> >>>I'm not sure if this has been discussed earlier. But after looking at the >> >>>the acpi_apd driver, all we need is just the platform-specific input clock >>

Re: [PATCH v2 0/2] i2c:dw: Add APM X-Gene ACPI I2C device support

2015-12-15 Thread Mika Westerberg
On Mon, Dec 14, 2015 at 06:53:25PM -0600, Suravee Suthikulanit wrote: > I'm not sure if this has been discussed earlier. But after looking at the > the acpi_apd driver, all we need is just the platform-specific input clock > frequency value used by the drivers/i2c/busses/i2c-designware-core.c: >

Re: [PATCH v2 0/2] i2c:dw: Add APM X-Gene ACPI I2C device support

2015-12-15 Thread Mika Westerberg
On Tue, Dec 15, 2015 at 08:52:19AM -0600, Suravee Suthikulpanit wrote: > > > On 12/15/2015 07:27 AM, Mika Westerberg wrote: > >On Mon, Dec 14, 2015 at 06:53:25PM -0600, Suravee Suthikulanit wrote: > >>>I'm not sure if this has been discussed earlier. But after looking at the > >>>the acpi_apd

Re: [PATCH v2 0/2] i2c:dw: Add APM X-Gene ACPI I2C device support

2015-12-15 Thread Suravee Suthikulpanit
On 12/15/2015 07:27 AM, Mika Westerberg wrote: On Mon, Dec 14, 2015 at 06:53:25PM -0600, Suravee Suthikulanit wrote: >I'm not sure if this has been discussed earlier. But after looking at the >the acpi_apd driver, all we need is just the platform-specific input clock >frequency value used by

Re: [PATCH v2 0/2] i2c:dw: Add APM X-Gene ACPI I2C device support

2015-12-14 Thread Suravee Suthikulanit
Hi, I'm not sure if this has been discussed earlier. But after looking at the the acpi_apd driver, all we need is just the platform-specific input clock frequency value used by the drivers/i2c/busses/i2c-designware-core.c: i2c_dw_init() to calculate the values to program into the