Re: [PATCH] i2c: rk3x: Add two new features for rk3399

2015-12-10 Thread Heiko Stübner
Hi David, Am Mittwoch, 9. Dezember 2015, 17:11:46 schrieb David Wu: > 1. support highspeed. > 2. check i2c bus idle status. Listing two separate changes in one patch is a big indicator that it should be split up into two patches. Also please be more verbose (aka explain more) what patches do -

[PATCH 1/2] i2c: designware: Keep pm_runtime_enable/_disable calls in sync

2015-12-10 Thread Jarkko Nikula
On an hardware shared I2C bus (certain Intel Baytrail SoC platforms) the runtime PM disable depth keeps increasing over repeated modprobe/rmmod cycle because pm_runtime_disable() is called without checking should it be disabled already because of bus sharing. This hasn't made any other harm than d

[PATCH 2/2] i2c: designware: Allow build Baytrail semaphore support when IOSF_MBI=m

2015-12-10 Thread Jarkko Nikula
I believe i2c-designware-baytrail.c doesn't have strict dependency that Intel SoC IOSF Sideband support must be always built-in in order to be able to compile support for Intel Baytrail I2C bus sharing HW semaphore. Redefine build dependencies so that CONFIG_IOSF_MBI=y is required only when CONFIG

Re: [PATCH 2/2] i2c: designware: Allow build Baytrail semaphore support when IOSF_MBI=m

2015-12-10 Thread Andy Shevchenko
On Thu, 2015-12-10 at 13:48 +0200, Jarkko Nikula wrote: > I believe i2c-designware-baytrail.c doesn't have strict dependency > that > Intel SoC IOSF Sideband support must be always built-in in order to > be > able to compile support for Intel Baytrail I2C bus sharing HW > semaphore. > > Redefine b

[PATCH] i2c: allow building emev2 without slave mode again

2015-12-10 Thread Arnd Bergmann
The emev2 driver stopped compiling in today's linux-next kernel: drivers/i2c/busses/i2c-emev2.c: In function 'em_i2c_slave_irq': drivers/i2c/busses/i2c-emev2.c:233:23: error: storage size of 'event' isn't known drivers/i2c/busses/i2c-emev2.c:250:3: error: implicit declaration of function 'i2c_sl

Re: [PATCH] i2c: allow building emev2 without slave mode again

2015-12-10 Thread Wolfram Sang
On Thu, Dec 10, 2015 at 02:14:49PM +0100, Arnd Bergmann wrote: > The emev2 driver stopped compiling in today's linux-next kernel: > > drivers/i2c/busses/i2c-emev2.c: In function 'em_i2c_slave_irq': > drivers/i2c/busses/i2c-emev2.c:233:23: error: storage size of 'event' isn't > known > drivers/i2c

Re: [PATCH] i2c: allow building emev2 without slave mode again

2015-12-10 Thread Arnd Bergmann
On Thursday 10 December 2015 14:34:46 Wolfram Sang wrote: > On Thu, Dec 10, 2015 at 02:14:49PM +0100, Arnd Bergmann wrote: > > The emev2 driver stopped compiling in today's linux-next kernel: > > > > drivers/i2c/busses/i2c-emev2.c: In function 'em_i2c_slave_irq': > > drivers/i2c/busses/i2c-emev2.c

Re: [PATCH 2/2] i2c: designware: Allow build Baytrail semaphore support when IOSF_MBI=m

2015-12-10 Thread Jarkko Nikula
On 12/10/2015 02:59 PM, Andy Shevchenko wrote: On Thu, 2015-12-10 at 13:48 +0200, Jarkko Nikula wrote: I believe i2c-designware-baytrail.c doesn't have strict dependency that Intel SoC IOSF Sideband support must be always built-in in order to be able to compile support for Intel Baytrail I2C bus

Re: [PATCH] i2c: allow building emev2 without slave mode again

2015-12-10 Thread kbuild test robot
Hi Arnd, [auto build test WARNING on wsa/i2c/for-next] [also build test WARNING on next-20151210] [cannot apply to v4.4-rc4] url: https://github.com/0day-ci/linux/commits/Arnd-Bergmann/i2c-allow-building-emev2-without-slave-mode-again/20151210-211642 base: https://git.kernel.org/pub/scm

Re: [PATCH] i2c: allow building emev2 without slave mode again

2015-12-10 Thread Arnd Bergmann
On Thursday 10 December 2015 22:54:25 kbuild test robot wrote: > >In file included from arch/x86/include/asm/realmode.h:5:0, > from arch/x86/include/asm/acpi.h:33, > from arch/x86/include/asm/fixmap.h:19, > from arch/x86/include/asm/a

Re: [PATCH] i2c: allow building emev2 without slave mode again

2015-12-10 Thread Wolfram Sang
> Alternatively, the inline could return an error, and both bus > drivers check for the error before using 'value'. I'll try to check these options tomorrow. signature.asc Description: Digital signature

Re: [PATCH v3 2/2] ACPI / gpio: Add irq_type when a gpio is used as an interrupt

2015-12-10 Thread Linus Walleij
On Mon, Nov 30, 2015 at 11:47 PM, Christophe Ricard wrote: > When a gpio is used as an interrupt, the irq_type was not available for > device driver. It is not align with devicetree probing. > > Signed-off-by: Christophe Ricard Acked-by: Linus Walleij Rafael you can merge this into the ACPI t

[PATCH v2 0/2] i2c:dw: Add APM X-Gene ACPI I2C device support

2015-12-10 Thread Loc Ho
Add APM X-Gene ACPI I2C device support. These patches follow the same implementation as AMD I2C driver - changes in ACPI APD and Designware I2C drivers. v2: * Spilt the acpi_apd change with defines for AMD and X-Gene I2C's Signed-off-by: Loc Ho --- Loc Ho (2): acpi:apd: Add APM X-Gene ACPI I2C

[PATCH v2 2/2] i2c:dw: Add APM X-Gene ACPI I2C device support

2015-12-10 Thread Loc Ho
Enable APM X-Gene ACPI I2C device support by adding the corresponding ACPI ID. The platform ACPI APD corresponding change is required to provide the proper clock frequency input. Signed-off-by: Loc Ho Acked-by: Mika Westerberg --- drivers/i2c/busses/i2c-designware-platdrv.c |1 + 1 files ch

[PATCH v2 1/2] acpi:apd: Add APM X-Gene ACPI I2C device support

2015-12-10 Thread Loc Ho
Add APM X-Gene ACPI I2C device support by hooks into existent ACPI apd driver. To fully enable support, require another patch to add the X-Gene ACPI node into the DW I2C driver. Signed-off-by: Loc Ho --- drivers/acpi/acpi_apd.c | 16 +++- 1 files changed, 15 insertions(+), 1 deleti

Re: [PATCH v2 1/2] acpi:apd: Add APM X-Gene ACPI I2C device support

2015-12-10 Thread Ken Xue
On Thu, 2015-12-10 at 14:19 -0700, Loc Ho wrote: > Add APM X-Gene ACPI I2C device support by hooks into existent > ACPI apd driver. To fully enable support, require another > patch to add the X-Gene ACPI node into the DW I2C driver. > > Signed-off-by: Loc Ho > --- > drivers/acpi/acpi_apd.c | 1

[Patch V10] i2c: imx: add runtime pm support to improve the performance

2015-12-10 Thread Gao Pan
In our former i2c driver, i2c clk is enabled and disabled in xfer function, which contributes to power saving. However, the clk enable process brings a busy wait delay until the core is stable. As a result, the performance is sacrificed. To weigh the power consumption and i2c bus performance, runt

[PATCH v2] I2C: designware: fix IO timeout issue for AMD controller

2015-12-10 Thread Xiangliang Yu
Because of some hardware limitation, AMD I2C controller can't trigger pending interrupt if interrupt status has been changed after clearing interrupt status bits. Then, I2C will lost interrupt and IO timeout. According to hardware design, this patch implements a workaround to disable i2c controlle