Re: [PATCH v3 2/2] i2c: New bus driver for the Qualcomm QUP I2C controller

2014-02-25 Thread Andy Gross
On Tue, Feb 25, 2014 at 08:07:13AM -0800, Bjorn Andersson wrote: [snip] > The v2 model will get BAM (DMAEngine) support soon, v1 uses an > older DMA core. So there's a difference. I'm not aware what differences > there are between 2.1.1 and 2.2.1. Difference between 2.1.1 and 2.2.1: - high spee

Re: [PATCH v5 2/2] i2c: New bus driver for the Qualcomm QUP I2C controller

2014-03-19 Thread Andy Gross
core. The driver > supports FIFO mode (for low bandwidth applications) and block mode (interrupt > generated for each block-size data transfer). > Looks good. Reviewed-by: Andy Gross -- sent by an employee of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc.

[PATCH] i2c: qup: Fix pm_runtime_get_sync usage

2014-05-02 Thread Andy Gross
This patch corrects the error check on the call to pm_runtime_get_sync. Signed-off-by: Andy Gross --- drivers/i2c/busses/i2c-qup.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/i2c/busses/i2c-qup.c b/drivers/i2c/busses/i2c-qup.c index 1b4cf14..2a5efb5 100644 --- a

[PATCH] i2c: qup: Fix order of runtime pm initialization

2014-09-29 Thread Andy Gross
The runtime pm calls need to be done before populating the children via the i2c_add_adapter call. If this is not done, a child can run into issues trying to do i2c read/writes due to the pm_runtime_sync failing. Signed-off-by: Andy Gross --- drivers/i2c/busses/i2c-qup.c | 12 1

Re: [PATCH] i2c: qup: Fix order of runtime pm initialization

2014-09-30 Thread Andy Gross
On Mon, Sep 29, 2014 at 06:53:24PM -0700, Bjorn Andersson wrote: > On Mon 29 Sep 15:00 PDT 2014, Andy Gross wrote: > > > The runtime pm calls need to be done before populating the children via the > > i2c_add_adapter call. If this is not done, a child can run into issues &g

Re: [PATCH 6/6] dts: msm8974: Add dma channels for blsp2_i2c1 node

2015-03-13 Thread Andy Gross
On Fri, Mar 13, 2015 at 11:19:52PM +0530, Sricharan R wrote: > Signed-off-by: Sricharan R > --- Reviewed-by: Andy Gross > arch/arm/boot/dts/qcom-msm8974.dtsi | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/arm/boot/dts/qcom-msm8974.dtsi > b/arch/arm/

Re: [PATCH V2 2/6] i2c: qup: Add V2 tags support

2015-04-06 Thread Andy Gross
On Tue, Apr 07, 2015 at 12:01:03AM +0530, Sricharan R wrote: > +static u32 qup_i2c_send_data(struct qup_i2c_dev *qup, int tlen, u8 *tbuf, > + int dlen, u8 *dbuf) > +{ > + u32 val = 0, idx = 0, pos = 0, i = 0, t; > + int len = tlen + dlen; > + u8 *buf = tbuf;

Re: [V5, 1/6] i2c: qup: Change qup_wait_writeready function to use for all timeouts

2016-01-04 Thread Andy Gross
aces as well. > > Signed-off-by: Sricharan R Looks good to me. Reviewed-by: Andy Gross -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html