If we don't find the correct rate, we want to end the loop with i
pointing to the last element in the array.
Signed-off-by: Dan Carpenter erro...@gmail.com
---
I will be offline for a while, sorry if I delay replying.
diff --git a/drivers/i2c/busses/i2c-stu300.c b/drivers/i2c/busses/i2c-stu300.c
to name goto destinations after the destination instead
of the starting point. In this case, we have two gotos to one
destination and the label err_request_irq makes no sense.
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-i2c in
the body of a message
worth cleaning.
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-i2c in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
the unwind needs to be fixed so it's a mirror reflection of
the allocation order. Also the labels are crap. Label names should be
based on the label location and not the goto location(s).
1273 return ret;
1274 }
regards,
dan carpenter
--
To unsubscribe from this list: send the line
ret = -ENOMEM;
1004 goto err_no_mem;
1005 }
1006
1007 dev-irq = adev-irq[0];
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-i2c in
the body of a message to majord...@vger.kernel.org
More
These should = ARRAY_SIZE() instead of ARRAY_SIZE().
Fixes: 10c5a8425968 ('i2c: qup: New bus driver for the Qualcomm QUP I2C
controller')
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
diff --git a/drivers/i2c/busses/i2c-qup.c b/drivers/i2c/busses/i2c-qup.c
index c9d5f78..ee40980 100644
ak09911_probe() is called from i2c_device_probe() when we do:
status = driver-probe(client, i2c_match_id(driver-id_table, client));
The functions which implement driver-probe() are not very consistent
in how the check for a NULL return from i2c_match_id().
tree:
);
+ module_put(port-ops-owner);
+
+ return NULL;
+}
+
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-i2c in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
,
+ int (*pf)(void *), void (*kf)(void *),
+ void (*irq_func)(void *), int flags,
+ void *handle, struct parport_driver *drv)
The difference between parport_register_device() and
parport_register_dev() isn't clear from the name.
regards,
dan carpenter
will always be true.
The question of how to handle impossible conditions is always tricky.
:P In this case just remove the condition.
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-i2c in
the body of a message to majord...@vger.kernel.org
More majordomo info
callback of parport device.
That doesn't work. Some of the callers pass a string literal.
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-i2c in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo
On Wed, Apr 08, 2015 at 02:38:32PM +0300, Dan Carpenter wrote:
1) We can't apply this patch on its own so this way of breaking up the
patches doesn't work.
The right thing is to do add an attach_ret().
static int do_attach(drv)
{
if (drv-attach_ret)
return drv
On Wed, Apr 08, 2015 at 05:20:10PM +0530, Sudip Mukherjee wrote:
On Wed, Apr 08, 2015 at 02:38:32PM +0300, Dan Carpenter wrote:
1) We can't apply this patch on its own so this way of breaking up the
patches doesn't work.
yes, if the first patch is reverted for any reason all the others need
The dma_mapping_error() function returns true if there is an error, it
doesn't return an error code. We should return -ENOMEM.
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
diff --git a/drivers/i2c/busses/i2c-xgene-slimpro.c
b/drivers/i2c/busses/i2c-xgene-slimpro.c
index 1c9cb65a
14 matches
Mail list logo
