Re: [PATCH] i2c: Add support SuperH SH7734 I2C bus controller

2012-04-11 Thread Kuninori Morimoto
. (not only SH7734 CPU) Best regards --- Kuninori Morimoto -- To unsubscribe from this list: send the line unsubscribe linux-i2c in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] i2c: Add support SuperH SH7734 I2C bus controller

2012-04-13 Thread Kuninori Morimoto
seems not same as SH-NAVI. Now I'm checking the series. Please wait. Best regards --- Kuninori Morimoto -- To unsubscribe from this list: send the line unsubscribe linux-i2c in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] i2c: Add support SuperH SH7734 I2C bus controller

2012-04-15 Thread Kuninori Morimoto
about it this morning. SH7734 I2C came from SH7266, and it came from SH-NaviJ3. Best regards --- Kuninori Morimoto -- To unsubscribe from this list: send the line unsubscribe linux-i2c in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo

[PATCH] i2c: add Renesas R-Car I2C driver

2012-07-25 Thread Kuninori Morimoto
R-Car I2C is similar with SH7760 I2C. But the SH7760 I2C driver had many workaround operations, since H/W had bugs. Thus, it was pointless to keep compatible between SH7760 and R-Car I2C drivers. This patch creates new Renesas R-Car I2C driver. Signed-off-by: Kuninori Morimoto kuninori.morimoto

Re: [PATCH] i2c: add Renesas R-Car I2C driver

2012-08-27 Thread Kuninori Morimoto
between SH7760 and R-Car I2C drivers. This patch creates new Renesas R-Car I2C driver. Signed-off-by: Kuninori Morimoto kuninori.morimoto...@renesas.com --- drivers/i2c/busses/Kconfig| 10 + drivers/i2c/busses/Makefile |1 + drivers/i2c/busses/i2c-rcar.c | 741

Re: [PATCH] i2c: add Renesas R-Car I2C driver

2012-08-27 Thread Kuninori Morimoto
Hi Shubhrajyoti Thank you for checking patch. I create v2 patch and post it soon. There is not big reason, but I would like to keep adap-retries for now. On Wed, Jul 25, 2012 at 12:06 PM, Kuninori Morimoto kuninori.morimoto...@renesas.com wrote: R-Car I2C is similar with SH7760 I2C

Re: [PATCH] i2c: add Renesas R-Car I2C driver

2012-08-28 Thread Kuninori Morimoto
device disabled I see. Best regards --- Kuninori Morimoto -- To unsubscribe from this list: send the line unsubscribe linux-i2c in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] i2c: add Renesas R-Car I2C driver

2012-08-28 Thread Kuninori Morimoto
Hi Shubhrajyoti Thank you for checking patch. I create v2 patch and post it soon. There is not big reason, but I would like to keep adap-retries for now. Or maybe just wait for Jean's advice on the same. I see. After Jean's advice, I will send v2 patch. Best regards --- Kuninori

Re: [PATCH v2] i2c: add Renesas R-Car I2C driver

2012-09-27 Thread Kuninori Morimoto
. Signed-off-by: Kuninori Morimoto kuninori.morimoto...@renesas.com --- v1 - v2 - removed #if 0 function - add explanation on rcar_i2c_bus_barrier() - removed IGNORE_NAK support - rename rcar_i2c_soft_reset() - rcar_i2c_init() - removed devm_kfree/devm_iounmap - __raw_writel/readl

Re: [PATCH v2] i2c: add Renesas R-Car I2C driver

2012-09-27 Thread Kuninori Morimoto
Dear Shubhrajyoti Thank you for your comment. Hi A few suggestions, On Tue, Aug 28, 2012 at 2:07 PM, Kuninori Morimoto kuninori.morimoto...@renesas.com wrote: R-Car I2C is similar with SH7760 I2C. But the SH7760 I2C driver had many workaround operations, since H/W had bugs. Thus

[PATCH v3] i2c: add Renesas R-Car I2C driver

2012-09-28 Thread Kuninori Morimoto
R-Car I2C is similar with SH7760 I2C. But the SH7760 I2C driver had many workaround operations, since H/W had bugs. Thus, it was pointless to keep compatible between SH7760 and R-Car I2C drivers. This patch creates new Renesas R-Car I2C driver. Signed-off-by: Kuninori Morimoto kuninori.morimoto

[PATCH] i2c: rcar: used devm_request_and_ioremap() instead of devm_ioremap()

2012-10-11 Thread Kuninori Morimoto
From: Kuninori Morimoto kuninori.morimoto...@renesas.com Signed-off-by: Kuninori Morimoto kuninori.morimoto...@renesas.com --- based on latest linus/master drivers/i2c/busses/i2c-rcar.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/i2c/busses/i2c-rcar.c b

[PATCH] i2c: rcar: fixup section mismatch on rcar_i2c_probe/remove()

2012-10-31 Thread Kuninori Morimoto
Reported-by: Simon Horman ho...@verge.net.au Signed-off-by: Kuninori Morimoto kuninori.morimoto...@renesas.com --- Simon Is this patch solve your issue ? drivers/i2c/busses/i2c-rcar.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/i2c/busses/i2c-rcar.c b

Re: [PATCH v2 1/1] i2c: rcar: modify I2C driver

2013-07-11 Thread Kuninori Morimoto
Hi Wolfram, Dung-san # I added Wolfram's email address From: Nguyen Viet Dung nv-d...@jinso.co.jp This patch modify calculate for clock in I2C driver. Signed-off-by: Nguyen Viet Dung nv-d...@jinso.co.jp --- You forgot to add Wolfram's email address on this patch :) Acked-by: Kuninori

[PATCH] i2c: rcar: fixup rcar type naming

2013-10-04 Thread Kuninori Morimoto
compatible, since still there is no user for i2c-rcar_h1/h2 at this point. Signed-off-by: Kuninori Morimoto kuninori.morimoto...@renesas.com --- drivers/i2c/busses/i2c-rcar.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/drivers/i2c/busses/i2c-rcar.c

Re: [PATCH 0/4] ARM: shmobile: r8a7778/r8a7779: add I2C support on DT

2013-10-04 Thread Kuninori Morimoto
These is no compile error without 2).. Kuninori Morimoto (4): ARM: shmobile: r8a7778: add I2C clock for DT ARM: shmobile: r8a7778: add I2C support on DTSI ARM: shmobile: r8a7779: tidyup I2C driver name on DTSI ARM: shmobile: r8a7779: add I2C clock for DT arch/arm/boot/dts/r8a7778

[PATCH resend] i2c: rcar: fixup rcar type naming

2013-10-21 Thread Kuninori Morimoto
-by: Kuninori Morimoto kuninori.morimoto...@renesas.com --- resend - exchanged Wolfram's email address drivers/i2c/busses/i2c-rcar.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/drivers/i2c/busses/i2c-rcar.c b/drivers/i2c/busses/i2c-rcar.c index

Re: [PATCH resend] i2c: rcar: fixup rcar type naming

2013-10-30 Thread Kuninori Morimoto
compatible. Best regards --- Kuninori Morimoto -- To unsubscribe from this list: send the line unsubscribe linux-i2c in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH] I2C: rcar: add R-Car Gen2 and r8a7791 support for DT

2014-04-10 Thread Kuninori Morimoto
From: Kuninori Morimoto kuninori.morimoto...@renesas.com Signed-off-by: Kuninori Morimoto kuninori.morimoto...@renesas.com --- drivers/i2c/busses/i2c-rcar.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/i2c/busses/i2c-rcar.c b/drivers/i2c/busses/i2c-rcar.c index 0282d4d

Re: [PATCH] I2C: rcar: add R-Car Gen2 and r8a7791 support for DT

2014-04-10 Thread Kuninori Morimoto
Hi Wolfram Please ignore this I noticed that it is already included on linux-next From: Kuninori Morimoto kuninori.morimoto...@renesas.com Signed-off-by: Kuninori Morimoto kuninori.morimoto...@renesas.com --- drivers/i2c/busses/i2c-rcar.c |2 ++ 1 file changed, 2 insertions

Re: [PATCH 00/11] i2c: rcar: cleanup series

2014-05-28 Thread Kuninori Morimoto
patches Acked-by: Kuninori Morimoto kuninori.morimoto...@renesas.com My small opinion is that keeping comment of Arbitration lost (= When arbitration lost, device become _slave_ mode) is helpful for non-renesas freak. I forgot detail, but, this behavior is not documented (?) -- To unsubscribe from

[PATCH 0/5] i2c: rcar: add renesas,i2c-rcar-gen1/gen2 in DT compatible

2014-08-05 Thread Kuninori Morimoto
Hi Wolfram, Simon These patches add R-Car generatoin level DT compatible on i2c-rcar driver and platform. Kuninori Morimoto (5): i2c: rcar: add renesas,i2c-rcar-gen1/gen2 in DT compatible ARM: shmobile: r8a7778: add generation level compatible for i2c ARM: shmobile: r8a7779: add

[PATCH 1/5] i2c: rcar: add renesas,i2c-rcar-gen1/gen2 in DT compatible

2014-08-05 Thread Kuninori Morimoto
From: Kuninori Morimoto kuninori.morimoto...@renesas.com This patch adds DT compatible for Renesas R-Car Gen1/Gen2. Current driver has SoC level .compatible (r8a7778/r8a7779/r8a7790/r8a7791/r8a7792/r8a7793/r8a7794), but these can be match as generation level. Signed-off-by: Kuninori Morimoto

[PATCH 2/5] ARM: shmobile: r8a7778: add generation level compatible for i2c

2014-08-05 Thread Kuninori Morimoto
From: Kuninori Morimoto kuninori.morimoto...@renesas.com Signed-off-by: Kuninori Morimoto kuninori.morimoto...@renesas.com --- arch/arm/boot/dts/r8a7778.dtsi |8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/arm/boot/dts/r8a7778.dtsi b/arch/arm/boot/dts/r8a7778

[PATCH 5/5] ARM: shmobile: r8a7791: add generation level compatible for i2c

2014-08-05 Thread Kuninori Morimoto
From: Kuninori Morimoto kuninori.morimoto...@renesas.com Signed-off-by: Kuninori Morimoto kuninori.morimoto...@renesas.com --- arch/arm/boot/dts/r8a7791.dtsi | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/arch/arm/boot/dts/r8a7791.dtsi b/arch/arm/boot/dts

[PATCH 3/5] ARM: shmobile: r8a7779: add generation level compatible for i2c

2014-08-05 Thread Kuninori Morimoto
From: Kuninori Morimoto kuninori.morimoto...@renesas.com Signed-off-by: Kuninori Morimoto kuninori.morimoto...@renesas.com --- arch/arm/boot/dts/r8a7779.dtsi |8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/arm/boot/dts/r8a7779.dtsi b/arch/arm/boot/dts/r8a7779

[PATCH 4/5] ARM: shmobile: r8a7790: add generation level compatible for i2c

2014-08-05 Thread Kuninori Morimoto
From: Kuninori Morimoto kuninori.morimoto...@renesas.com Signed-off-by: Kuninori Morimoto kuninori.morimoto...@renesas.com --- arch/arm/boot/dts/r8a7790.dtsi |8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/arm/boot/dts/r8a7790.dtsi b/arch/arm/boot/dts/r8a7790

Re: [PATCH 1/5] i2c: rcar: add renesas,i2c-rcar-gen1/gen2 in DT compatible

2014-08-06 Thread Kuninori Morimoto
Hi Simon From: Kuninori Morimoto kuninori.morimoto...@renesas.com This patch adds DT compatible for Renesas R-Car Gen1/Gen2. Current driver has SoC level .compatible (r8a7778/r8a7779/r8a7790/r8a7791/r8a7792/r8a7793/r8a7794), but these can be match as generation level. Hi Morimoto

Re: [PATCH 1/5] i2c: rcar: add renesas,i2c-rcar-gen1/gen2 in DT compatible

2014-08-06 Thread Kuninori Morimoto
all H2/M2/E2/V2. And, from HW team point of view, they don't want to create same name but multi feature IP in same generation. Creating and Testing new IP needs too much time / money / paper work. Best regards --- Kuninori Morimoto -- To unsubscribe from this list: send the line unsubscribe linux

Re: [PATCH 1/5] i2c: rcar: add renesas,i2c-rcar-gen1/gen2 in DT compatible

2014-08-06 Thread Kuninori Morimoto
or later. But yes, we want to know which SoC is supported. We can use Document/devicetree/...txt for this purpose Best regards --- Kuninori Morimoto -- To unsubscribe from this list: send the line unsubscribe linux-i2c in the body of a message to majord...@vger.kernel.org More majordomo info

Re: [PATCH 1/5] i2c: rcar: add renesas,i2c-rcar-gen1/gen2 in DT compatible

2014-08-07 Thread Kuninori Morimoto
for this purpose I agree about that portion. =) Thank you :) Best regards --- Kuninori Morimoto -- To unsubscribe from this list: send the line unsubscribe linux-i2c in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 0/2] ARM: shmobile: r8a7740: move I2C errata handling into the driver

2015-06-10 Thread Kuninori Morimoto
-- drivers/i2c/busses/i2c-sh_mobile.c | 40 + 2 files changed, 40 insertions(+), 55 deletions(-) Thank you for your patches For all patches Acked-by: Kuninori Morimoto kuninori.morimoto...@renesas.com Best regards --- Kuninori Morimoto -- To unsubscribe from this list: send

Re: [PATCH v2] i2c: rcar: make sure clocks are on when doing hw init

2015-10-29 Thread Kuninori Morimoto
Hi Wolfram Sang wrote: > > From: Wolfram Sang <wsa+rene...@sang-engineering.com> > > Reported-by: Kuninori Morimoto <kuninori.morimoto...@renesas.com> > Signed-off-by: Wolfram Sang <wsa+rene...@sang-engineering.com> > --- Please add explain why this patc

Re: [PATCH] i2c: rcar: call rcar_i2c_init() after pm_runtime_get_sync()

2015-10-29 Thread Kuninori Morimoto
Hi Geert > > From: Kuninori Morimoto <kuninori.morimoto...@renesas.com> > > > > rcar_i2c_init() initializes I2C device, but it should be called > > *after* pm_runtime_get_sync(). Otherwise it outputs very hi speed > > clock. This patch solved this issue, &

Re: [PATCH] i2c: rcar: make sure clocks are on when doing hw init

2015-10-29 Thread Kuninori Morimoto
Hi, Wolfram > From: Wolfram Sang <wsa+rene...@sang-engineering.com> > > Reported-by: Kuninori Morimoto <kuninori.morimoto...@renesas.com> > Signed-off-by: Wolfram Sang <wsa+rene...@sang-engineering.com> > --- > drivers/i2c/busses/i2c-rcar.c | 4 +++- &

[PATCH] i2c: rcar: call rcar_i2c_init() after pm_runtime_get_sync()

2015-10-29 Thread Kuninori Morimoto
From: Kuninori Morimoto <kuninori.morimoto...@renesas.com> rcar_i2c_init() initializes I2C device, but it should be called *after* pm_runtime_get_sync(). Otherwise it outputs very hi speed clock. This patch solved this issue, This patch also removes pointless rcar_i2c_init() from rcar_i2c

Re: [PATCH] i2c: rcar: make sure clocks are on when doing hw init

2015-11-11 Thread Kuninori Morimoto
Hi Wolfram > > pm_runtime_get_sync() > > myfunc_A() > > pm_runtime_put() > > ... > > pm_runtime_get_sync() > > myfunc_B() > > pm_runtime_put() > > > > It should be this ? > > > > pm_runtime_get_sync() > > myfunc_A() > > myfunc_B() > >

Re: [PATCH v2 00/10] i2c: rcar: tackle race conditions in the driver

2015-11-12 Thread Kuninori Morimoto
renesas/rcar-i2c-rework-v2 I tested this branch on Lagar and Salvator-X with Sound. (Sound uses I2C for ak4642, ak4613, and CS2000) Actually, above branch is missing some necessary sound patch, but anyway, I2C works good for sound. For all patches Tested-by: Kuninori Morimoto <kuninori

Re: [PATCH] i2c: rcar: make sure clocks are on when doing hw init

2015-11-11 Thread Kuninori Morimoto
Hi Wolfram > > On SH-Mobile case, it automatically power-off:ed if all driver > > user was gone. > > It does that without calling some callback? Do you mean you can call init() in callback ? I don't care detail of design. But my concern was that register value might be disappear during many

Re: [RFT 0/2] i2c: add support for r8a7795 (RCar H3)

2015-09-16 Thread Kuninori Morimoto
| 3 +++ > drivers/i2c/busses/i2c-sh_mobile.c | 1 + > 4 files changed, 6 insertions(+) For all patches, on Salvator-X board with ak4613 / cs2000 chip Tested-by: Kuninori Morimoto <kuninori.morimoto...@renesas.com> -- To unsubscribe from this

Question about i2c_xxx function on CONFIG_I2C

2011-06-27 Thread kuninori . morimoto . gx
i2c_get_adapter(nr) NULL ... #endif Best regards --- Kuninori Morimoto -- To unsubscribe from this list: send the line unsubscribe linux-i2c in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: Question about i2c_xxx function on CONFIG_I2C

2011-06-27 Thread kuninori . morimoto . gx
for example. I understand, thank you. I use #ifdef for it. Best regards --- Kuninori Morimoto -- To unsubscribe from this list: send the line unsubscribe linux-i2c in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html