Re: [PATCH 2/2] i2c-s3c2410: Add stub runtime power management

2012-01-21 Thread Sylwester Nawrocki
On 01/21/2012 02:28 PM, Mark Brown wrote: Add stub runtime_pm calls which go through the flow of enabling and disabling but don't actually do anything with the device itself as there's nothing useful we can do. This provides the core PM framework with information about when the device is idle,

Re: [PATCH 1/2] i2c-s3c2410: Convert to devm_kzalloc()

2012-01-21 Thread Sylwester Nawrocki
On 01/21/2012 02:28 PM, Mark Brown wrote: Saves remembering to call kfree(). There's some kfree()s used by the resource still, these will be removed in 3.3 using the newly added devm_request_and_ioremap(). Signed-off-by: Mark Brown broo...@opensource.wolfsonmicro.com Acked-by: Sylwester

Re: [PATCH 1/2] i2c-s3c2410: Convert to devm_kzalloc()

2012-01-21 Thread Sylwester Nawrocki
On 01/21/2012 02:28 PM, Mark Brown wrote: Saves remembering to call kfree(). There's some kfree()s used by the resource still, these will be removed in 3.3 using the newly added devm_request_and_ioremap(). Signed-off-by: Mark Brown Mark Brownbroo...@opensource.wolfsonmicro.com ---

Re: [PATCH 1/2] i2c-s3c2410: Convert to devm_kzalloc()

2012-01-21 Thread Sylwester Nawrocki
On 01/21/2012 06:57 PM, Mark Brown wrote: On Sat, Jan 21, 2012 at 05:10:22PM +0100, Sylwester Nawrocki wrote: - i2c = kzalloc(sizeof(struct s3c24xx_i2c), GFP_KERNEL); + i2c = devm_kzalloc(pdev-dev, sizeof(struct s3c24xx_i2c), GFP_KERNEL); Just in case you are resending the patch for any

Re: [PATCH] i2c-s3c2410: Add stub runtime power management

2012-01-23 Thread Sylwester Nawrocki
On 01/22/2012 10:39 PM, Mark Brown wrote: On Sun, Jan 22, 2012 at 06:48:36PM +0100, Sylwester Nawrocki wrote: On 01/22/2012 06:27 PM, Bill Gatliff wrote: I for one would rather see in-kernel drivers that require it, and then In fact we have to deal with the opposite now, as some existing

Re: [RFC PATCH 5/7] ARM: davinci: i2c: add OF support

2012-01-23 Thread Sylwester Nawrocki
Hello, On 01/23/2012 09:56 AM, Heiko Schocher wrote: add of support for the davinci i2c driver. Signed-off-by: Heiko Schocherh...@denx.de Cc: davinci-linux-open-sou...@linux.davincidsp.com Cc: linux-arm-ker...@lists.infradead.org Cc: devicetree-disc...@lists.ozlabs.org Cc:

Re: [RFC PATCH 5/7] ARM: davinci: i2c: add OF support

2012-01-24 Thread Sylwester Nawrocki
Hello Heiko, On 01/24/2012 08:18 AM, Heiko Schocher wrote: On 01/23/2012 09:56 AM, Heiko Schocher wrote: add of support for the davinci i2c driver. Signed-off-by: Heiko Schocherh...@denx.de Cc: davinci-linux-open-sou...@linux.davincidsp.com Cc: linux-arm-ker...@lists.infradead.org Cc:

Re: [RFC PATCH 5/7] ARM: davinci: i2c: add OF support

2012-02-05 Thread Sylwester Nawrocki
Hi Grant, On 01/30/2012 09:13 PM, Grant Likely wrote: The whole 'cell-index' or 'id' thing is a BadIdea(tm). Don't use it, and tell others not to do it when you see it. There are some legacy uses in powerpc, but those were written before I and others knew better. The *only* situation

Re: [PATCH 1/2] i2c-s3c2410: Convert to devm_kzalloc()

2012-02-14 Thread Sylwester Nawrocki
Hi Shubhrajyoti, On 02/14/2012 02:03 PM, Shubhrajyoti Datta wrote: Hi Mark, The changes look good to me. Reviewed-by: Datta Shubhrajyoti shubhrajy...@ti.com For your changes. Some other doubts though not related to your patch. Just curious. ... diff --git

Re: [PATCH 3/8] i2c: at91: use an id table for SoC dependent parameters

2012-08-31 Thread Sylwester Nawrocki
On 08/31/2012 04:51 PM, Nicolas Ferre wrote: diff --git a/arch/arm/mach-at91/at91rm9200.c b/arch/arm/mach-at91/at91rm9200.c index f2112f9..0bc91e5 100644 --- a/arch/arm/mach-at91/at91rm9200.c +++ b/arch/arm/mach-at91/at91rm9200.c @@ -187,7 +187,7 @@ static struct clk_lookup

Re: [PATCH 3/8] i2c: at91: use an id table for SoC dependent parameters

2012-09-02 Thread Sylwester Nawrocki
On 09/01/2012 11:10 AM, Jean-Christophe PLAGNIOL-VILLARD wrote: On 22:47 Fri 31 Aug , Sylwester Nawrocki wrote: On 08/31/2012 04:51 PM, Nicolas Ferre wrote: diff --git a/arch/arm/mach-at91/at91rm9200.c b/arch/arm/mach-at91/at91rm9200.c index f2112f9..0bc91e5 100644 --- a/arch/arm/mach

Re: [REPOST PATCH 2/2] i2c: pxa: Use i2c-core to get bus number now

2013-01-11 Thread Sylwester Nawrocki
Hi, On 01/11/2013 06:57 PM, Doug Anderson wrote: The commit: i2c-core: dt: Pick i2c bus number from i2c alias if present adds support for automatically picking the bus number based on the alias ID. Remove the now unnecessary code from i2c-pxa that did the same thing. Signed-off-by: Doug

Re: Writing I2C Sensor Kernel Modules

2013-06-27 Thread Sylwester Nawrocki
Hi, On 06/27/2013 04:33 PM, Robin Müller-Bady wrote: I have a (architectural design) question about I2C drivers in kernel space. Currently, I'm writing userspace software for using external sensors on an raspberry pi via bcm2835's I2C bus with the help of wiringPi/ioctl, e.g. the barometric

Re: [PATCH RESEND] i2c: move of helpers into the core

2013-08-19 Thread Sylwester Nawrocki
tests very welcome. Thanks! drivers/i2c/busses/i2c-s3c2410.c|2 - drivers/media/platform/exynos4-is/fimc-is-i2c.c |3 - For these: Acked-by: Sylwester Nawrocki s.nawro...@amsung.com However this patch fails to apply onto either v3.11-rc4 or v3.11-rc6: Applying: i2c

Re: [PATCH V2] i2c: move of helpers into the core

2013-08-21 Thread Sylwester Nawrocki
instead of doing this manually in each driver. So, fix the drivers and documentation, too. Acked-by: Sylwester Nawrocki s.nawro...@amsung.com Acked-by: Rob Herring rob.herr...@calxeda.com Reviewed-by: Felipe Balbi ba...@ti.com Acked-by: Rafael J. Wysocki rafael.j.wyso...@intel.com Signed

Re: [PATCH v2 1/9] i2c: prepare runtime PM support for I2C client devices

2013-09-12 Thread Sylwester Nawrocki
On 09/11/2013 05:32 PM, Mika Westerberg wrote: From: Aaron Luaaron...@intel.com This patch adds runtime PM support for the I2C bus in a similar way that has been done for PCI bus already. This means that the I2C bus core prepares runtime PM for a client device just before a driver is about to

Re: [PATCH v2 1/9] i2c: prepare runtime PM support for I2C client devices

2013-09-13 Thread Sylwester Nawrocki
On 09/13/2013 08:54 AM, Mika Westerberg wrote: On Thu, Sep 12, 2013 at 02:34:21PM -0700, Kevin Hilman wrote: diff --git a/drivers/i2c/i2c-core.c b/drivers/i2c/i2c-core.c index f32ca29..44374b4 100644 --- a/drivers/i2c/i2c-core.c +++ b/drivers/i2c/i2c-core.c @@ -248,11 +248,30 @@

Re: [PATCH v2 1/9] i2c: prepare runtime PM support for I2C client devices

2013-09-17 Thread Sylwester Nawrocki
On 09/16/2013 10:47 AM, Mika Westerberg wrote: I'm actually thinking that it is probably better now if we don't touch the client runtime PM at all in the I2C core. I proposed a less intrusive solution in this same thread where we power the I2C controller briefly at the client -probe() (In

Re: [alsa-devel] [PATCH 1/8] [media] s5c73m3: Don't use i2c_client-driver

2013-09-29 Thread Sylwester Nawrocki
. Signed-off-by: Lars-Peter Clausenl...@metafoo.de Cc: Kyungmin Parkkyungmin.p...@samsung.com Cc: Andrzej Hajdaa.ha...@samsung.com Acked-by: Sylwester Nawrocki s.nawro...@samsung.com -- To unsubscribe from this list: send the line unsubscribe linux-i2c in the body of a message to majord

Re: [alsa-devel] [PATCH 2/8] [media] exynos4-is: Don't use i2c_client-driver

2013-09-29 Thread Sylwester Nawrocki
. Signed-off-by: Lars-Peter Clausenl...@metafoo.de Cc: Kyungmin Parkkyungmin.p...@samsung.com Cc: Sylwester Nawrockis.nawro...@samsung.com Acked-by: Sylwester Nawrocki s.nawro...@samsung.com -- To unsubscribe from this list: send the line unsubscribe linux-i2c in the body of a message to majord

I2C dummy adapter driver ?

2014-02-19 Thread Sylwester Nawrocki
Hi All, I was wondering whether it would be reasonable to create a generic Linux dummy I2C bus controller driver. The rationale behind it is there might be hardware configurations where I2C communication is handled by firmware but still it is useful to have I2C slave devices instantiated by a

Re: I2C dummy adapter driver ?

2014-02-21 Thread Sylwester Nawrocki
On 20/02/14 17:49, Stephen Warren wrote: On 02/19/2014 04:03 PM, Sylwester Nawrocki wrote: [...] I was wondering whether it would be reasonable to create a generic Linux dummy I2C bus controller driver. The rationale behind it is there might be hardware configurations where I2C communication

Re: I2C dummy adapter driver ?

2014-02-21 Thread Sylwester Nawrocki
On 21/02/14 06:57, Jassi Brar wrote: On 20 February 2014 04:33, Sylwester Nawrocki sylvester.nawro...@gmail.com wrote: Hi All, I was wondering whether it would be reasonable to create a generic Linux dummy I2C bus controller driver. The rationale behind it is there might be hardware

Re: I2C dummy adapter driver ?

2014-03-04 Thread Sylwester Nawrocki
On 28/02/14 07:07, Mark Brown wrote: On Fri, Feb 21, 2014 at 12:45:21PM +0100, Sylwester Nawrocki wrote: The I2C bus driver with empty i2c_algorithm.master_xfer() helps WRT to using standard DT binding and v4l2_subdev interface. Wouldn't a platform device do just as well here if there's

Re: I2C dummy adapter driver ?

2014-03-07 Thread Sylwester Nawrocki
On 05/03/14 02:15, Mark Brown wrote: On Tue, Mar 04, 2014 at 12:38:28PM +0100, Sylwester Nawrocki wrote: On 28/02/14 07:07, Mark Brown wrote: On Fri, Feb 21, 2014 at 12:45:21PM +0100, Sylwester Nawrocki wrote: The I2C bus driver with empty i2c_algorithm.master_xfer() helps WRT to using

[PATCH/RFC V7] clk: Default clock parents and rates assigned from DT

2014-06-18 Thread Sylwester Nawrocki
and browsed at http://git.linuxtv.org/cgit.cgi/snawrocki/samsung.git/log/?h=v3.16-rc1-odroid-sound-clk Sylwester Nawrocki (1): clk: Support for clock parents and rates assigned from device tree .../devicetree/bindings/clock/clock-bindings.txt | 36 + drivers/base/platform.c

[PATCH/RFC V7] clk: Support for clock parents and rates assigned from device tree

2014-06-18 Thread Sylwester Nawrocki
the driver probing and also in the clock core after registration of a clock provider. Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com Acked-by: Kyungmin Park kyungmin.p...@samsung.com --- Changes since v6: - use a set of separate DT properties to specify the default parent clocks

Re: [PATCH/RFC V7] clk: Support for clock parents and rates assigned from device tree

2014-06-18 Thread Sylwester Nawrocki
Please ignore this patch, I'll send the correct one in a while. My apologies for spamming. On 18/06/14 12:47, Sylwester Nawrocki wrote: This patch adds helper functions to configure clock parents and rates as specified through 'assigned-clock-parents', 'assigned-clock-rates' DT properties

[PATCH/RFC V8 1/1] clk: Support for clock parents and rates assigned from device tree

2014-06-18 Thread Sylwester Nawrocki
the driver probing and also in the clock core after registration of a clock provider. Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com Acked-by: Kyungmin Park kyungmin.p...@samsung.com --- Changes since v6: - use a set of separate DT properties to specify the default parent clocks

Re: [PATCH/RFC V8 1/1] clk: Support for clock parents and rates assigned from device tree

2014-07-03 Thread Sylwester Nawrocki
On 18/06/14 17:29, Sylwester Nawrocki wrote: This patch adds helper functions to configure clock parents and rates as specified through 'assigned-clock-parents', 'assigned-clock-rates' DT properties for a clock provider or clock consumer device. The helpers are now being called by the bus code

Re: [PATCH] i2c: s3c2410: Don't enable PM runtime on the adapter device

2015-04-16 Thread Sylwester Nawrocki
On 16/04/15 12:10, Charles Keepax wrote: Commit 523c5b89640e (i2c: Remove support for legacy PM) removed the PM ops from the bus type, which causes the pm operations on the s3c2410 adapter device to fail (-ENOSUPP in rpm_callback). The adapter device doesn't get bound to a driver and as such

Re: [PATCH] i2c: s3c2410: remove superfluous runtime PM calls

2015-12-16 Thread Sylwester Nawrocki
On 15/12/15 19:14, Wolfram Sang wrote: > Since commit 6ada5c1e1b077a ("i2c: Mark adapter devices with > pm_runtime_no_callbacks"), runtime PM on adapters turned into a no-op. > So, we can remove these calls. Won't this break i2c client devices that use runtime PM? Not sure if any cases of such