Re: [RFC] i2c: Revert back to old device naming for ACPI enumerated I2C slaves

2015-08-25 Thread Wolfram Sang
So I am not surprised that this only shows up now. I am, to be honest. It shows running lm-sensors with ACPI on a kernel newer than 18 months. Not a rare scenario, so I thought. And thanks to Mark's recent post I understand now that this is only relevant for ACPI5 enumerated devices. I

Re: [RFC] i2c: Revert back to old device naming for ACPI enumerated I2C slaves

2015-08-25 Thread Wolfram Sang
On Tue, Aug 25, 2015 at 08:18:30AM -0700, Guenter Roeck wrote: On 08/25/2015 07:57 AM, Wolfram Sang wrote: On Tue, Aug 25, 2015 at 06:25:13AM +0100, Mark Brown wrote: On Mon, Aug 24, 2015 at 01:52:02PM +0300, Jarkko Nikula wrote: Commit 70762abb9f89 (i2c: Use stable dev_name for ACPI

Re: [RFC] i2c: Revert back to old device naming for ACPI enumerated I2C slaves

2015-08-25 Thread Guenter Roeck
On 08/25/2015 09:18 AM, Wolfram Sang wrote: On Tue, Aug 25, 2015 at 08:18:30AM -0700, Guenter Roeck wrote: On 08/25/2015 07:57 AM, Wolfram Sang wrote: On Tue, Aug 25, 2015 at 06:25:13AM +0100, Mark Brown wrote: On Mon, Aug 24, 2015 at 01:52:02PM +0300, Jarkko Nikula wrote: Commit

Re: [RFC] i2c: Revert back to old device naming for ACPI enumerated I2C slaves

2015-08-25 Thread Jarkko Nikula
On 08/25/2015 08:03 AM, Dustin Byford wrote: On Mon Aug 24 13:52, Jarkko Nikula wrote: I don't know how common ACPI enumerated I2C hwmon devices are but I guess they exists since Dustin notices this issue and wrote With that change, /sys/bus/i2c/devices/i2c-0-004a, for example, became

Re: [RFC] i2c: Revert back to old device naming for ACPI enumerated I2C slaves

2015-08-25 Thread Wolfram Sang
In this particular case it looks like we need a mechanism to use the old naming scheme for hwmon and the new one for everything else or something similar. I'm afraid I am not familiar enough with the i2c core to suggest anything specific ATM, though. Well, it boils down to directory names

Re: [RFC] i2c: Revert back to old device naming for ACPI enumerated I2C slaves

2015-08-25 Thread Wolfram Sang
On Tue, Aug 25, 2015 at 06:25:13AM +0100, Mark Brown wrote: On Mon, Aug 24, 2015 at 01:52:02PM +0300, Jarkko Nikula wrote: Commit 70762abb9f89 (i2c: Use stable dev_name for ACPI enumerated I2C slaves) broke the lm-sensors which relies on I2C hwmon slave devices under /sys/bus/i2c/devices/

Re: [RFC] i2c: Revert back to old device naming for ACPI enumerated I2C slaves

2015-08-25 Thread Guenter Roeck
On 08/25/2015 07:57 AM, Wolfram Sang wrote: On Tue, Aug 25, 2015 at 06:25:13AM +0100, Mark Brown wrote: On Mon, Aug 24, 2015 at 01:52:02PM +0300, Jarkko Nikula wrote: Commit 70762abb9f89 (i2c: Use stable dev_name for ACPI enumerated I2C slaves) broke the lm-sensors which relies on I2C hwmon

Re: [RFC] i2c: Revert back to old device naming for ACPI enumerated I2C slaves

2015-08-25 Thread Mark Brown
On Tue, Aug 25, 2015 at 04:57:56PM +0200, Wolfram Sang wrote: On Tue, Aug 25, 2015 at 06:25:13AM +0100, Mark Brown wrote: On Mon, Aug 24, 2015 at 01:52:02PM +0300, Jarkko Nikula wrote: Commit 70762abb9f89 (i2c: Use stable dev_name for ACPI enumerated I2C slaves) broke the lm-sensors

Re: [RFC] i2c: Revert back to old device naming for ACPI enumerated I2C slaves

2015-08-24 Thread Wolfram Sang
On Mon, Aug 24, 2015 at 01:52:02PM +0300, Jarkko Nikula wrote: Commit 70762abb9f89 (i2c: Use stable dev_name for ACPI enumerated I2C slaves) broke the lm-sensors which relies on I2C hwmon slave devices under /sys/bus/i2c/devices/ to be named as x-00yz. However if those hwmon devices are ACPI 5

[RFC] i2c: Revert back to old device naming for ACPI enumerated I2C slaves

2015-08-24 Thread Jarkko Nikula
Commit 70762abb9f89 (i2c: Use stable dev_name for ACPI enumerated I2C slaves) broke the lm-sensors which relies on I2C hwmon slave devices under /sys/bus/i2c/devices/ to be named as x-00yz. However if those hwmon devices are ACPI 5 enumerated their name became i2c-INTABCD:ij and sysfs code in

Re: [RFC] i2c: Revert back to old device naming for ACPI enumerated I2C slaves

2015-08-24 Thread Rafael J. Wysocki
On Monday, August 24, 2015 03:26:13 PM Wolfram Sang wrote: On Mon, Aug 24, 2015 at 01:52:02PM +0300, Jarkko Nikula wrote: Commit 70762abb9f89 (i2c: Use stable dev_name for ACPI enumerated I2C slaves) broke the lm-sensors which relies on I2C hwmon slave devices under /sys/bus/i2c/devices/ to

Re: [RFC] i2c: Revert back to old device naming for ACPI enumerated I2C slaves

2015-08-24 Thread Mark Brown
On Mon, Aug 24, 2015 at 01:52:02PM +0300, Jarkko Nikula wrote: Commit 70762abb9f89 (i2c: Use stable dev_name for ACPI enumerated I2C slaves) broke the lm-sensors which relies on I2C hwmon slave devices under /sys/bus/i2c/devices/ to be named as x-00yz. However if those hwmon devices are ACPI 5