Re: Issues with touchpad / touchscreen on yoga 900
> The fix is included in the "intel-lpss: support for non-ACPI platforms" > series by Andy [1]. You and Kevin are both Cc'd. Thanks for this info! signature.asc Description: Digital signature
Re: Issues with touchpad / touchscreen on yoga 900
On Tue, Dec 01, 2015 at 01:35:54AM +0100, Wolfram Sang wrote: > I didn't find any patch coming out of this? Mika, did I miss something? The fix is included in the "intel-lpss: support for non-ACPI platforms" series by Andy [1]. You and Kevin are both Cc'd. https://lkml.org/lkml/2015/11/30/441 The patch solving this issue is "[14/16] mfd: intel-lpss: Pass SDA hold time to I2C host controller driver". -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: Issues with touchpad / touchscreen on yoga 900
On Wed, Nov 04, 2015 at 07:51:43AM -0700, Kevin Fenzi wrote: > On Tue, 3 Nov 2015 10:18:40 +0200 > Mika Westerberg wrote: > > > On Mon, Nov 02, 2015 at 12:47:28PM -0700, Kevin Fenzi wrote: > > > Any other ideas or things to try? > > > > > > It would be nice to have a working touchpad. ;) > > > > Please attach acpidump of that machine to the bug (or send it directly > > to me) and provide full dmesg with i2c_hid.debug=1. > > Just to circle back here, I exchanged some emails with Mika and this > one liner gets it working... > > Hopefully something can be made upstreamable from this. Thanks much. I didn't find any patch coming out of this? Mika, did I miss something? > > kevin > -- > diff --git a/drivers/i2c/busses/i2c-designware-platdrv.c > b/drivers/i2c/busses/i2c-designware-platdrv.c > index 3dd2de3..31ea736 100644 > --- a/drivers/i2c/busses/i2c-designware-platdrv.c > +++ b/drivers/i2c/busses/i2c-designware-platdrv.c > @@ -90,6 +90,11 @@ static int dw_i2c_acpi_configure(struct platform_device > *pdev) > dw_i2c_acpi_params(pdev, "SSCN", &dev->ss_hcnt, &dev->ss_lcnt, NULL); > dw_i2c_acpi_params(pdev, "FMCN", &dev->fs_hcnt, &dev->fs_lcnt, >&dev->sda_hold_time); > > + dev->sda_hold_time = 30; > > /* > * Provide a way for Designware I2C host controllers that are not signature.asc Description: Digital signature
Re: Issues with touchpad / touchscreen on yoga 900
On Tue, 3 Nov 2015 10:18:40 +0200 Mika Westerberg wrote: > On Mon, Nov 02, 2015 at 12:47:28PM -0700, Kevin Fenzi wrote: > > Any other ideas or things to try? > > > > It would be nice to have a working touchpad. ;) > > Please attach acpidump of that machine to the bug (or send it directly > to me) and provide full dmesg with i2c_hid.debug=1. Just to circle back here, I exchanged some emails with Mika and this one liner gets it working... Hopefully something can be made upstreamable from this. Thanks much. kevin -- diff --git a/drivers/i2c/busses/i2c-designware-platdrv.c b/drivers/i2c/busses/i2c-designware-platdrv.c index 3dd2de3..31ea736 100644 --- a/drivers/i2c/busses/i2c-designware-platdrv.c +++ b/drivers/i2c/busses/i2c-designware-platdrv.c @@ -90,6 +90,11 @@ static int dw_i2c_acpi_configure(struct platform_device *pdev) dw_i2c_acpi_params(pdev, "SSCN", &dev->ss_hcnt, &dev->ss_lcnt, NULL); dw_i2c_acpi_params(pdev, "FMCN", &dev->fs_hcnt, &dev->fs_lcnt, &dev->sda_hold_time); + dev->sda_hold_time = 30; /* * Provide a way for Designware I2C host controllers that are not pgpa98qE9lUzw.pgp Description: OpenPGP digital signature
Re: Issues with touchpad / touchscreen on yoga 900
On Mon, Nov 02, 2015 at 12:47:28PM -0700, Kevin Fenzi wrote: > Any other ideas or things to try? > > It would be nice to have a working touchpad. ;) Please attach acpidump of that machine to the bug (or send it directly to me) and provide full dmesg with i2c_hid.debug=1. -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: Issues with touchpad / touchscreen on yoga 900
On Fri, 30 Oct 2015 10:04:42 -0600 Kevin Fenzi wrote: > On Fri, 30 Oct 2015 09:58:14 +0200 > Jarkko Nikula wrote: > > > Hi > > > > On 10/29/2015 08:30 PM, Wolfram Sang wrote: > > > On Thu, Oct 29, 2015 at 11:29:13AM -0600, Kevin Fenzi wrote: > > >> Greetings. > > >> > > >> I'm having problems with a lenovo yoga 900 not seeing it's > > >> touchscreen or touchpad. > > >> > > >> Downstream bug: > > >> https://bugzilla.redhat.com/show_bug.cgi?id=1275718 > > >> > > >> The problem parts of dmesg seem to be: > > >> > > >> Oct 26 15:20:08 localhost kernel: i2c_designware > > >> i2c_designware.1: i2c_dw_handle_tx_abort: lost arbitration Oct > > >> 26 15:20:08 localhost kernel: i2c_hid i2c-SYNA2B29:00: > > >> hid_descr_cmd failed Oct 26 15:20:08 localhost kernel: > > >> i2c_designware i2c_designware.2: i2c_dw_handle_tx_abort: lost > > >> arbitration Oct 26 15:20:08 localhost kernel: i2c_hid > > >> i2c-ELAN21EF:00: hid_descr_cmd failed > > >> > > >> This is with 4.3.0-0.rc7.git1.1.fc24.x86_64 (post rc7 4.3.0). > > >> > > >> Happy to gather further info or try patches. ;) > > > > > Could you try this test patch from Mika that prints the parameters > > it gets from ACPI and forces using calculated ones (your quirk was > > supposed to be doing the same): > > > > http://www.spinics.net/lists/linux-i2c/msg21239.html > > ok. That gives me: > > [157408.224530] i2c_designware i2c_designware.1: ACPI SSCN 0:0 > [157408.224534] i2c_designware i2c_designware.1: ACPI FMCN 0:0 > [157408.224536] i2c_designware i2c_designware.1: ACPI SDA hold 0 > [157408.228054] i2c_designware i2c_designware.1: > i2c_dw_handle_tx_abort: lost arbitration [157408.228061] i2c_hid > i2c-SYNA2B29:00: hid_descr_cmd failed [157408.235275] > [157408.250399] i2c_designware i2c_designware.2: ACPI SSCN 0:0 > [157408.250403] i2c_designware i2c_designware.2: ACPI FMCN 0:0 > [157408.250405] i2c_designware i2c_designware.2: ACPI SDA hold 0 > [157408.261255] idma64 idma64.2: idma64_irq: status=0x0 > [157408.261284] idma64 idma64.2: idma64_irq: status=0x0 > [157408.261319] i2c_designware i2c_designware.2: > i2c_dw_handle_tx_abort: lost arbitration [157408.261325] i2c_hid > i2c-ELAN21EF:00: hid_descr_cmd failed > > Also, if it helps with i2c-hid debug=1: > > Oct 30 12:02:10 localhost kernel: i2c_hid i2c-ITE8396:00: Fetching > the HID descriptor Oct 30 12:02:10 localhost kernel: i2c_hid > i2c-ITE8396:00: __i2c_hid_command: cmd=01 00 Oct 30 12:02:10 > localhost kernel: i2c_hid i2c-ITE8396:00: HID Descriptor: 1e 00 00 01 > dc 0a 02 00 03 00 16 00 04 00 00 00 05 00 06 00 8d 04 96 83 17 10 00 > 00 00 00 Oct 30 12:02:10 localhost kernel: i2c_hid i2c-ITE8396:00: > entering i2c_hid_parse Oct 30 12:02:10 localhost kernel: i2c_hid > i2c-ITE8396:00: i2c_hid_hwreset Oct 30 12:02:10 localhost kernel: > i2c_hid i2c-ITE8396:00: i2c_hid_set_power Oct 30 12:02:10 localhost > kernel: i2c_hid i2c-ITE8396:00: __i2c_hid_command: cmd=05 00 00 08 > Oct 30 12:02:10 localhost kernel: i2c_hid i2c-ITE8396:00: input: 0c > 00 01 02 02 ed ff 82 fc 89 fe 00 Oct 30 12:02:10 localhost kernel: > i2c_hid i2c-ITE8396:00: resetting... Oct 30 12:02:10 localhost > kernel: i2c_hid i2c-ITE8396:00: __i2c_hid_command: cmd=05 00 00 01 > Oct 30 12:02:10 localhost kernel: i2c_hid i2c-ITE8396:00: > __i2c_hid_command: waiting... Oct 30 12:02:10 localhost kernel: > i2c_hid i2c-ITE8396:00: __i2c_hid_command: finished. Oct 30 12:02:10 > localhost kernel: i2c_hid i2c-ITE8396:00: asking HID report > descriptor Oct 30 12:02:10 localhost kernel: i2c_hid i2c-ITE8396:00: > __i2c_hid_command: cmd=02 00 Oct 30 12:02:11 localhost kernel: > i2c_hid i2c-ITE8396:00: Report Descriptor: 06 83 ff 09 80 a1 01 85 5a > 09 01 15 00 26 ff 00 75 08 95 10 b1 00 c0 05 20 09 01 a1 01 85 01 05 > 20 09 73 a1 00 05 20 0a 09 03 15 00 25 02 75 08 95 01 a1 02 0a 30 08 > 0a 31 08 0a 32 08 b1 00 c0 Oct 30 12:02:11 localhost kernel: i2c_hid > i2c-ITE8396:00: input: 11 00 02 02 02 00 00 00 00 00 00 00 00 00 00 > 00 00 Oct 30 12:02:11 localhost kernel: i2c_hid i2c-ITE8396:00: > input: 14 00 03 02 02 9b 06 5e b5 fb ff c3 32 f4 ff c3 71 14 00 03 > Oct 30 12:02:11 localhost kernel: i2c_hid i2c-ITE8396:00: > i2c_hid_get_report Oct 30 12:02:11 localhost kernel: i2c_hid > i2c-ITE8396:00: __i2c_hid_command: cmd=05 00 3f 02 5a 06 00 Oct 30 > 12:02:11 localhost kernel: i2c_hid i2c-ITE8396:00: report (len=19): > 12 00 5a ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff 00 Oct 30 > 12:02:11 localhost kernel: i2c_hid i2c-ITE8396:00: error in > i2c_hid_init_report size:19 / ret_size:18 Oct 30 12:02:11 localhost > kernel: i2c_hid i2c-ITE8396:00: i2c_hid_get_report Oct 30 12:02:11 > localhost kernel: i2c_hid i2c-ITE8396:00: __i2c_hid_command: cmd=05 > 00 31 02 06 00 Oct 30 12:02:11 localhost kernel: i2c_hid > i2c-ITE8396:00: report (len=21): 15 00 01 01 02 02 02 c8 00 00 00 02 > 00 02 00 32 00 a0 0f 60 f0 Oct 30 12:02:11 localhost kernel: i2c_hid > i2c-ITE8396:00: i2c_hid_get_report Oct 30 12:02:11 localhost kernel: > i2c_hid i2c-ITE8396:00: _
Re: Issues with touchpad / touchscreen on yoga 900
On Fri, 30 Oct 2015 09:58:14 +0200 Jarkko Nikula wrote: > Hi > > On 10/29/2015 08:30 PM, Wolfram Sang wrote: > > On Thu, Oct 29, 2015 at 11:29:13AM -0600, Kevin Fenzi wrote: > >> Greetings. > >> > >> I'm having problems with a lenovo yoga 900 not seeing it's > >> touchscreen or touchpad. > >> > >> Downstream bug: > >> https://bugzilla.redhat.com/show_bug.cgi?id=1275718 > >> > >> The problem parts of dmesg seem to be: > >> > >> Oct 26 15:20:08 localhost kernel: i2c_designware i2c_designware.1: > >> i2c_dw_handle_tx_abort: lost arbitration Oct 26 15:20:08 localhost > >> kernel: i2c_hid i2c-SYNA2B29:00: hid_descr_cmd failed Oct 26 > >> 15:20:08 localhost kernel: i2c_designware i2c_designware.2: > >> i2c_dw_handle_tx_abort: lost arbitration Oct 26 15:20:08 localhost > >> kernel: i2c_hid i2c-ELAN21EF:00: hid_descr_cmd failed > >> > >> This is with 4.3.0-0.rc7.git1.1.fc24.x86_64 (post rc7 4.3.0). > >> > >> Happy to gather further info or try patches. ;) > > > Could you try this test patch from Mika that prints the parameters it > gets from ACPI and forces using calculated ones (your quirk was > supposed to be doing the same): > > http://www.spinics.net/lists/linux-i2c/msg21239.html ok. That gives me: [157408.224530] i2c_designware i2c_designware.1: ACPI SSCN 0:0 [157408.224534] i2c_designware i2c_designware.1: ACPI FMCN 0:0 [157408.224536] i2c_designware i2c_designware.1: ACPI SDA hold 0 [157408.228054] i2c_designware i2c_designware.1: i2c_dw_handle_tx_abort: lost arbitration [157408.228061] i2c_hid i2c-SYNA2B29:00: hid_descr_cmd failed [157408.235275] [157408.250399] i2c_designware i2c_designware.2: ACPI SSCN 0:0 [157408.250403] i2c_designware i2c_designware.2: ACPI FMCN 0:0 [157408.250405] i2c_designware i2c_designware.2: ACPI SDA hold 0 [157408.261255] idma64 idma64.2: idma64_irq: status=0x0 [157408.261284] idma64 idma64.2: idma64_irq: status=0x0 [157408.261319] i2c_designware i2c_designware.2: i2c_dw_handle_tx_abort: lost arbitration [157408.261325] i2c_hid i2c-ELAN21EF:00: hid_descr_cmd failed Also, if it helps with i2c-hid debug=1: Oct 30 12:02:10 localhost kernel: i2c_hid i2c-ITE8396:00: Fetching the HID descriptor Oct 30 12:02:10 localhost kernel: i2c_hid i2c-ITE8396:00: __i2c_hid_command: cmd=01 00 Oct 30 12:02:10 localhost kernel: i2c_hid i2c-ITE8396:00: HID Descriptor: 1e 00 00 01 dc 0a 02 00 03 00 16 00 04 00 00 00 05 00 06 00 8d 04 96 83 17 10 00 00 00 00 Oct 30 12:02:10 localhost kernel: i2c_hid i2c-ITE8396:00: entering i2c_hid_parse Oct 30 12:02:10 localhost kernel: i2c_hid i2c-ITE8396:00: i2c_hid_hwreset Oct 30 12:02:10 localhost kernel: i2c_hid i2c-ITE8396:00: i2c_hid_set_power Oct 30 12:02:10 localhost kernel: i2c_hid i2c-ITE8396:00: __i2c_hid_command: cmd=05 00 00 08 Oct 30 12:02:10 localhost kernel: i2c_hid i2c-ITE8396:00: input: 0c 00 01 02 02 ed ff 82 fc 89 fe 00 Oct 30 12:02:10 localhost kernel: i2c_hid i2c-ITE8396:00: resetting... Oct 30 12:02:10 localhost kernel: i2c_hid i2c-ITE8396:00: __i2c_hid_command: cmd=05 00 00 01 Oct 30 12:02:10 localhost kernel: i2c_hid i2c-ITE8396:00: __i2c_hid_command: waiting... Oct 30 12:02:10 localhost kernel: i2c_hid i2c-ITE8396:00: __i2c_hid_command: finished. Oct 30 12:02:10 localhost kernel: i2c_hid i2c-ITE8396:00: asking HID report descriptor Oct 30 12:02:10 localhost kernel: i2c_hid i2c-ITE8396:00: __i2c_hid_command: cmd=02 00 Oct 30 12:02:11 localhost kernel: i2c_hid i2c-ITE8396:00: Report Descriptor: 06 83 ff 09 80 a1 01 85 5a 09 01 15 00 26 ff 00 75 08 95 10 b1 00 c0 05 20 09 01 a1 01 85 01 05 20 09 73 a1 00 05 20 0a 09 03 15 00 25 02 75 08 95 01 a1 02 0a 30 08 0a 31 08 0a 32 08 b1 00 c0 Oct 30 12:02:11 localhost kernel: i2c_hid i2c-ITE8396:00: input: 11 00 02 02 02 00 00 00 00 00 00 00 00 00 00 00 00 Oct 30 12:02:11 localhost kernel: i2c_hid i2c-ITE8396:00: input: 14 00 03 02 02 9b 06 5e b5 fb ff c3 32 f4 ff c3 71 14 00 03 Oct 30 12:02:11 localhost kernel: i2c_hid i2c-ITE8396:00: i2c_hid_get_report Oct 30 12:02:11 localhost kernel: i2c_hid i2c-ITE8396:00: __i2c_hid_command: cmd=05 00 3f 02 5a 06 00 Oct 30 12:02:11 localhost kernel: i2c_hid i2c-ITE8396:00: report (len=19): 12 00 5a ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff 00 Oct 30 12:02:11 localhost kernel: i2c_hid i2c-ITE8396:00: error in i2c_hid_init_report size:19 / ret_size:18 Oct 30 12:02:11 localhost kernel: i2c_hid i2c-ITE8396:00: i2c_hid_get_report Oct 30 12:02:11 localhost kernel: i2c_hid i2c-ITE8396:00: __i2c_hid_command: cmd=05 00 31 02 06 00 Oct 30 12:02:11 localhost kernel: i2c_hid i2c-ITE8396:00: report (len=21): 15 00 01 01 02 02 02 c8 00 00 00 02 00 02 00 32 00 a0 0f 60 f0 Oct 30 12:02:11 localhost kernel: i2c_hid i2c-ITE8396:00: i2c_hid_get_report Oct 30 12:02:11 localhost kernel: i2c_hid i2c-ITE8396:00: __i2c_hid_command: cmd=05 00 32 02 06 00 Oct 30 12:02:11 localhost kernel: i2c_hid i2c-ITE8396:00: report (len=31): 1f 00 02 01 01 06 02 64 00 00 00 58 1b 00 00 e0 70 72 00 50 c3 00 00 00 c2 eb 0b 00 3e 14 f4 Oct 30 12:02:11 localhost ke
Re: Issues with touchpad / touchscreen on yoga 900
Hi On 10/29/2015 08:30 PM, Wolfram Sang wrote: On Thu, Oct 29, 2015 at 11:29:13AM -0600, Kevin Fenzi wrote: Greetings. I'm having problems with a lenovo yoga 900 not seeing it's touchscreen or touchpad. Downstream bug: https://bugzilla.redhat.com/show_bug.cgi?id=1275718 The problem parts of dmesg seem to be: Oct 26 15:20:08 localhost kernel: i2c_designware i2c_designware.1: i2c_dw_handle_tx_abort: lost arbitration Oct 26 15:20:08 localhost kernel: i2c_hid i2c-SYNA2B29:00: hid_descr_cmd failed Oct 26 15:20:08 localhost kernel: i2c_designware i2c_designware.2: i2c_dw_handle_tx_abort: lost arbitration Oct 26 15:20:08 localhost kernel: i2c_hid i2c-ELAN21EF:00: hid_descr_cmd failed This is with 4.3.0-0.rc7.git1.1.fc24.x86_64 (post rc7 4.3.0). Happy to gather further info or try patches. ;) Could you try this test patch from Mika that prints the parameters it gets from ACPI and forces using calculated ones (your quirk was supposed to be doing the same): http://www.spinics.net/lists/linux-i2c/msg21239.html Another fix from Mika that comes to my mind is "HID: multitouch: Fetch feature reports on demand for Win8 devices" which is sitting in linux-next. Not sure is it related but probably worth to try. https://lkml.org/lkml/2015/9/28/404 -- Jarkko -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: Issues with touchpad / touchscreen on yoga 900
On Thu, Oct 29, 2015 at 11:29:13AM -0600, Kevin Fenzi wrote: > Greetings. > > I'm having problems with a lenovo yoga 900 not seeing it's touchscreen > or touchpad. > > Downstream bug: > https://bugzilla.redhat.com/show_bug.cgi?id=1275718 > > The problem parts of dmesg seem to be: > > Oct 26 15:20:08 localhost kernel: i2c_designware i2c_designware.1: > i2c_dw_handle_tx_abort: lost arbitration > Oct 26 15:20:08 localhost kernel: i2c_hid i2c-SYNA2B29:00: hid_descr_cmd > failed > Oct 26 15:20:08 localhost kernel: i2c_designware i2c_designware.2: > i2c_dw_handle_tx_abort: lost arbitration > Oct 26 15:20:08 localhost kernel: i2c_hid i2c-ELAN21EF:00: > hid_descr_cmd failed > > This is with 4.3.0-0.rc7.git1.1.fc24.x86_64 (post rc7 4.3.0). > > Happy to gather further info or try patches. ;) Ccing more people... signature.asc Description: Digital signature
Issues with touchpad / touchscreen on yoga 900
Greetings. I'm having problems with a lenovo yoga 900 not seeing it's touchscreen or touchpad. Downstream bug: https://bugzilla.redhat.com/show_bug.cgi?id=1275718 The problem parts of dmesg seem to be: Oct 26 15:20:08 localhost kernel: i2c_designware i2c_designware.1: i2c_dw_handle_tx_abort: lost arbitration Oct 26 15:20:08 localhost kernel: i2c_hid i2c-SYNA2B29:00: hid_descr_cmd failed Oct 26 15:20:08 localhost kernel: i2c_designware i2c_designware.2: i2c_dw_handle_tx_abort: lost arbitration Oct 26 15:20:08 localhost kernel: i2c_hid i2c-ELAN21EF:00: hid_descr_cmd failed This is with 4.3.0-0.rc7.git1.1.fc24.x86_64 (post rc7 4.3.0). Happy to gather further info or try patches. ;) Thanks! kevin pgpgF9G3HT9Jf.pgp Description: OpenPGP digital signature
