Re: [PATCH] i2c: rcar: Revert the latest refactoring series

2015-11-02 Thread Geert Uytterhoeven
On Fri, Oct 30, 2015 at 12:30 PM, Wolfram Sang  wrote:
> From: Wolfram Sang 
>
> This whole series caused sometimes timeouts and even OOPSes on some
> r8a7791 Koelsch boards. We need to understand and fix those first.
>
> Revert "i2c: rcar: clean up after refactoring"
> Revert "i2c: rcar: revoke START request early"
> Revert "i2c: rcar: check master irqs before slave irqs"
> Revert "i2c: rcar: don't issue stop when HW does it automatically"
> Revert "i2c: rcar: init new messages in irq"
> Revert "i2c: rcar: refactor setup of a msg"
> Revert "i2c: rcar: remove spinlock"
> Revert "i2c: rcar: remove unused IOERROR state"
> Revert "i2c: rcar: rework hw init"

I can confirm this gets rid of the following error messages on koelsch:

-i2c-rcar e653.i2c: error -16 : 0
-adv7511: probe of 2-0039 failed with error -16

(2-0039 = adv7511)

-i2c-rcar e653.i2c: error -16 : 0
-i2c-rcar e653.i2c: error -16 : 0
-i2c-rcar e653.i2c: pm_clk_suspend()
-i2c-rcar e653.i2c: pm_clk_resume()
-i2c-rcar e653.i2c: error -16 : 0
-adv7180: probe of 2-0020 failed with error -16

(2-0020 = adv7180)

-i2c-rcar e653.i2c: pm_clk_resume()
-i2c-rcar e653.i2c: error -16 : 0
-i2c-rcar e653.i2c: error -16 : 0
-i2c-rcar e653.i2c: error -16 : 0
-i2c-rcar e653.i2c: error -16 : 0
-i2c-rcar e653.i2c: error -16 : 0
-i2c-rcar e653.i2c: error -16 : 0

-i2c-rcar e653.i2c: error -16 : 0
-i2c-rcar e653.i2c: error -16 : 0
-i2c-rcar e653.i2c: error -16 : 0
-i2c-rcar e653.i2c: error -16 : 0
-i2c-rcar e653.i2c: error -16 : 0
-i2c-rcar e653.i2c: error -16 : 0

(related to ak4642, I think)

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH] i2c: rcar: Revert the latest refactoring series

2015-10-30 Thread Wolfram Sang
On Fri, Oct 30, 2015 at 12:30:06PM +0100, Wolfram Sang wrote:
> From: Wolfram Sang 
> 
> This whole series caused sometimes timeouts and even OOPSes on some
> r8a7791 Koelsch boards. We need to understand and fix those first.
> 
> Revert "i2c: rcar: clean up after refactoring"
> Revert "i2c: rcar: revoke START request early"
> Revert "i2c: rcar: check master irqs before slave irqs"
> Revert "i2c: rcar: don't issue stop when HW does it automatically"
> Revert "i2c: rcar: init new messages in irq"
> Revert "i2c: rcar: refactor setup of a msg"
> Revert "i2c: rcar: remove spinlock"
> Revert "i2c: rcar: remove unused IOERROR state"
> Revert "i2c: rcar: rework hw init"
> 
> Signed-off-by: Wolfram Sang 

Applied to for-next, thanks!



signature.asc
Description: Digital signature