Re: [PATCH] i2c: rcar: call rcar_i2c_init() after pm_runtime_get_sync()

2015-10-29 Thread Geert Uytterhoeven
On Thu, Oct 29, 2015 at 10:37 AM, Kuninori Morimoto wrote: > From: Kuninori Morimoto > > rcar_i2c_init() initializes I2C device, but it should be called > *after* pm_runtime_get_sync(). Otherwise it outputs very hi speed >

Re: [PATCH] i2c: rcar: call rcar_i2c_init() after pm_runtime_get_sync()

2015-10-29 Thread Wolfram Sang
> Hence now it's done again for every transfer? > > What about moving it just before the call to i2c_add_numbered_adapter(), > and wrapping it inside pm_runtime_get_sync(dev)/pm_runtime_put()? > > Wolfram, what do you think? I'd prefer the latter. Sending a tested patch in a second...

Re: [PATCH] i2c: rcar: call rcar_i2c_init() after pm_runtime_get_sync()

2015-10-29 Thread Kuninori Morimoto
Hi Geert > > From: Kuninori Morimoto > > > > rcar_i2c_init() initializes I2C device, but it should be called > > *after* pm_runtime_get_sync(). Otherwise it outputs very hi speed > > clock. This patch solved this issue, > > This patch also removes pointless