Re: [PATCH v1 11/13] mfd: intel-lpss: Pass HSUART configuration via properties
Hi Mika,
[auto build test ERROR on v4.4-rc2]
[also build test ERROR on next-20151124]
[cannot apply to ljones-mfd/for-mfd-next]
url:
https://github.com/0day-ci/linux/commits/Andy-Shevchenko/device-property-always-check-for-fwnode-type/20151124-183221
config: x86_64-randconfig-x019-11241713 (attached as .config)
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64
All error/warnings (new ones prefixed by >>):
>> drivers/mfd/intel-lpss-pci.c:68:30: error: array type has incomplete element
>> type 'struct property_entry'
static struct property_entry uart_properties[] = {
^
>> drivers/mfd/intel-lpss-pci.c:69:2: error: implicit declaration of function
>> 'PROPERTY_ENTRY_U32' [-Werror=implicit-function-declaration]
PROPERTY_ENTRY_U32("reg-io-width", 4),
^
>> drivers/mfd/intel-lpss-pci.c:71:2: error: implicit declaration of function
>> 'PROPERTY_ENTRY_U8' [-Werror=implicit-function-declaration]
PROPERTY_ENTRY_U8("snps,uart-16550-compatible", 1),
^
>> drivers/mfd/intel-lpss-pci.c:75:15: error: variable 'uart_pset' has
>> initializer but incomplete type
static struct property_set uart_pset = {
^
>> drivers/mfd/intel-lpss-pci.c:76:2: error: unknown field 'properties'
>> specified in initializer
.properties = uart_properties,
^
>> drivers/mfd/intel-lpss-pci.c:76:16: warning: excess elements in struct
>> initializer
.properties = uart_properties,
^
drivers/mfd/intel-lpss-pci.c:76:16: note: (near initialization for
'uart_pset')
>> drivers/mfd/intel-lpss-pci.c:68:30: warning: 'uart_properties' defined but
>> not used [-Wunused-variable]
static struct property_entry uart_properties[] = {
^
cc1: some warnings being treated as errors
vim +68 drivers/mfd/intel-lpss-pci.c
62 static INTEL_LPSS_PM_OPS(intel_lpss_pci_pm_ops);
63
64 static const struct intel_lpss_platform_info spt_info = {
65 .clk_rate = 12000,
66 };
67
> 68 static struct property_entry uart_properties[] = {
> 69 PROPERTY_ENTRY_U32("reg-io-width", 4),
70 PROPERTY_ENTRY_U32("reg-shift", 2),
> 71 PROPERTY_ENTRY_U8("snps,uart-16550-compatible", 1),
72 { },
73 };
74
> 75 static struct property_set uart_pset = {
> 76 .properties = uart_properties,
77 };
78
79 static const struct intel_lpss_platform_info spt_uart_info = {
---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: Binary data
Re: [PATCH v1 11/13] mfd: intel-lpss: Pass HSUART configuration via properties
On Tue, Nov 24, 2015 at 06:44:53PM +0800, kbuild test robot wrote:
> Hi Mika,
>
> [auto build test ERROR on v4.4-rc2]
> [also build test ERROR on next-20151124]
> [cannot apply to ljones-mfd/for-mfd-next]
>
> url:
> https://github.com/0day-ci/linux/commits/Andy-Shevchenko/device-property-always-check-for-fwnode-type/20151124-183221
> config: x86_64-randconfig-x019-11241713 (attached as .config)
> reproduce:
> # save the attached .config to linux build tree
> make ARCH=x86_64
>
> All error/warnings (new ones prefixed by >>):
>
> >> drivers/mfd/intel-lpss-pci.c:68:30: error: array type has incomplete
> >> element type 'struct property_entry'
> static struct property_entry uart_properties[] = {
Thanks kbuild robot!
This patch misses include of . It seems that it got
added by a subsequent patch which was not sent out.
We will fix this.
--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v1 11/13] mfd: intel-lpss: Pass HSUART configuration via properties
On Tuesday 24 November 2015 12:22:57 Andy Shevchenko wrote:
> +static struct property_entry uart_properties[] = {
> + PROPERTY_ENTRY_U32("reg-io-width", 4),
> + PROPERTY_ENTRY_U32("reg-shift", 2),
> + PROPERTY_ENTRY_U8("snps,uart-16550-compatible", 1),
> + { },
>
If I read the binding correctly, the "snps,uart-16550-compatible" property
is meant to be boolean, meaning true if present and zero-length or false
if absent. Using a u8 propert instead feels wrong.
Maybe we can have a PROPERTY_ENTRY_BOOL() for that?
Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v1 11/13] mfd: intel-lpss: Pass HSUART configuration via properties
On Tue, Nov 24, 2015 at 08:53:04PM +0100, Arnd Bergmann wrote:
> On Tuesday 24 November 2015 12:22:57 Andy Shevchenko wrote:
> > +static struct property_entry uart_properties[] = {
> > + PROPERTY_ENTRY_U32("reg-io-width", 4),
> > + PROPERTY_ENTRY_U32("reg-shift", 2),
> > + PROPERTY_ENTRY_U8("snps,uart-16550-compatible", 1),
> > + { },
> >
>
> If I read the binding correctly, the "snps,uart-16550-compatible" property
> is meant to be boolean, meaning true if present and zero-length or false
> if absent. Using a u8 propert instead feels wrong.
>
> Maybe we can have a PROPERTY_ENTRY_BOOL() for that?
That's a good idea. We'll add it to the next revision of the series.
--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
