Albert Lee wrote:
Jeff,
The PIO fixes revised according to the previous reviews.
1/2 pio1.diff:
- Modify ata_mmio_data_xfer() and ata_pio_data_xfer() to handle buffer
with odd length.
2/2 pio2.diff:
- Modify __atapi_pio_bytes() to handle the case where device
returns/needs extra data.
Jeff,
PATCH 2/2:
Description:
Sometimes the device returns/needs extra data than expected.
Changes:
Modify __atapi_pio_bytes() to handle the case where device returns/needs
extra data.
- for read case, discard trailing data from the device
- for write case, padding zero data to the
Jeff,
PATCH 1/2: ata_data_xfer() fix
Changes:
- Modify ata_mmio_data_xfer() and ata_pio_data_xfer() to handle odd-lengthed
buffer.
- Add some function comments
This patch does not reuse ap->pad as alignment buffer since
using local variable seems good enough.
For your review, thanks.
Alb
Jeff,
The PIO fixes revised according to the previous reviews.
1/2 pio1.diff:
- Modify ata_mmio_data_xfer() and ata_pio_data_xfer() to handle buffer with
odd length.
2/2 pio2.diff:
- Modify __atapi_pio_bytes() to handle the case where device returns/needs
extra data.
(Patch diff'ed again
Rob van Nieuwkerk wrote:
On Fri, 12 Aug 2005 01:09:12 -0400
Jeff Garzik <[EMAIL PROTECTED]> wrote:
Hi Jeff,
Things in SATA-land have been moving along recently, so I updated the
software status report:
http://linux.yyz.us/sata/software-status.html
Is any progress made on SMART su
On Fri, 12 Aug 2005 01:09:12 -0400
Jeff Garzik <[EMAIL PROTECTED]> wrote:
Hi Jeff,
> Things in SATA-land have been moving along recently, so I updated the
> software status report:
>
> http://linux.yyz.us/sata/software-status.html
Is any progress made on SMART support ?
I've been reading
Things in SATA-land have been moving along recently, so I updated the
software status report:
http://linux.yyz.us/sata/software-status.html
Although I have not updated it in several weeks, folks may wish to refer
to the hardware status report as well:
http://linux.yyz.us/sa
Chris Boot wrote:
Hi all,
I just recently took the plunge and bought 4 250 GB Seagate drives and
a 2 port Silicon Image 3112A controller card for the 2 drives my
motherboard doesn't handle. No matter how hard I try, I can't get the
hard drives to work: they are detected correctly and work
Tejun Heo wrote:
Mark Lord wrote:
Tejun Heo wrote:
* _All_ errors are handled in EH thread.
* Once any error has occurred, all normal processing stops until
error condition is cleared by EH.
Do you mean "all normal processing" for that channel stops,
or *ALL* processing on all libata
Mark Lord wrote:
Tejun Heo wrote:
* _All_ errors are handled in EH thread.
* Once any error has occurred, all normal processing stops until
error condition is cleared by EH.
Do you mean "all normal processing" for that channel stops,
or *ALL* processing on all libata channels stops?
Obv
Tejun Heo wrote:
* _All_ errors are handled in EH thread.
* Once any error has occurred, all normal processing stops until error
condition is cleared by EH.
Do you mean "all normal processing" for that channel stops,
or *ALL* processing on all libata channels stops?
Obviously the former, I
Mark Lord wrote:
> James Courtier-Dutton wrote:
>
>> Google did not help me.
>>
>> Can I use the kernel libata and do commands like this now? :
>> hdparm -S60 /dev/sda
>
>
> Yes, but only if you manually apply the "libata-passthru" patch.
For those occasions when libata is one box removed
(e.g. s
Jeff Garzik wrote:
Tejun Heo wrote:
Hello, Jeff & Carlos.
These patches are misc fixes suggested by Jeff for rewritten sil24
driver. The follwing issues are not fixed in this patchset. I need
more info to work on these.
* Device signature access on reset.
* How to discern completion int
Jeff Garzik wrote:
Tejun Heo wrote:
05_sil24_mdelay-instead-of-udelay.patch
loop 100 times with mdelay(1) instead of 1000 times with
udelay(100) in sil24_reset_controller.
Jeff, is this what you wanted? If not, just ignore this
patch. The following patches will apply without
Hello, Jeff.
The patch I posted in this thread is just collapsed version of the
following patchset.
http://marc.theaimsgroup.com/?l=linux-ide&m=112074204019013&w=2
Above post has it splitted over 11 patches and has proper explanations.
Jeff Garzik wrote:
Tejun Heo wrote:
And this is
Bjorn Helgaas wrote:
You deduce this by the absence of SecO and PriO? I wonder if lspci
should be enhanced to notice this, too. I assume that the IRQ 169
doesn't correspond to anything in /proc/interrupts.
Correct.
So the scenario in question (correct me if I'm wrong) is that we
have a PCI
(resend with correct cc list).
On Thu, Aug 11, 2005 at 02:24:43PM -0600, Bjorn Helgaas wrote:
> IA64 boxes only have PCI IDE devices, so there's no need to blindly poke
> around in I/O port space. Poking at things that don't exist causes MCAs
> on HP ia64 systems.
H, can you change the test
On Thursday 11 August 2005 3:56 pm, Jeff Garzik wrote:
> Jeff Garzik wrote:
> > 00:1f.1 IDE interface: Intel Corporation 82801EB/ER (ICH5/ICH5R) IDE
> > Controller
> > (rev 02) (prog-if 8a [Master SecP PriP])
> > Subsystem: Hewlett-Packard Company d530 CMT (DG746A)
> > Control: I/
On Thu, Aug 11, 2005 at 03:42:07PM -0600, Bjorn Helgaas wrote:
> On Thursday 11 August 2005 2:56 pm, Jeff Garzik wrote:
> > Bjorn Helgaas wrote:
> > > On Thursday 11 August 2005 2:36 pm, Jeff Garzik wrote:
> > >>Bjorn Helgaas wrote:
> > >>> config IDE_GENERIC
> > >>> tristate "generic/defau
Luck, Tony wrote:
Tony, others, does this change give you any heartburn? On
the 460GX and 870 boxes I have, IDE is a PCI device.
No heartburn for me ... as you say IDE is built into one
of the 870 chips.
I don't know whether any non-Intel chipsets provide legacy IDE.
The question is not ab
>Tony, others, does this change give you any heartburn? On
>the 460GX and 870 boxes I have, IDE is a PCI device.
No heartburn for me ... as you say IDE is built into one
of the 870 chips.
I don't know whether any non-Intel chipsets provide legacy IDE.
-Tony
-
To unsubscribe from this list: sen
Jeff Garzik wrote:
00:1f.1 IDE interface: Intel Corporation 82801EB/ER (ICH5/ICH5R) IDE Controller
(rev 02) (prog-if 8a [Master SecP PriP])
Subsystem: Hewlett-Packard Company d530 CMT (DG746A)
Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Step
ping- SERR- Fa
On Thu, Aug 11, 2005 at 03:42:07PM -0600, Bjorn Helgaas wrote:
> Tony, others, does this change give you any heartburn? On
> the 460GX and 870 boxes I have, IDE is a PCI device.
>
> (I have been told that the SGI ia64 simulator depends on
> IDE_GENERIC. But it really should make the IDE device
>
On Thursday 11 August 2005 2:56 pm, Jeff Garzik wrote:
> Bjorn Helgaas wrote:
> > On Thursday 11 August 2005 2:36 pm, Jeff Garzik wrote:
> >>Bjorn Helgaas wrote:
> >>> config IDE_GENERIC
> >>> tristate "generic/default IDE chipset support"
> >>>+ depends on !IA64
> >>
> >>hm. Are you PO
Bjorn Helgaas wrote:
On Thursday 11 August 2005 2:36 pm, Jeff Garzik wrote:
Bjorn Helgaas wrote:
IA64 boxes only have PCI IDE devices, so there's no need to blindly poke
around in I/O port space. Poking at things that don't exist causes MCAs
on HP ia64 systems.
Signed-off-by: Bjorn Helgaas
Since there's been some recent interest in the subject, I thought I
would post the PATA todo list for libata. Some of these items are from
my memory, and some are from a list Alan was kind enough to create. The
items verbatim from Alan are prefixed "Alan: ".
1) Locked device/host speed
T
On Thursday 11 August 2005 2:36 pm, Jeff Garzik wrote:
> Bjorn Helgaas wrote:
> > IA64 boxes only have PCI IDE devices, so there's no need to blindly poke
> > around in I/O port space. Poking at things that don't exist causes MCAs
> > on HP ia64 systems.
> >
> > Signed-off-by: Bjorn Helgaas <[EMA
Bjorn Helgaas wrote:
IA64 boxes only have PCI IDE devices, so there's no need to blindly poke
around in I/O port space. Poking at things that don't exist causes MCAs
on HP ia64 systems.
Signed-off-by: Bjorn Helgaas <[EMAIL PROTECTED]>
Index: work-vga/drivers/ide/Kconfig
===
On Thursday 11 August 2005 2:34 pm, Christoph Hellwig wrote:
> On Thu, Aug 11, 2005 at 02:24:43PM -0600, Bjorn Helgaas wrote:
> > IA64 boxes only have PCI IDE devices, so there's no need to blindly poke
> > around in I/O port space. Poking at things that don't exist causes MCAs
> > on HP ia64 syst
On Thu, Aug 11, 2005 at 02:24:43PM -0600, Bjorn Helgaas wrote:
> IA64 boxes only have PCI IDE devices, so there's no need to blindly poke
> around in I/O port space. Poking at things that don't exist causes MCAs
> on HP ia64 systems.
Maybe it should instead depend on those systems where it is ava
Dick wrote:
How do I put an SATA ata_piix harddisk to sleep?
I've tried blktool, hdparm and sdparm but none seem to work, does it need a
special ioctl or should I patch something?
Apply the ATA passthru patch, or grab the latest 'upstream' branch of
libata-dev.git and use the SCSI START STOP
Jeff Garzik wrote:
The system is thus:
1) drivers/pci/quirks.c reserves SATA ports (only!) for libata
2) Legacy IDE driver claims the unreserved PATA port
3) libata loads and uses the ports reserved in #1
This requires a specific kernel configuration:
(a) CONFIG_IDE_GENERIC be set, and
(b) IDE
IA64 boxes only have PCI IDE devices, so there's no need to blindly poke
around in I/O port space. Poking at things that don't exist causes MCAs
on HP ia64 systems.
Signed-off-by: Bjorn Helgaas <[EMAIL PROTECTED]>
Index: work-vga/drivers/ide/Kconfig
==
Erik Slagter wrote:
On Thu, 2005-08-11 at 13:19 -0400, Jeff Garzik wrote:
Mark Lord wrote:
Jeff Garzik wrote:
currently no one should be using libata for PATA support.
We emailed back and forth extensively about how this has
not been true since early this year. Modern laptops are
using l
On Thu, 2005-08-11 at 13:19 -0400, Jeff Garzik wrote:
Mark Lord wrote:
Jeff Garzik wrote:
currently no one should be using libata for PATA support.
We emailed back and forth extensively about how this has
not been true since early this year. Modern laptops are
using liba
Tejun Heo wrote:
And this is the combined patch against ncq head of libata-dev-2.6
tree. Commit d032ec9048ff82a704b96b93cfd6f2e8e3a06b19.
Only ata_piix, sata_sil and ahci are converted and all other SATA
drivers are broken. So, enable only those three SATA drivers when
compiling with this pa
On Thu, 2005-08-11 at 13:19 -0400, Jeff Garzik wrote:
> Mark Lord wrote:
> > Jeff Garzik wrote:
> >> currently no one should be using libata for PATA support.
> > We emailed back and forth extensively about how this has
> > not been true since early this year. Modern laptops are
> > using libata f
Timothy Thelin wrote:
Well it doesn't seem that nasty to adopt flagged access. From a userland
API point of view how about adopting the IDE driver's taskfile mechanism,
and simply translating that into the yet-to-be internal flagged mechanism?
There is actually already an internal flagged mech
Tejun Heo wrote:
Hello, Jeff & Carlos.
These patches are misc fixes suggested by Jeff for rewritten sil24
driver. The follwing issues are not fixed in this patchset. I need
more info to work on these.
* Device signature access on reset.
* How to discern completion interrupts from error on
Tejun Heo wrote:
07_sil24_add-FIXME-ata_device_add-return_value.patch
Add FIXME comment above ata_device_add.
Signed-off-by: Tejun Heo <[EMAIL PROTECTED]>
ACK
-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to [EMAIL PROTECTED]
More ma
Tejun Heo wrote:
06_sil24_add-flusing-after-masking-irq.patch
Add IO flushing after masking irq during initialization.
Signed-off-by: Tejun Heo <[EMAIL PROTECTED]>
ACK
-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to [EMAIL PROTECTED
Tejun Heo wrote:
05_sil24_mdelay-instead-of-udelay.patch
loop 100 times with mdelay(1) instead of 1000 times with
udelay(100) in sil24_reset_controller.
Jeff, is this what you wanted? If not, just ignore this
patch. The following patches will apply without this
Tejun Heo wrote:
04_sil24_remove-irq-disable-on-spurious-interrupt.patch
If interrupt occurs on a disabled port, the driver used to
mask the port's interrupt, but we don't know if such action is
necessary yet and that's not what other drives do. So, just
do nothi
Tejun Heo wrote:
03_sil24_add-test-for-PCI-fault.patch
On entry to interrupt handler, PORT_SLOT_STAT register is read
first. Check if PCI fault or device removal has occurred by
testing the value for 0x.
Signed-off-by: Tejun Heo <[EMAIL PROTECTED]>
ACK
-
To
Tejun Heo wrote:
01_sil24_add-status-emulation.patch
Add back status register emulation. It's very simple. If the
previous command completed successfully, we return ATA_DRDY
for all following status register queries; otherwise, we
return ATA_DRDY | ATA_ERR. We
Tejun Heo wrote:
02_sil24_separate-out-error-path.patch
Move error handling from sil24_host_intr into separate
function - sil24_error_intr.
Jeff, I don't think this patch actually improves readability
and/or performance. Is this what you wanted?
Yes.
It impro
Brett Russ wrote:
Simple cleanup to eliminate X copies of the same function in libata.
Moved pci_enable_intx() to pci.c, added pci_disable_intx() as well,
and use them throughout libata and msi.c.
Signed-off-by: Brett Russ <[EMAIL PROTECTED]>
Though there is nothing wrong with this patch, I
I'm getting confused with all the patches from you :/
It's my fault, but, would you be kind enough to resend the latest
versions of -all- libata and pdc2027x patches?
Jeff
-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to [EMAIL PROTE
Mark Lord wrote:
Jeff Garzik wrote:
currently no one should be using libata for PATA support.
We emailed back and forth extensively about how this has
not been true since early this year. Modern laptops are
using libata for the ICH6M support, simply because libata
claims that chipset, and t
Jeff Garzik wrote:
currently no one should be using libata for PATA support.
We emailed back and forth extensively about how this has
not been true since early this year. Modern laptops are
using libata for the ICH6M support, simply because libata
claims that chipset, and the IDE driver does
> > > AFAIR ICH6M has only one PATA port and putting both HDD and DVD drive
> > > on the same PATA port would sacrifice performance (because only one PATA
> > > device can be used at a time).
> >
> > That's duff. The PATA harddisk that is used in my laptop, also comes in
> > a SATA version...
>
>
On 8/11/05, Erik Slagter <[EMAIL PROTECTED]> wrote:
> On Thu, 2005-08-11 at 12:26 +0200, Bartlomiej Zolnierkiewicz wrote:
> > > As ICH6M features both PATA and SATA connections, I don't see why they'd
> > > use a PATA bridge... The DVD drives use PATA anyway, btw.
> >
> > AFAIR ICH6M has only one P
On Thu, 2005-08-11 at 16:23 +0200, Raphael Bossek wrote:
> Will
> http://www.kernel.org/pub/linux/kernel/people/jgarzik/libata/2.6.11-libata-dev1.patch.bz2
> add support for PDC20775 PATA interface? Could not find any reference
> to this device within the sources.
Doesn't seem to do it. Although I
On Thu, 2005-08-11 at 12:26 +0200, Bartlomiej Zolnierkiewicz wrote:
> > As ICH6M features both PATA and SATA connections, I don't see why they'd
> > use a PATA bridge... The DVD drives use PATA anyway, btw.
>
> AFAIR ICH6M has only one PATA port and putting both HDD and DVD drive
> on the same PAT
Will
http://www.kernel.org/pub/linux/kernel/people/jgarzik/libata/2.6.11-libata-dev1.patch.bz2
add support for PDC20775 PATA interface? Could not find any reference
to this device within the sources.
--
Raphael Bossek
--
GMX DSL = Maximale Leistung zum minimalen Preis!
2000 MB nur 2,99, Flatrate
Hi Bart !
That seem to be a new problem though I can't tell for sure when it
started. I've had reports from users for some time now of
"occasional" (once in a while, maybe once a day) lost interrupts on the
mac hard disk. I have about 30 days uptime and just saw a similar one in
my log. It happen
On 8/11/05, Erik Slagter <[EMAIL PROTECTED]> wrote:
> On Thu, 2005-08-11 at 12:03 +0200, Bartlomiej Zolnierkiewicz wrote:
> > > > > Most current laptops ship with a PATA hard drive, and a PATA
> > > > > ATAPI drive. The easiest way to make them usable under Linux-2.6
> >
> > New laptops rather shi
On Thu, 2005-08-11 at 12:03 +0200, Bartlomiej Zolnierkiewicz wrote:
> > > > Most current laptops ship with a PATA hard drive, and a PATA
> > > > ATAPI drive. The easiest way to make them usable under Linux-2.6
>
> New laptops rather ship with:
>
> SATA (or PATA + bridge) hard disk and PATA ATAPI
On 8/11/05, Erik Slagter <[EMAIL PROTECTED]> wrote:
> On Wed, 2005-08-10 at 23:57 -0400, Jeff Garzik wrote:
>
> > > Most current laptops ship with a PATA hard drive, and a PATA
> > > ATAPI drive. The easiest way to make them usable under Linux-2.6
New laptops rather ship with:
SATA (or PATA + b
Benjamin Herrenschmidt wrote:
On Wed, 2005-08-10 at 23:04 -0400, Jeff Garzik wrote:
mdelay() should be investigated as to why its not working on your
platform. do_gettimeofday() is -less- granular and accurate than
mdelay(), usually.
Agreed. mdelay() should have worked.
Understood.
Jeff,
Albert Lee wrote:
Jeff,
Patch 1/3: Convert pdc2027x from PIO to MMIO
Description:
Indexed registers need two PIO accesses: one access writes to the
index register and the other access
reads/writes the indexed register. Using MMIO can access the register
directly and simplify th
On Wed, 2005-08-10 at 23:57 -0400, Jeff Garzik wrote:
> > Most current laptops ship with a PATA hard drive, and a PATA
> > ATAPI drive. The easiest way to make them usable under Linux-2.6
> > is to patch libata and turn on ATAPI support, using ata_piix.
>
> No, the best thing to do is use the ID
Our new SIS based AMD desktop systems come with a very new SIS chipset
that has a Serial ATA controller that has the device ID 0x182. Without
this patch the system won't be able to use the hard disk in native mode.
As a proof of concept we patched the kernel on a system with an older SIS
chipset an
On Wed, 2005-08-10 at 23:04 -0400, Jeff Garzik wrote:
> mdelay() should be investigated as to why its not working on your
> platform. do_gettimeofday() is -less- granular and accurate than
> mdelay(), usually.
Agreed. mdelay() should have worked.
Ben.
-
To unsubscribe from this list: send th
64 matches
Mail list logo
