[PATCH] libata: set IRQF_SHARED for legacy PCI IDE IRQs

2006-11-16 Thread Tejun Heo
There are machines out there which share legacy PCI IDE IRQs w/ other devices. libata SFF interrupt/HSM code is ready for shared IRQ and has been setting IRQF_SHARED for devices in native PCI mode. Device in legacy mode is still a PCI device and thus supposedly uses active-low level triggered IRQ

Re: [PATCH 2/2] libata: make sure IRQ is cleared after ata_bmdma_freeze()

2006-11-16 Thread Tejun Heo
Mark Lord wrote: Tejun Heo wrote: Note that ->freeze() handler is always called under ap->lock held and irq disabled. Even if CTL manipulation causes stuck IRQ, it's cleared immediately. This should be safe (enough) even in SMP environment. More correct solution is to mask the IRQ from IRQ co

Re: [PATCH 2/2] libata: make sure IRQ is cleared after ata_bmdma_freeze()

2006-11-16 Thread Mark Lord
Tejun Heo wrote: Note that ->freeze() handler is always called under ap->lock held and irq disabled. Even if CTL manipulation causes stuck IRQ, it's cleared immediately. This should be safe (enough) even in SMP environment. More correct solution is to mask the IRQ from IRQ controller but that

[PATCH 2/2 UPDATED] libata: make sure IRQ is cleared after ata_bmdma_freeze()

2006-11-16 Thread Tejun Heo
Now that BMDMA status is recorded in irq handler. ata_bmdma_freeze() is free to manipulate host status. Under certain circumstances, some controllers (ICH7 in enhanced mode w/ IRQ shared) raise IRQ when CTL register is written to and ATA_NIEN doesn't mask it. This patch makes ata_bmdma_freeze()

[PATCH 2/2] libata: make sure IRQ is cleared after ata_bmdma_freeze()

2006-11-16 Thread Tejun Heo
Now that BMDMA status is recorded in irq handler. ata_bmdma_freeze() is free to manipulate host status. Under certain circumstances, some controllers (ICH7 in enhanced mode w/ IRQ shared) raise IRQ when CTL register is written to and ATA_NIEN doesn't mask it. This patch makes ata_bmdma_freeze()

[PATCH 1/2] libata: move BMDMA host status recording from EH to interrupt handler

2006-11-16 Thread Tejun Heo
For certain errors, interrupt handler alter BMDMA host status before entering EH (clears active and intr). Thus altered BMDMA host status value is recorded by BMDMA EH and reported to user. Move BMDMA host status recording from EH to interrupt handler. Signed-off-by: Tejun Heo <[EMAIL PROTECTED]

[PATCH] libata: remove unused HSM_ST_UNKNOWN

2006-11-16 Thread Tejun Heo
HSM_ST_UNKNOWN is not used anywhere. Its value is zero and supposed to serve sanity check purpose but HSM_ST_IDLE is used for that purpose. This unused state causes confusion. After a port is initialized but before the first command is executed, the idle hsm state is UNKNOWN. However, once a co

Re: [PATCH/RFC] ata: Add support for the MPC52xx ATA controller using libata

2006-11-16 Thread Alan
On Thu, 16 Nov 2006 23:12:19 +0100 Sylvain Munaut <[EMAIL PROTECTED]> wrote: > * The manual states we should check for the TIP bit before all > PIO transaction. That's not really supported by libata and requires > reimplementing almost all the hooks. But after talking to Freescale, > it turnsout i

2.6.19-rc5-mm2: WARNING at drivers/ata/sata_nv.c:762 nv_adma_bmdma_setup()

2006-11-16 Thread Nicolas Mailhot
Hi, When booting a fresh 2.6.19-rc5-mm2, I get a lof of traces like this: WARNING at drivers/ata/sata_nv.c:762 nv_adma_bmdma_setup() Call Trace: [] show_trace+0x34/0x47 [] dump_stack+0x12/0x17 [] :libata:ata_qc_issue_prot+0x1ec/0x24c [] :libata:ata_qc_issue+0x400/0x45d [] :libata:ata_scsi_

[PATCH/RFC] ata: Add support for the MPC52xx ATA controller using libata

2006-11-16 Thread Sylvain Munaut
This is the first attempt at a libata driver for this controller. The two main issues : * The manual states we should check for the TIP bit before all PIO transaction. That's not really supported by libata and requires reimplementing almost all the hooks. But after talking to Freescale, it turnsou

Re: Testing with 2.6.19-rc5

2006-11-16 Thread Andrew Morton
On Thu, 16 Nov 2006 13:52:28 + "Andrew Lyon" <[EMAIL PROTECTED]> wrote: > > Comparing the first 32k of the 4 disks under 2.6.18.2 and 2.6.19-rc5 > there is no difference, so I decided to compare the bootup dmesg, the > following text is not output with 2.6.19-rc5: > > md: md driver 0.90.3 MA

Re: 2.6.19-rc5: Geode GX IDE and compact flash issues

2006-11-16 Thread Jordan Crouse
On 15/11/06 23:10 -0600, Ben Gardner wrote: > On 11/15/06, Jordan Crouse <[EMAIL PROTECTED]> wrote: > >I am embarrassed to say that I have yet to try out the > >CS5535 PATA driver. > > So which driver is used with the OLPC? > Or does that not use IDE devices? OLPC uses USB and NAND. I'll leave i

pata_hpt37x problem when writing on ports 2&3 with RocketRaid 1540

2006-11-16 Thread Brad Campbell
G'day all, Rehash of an old problem. I've done a bit of homework and found this only occurs on the last 2 ports of the card. If I take the drives from ports 3&4 and put them on a SIL3112 I've got lying around, then the system works perfectly. Diving deeper, the below problem only surfaces whe

Re: AHCI and add_disk_randomness()

2006-11-16 Thread Jens Axboe
On Wed, Nov 15 2006, Marek Podmaka wrote: > Hello, > > I have server with Intel 5000V motherboard with integrated AHCI SATA > controller. It works well with kernel 2.6.18.2. But I have problem > with little entropy available and I'm not sure if one of the reasons > is that AHCI driver does

Re: [PATCH] clear garbage after CDBs on SG_IO

2006-11-16 Thread Tejun Heo
Andrew Morton wrote: On Thu, 16 Nov 2006 09:52:27 +0900 Tejun Heo <[EMAIL PROTECTED]> wrote: ATAPI devices transfer fixed number of bytes for CDBs (12 or 16). Some ATAPI devices choke when shorter CDB is used and the left bytes contain garbage. Block SG_IO cleared left bytes but SCSI SG_IO did

Re: Testing with 2.6.19-rc5

2006-11-16 Thread Andrew Lyon
On 11/15/06, Andrew Morton <[EMAIL PROTECTED]> wrote: On Wed, 15 Nov 2006 14:45:27 + "Andrew Lyon" <[EMAIL PROTECTED]> wrote: > Andrew, > > You asked me to test if the issues I reported (Re: JMicron 20360/20363 > AHCI Controller much slower with 2.6.18 / Re: SATA CD/DVDRW Support in > 2.6.18

AW: Promise SATA vendor drivers uploaded

2006-11-16 Thread Martin Bene
> To further assist anyone wishing to hack on sata_promise.c, I just > uploaded the long-since-GPL'd vendor drivers for Generation-I and > Generation-II chipsets to > http://gkernel.sourceforge.net/specs/promise/ > > This should help with isolating the proper initialization > sequence for a gi

Re: [PATCH] clear garbage after CDBs on SG_IO

2006-11-16 Thread Andrew Morton
On Thu, 16 Nov 2006 09:52:27 +0900 Tejun Heo <[EMAIL PROTECTED]> wrote: > ATAPI devices transfer fixed number of bytes for CDBs (12 or 16). > Some ATAPI devices choke when shorter CDB is used and the left bytes > contain garbage. Block SG_IO cleared left bytes but SCSI SG_IO > didn't. This patch

Re: [Q] PCI Express and ide (native) leads to irq storm?

2006-11-16 Thread Vasily Averin
Tejun Heo wrote: > Vasily Averin wrote: >> Alan Cox wrote: >>> Ar Gwe, 2006-10-27 am 17:17 +0400, ysgrifennodd Vasily Averin: Could somebody please help me to troubleshoot this issue? I've seen this issue on the customer nodes and would like to know how I can work-around this