Re: [PATCH 2/2] drivers/ata: export some static functions in libata-core.c

2007-01-11 Thread Akira Iguchi
Hi, Arnd-san. Thank you for checking our patches. On Thursday 11 January 2007 09:56, Akira Iguchi wrote: This patch modifies some static functions in libata-core.c and libata.h to use them in ata_scc.c. Exporting new symbols needs some explanation here about why they should now be global for

Re: hwif-rw_disk() method

2007-01-11 Thread Sergei Shtylyov
Hello. Alan wrote: Alan/Bart/anybody, could you enlighten me why hwif-rw_disk() method came into being at all? When you needed to wrap entire disk operations. The -dma_ methods only wrap DMA commands. BTW, I've looked at the clock turnaround code both in drivers/ide/hpt366.c and

Re: [PATCH 1/2] drivers/ata: PATA driver for Celleb

2007-01-11 Thread Benjamin Herrenschmidt
Actually, an even stronger reason to use an abstraction is the fact that this is not really a PCI device and you therefore don't use readl/writel, but rather in_be32/out_be32. If you think the code gets better by using the low-level calls, then it would be good if you also do the patch to

Re: [PATCH 2/2] drivers/ata: export some static functions in libata-core.c

2007-01-11 Thread Benjamin Herrenschmidt
On Thu, 2007-01-11 at 18:30 +0900, Akira Iguchi wrote: Hi, Arnd-san. Thank you for checking our patches. On Thursday 11 January 2007 09:56, Akira Iguchi wrote: This patch modifies some static functions in libata-core.c and libata.h to use them in ata_scc.c. Exporting new symbols

Re: [2.6.18,19] SATA boot problems (ICH6/ICH6W)

2007-01-11 Thread Kovid Goyal
Hi, I was finally able to get the netconsole logs for a failing boot. Attached as log-panic. Sorry for the delay. Thanks, Kovid. On Tuesday 19 December 2006 18:13, you wrote: Kovid Goyal wrote: Yes going back to 2.6.17 does fix it. Also windows and various LiveCDs boot without problems.

Re: [PATCH 2/2] drivers/ata: export some static functions in libata-core.c

2007-01-11 Thread Benjamin Herrenschmidt
Why is it that other drivers did not need this functions? Did they copy them? Or maybe they don't need them? Most drivers can use the common functions as is. The problem starts when you need special mecanisms to access the taskfile registers. Ben. - To unsubscribe from this list: send the

[2.6 patch] let BLK_DEV_AMD74XX depend on X86

2007-01-11 Thread Adrian Bunk
It's unlikely that this driver will ever be of any use on other architectures. This fixes the following compile error on ia64: -- snip -- ... CC drivers/ide/pci/amd74xx.o /home/bunk/linux/kernel-2.6/linux-2.6.20-rc3-mm1/drivers/ide/pci/amd74xx.c: In function 'init_hwif_amd74xx':

[PATCH] ia64: add pci_get_legacy_ide_irq() (was: [2.6 patch] let BLK_DEV_AMD74XX depend on X86)

2007-01-11 Thread Bartlomiej Zolnierkiewicz
Adrian Bunk wrote: It's unlikely that this driver will ever be of any use on other architectures. It is already used on PPC. [ see arch/powerpc/platforms/maple/pci.c:maple_pci_get_legacy_ide_irq() ] This fixes the following compile error on ia64: -- snip -- ... CC

Re: [2.6 patch] let BLK_DEV_AMD74XX depend on X86

2007-01-11 Thread Alan
On Thu, 11 Jan 2007 14:49:17 +0100 Adrian Bunk [EMAIL PROTECTED] wrote: It's unlikely that this driver will ever be of any use on other architectures. This fixes the following compile error on ia64: NAK pci_get_legacy_ide_irq() is a required method for all platforms and is usually filled

Re: [2.6 patch] let BLK_DEV_AMD74XX depend on X86

2007-01-11 Thread Segher Boessenkool
It's unlikely that this driver will ever be of any use on other architectures. It's already being used, for example, the AMD8111 is used one some PowerPC systems (some with IDE connected even). Segher - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a

[PATCH 0/19] new IDE quilt tree

2007-01-11 Thread Bartlomiej Zolnierkiewicz
Hi, My working IDE tree (against Linus' tree) now resides here: http://kernel.org/pub/linux/kernel/people/bart/pata-2.6/patches/ and is managed by quilt. Currently it contains the following changes: * all IDE patches from 2.6.20-rc3-mm1 (great work done by Sergei Shtylyov [EMAIL

[PATCH 2/19] ide: add it8213 driver

2007-01-11 Thread Bartlomiej Zolnierkiewicz
[PATCH] ide: add it8213 driver From: Jack Lee [EMAIL PROTECTED] From: Alan Cox [EMAIL PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/Kconfig |5 drivers/ide/pci/Makefile |2 drivers/ide/pci/it8213.c | 402

[PATCH 3/19] ide: it8213 driver update

2007-01-11 Thread Bartlomiej Zolnierkiewicz
[PATCH] ide: it8213 driver update * set ATAPI/IORDY/TIME bits correctly in it8213_tuneproc() * fix UDMA/MWDMA/SWDMA masks in it8213_init_hwif() * in it8213_tune_chipset() SWDMA2 mode should be used instead of MWDMA0 * backport various fixes from piix/slc90e66 drivers: - in it8213_tuneproc() the

[PATCH 6/19] pdc202xx_old: remove dead code

2007-01-11 Thread Bartlomiej Zolnierkiewicz
[PATCH] pdc202xx_old: remove dead code CONFIG_PDC202XX_MASTER config option doesn't exist Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/pci/pdc202xx_old.c | 19 --- 1 file changed, 19 deletions(-) Index: a/drivers/ide/pci/pdc202xx_old.c

[PATCH 14/19] cs5530: small cleanup

2007-01-11 Thread Bartlomiej Zolnierkiewicz
[PATCH] cs5530: small cleanup * BUG() on unknown DMA mode in cs5530_config_dma() * there is no need to call hwif-ide_dma_host_{off,on}() in cs5530_config_dma() because hwif-ide_dma_host_{off,on}() is called by hwif-ide_dma_off_{quietly,on}() Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL

[PATCH 12/19] ide: remove ide_drive_t.usage

2007-01-11 Thread Bartlomiej Zolnierkiewicz
[PATCH] ide: remove ide_drive_t.usage This field is no longer used by the core IDE code so fix ide-{disk,floppy} drivers to keep openers count in the driver specific objects and remove it from ide-{cd,scsi,tape} drivers (it was write-only). Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL

[PATCH 16/19] sis5513: sis5513_config_xfer_rate() cleanup

2007-01-11 Thread Bartlomiej Zolnierkiewicz
[PATCH] sis5513: sis5513_config_xfer_rate() cleanup * remove bogus comment for sis5513_config_xfer_rate() * there is no need to call config_drive_art_rwp() because it is called by config_art_rwp_pio() * remove needless wrapper * remove stale TODO comment (IDE core should provide generic

[PATCH 17/19] ide: unexport ide_set_xfer_rate()

2007-01-11 Thread Bartlomiej Zolnierkiewicz
[PATCH] ide: unexport ide_set_xfer_rate() In cmd64x and siimage drivers: * don't set drive-init_speed as it should be already set by successful execution of ide_set_xfer_rate() * use hwif-speedproc functions directly Above changes allows removal of EXPORT_SYMBOL_GPL(ide_set_xfer_rate).

[PATCH 18/19] ide: add ide_use_fast_pio() helper

2007-01-11 Thread Bartlomiej Zolnierkiewicz
[PATCH] ide: add ide_use_fast_pio() helper * add ide_use_fast_pio() helper for use by host drivers * add DMA capability and autodma checks to ide_use_dma() - au1xxx-ide/it8213/it821x drivers didn't check for (id-capability 1) - ide-cris driver didn't set -autodma Signed-off-by: Bartlomiej

[PATCH 9/19] ide: remove write-only ide_hwif_t.no_dsc flag

2007-01-11 Thread Bartlomiej Zolnierkiewicz
[PATCH] ide: remove write-only ide_hwif_t.no_dsc flag Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-cd.c |8 drivers/ide/ide.c |1 - drivers/ide/pci/aec62xx.c |4 +--- drivers/ide/pci/hpt34x.c |1 - include/linux/ide.h