Re: [RFC] libata IORDY handling

2007-01-29 Thread Alan
Atttaching my (already obsolete) patch, just in case... Thanks. Double checking my code it looks similar although I don't bother with the DMA check as the drivers know that in DMA cases the PIO call will be made before the DMA mode is set when DMA modes are in use. - To unsubscribe from

Re: 2.6.20-rc6: known unfixed regressions (v2) (part 2)

2007-01-29 Thread Mike Galbraith
On Mon, 2007-01-29 at 11:01 +0100, Mike Galbraith wrote: On Sun, 2007-01-28 at 23:04 -0800, Linus Torvalds wrote: [ Added Jeff, Jens and Mike Christie to Cc. I would _guess_ this is associated with the larger block pc request stuff: Mike, Jens? James B added for good luck.

Re: 2.6.20-rc6: known unfixed regressions (v2) (part 2)

2007-01-29 Thread Mike Christie
Linus Torvalds wrote: [ Added Jeff, Jens and Mike Christie to Cc. I would _guess_ this is associated with the larger block pc request stuff: Mike, Jens? James B added for good luck. It apparently started happening somewhere between 2.6.19 and 2.6.20-rc2, and doing a

Re: 2.6.20-rc6: known unfixed regressions (v2) (part 2)

2007-01-29 Thread Linus Torvalds
On Mon, 29 Jan 2007, Mike Galbraith wrote: The extremely unlikely winner is: 29b08d2bae854f66d3cfd5f57aaf2e7c2c7fce32 is first bad commit Yeah, that's not going to be it. You probably had a bad kernel there somewhere that you called good. Git bisect is wonderful for figuring out

sil_24 PMP performance issue.

2007-01-29 Thread Richard Scobie
Hi Tejun, Did you get any response back from Silicon Image? Reference this thread: http://marc.theaimsgroup.com/?l=linux-idem=116727812518914w=2 While dmesg claims that 3.0Gbps was negotiated, the combined performance of the 5 disks never exceeds 1.5Gbps, no matter how I combine them.

Re: 2.6.20-rc6: known unfixed regressions (v2) (part 2)

2007-01-29 Thread Mike Christie
Linus Torvalds wrote: [ 4362.972995] hdd: status error: status=0x58 { DriveReady SeekComplete DataRequest } [ 4362.981475] ide: failed opcode was: unknown [ 4362.986183] hdd: drive not ready for command What chipsets are you guys using? I tried 2.6.20-rc6, and forced my cdrom to be used

Re: 2.6.20-rc6: known unfixed regressions (v2) (part 2)

2007-01-29 Thread Linus Torvalds
On Mon, 29 Jan 2007, Linus Torvalds wrote: That said, I'm making progress with my bisection. 16 revisions left to test after this, and three of those sixteen are Remove unnecessary blk_queue_bounce in SG_IO fix SG_IO bio leak remove blk_queue_activity_fn I've now

[PATCH] libata-scsi: ata_task_ioctl should return ATA registers (RESEND)

2007-01-29 Thread David Milburn
User applications using the HDIO_DRIVE_TASK ioctl specific ATA registers to be returned to userspace. Signed-off-by: David Milburn [EMAIL PROTECTED] Acked-by: Tejun Heo [EMAIL PROTECTED] Acked-by: Jeff Garzik [EMAIL PROTECTED] Signed-off-by: Andrew Morton [EMAIL PROTECTED] --- diff --git

Re: 2.6.20-rc6: known unfixed regressions (v2) (part 2)

2007-01-29 Thread Linus Torvalds
On Mon, 29 Jan 2007, Linus Torvalds wrote: Two more reboots and I should know exactly which one broke nero. This one. However, the scary thing is that I think the patch really is correct, and I wonder if nero has some strange work-around for an older bug.. Although I don't see how you

Re: 2.6.20-rc6: known unfixed regressions (v2) (part 2)

2007-01-29 Thread Linus Torvalds
Uwe, others, does this patch fix your problem? It will have a few printk's that it spews out, but if it fixes your problem, at least we know a bit more. Linus --- diff --git a/block/scsi_ioctl.c b/block/scsi_ioctl.c index 2528a0c..f0ff151 100644 --- a/block/scsi_ioctl.c +++

Re: 2.6.20-rc6: known unfixed regressions (v2) (part 2)

2007-01-29 Thread Mike Christie
Linus Torvalds wrote: Uwe, others, does this patch fix your problem? I can replicate the problem now using a older box, but same driver. It will have a few printk's that it spews out, but if it fixes your problem, at least we know a bit more. Linus --- diff --git

Re: 2.6.20-rc6: known unfixed regressions (v2) (part 2)

2007-01-29 Thread Linus Torvalds
On Mon, 29 Jan 2007, Mike Christie wrote: rq-bio is NULL here, so no data is coped back to userspace and it seems nero just stops trying to talk to the drive after this. Well, except that's what we used to do in 2.6.19 too. So what changed? Because nero just gives up, no more commands are

Re: 2.6.20-rc6: known unfixed regressions (v2) (part 2)

2007-01-29 Thread Mike Christie
Linus Torvalds wrote: On Mon, 29 Jan 2007, Mike Christie wrote: rq-bio is NULL here, so no data is coped back to userspace and it seems nero just stops trying to talk to the drive after this. Well, except that's what we used to do in 2.6.19 too. So what changed? Oops, you are right. I

Re: [2.6.18,19] SATA boot problems (ICH6/ICH6W)

2007-01-29 Thread Gary Hade
On Thu, Dec 21, 2006 at 09:10:35AM -0800, Gary Hade wrote: On Wed, Dec 20, 2006 at 12:53:57PM +0900, Tejun Heo wrote: Howdy, Gary Hade wrote: I noticed that Tejun recently provided a libata: handle 0xff status properly patch that is now in mainline that improves this code re:

Re: sata_promise TX2/TX4 cards rejecting smart auto-offline auto-save ata cmds?

2007-01-29 Thread Tejun Heo
Jim Paris wrote: Tejun Heo wrote: Andrew Paprocki wrote: On 10/30/06, Tejun Heo [EMAIL PROTECTED] wrote: Please read the following thread. http://thread.gmane.org/gmane.linux.ide/13222/focus=13235 Worked like a charm! Just patched up smartmontools now and I don't get the failed cmds

[PATCH 0/2] ide: clear bmdma status in ide_intr for Intel controllers (revised #3)

2007-01-29 Thread Albert Lee
patch 1/2: remove clearing bmdma status from cdrom_decode_status() since ATA devices might need it as well. patch 2/2: clear bmdma status in ide_intr() and add a new hwif-ide_dma_clear_irq for piix.c to use. - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a

Re: 2.6.20-rc6: known unfixed regressions (v2) (part 2)

2007-01-29 Thread Mike Christie
Linus Torvalds wrote: On Mon, 29 Jan 2007, Mike Christie wrote: Actually, I do not think we did this in 2.6.19. Tomo added a bug when he ported a patch and mixed up some things so we did something weird for 2.6.20-rc1. Ah, ok. Warring bugs. Have you pinpointed the original one? Is it

Re: 2.6.20-rc6: known unfixed regressions (v2) (part 2)

2007-01-29 Thread Mike Christie
Mike Christie wrote: Linus Torvalds wrote: On Mon, 29 Jan 2007, Mike Christie wrote: Actually, I do not think we did this in 2.6.19. Tomo added a bug when he ported a patch and mixed up some things so we did something weird for 2.6.20-rc1. Ah, ok. Warring bugs. Have you pinpointed the

Re: 2.6.20-rc6: known unfixed regressions (v2) (part 2)

2007-01-29 Thread Andrew Morton
On Mon, 29 Jan 2007 20:50:58 -0600 Mike Christie [EMAIL PROTECTED] wrote: With the attached patch, nero finds the cd drives and I can burn disks. There is no errors from the ide layer like before. [use-old-timeout-calc.patch text/x-patch (399B)] diff --git a/block/scsi_ioctl.c

Re: 2.6.20-rc6: known unfixed regressions (v2) (part 2)

2007-01-29 Thread Mike Christie
On Mon, 2007-01-29 at 19:08 -0800, Andrew Morton wrote: On Mon, 29 Jan 2007 20:50:58 -0600 Mike Christie [EMAIL PROTECTED] wrote: With the attached patch, nero finds the cd drives and I can burn disks. There is no errors from the ide layer like before. [use-old-timeout-calc.patch

Re: 2.6.20-rc6: known unfixed regressions (v2) (part 2)

2007-01-29 Thread Andrew Morton
On Mon, 29 Jan 2007 21:18:38 -0500 Mike Christie [EMAIL PROTECTED] wrote: Ok. here is a fix with the overflow check sg.c has. Patch was made against Linus's tree and tested with nero. Userspace does not send us jiffies. Use msecs_to_jiffies and check for overflow like sg.c Signed-off-by:

Re: 2.6.20-rc6: known unfixed regressions (v2) (part 2)

2007-01-29 Thread Mike Galbraith
On Mon, 2007-01-29 at 10:43 -0800, Linus Torvalds wrote: On Mon, 29 Jan 2007, Mike Galbraith wrote: The extremely unlikely winner is: 29b08d2bae854f66d3cfd5f57aaf2e7c2c7fce32 is first bad commit Yeah, that's not going to be it. You probably had a bad kernel there somewhere that

Re: 2.6.20-rc6: known unfixed regressions (v2) (part 2)

2007-01-29 Thread Linus Torvalds
On Mon, 29 Jan 2007, Mike Christie wrote: Ok. here is a fix with the overflow check sg.c has. Patch was made against Linus's tree and tested with nero. Userspace does not send us jiffies. Use msecs_to_jiffies and check for overflow like sg.c Signed-off-by: Mike Christie [EMAIL

Re: sata driver fails to work after resume from S3

2007-01-29 Thread Tejun Heo
Zhang Rui wrote: But how to make SATA drive S3 work properly in 2.6.16.33? There is no simple patch which can fix S3 support in 2.6.16. You need to backport whole libata EH including PM support. If you absolutely have to keep using 2.6.16.33, consider backporting libata as a whole from 2.6.19

Re: [2.6.18,19] SATA boot problems (ICH6/ICH6W)

2007-01-29 Thread Tejun Heo
Hello, Gary. Gary Hade wrote: If they verify your fix (ie, GoVault sometimes take more than 150ms to transmit the first D2H Reg FIs after SRST), I'll push similar patch upstream. Thanks. If you think that changes to increase the delays are the way to go (at least until we can find a better

Re: [PATCH RFC] sd: spin down disks on removal or power-down

2007-01-29 Thread Andrew Morton
On Sun, 28 Jan 2007 19:47:27 -0600 Robert Hancock [EMAIL PROTECTED] wrote: Here's a patch for sd.c I've cooked up which issues a START STOP UNIT command to stop the drive when the SCSI disk is removed or the machine is powered down. The rationale behind this is that apparently on many drives,

Re: [PATCH RFC] sd: spin down disks on removal or power-down

2007-01-29 Thread James Bottomley
On Mon, 2007-01-29 at 15:47 -0800, Andrew Morton wrote: What we don't want to happen is for those disks to spin down during a reboot. It seems that this is OK with this patch. Also, we probably don't want them to be spun down during a kexec_load, but I expect that's OK too. Actually,