Re: DVD drive fails in 2.6.20.2

2007-03-19 Thread Albert Lee
Albert Lee wrote: Vlad Codrea wrote: Albert Lee wrote: This is the first problem. It's weird to see HSM violation here, without any debug task_state trace. In your previous log, it was detected correctly with debug task_state trace. ata2.00: ATAPI, max MWDMA2, CDB intr ata2.00: configured

Re: [git patches] libata fixes

2007-03-19 Thread Tejun Heo
Paul Rolland wrote: Oh... that's just weird. It seems you'll have to continue boot with the timeouts for the time being. Sorry about that. Would you agree to a patch to add a kernel boot parameter to skip some ata ports ? I found some archives refering to some ataX=noprobe, but it seems to

Re: libata: CD and dvd devices not recognized

2007-03-19 Thread YUP
What about ata_piix, have I enable this? 2. Reconfigure the kernel. Remove the IDE pdc202xx_new and add the libata pata_pdc2027x driver for debugging. - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info

Re: libata: CD and dvd devices not recognized

2007-03-19 Thread Albert Lee
YUP wrote: What about ata_piix, have I enable this? It's ok to use either IDE (piix) or libata (ata_piix) to drive the HP drive. We don't need the log of the HP drive since it seems to work ok. -- albert - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a

Re: libata: CD and dvd devices not recognized

2007-03-19 Thread Sergei Shtylyov
Hello. Bartlomiej Zolnierkiewicz wrote: It seems that the drive works just fine in PIO mode with pdc202xx_new IDE driver (it doesn't support ATAPI DMA at the moment) There used to be Albert's patch enabling ATAPIT DMA in this driver: http://marc.info/?l=linux-idem=111027913608663 Oh

Re: DVD drive fails in 2.6.20.2

2007-03-19 Thread Vlad Codrea
Albert Lee wrote: From the following trace, it is not clear what happened right before the crash. Could you please sent me the full dmesg. (If it is too big for the mailing list, please gzip and send to my e-mail address as attachment.) Ah, just saw this on bugzilla (bug 6710):

Errors with AHCI and 10K Raptor drive

2007-03-19 Thread Stephen Hemminger
I am getting lots of these errors under moderate load. This is a new drive, so I suspect some driver incompatibility between the driver (AHCI) and the hard drive (WD Raptor 10K 74G). Lspci: 00:1f.2 SATA controller: Intel Corporation 82801FR/FRW (ICH6R/ICH6RW) SATA Controller (rev 03) (prog-if 01

Re: Errors with AHCI and 10K Raptor drive

2007-03-19 Thread Jeff Garzik
Stephen Hemminger wrote: This is a new drive, so I suspect some driver incompatibility between the driver (AHCI) and the hard drive (WD Raptor 10K 74G). Driver incompatibilities between the driver (LLDD or libata-core) and a hard drive are extremely rare. The most common problem on modern

Re: IOMEGA IDE ZIP (ATAPI) drive

2007-03-19 Thread Mark Lord
Albert Lee wrote: Mark Lord wrote: .. I patched the above in, and it was NEVER hit. Do you mean no wait for DRQ messages at all? Is the HSM violation still seen? The code you sent me to patch in was never hit. The wait for DRQ message therefore never gets output. The exact same set of HSM

Re: [PATCH] libata: add support for ATA_16 on ATAPI

2007-03-19 Thread Mark Lord
Tejun Heo wrote: Mark Lord wrote: (many months and hours of wasted effort later, still resending..) This patch adds support for issuing ATA_16 passthru commands to ATAPI devices managed by libata. It requires the previous CDB length fix patch. A boot/module parameter, ata16_passthru=1 can be

Re: [PATCH] libata: add support for ATA_16 on ATAPI

2007-03-19 Thread Tejun Heo
Here it is again, without the two extraneous spaces. This patch adds support for issuing ATA_16 passthru commands to ATAPI devices managed by libata. It requires the previous CDB length fix patch. A boot/module parameter, ata16_passthru=1 can be used to globally disable this feature, if ever

Re: [PATCH] sata_sil24: Add Adaptec 1220SA PCI ID

2007-03-19 Thread Jeff Garzik
Jamie Clark wrote: Add Adaptec 1220SA (SIL3132) to devices claimed by sata_sil24 Patch generated against 2.6.20.2 Signed-off-by: Jamie Clark [EMAIL PROTECTED] --- drivers/ata/sata_sil24.c.orig2007-03-10 02:58:04.0 +0800 +++ drivers/ata/sata_sil24.c2007-03-12 20:41:02.0

Re: [PATCH] drivers/ata/Kconfig: PATA_SCC depends on wrong platform

2007-03-19 Thread Jeff Garzik
Akira Iguchi wrote: PATA_SCC depends on PPC_CELLEB. (not PPC_IBM_CELL_BLADE) Signed-off-by: Kou Ishizaki [EMAIL PROTECTED] Signed-off-by: Akira Iguchi [EMAIL PROTECTED] --- diff -Nrpu -X linux-2.6.21-rc3/Documentation/dontdiff linux-2.6.21-rc3/drivers/ata/Kconfig

Re: [PATCH] sata_inic162x: kill double region requests

2007-03-19 Thread Jeff Garzik
Tejun Heo wrote: Regions are requested twice during initialization causing the second one to fail. This is regression introduced during iomap conversion. Signed-off-by: Tejun Heo [EMAIL PROTECTED] --- Nate, this should fix it. But LBA48 support is broken on the controller. diff --git

Re: [PATCH] libata: kernel-doc fix

2007-03-19 Thread Jeff Garzik
Randy Dunlap wrote: From: Randy Dunlap [EMAIL PROTECTED] Warning(linux-2621-rc3g7/drivers/ata/libata-core.c:842): No description found for parameter 'unknown' Signed-off-by: Randy Dunlap [EMAIL PROTECTED] --- drivers/ata/libata-core.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: Errors with AHCI and 10K Raptor drive

2007-03-19 Thread Stephen Hemminger
On Mon, 19 Mar 2007 11:01:37 -0400 Jeff Garzik [EMAIL PROTECTED] wrote: Stephen Hemminger wrote: This is a new drive, so I suspect some driver incompatibility between the driver (AHCI) and the hard drive (WD Raptor 10K 74G). Driver incompatibilities between the driver (LLDD or

Re: Change Libata Error Handling for Drive Testing

2007-03-19 Thread Fajun Chen
Another error we're analyzing is disabled IRQ due to screaming unhandled interrupts from ata_interrupt(). Since this happened on different drives, it doesn't seem to be a drive issue. Any known problem on this one? Could long ISR locking by some rogue application cause this problem? To

Re: Change Libata Error Handling for Drive Testing

2007-03-19 Thread Fajun Chen
On 3/19/07, Fajun Chen [EMAIL PROTECTED] wrote: Another error we're analyzing is disabled IRQ due to screaming unhandled interrupts from ata_interrupt(). Since this happened on different drives, it doesn't seem to be a drive issue. Any known problem on this one? Could long ISR

Re: CONFIG_IBM_BAY

2007-03-19 Thread Holger Macht
On Mon 19. Mar - 13:22:43, Matthew Garrett wrote: On Sun, Mar 18, 2007 at 09:27:51AM +0100, Holger Macht wrote: I don't prefer any solution, whether doing it inside the kernel, or doing it in userspace. What would be good would be to know what's the 'right' way to go, or at least what

Re: CONFIG_IBM_BAY

2007-03-19 Thread Matthew Garrett
On Sun, Mar 18, 2007 at 09:27:51AM +0100, Holger Macht wrote: I don't prefer any solution, whether doing it inside the kernel, or doing it in userspace. What would be good would be to know what's the 'right' way to go, or at least what both kernel people and userspace people can agree on so

Re: CONFIG_IBM_BAY

2007-03-19 Thread Matthew Garrett
On Mon, Mar 19, 2007 at 02:48:22PM +0100, Holger Macht wrote: 1. libata integration into the bay driver It actually makes sense to tie all PATA/SATA devices to their ACPI handles where appropriate - there's already code to do that in libata-acpi.c, but it would be nicer if it was integrated

Re: CONFIG_IBM_BAY

2007-03-19 Thread Holger Macht
On Mon 19. Mar - 14:04:03, Matthew Garrett wrote: On Mon, Mar 19, 2007 at 02:48:22PM +0100, Holger Macht wrote: 1. libata integration into the bay driver It actually makes sense to tie all PATA/SATA devices to their ACPI handles where appropriate - there's already code to do that in

Re: CONFIG_IBM_BAY

2007-03-19 Thread Henrique de Moraes Holschuh
On Mon, 19 Mar 2007, Matthew Garrett wrote: But you still have to deal with mounted filesystems, no matter if it a cardbus or a cdrom. Wouldn't we need something like 'save removal' triggered from userspace like you maybe know from 'the other' operating system? Yes, there's a need for a

Re: CONFIG_IBM_BAY

2007-03-19 Thread Holger Macht
On Mon 19. Mar - 12:36:59, Henrique de Moraes Holschuh wrote: On Mon, 19 Mar 2007, Matthew Garrett wrote: But you still have to deal with mounted filesystems, no matter if it a cardbus or a cdrom. Wouldn't we need something like 'save removal' triggered from userspace like you maybe know

Re: [ibm-acpi-devel] CONFIG_IBM_BAY

2007-03-19 Thread Shem Multinymous
On 3/19/07, Henrique de Moraes Holschuh [EMAIL PROTECTED] wrote: True. The best available procedure to do this for ACPI bay/dock currently is, AFAIK: 1. Send event when bay/dock please release button/lever is pressed. Do *nothing* else. I know bay does this right, maybe dock doesn't. 2. Wait

Re: CONFIG_IBM_BAY

2007-03-19 Thread Kristen Carlson Accardi
On Sun, 18 Mar 2007 15:36:52 -0300 Henrique de Moraes Holschuh [EMAIL PROTECTED] wrote: On Sun, 18 Mar 2007, Holger Macht wrote: those ThinkPads where it is needed. Afterwards it does the corresponding dock/undock request on ibm_acpi. And this works reliably good what I can see from the

Re: [git patches] libata fixes

2007-03-19 Thread Alan Cox
On Mon, Mar 19, 2007 at 08:48:00AM +0100, Paul Rolland wrote: Would you agree to a patch to add a kernel boot parameter to skip some ata ports ? It should in theory not be neccessary I found some archives refering to some ataX=noprobe, but it seems to have no effect, and I'd like to

Re: [PATCH 2.6.22] Add LED trigger to libata core

2007-03-19 Thread Alan Cox
On Mon, 19 Mar 2007 13:42:37 +0900 Tejun Heo [EMAIL PROTECTED] wrote: Tony Vroon wrote: This duplicates the IDE core LED trigger in the libata core. I plan to use this by allowing PMU LED control on G5 towers. My test platform is a PowerMac 7,3 (Dual G5 2.0GHz, June 2004) with a K2

Re: [PATCH 2.6.22] Add LED trigger to libata core

2007-03-19 Thread Mikael Pettersson
On Mon, 19 Mar 2007 12:46:16 +, Alan Cox wrote: This duplicates the IDE core LED trigger in the libata core. I plan to use this by allowing PMU LED control on G5 towers. My test platform is a PowerMac 7,3 (Dual G5 2.0GHz, June 2004) with a K2 (sata_svw) controller. I

Re: [PATCH 2.6.22] Add LED trigger to libata core

2007-03-19 Thread Tejun Heo
Alan Cox wrote: On Mon, 19 Mar 2007 13:42:37 +0900 Tejun Heo [EMAIL PROTECTED] wrote: Tony Vroon wrote: This duplicates the IDE core LED trigger in the libata core. I plan to use this by allowing PMU LED control on G5 towers. My test platform is a PowerMac 7,3 (Dual G5 2.0GHz, June 2004)

Re: [PATCH 2.6.22] Add LED trigger to libata core

2007-03-19 Thread Tony Vroon
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Alan Cox wrote: Gak. I'd rather it stayed out of ata_qc_issue() which is a critical path for performance. Our command issu is already too heavy and not all controllers have queueing to absorb that. How many controllers actually need this hook

Re: [PATCH] libata: don't whine if -prereset() returns -ENOENT

2007-03-19 Thread Jeff Garzik
Tejun Heo wrote: -prereset() returns -ENOENT to tell libata that the port is empty and reset sequencing should be stopped. This is not an error condition. Update ata_eh_reset() such that it sets device classes to ATA_DEV_NONE and return success in on -ENOENT. This makes spurious error message

[git patches] libata fixes

2007-03-19 Thread Jeff Garzik
Please pull from 'upstream-linus' branch of master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/libata-dev.git upstream-linus to receive the following updates: drivers/ata/Kconfig |2 +- drivers/ata/libata-core.c|2 +- drivers/ata/libata-eh.c |8 +++-

Re: libata: CD and dvd devices not recognized

2007-03-19 Thread YUP
Hi Sergei, Albert and Bartek, Thanks for the patch. If you dealt with it, could you please apply this patch to 2.6.20.3 kernel and send me diff? I'm just afraid that I couldn't do it right. Albert and Bartek, please find latest dmsg output with Albert's patch. I quoted here only output

Re: Errors with AHCI and 10K Raptor drive

2007-03-19 Thread Stephen Hemminger
On Mon, 19 Mar 2007 11:01:37 -0400 Jeff Garzik [EMAIL PROTECTED] wrote: Stephen Hemminger wrote: This is a new drive, so I suspect some driver incompatibility between the driver (AHCI) and the hard drive (WD Raptor 10K 74G). Driver incompatibilities between the driver (LLDD or

Re: Errors with AHCI and 10K Raptor drive

2007-03-19 Thread Jeff Garzik
Stephen Hemminger wrote: On Mon, 19 Mar 2007 11:01:37 -0400 Jeff Garzik [EMAIL PROTECTED] wrote: Stephen Hemminger wrote: This is a new drive, so I suspect some driver incompatibility between the driver (AHCI) and the hard drive (WD Raptor 10K 74G). Driver incompatibilities between the driver

Re: libata: CD and dvd devices not recognized

2007-03-19 Thread YUP
Hi Sergei, Well, I checked pata_pdc2027x.c code and found that code completely rewrited. For unexperienced user it is not so easy to apply. Yarema There used to be Albert's patch enabling ATAPIT DMA in this driver: http://marc.info/?l=linux-idem=111027913608663 Oh my, that was 2

[PATCH 2.6.22 1/3] Add LED trigger to libata core

2007-03-19 Thread Tony Vroon
This adds an optional wrapper around ata_ac_issue_prot that triggers the LED layer. I plan to use this by allowing PMU LED control on G5 towers. My test platform is a PowerMac 7,3 (Dual G5 2.0GHz, June 2004) with a K2 (sata_svw) controller. Respin of an earlier patch, based on comments by Tejun

Re: [PATCH 2.6.22 3/3] Add LED trigger to libata core

2007-03-19 Thread Tejun Heo
Tony Vroon wrote: The first user of ata_ac_issue_prot_with_ledtrigger, the ServerWorks Frodo/ Apple K2 driver. Used by the IDE LED trigger on G5 towers. Respin of an earlier patch, based on comments by Tejun Heo Alan Cox. Just two comments. 1. IMHO, ata_qc_issue_prot_ledtrigger() without

Re: Change Libata Error Handling for Drive Testing

2007-03-19 Thread Tejun Heo
Fajun Chen wrote: Please ignore the changes to pata_sil680.c. The same failure happened to standard sil680 driver without my change as well. Does it also happen when the second port is empty? -- tejun - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a

Re: Change Libata Error Handling for Drive Testing

2007-03-19 Thread Fajun Chen
On 3/19/07, Tejun Heo [EMAIL PROTECTED] wrote: Fajun Chen wrote: Please ignore the changes to pata_sil680.c. The same failure happened to standard sil680 driver without my change as well. Does it also happen when the second port is empty? Yes, it happens even when one of the port (either

[PATCH] libata: improve AC_ERR_DEV handling for -post_internal_cmd

2007-03-19 Thread Tejun Heo
-post_internal_cmd is simplified EH for internal commands. Its primary mission is to stop the controller such that no rogue memory access or other activities occur after the internal command is released. It may provide error diagnostics by setting qc-err_mask but this hasn't been a requirement.

Re: [ibm-acpi-devel] CONFIG_IBM_BAY

2007-03-19 Thread Henrique de Moraes Holschuh
On Mon, 19 Mar 2007, Shem Multinymous wrote: Userspace wants to (non-force-)-unmount by itself after (1), so it can stop the eject process if the filesystems cannot be cleanly unmounted. So the force-unmount at (3) ends up being a redundant safety measure at best. More like it is a make sure

new warning in ata_sg_clean

2007-03-19 Thread Meelis Roos
In todays 2.6.21-rc4+git the following news warning has appeared on my ppc computer: CC [M] drivers/ata/libata-core.o drivers/ata/libata-core.c: In function 'ata_sg_clean': drivers/ata/libata-core.c:3558: warning: unused variable 'dir' -- Meelis Roos ([EMAIL PROTECTED]) - To unsubscribe