[PATCH] libata: blacklist TOSHIBA MK1637GSX

2007-11-19 Thread Konstantin A. Lepikhov
Hi! TOSHIBA MK1637GSX do spurious command completion More details can be found in http://bugzilla.kernel.org/show_bug.cgi?id=9410 -- WBR et al. >From 9aca07148a192ece4c6fe085148b3cfb7390d367 Mon Sep 17 00:00:00 2001 From: Konstantin A. Lepikhov <[EMAIL PROTECTED]> Date: Mon, 19 Nov 2007 23:56:2

2.6.23.1 SATA disk not properly spun down

2007-11-19 Thread Filippo Zangheri
Hi, I'm not subscribed to the list so, please, CC me in replies, My shutdown sequence terminates with a message stating that my SATA disk was not correctly spun down and that I have to go to linux-ata.org . Well, I went there but no solutions. is there any patch? Thank you, great job guys. --

Re: [PATCH 2/2] sata_nv: fix ATAPI issues with memory over 4GB (v3)

2007-11-19 Thread Tejun Heo
Robert Hancock wrote: > It looks like the problem is that even though we set the DMA mask after > we allocate the PRD and pad buffers, when the other port is set up, the > DMA mask is already over 64-bit and so it allocates its buffers over 4GB > and fails. I think we just need to explicitly set to

Re: [PATCH 2/2] sata_nv: fix ATAPI issues with memory over 4GB (v3)

2007-11-19 Thread Robert Hancock
Tejun Heo wrote: Robert Hancock wrote: Tejun Heo wrote: Robert Hancock wrote: This fixes some problems with ATAPI devices on nForce4 controllers in ADMA mode on systems with memory located above 4GB. We need to delay setting the 64-bit DMA mask until the PRD table and padding buffer are alloca

[PATCH 17/59] drivers/ide: Add missing "space"

2007-11-19 Thread Joe Perches
Signed-off-by: Joe Perches <[EMAIL PROTECTED]> --- drivers/ide/ppc/pmac.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/ide/ppc/pmac.c b/drivers/ide/ppc/pmac.c index 5afdfef..7f7a598 100644 --- a/drivers/ide/ppc/pmac.c +++ b/drivers/ide/ppc/pmac.c @@ -1513,7 +1

Re: 2.6.24-rc & SB600 AHCI no go on >=4GB of RAM

2007-11-19 Thread Tejun Heo
Andi Kleen wrote: > >> The AHCI code falls back to 32bit DMA in that case. Which in turn >> causes the problem seen by Srihari. There is not much printk sticking >> necessary, the code is simply not handling this. > > What code is not handling what? > > IOMMU merging should be always safe. If

Re: [PATCH 2/2] sata_nv: fix ATAPI issues with memory over 4GB (v3)

2007-11-19 Thread Tejun Heo
Robert Hancock wrote: > Tejun Heo wrote: >> Robert Hancock wrote: >>> This fixes some problems with ATAPI devices on nForce4 controllers in >>> ADMA mode >>> on systems with memory located above 4GB. We need to delay setting >>> the 64-bit >>> DMA mask until the PRD table and padding buffer are all

Re: 2.6.24-rc & SB600 AHCI no go on >=4GB of RAM

2007-11-19 Thread Srihari Vijayaraghavan
Andi Kleen <[EMAIL PROTECTED]> wrote: [...] > > IOMMU merging should be always safe. If it is not the driver should > not submit things in a single SG list. > > > So the main option > > right now seems to revert the iommu_merge patch. > > I don't think that is the correct fix. Just to make sur

Re: [Bugme-new] [Bug 9410] New: TOSHIBA MK1637GSX do spurious command completion

2007-11-19 Thread Andrew Morton
On Mon, 19 Nov 2007 13:21:36 -0800 (PST) [EMAIL PROTECTED] wrote: > http://bugzilla.kernel.org/show_bug.cgi?id=9410 > >Summary: TOSHIBA MK1637GSX do spurious command completion >Product: IO/Storage >Version: 2.5 > KernelVersion: 2.6.24-rc2 GIT 8c0863403f10

Re: [PATCH 6/21] ide: move CONFIG_IDE_ETRAX to drivers/ide/Kconfig

2007-11-19 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: * Move ETRAX_IDE and friends from arch/cris/arch-{v10,v32}/drivers/Kconfig to drivers/ide/Kconfig. * Don't force selecting ide-disk and ide-cd device drivers (please handle this through defconfig if necessary). * Make ETRAX_IDE depend on BROKEN for the

Re: [PATCH 5/21] ide: add CONFIG_IDE_H8300 config option

2007-11-19 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: Add a separate config option for ide-8300 host driver instead of depending on CONFIG_H8300. This change is a preparation for the future changes and also allows ide-h8300 to be disabled if needed. Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]>

Re: [PATCH 4/21] ide/Kconfig: fix mpc8xx host driver dependencies

2007-11-19 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: Only LWMON, IVMS8, IVML24 and TQM8xxL platforms have the needed defines (IDE0_BASE_OFFSET and friends) in the platform header file. Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> Acked-by: Sergei Shtylyov <[EMAIL PROTECTED]> MBR, Sergei - To u

Re: Process Scheduling Issue using sg/libata

2007-11-19 Thread Alan Cox
> SFF ATA controllers are peculiar in that... > > 1. it doesn't have reliable IRQ pending bit. > > 2. it doesn't have reliable IRQ mask bit. > > 3. some controllers tank the machine completely if status or data > register is accessed differently than the chip likes. And 4. which is a killer for

Re: Process Scheduling Issue using sg/libata

2007-11-19 Thread Tejun Heo
James Chapman wrote: > Mark Lord wrote: >> One way to deal with it in an embedded device, is to force the >> application that's generating the I/O to self-throttle. >> Or modify the device driver to self-throttle. > > Does disk access have to be so interrupt driven? Could disk interrupt > handling

Re: Process Scheduling Issue using sg/libata

2007-11-19 Thread James Chapman
Mark Lord wrote: > Fajun Chen wrote: >> >> As a matter of fact, I'm using /dev/sg*. Due to the size of my test >> application, I have not be able to compress it into a small and >> publishable form. However, this issue can be easily reproduced on my >> ARM XScale target using sg3_util code as foll

[PATCH] ata.h: Don't do a SATA check for 40wire_relaxed

2007-11-19 Thread Alan Cox
Without the valid bits at least one set of TSScorp drives report 0 in word 93 for PATA 40 wire, which we (and the specs) say actually means SATA. (The SATA version seems to report 80 wire...) Signed-off-by: Alan Cox <[EMAIL PROTECTED]> diff -u --new-file --recursive --exclude-from /usr/src/exclud

[PATCH] pata_ninja32: Cardbus ATA initial support

2007-11-19 Thread Alan Cox
Lots of work needed to bring it up to scratch but it does work so you can now use the card. That makes it at least useful, especially as the other cardbus cards are usually INIC162x which aren't yet supported well. Signed-off-by: Alan Cox <[EMAIL PROTECTED]> diff -u --new-file --recursive --exclu

[PATCH] pata_pcmcia: Minor cleanups and support for dual channel cards

2007-11-19 Thread Alan Cox
Signed-off-by: Alan Cox <[EMAIL PROTECTED]> diff -u --new-file --recursive --exclude-from /usr/src/exclude linux.vanilla-2.6.24-rc2-mm1/drivers/ata/pata_pcmcia.c linux-2.6.24-rc2-mm1/drivers/ata/pata_pcmcia.c --- linux.vanilla-2.6.24-rc2-mm1/drivers/ata/pata_pcmcia.c 2007-11-16 17:55:11.00

[PATCH] pata_hpt37x: Fix cable detect bug spotted by Sergei

2007-11-19 Thread Alan Cox
Signed-off-by: Alan Cox <[EMAIL PROTECTED]> diff -u --new-file --recursive --exclude-from /usr/src/exclude linux.vanilla-2.6.24-rc2-mm1/drivers/ata/pata_hpt37x.c linux-2.6.24-rc2-mm1/drivers/ata/pata_hpt37x.c --- linux.vanilla-2.6.24-rc2-mm1/drivers/ata/pata_hpt37x.c 2007-11-16 17:55:11.00

[PATCH] pata_ali: Lots of problems still showing up with small ATAPI DMA

2007-11-19 Thread Alan Cox
Hopefully there is a better long term solution but for now lets favour reliability. Signed-off-by: Alan Cox <[EMAIL PROTECTED]> diff -u --new-file --recursive --exclude-from /usr/src/exclude linux.vanilla-2.6.24-rc2-mm1/drivers/ata/pata_ali.c linux-2.6.24-rc2-mm1/drivers/ata/pata_ali.c --- linu

[PATCH] pata_ali: Add Mitac 8317 and derivatives

2007-11-19 Thread Alan Cox
Signed-off-by: Alan Cox <[EMAIL PROTECTED]> diff -u --new-file --recursive --exclude-from /usr/src/exclude linux.vanilla-2.6.24-rc2-mm1/drivers/ata/pata_ali.c linux-2.6.24-rc2-mm1/drivers/ata/pata_ali.c --- linux.vanilla-2.6.24-rc2-mm1/drivers/ata/pata_ali.c 2007-11-16 17:55:11.0 +

[PATCH] libata-sff: tf_load

2007-11-19 Thread Alan Cox
Jeff said he preferred that the SFF tf_load followed the spec and we documented that anyone who needed different overrode it, rather than it using the ->check_status methods. No driver relies on the current behaviour. Signed-off-by: Alan Cox <[EMAIL PROTECTED]> diff -u --new-file --recursive --ex

[PATCH] libata: IORDY handling

2007-11-19 Thread Alan Cox
I believe this version meets all Sergei's objections Correct the logic for when we issue a set features for transfer mode - If the device has IORDY and the controller has IORDY - set the mode - If the device has IORDY and the controller does not - turn IORDY off - If neither has IORDY do nothing

[PATCH] libata-core: List more documentation sources for reference

2007-11-19 Thread Alan Cox
And next time I'll be able to find the ata tape spec easily... Signed-off-by: Alan Cox <[EMAIL PROTECTED]> diff -u --new-file --recursive --exclude-from /usr/src/exclude linux.vanilla-2.6.24-rc2-mm1/drivers/ata/libata-core.c linux-2.6.24-rc2-mm1/drivers/ata/libata-core.c --- linux.vanilla-2.6.2

[PATCH] ahci: Invalid use of writel/readl with iomap

2007-11-19 Thread Alan Cox
Should use ioread* as discussed previously Signed-off-by: Alan Cox <[EMAIL PROTECTED]> diff -u --new-file --recursive --exclude-from /usr/src/exclude linux.vanilla-2.6.24-rc2-mm1/drivers/ata/ata_piix.c linux-2.6.24-rc2-mm1/drivers/ata/ata_piix.c --- linux.vanilla-2.6.24-rc2-mm1/drivers/ata/ata_

Re: [PATCH] pata_platform: move ARCH_RPC to use MACH_HAS_PATA_PLATFORM

2007-11-19 Thread Ben Dooks
On Mon, Nov 19, 2007 at 12:50:15PM +, Russell King - ARM Linux wrote: > On Mon, Nov 19, 2007 at 12:43:40PM +, Ben Dooks wrote: > > Move ARCH_RPC to using MACH_HAS_PATA_PLATFORM as an example > > of using this new configuration. > > I thought that it had been agreed (on linux-arch) that the

Re: Hang during boot in piix_init_pcs (ata_piix.c) with macbook pro

2007-11-19 Thread Thomas Rohwer
I meant the former. Can you post the result of "lspci -nnvvvxxx"? Thanks. Here it is. Thomas 00:00.0 Host bridge [0600]: Intel Corporation Mobile Memory Controller Hub [8086:2a00] (rev 03) Subsystem: Apple Computer Inc. Unknown device [106b:00a0] Control: I/O- Mem+ BusMaste

Re: Hang during boot in piix_init_pcs (ata_piix.c) with macbook pro

2007-11-19 Thread Tejun Heo
Thomas Rohwer wrote: >> One question. Does macbook's firmware allow putting the controller into >> ahci mode? > > Do you mean, that one can configure the firmware, so that it puts the > controller in ahci mode during boot? I don't know. There seems to be no > user interface > for the firmware. Th

Re: Hang during boot in piix_init_pcs (ata_piix.c) with macbook pro

2007-11-19 Thread Thomas Rohwer
One question. Does macbook's firmware allow putting the controller into ahci mode? Do you mean, that one can configure the firmware, so that it puts the controller in ahci mode during boot? I don't know. There seems to be no user interface for the firmware. The refit bootloader is able to mani

Re: [PATCH] pata_platform: move ARCH_RPC to use MACH_HAS_PATA_PLATFORM

2007-11-19 Thread Russell King - ARM Linux
On Mon, Nov 19, 2007 at 12:43:40PM +, Ben Dooks wrote: > Move ARCH_RPC to using MACH_HAS_PATA_PLATFORM as an example > of using this new configuration. I thought that it had been agreed (on linux-arch) that the name of these options shall be HAVE_foo to enable a driver configuration symbol of

[PATCH] pata_platform: move ARCH_RPC to use MACH_HAS_PATA_PLATFORM

2007-11-19 Thread Ben Dooks
Move ARCH_RPC to using MACH_HAS_PATA_PLATFORM as an example of using this new configuration. Signed-off-by: Ben Dooks <[EMAIL PROTECTED]> diff -urpN -X linux-2.6.24-rc3-pata1/Documentation/dontdiff linux-2.6.24-rc3-pata1/drivers/ata/Kconfig linux-2.6.24-rc3-pata2/drivers/ata/Kconfig --- linux-2

[PATCH] pata_platfrom: add MACH_HAS_PATA_PLATFORM configuration

2007-11-19 Thread Ben Dooks
Add a configuration entry (MACH_HAS_PATA_PLATFORM) so that any machine impelementing a pata_platform driver can add this to their own Kconfig to enable the PATA_PLATFORM driver. This will avoid multiple patches to the drivers/ata/Kconfig when new machine support is added. Signed-off-by: Ben Dooks

Re: [PATCH 1/21] ide: dump taskfile HOB registers in ide_tf_load() (if DEBUG is defined)

2007-11-19 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: * Dump taskfile HOB registers in ide_tf_load() (if DEBUG is defined). * Remove no longer needed DEBUG code from __ide_do_rw_disk(). Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> Acked-by: Sergei Shtylyov <[EMAIL PROTECTED]> MBR, Sergei - T

Re: [PATCH 3/21] macide/q40ide: add missing __init tag to {macide,q40ide}_init()

2007-11-19 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> Acked-by: Sergei Shtylyov <[EMAIL PROTECTED]> MBR, Sergei - To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to [EMAIL PROTECTED] More majordomo info at

[PATCH] pata_jmicron: fix disabled port handling in jmicron_pre_reset()

2007-11-19 Thread Tejun Heo
There are two bugs in disabled port handling. * test in PORT_PATA0 is reversed * ->prereset should return -ENOENT for disabled ports not 0 The first bug makes the PATA channel considered disabled but the second bug saves the day by returning 0. The net result is that cable is always left at ATA_