Re: Kernel 2.6.23.9 / P35 Chipset + WD 750GB Drives (reset port)

2007-12-01 Thread Jan Engelhardt
On Dec 1 2007 06:26, Justin Piszcz wrote: I ran the following: dd if=/dev/zero of=/dev/sdc dd if=/dev/zero of=/dev/sdd dd if=/dev/zero of=/dev/sde (as it is always a very good idea to do this with any new disk) Why would you care about what's on the disk? fdisk, mkfs and the day-to-day

Re: SAS v SATA interface performance

2007-12-01 Thread Greg Freemyer
On Dec 1, 2007 2:43 AM, Richard Scobie [EMAIL PROTECTED] wrote: Alan Cox wrote: If you want really high performance use multiple drives, on multiple PCIE controllers. Just make sure your backup planning of raid 1+0 setup is done right as many drives means a lot more drive fails. Thanks

[PATCH] sata_mv: Fix broken Marvell 7042 support.

2007-12-01 Thread Mark Lord
sata_mv: Fix broken Marvell 7042 support. The Marvell 7042 chip is more or less the same as the 6042 internally, but sports a PCIe bus. Despite having identical SATA cores, the 7042 does differ from its PCI bus counterparts in placment and layout of certain bus related registers. This patch

Re: [PATCH] sata_mv: Fix broken Marvell 7042 support.

2007-12-01 Thread Alan Cox
On Sat, 01 Dec 2007 13:07:22 -0500 Mark Lord [EMAIL PROTECTED] wrote: sata_mv: Fix broken Marvell 7042 support. The Marvell 7042 chip is more or less the same as the 6042 internally, but sports a PCIe bus. Despite having identical SATA cores, the 7042 does differ from its PCI bus

Re: Kernel 2.6.23.9 / P35 Chipset + WD 750GB Drives (reset port)

2007-12-01 Thread Bill Davidsen
Jan Engelhardt wrote: On Dec 1 2007 06:26, Justin Piszcz wrote: I ran the following: dd if=/dev/zero of=/dev/sdc dd if=/dev/zero of=/dev/sdd dd if=/dev/zero of=/dev/sde (as it is always a very good idea to do this with any new disk) Why would you care about what's on the disk? fdisk, mkfs

Re: SAS v SATA interface performance

2007-12-01 Thread Richard Scobie
Greg Freemyer wrote: Also, if you have Port Multiplexers (PMPs) in use, that would be interesting to know. I don't even know if PMPs are supported via SAS controllers in 2.6.24 or not. ie. PMP support is new to 2.6.24 and only a few Sata controllers will have PMP support in 2.6.24. No,

Re: SAS v SATA interface performance

2007-12-01 Thread Mark Lord
Richard Scobie wrote: Greg Freemyer wrote: Also, if you have Port Multiplexers (PMPs) in use, that would be interesting to know. I don't even know if PMPs are supported via SAS controllers in 2.6.24 or not. ie. PMP support is new to 2.6.24 and only a few Sata controllers will have PMP

Re: Kernel 2.6.23.9 / P35 Chipset + WD 750GB Drives (reset port)

2007-12-01 Thread Robert Hancock
Justin Piszcz wrote: I am putting a new machine together and I have dual raptor raid 1 for the root, which works just fine under all stress tests. Then I have the WD 750 GiB drive (not RE2, desktop ones for ~150-160 on sale now adays): I ran the following: dd if=/dev/zero of=/dev/sdc dd

Re: SAS v SATA interface performance

2007-12-01 Thread Jeff Garzik
Mark Lord wrote: SATA port multipliers (think, hub) permit multiple drives to be active simultaneously. Quite true, although the host controller could artificially limit this, giving the user a mistaken impression of their port multiplier being limited to one-command-per-N-drives. /nit

Re: [PATCH] [libata] sata_mv: fix compilation error when enabling DEBUG

2007-12-01 Thread Jeff Garzik
Saeed Bishara wrote: From: Saeed Bishara [EMAIL PROTECTED] use sstatus instead status. Signed-off-by: Saeed Bishara [EMAIL PROTECTED] --- drivers/ata/sata_mv.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/ata/sata_mv.c b/drivers/ata/sata_mv.c index

Re: [PATCH 1/1] Several fixes for the AVR32 PATA driver

2007-12-01 Thread Jeff Garzik
Kristoffer Nyborg Gregertsen wrote: Several fixes for the AVR32 PATA driver: * Updated to use new AVR32 SMC timing API. This removes the need for magic constants in signal timing. * Removed the ATA_FLAG_PIO_POLLING, the driver should use interrupts. * Removed .port_disable and .irq_ack as

Re: [PATCH] libata: report protocol and full CDB on error

2007-12-01 Thread Jeff Garzik
Tejun Heo wrote: Protocol and CDB allocation size field are important in determining what went wrong with ATAPI commands. Report them on failure. Signed-off-by: Tejun Heo [EMAIL PROTECTED] --- This one is for #upstream-fixes. Thanks. nod, applied - To unsubscribe from this list: send the

Re: Peculiar out-of-sync boot log lines

2007-12-01 Thread Bartlomiej Zolnierkiewicz
Hi, On Thursday 29 November 2007, Mark Lord wrote: Nick Warne wrote: Hi all, 2.6.23.9 I have noticed after applying Bart's patch to word93 blacklist my new DVD drive: http://lkml.org/lkml/2007/10/23/475 I see now in logs (look at the hdd line: [dmesg] hdc:

Re: [PATCH 26/28] blk_end_request: changing ide-cd (take 3)

2007-12-01 Thread Bartlomiej Zolnierkiewicz
Hi, On Saturday 01 December 2007, Kiyoshi Ueda wrote: This patch converts ide-cd (cdrom_newpc_intr()) to use blk_end_request(). ide-cd (cdrom_newpc_intr()) has some tricky behaviors below which need to use blk_end_request_callback(). Needs to: 1. call post_transform_command() to modify

Re: [PATCH 24/28] blk_end_request: changing ide normal caller (take 3)

2007-12-01 Thread Bartlomiej Zolnierkiewicz
On Saturday 01 December 2007, Kiyoshi Ueda wrote: This patch converts normal parts of ide to use blk_end_request(). Signed-off-by: Kiyoshi Ueda [EMAIL PROTECTED] Signed-off-by: Jun'ichi Nomura [EMAIL PROTECTED] --- drivers/ide/ide-cd.c |6 +++--- drivers/ide/ide-io.c | 17

Re: [PATCH] sata_mv: Fix broken Marvell 7042 support.

2007-12-01 Thread Jeff Garzik
Mark Lord wrote: sata_mv: Fix broken Marvell 7042 support. The Marvell 7042 chip is more or less the same as the 6042 internally, but sports a PCIe bus. Despite having identical SATA cores, the 7042 does differ from its PCI bus counterparts in placment and layout of certain bus related

Re: [PATCH #upstream-fixes] ata_piix: add more toshiba laptops to broken suspend list

2007-12-01 Thread Jeff Garzik
Tejun Heo wrote: From: Peter Schwenke [EMAIL PROTECTED] Add more toshiba laptops to broken suspend list. This is from OSDL bugzilla bug 7780. tj: re-formatted patch and added description and SOB. Signed-off-by: Peter Schwenke [EMAIL PROTECTED] Signed-off-by: Tejun Heo [EMAIL PROTECTED] ---

Re: [PATCH 2/8] libata: implement protocol tests

2007-12-01 Thread Jeff Garzik
Tejun Heo wrote: diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c index 5eb5983..8d5cd16 100644 --- a/drivers/ata/libata-core.c +++ b/drivers/ata/libata-core.c @@ -5969,7 +5946,7 @@ void ata_qc_issue(struct ata_queued_cmd *qc) */ WARN_ON(ap-ops-error_handler

Re: [PATCH 4/8] libata: move ata_set_mode() to libata-eh.c

2007-12-01 Thread Jeff Garzik
Tejun Heo wrote: Move ata_set_mode() to libata-eh.c. ata_set_mode() is surely an EH action and will be more tightly coupled with the rest of error handling. Move it to libata-eh.c. Signed-off-by: Tejun Heo [EMAIL PROTECTED] Does this mean SET FEATURES - XFER MODE via SG_IO will be possible

Re: [PATCH 8/8] libata: implement fast speed down for unverified data transfer mode

2007-12-01 Thread Jeff Garzik
Tejun Heo wrote: It's very likely that the configured data transfer mode is the wrong one if device fails data transfers right after initial data transfer mode configuration (including NCQ on/off and xfermode). libata EH needs to speed down fast before upper layers give up on probing. This

Re: [PATCH 0/3] OF-platform PATA driver

2007-12-01 Thread Jeff Garzik
Anton Vorontsov wrote: Hi all, Here is the second spin of the OF-platform PATA driver and related patches. Changes since RFC: - nuked drivers/ata/pata_platform.h; - powerpc bits: proper localbus node added. Thanks for the previous review! This time I'm collecting acks, don't be shy to give

Re: [PATCH 1/8] libata: rearrange ATA_DFLAG_*

2007-12-01 Thread Jeff Garzik
Tejun Heo wrote: Area for DFLAGs which are cleared on INIT is full. Extend it by 8 bits. Signed-off-by: Tejun Heo [EMAIL PROTECTED] --- include/linux/libata.h |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) applied 1-8 to #upstream - To unsubscribe from this list: send the

Re: [PATCH 12/12] pata_amd: update mode selection for NV PATAs

2007-12-01 Thread Jeff Garzik
Tejun Heo wrote: Cable detection on NV PATA hosts isn't implemented and the CBLID- cable isn't wired according to the sepc either, so both host-side and generic drive-side cable detections are broken. Till now, nv_cable_detect() relied on peeking BIOS and ACPI configurations to upgrade to 80C

Re: [PATCH RFC] sata_promise: make pdc_atapi_pkt() use values from qc-tf

2007-12-01 Thread Jeff Garzik
Tejun Heo wrote: Make pdc_atapi_pkt() use values from qc-tf instead of creating its own. This is to ease future ATAPI handling changes. DONT APPLY YET --- Mikael, would this work? Values other than lbam and lbah remain the same. Does sata_promise have strict requirements for lbam and lbah?

Re: [patch] ata: ahci: Enclosure Management via LED rev2

2007-12-01 Thread Jeff Garzik
Kristen Carlson Accardi wrote: Enclosure Management via LED This patch implements Enclosure Management via the LED protocol as specified in AHCI specification. Signed-off-by: Kristen Carlson Accardi [EMAIL PROTECTED] --- This revision makes the change to the comment requested by Mark Lord,

[git patches] libata fixes

2007-12-01 Thread Jeff Garzik
Please pull from 'upstream-linus' branch of master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/libata-dev.git upstream-linus to receive the following updates: drivers/ata/ata_piix.c| 28 +++ drivers/ata/libata-core.c |8 +++-- drivers/ata/libata-eh.c | 42

Re: [PATCH 04/12] libata: kill ata_id_to_dma_mode()

2007-12-01 Thread Jeff Garzik
Tejun Heo wrote: ata_id_to_dma_mode() isn't quite generic. The function is basically privately implemented ata_id_xfermask() combined with hardcoded mode printing and configuration which are specific to ata_generic. Kill the function and open code it in generic_set_mode() using generic

Re: Peculiar out-of-sync boot log lines

2007-12-01 Thread Randy Dunlap
On Sat, 1 Dec 2007 22:59:35 +0100 Bartlomiej Zolnierkiewicz wrote: Thanks for reporting/debugging it guys! Something in there needs to insert a '\n' before the skipping word message. Since it doesn't do that right now, the KERN_DEBUG string appears as 7 This seems like a good

Re: [PATCH 01/12] ata_generic: unindent loop in generic_set_mode()

2007-12-01 Thread Jeff Garzik
Tejun Heo wrote: Unindent loop body in generic_set_mode(). This is to ease future change. Signed-off-by: Tejun Heo [EMAIL PROTECTED] --- drivers/ata/ata_generic.c | 31 --- 1 files changed, 16 insertions(+), 15 deletions(-) applied 1-12 to #upstream, with

Re: SAS v SATA interface performance

2007-12-01 Thread Richard Scobie
Jeff Garzik wrote: Mark Lord wrote: SATA port multipliers (think, hub) permit multiple drives to be active simultaneously. Quite true, although the host controller could artificially limit this, giving the user a mistaken impression of their port multiplier being limited to

Re: SAS v SATA interface performance

2007-12-01 Thread Mark Lord
Richard Scobie wrote: Jeff Garzik wrote: Mark Lord wrote: SATA port multipliers (think, hub) permit multiple drives to be active simultaneously. Quite true, although the host controller could artificially limit this, giving the user a mistaken impression of their port multiplier being

Re: SAS v SATA interface performance

2007-12-01 Thread Mark Lord
Oh, more fiction: Because SATA uses point-to-point connectivity, the scaling available with SAS controllers is not possible with SATA controllers. SATA drives must be connected on a one-to-one basis with the SATA connectors on the controller – i.e, a fourport SATA controller can connect up to

Re: [PATCH 0/3] OF-platform PATA driver

2007-12-01 Thread Olof Johansson
On Sun, Dec 02, 2007 at 02:58:10AM +0300, Anton Vorontsov wrote: On Sat, Dec 01, 2007 at 05:54:49PM -0500, Jeff Garzik wrote: while (1) { send_patches(); if (ack_collected(PaulM) ack_collected(PowerPC_people)) break; sleep(wait_for_comments_timeout); --

Re: [PATCH 2/3] [libata] pata_of_platform: OF-Platform PATA device driver

2007-12-01 Thread Olof Johansson
On Tue, Nov 27, 2007 at 06:39:08PM +0300, Anton Vorontsov wrote: +static struct of_device_id pata_of_platform_match[] = { + { .compatible = pata-platform, }, +}; On top of previous comment about the compatible string being inappropriate: You should add a MODULE_DEVICE_TABLE() entry for