Re: Iomega ZIP-100 drive unsupported with jmicron JMB361 chip?

2007-12-17 Thread Andrew Morton
On Mon, 10 Dec 2007 15:09:43 -0500 trash can [EMAIL PROTECTED] wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 I have tolerated this problem for a year and do not post to this list in haste. I have posted on forums and searched the community over the past year. Your report is welcome

Re: ATA bus error with external hd on esata

2007-12-17 Thread Andrew Morton
On Sat, 15 Dec 2007 21:10:47 +0100 Zsolt Barat [EMAIL PROTECTED] wrote: Zsolt Barat schrieb: hi list, Let's cc the IDE development list. i just bought a MyBook called external HD with a fixed enclosure, from WD. Connected to the SATA port i constantly get ATA bus error messages in the

Re: CMD646 cdrom: drive appears confused drive not ready for command

2007-12-17 Thread Andrew Morton
On Mon, 17 Dec 2007 02:59:03 -0800 Andrew Morton [EMAIL PROTECTED] wrote: (added linux-ide) (Ths time for real) On Sun, 16 Dec 2007 20:36:04 +0200 (EET) Meelis Roos [EMAIL PROTECTED] wrote: I just noticed that all my recent test kernels on Sun Ultra 5 spam dmesg with hdc: drive not

sata_mv not working with a RocketRaid 2220

2007-12-17 Thread Jean-Louis Dupond
Added CC to linux-ide Originele bericht Onderwerp: sata_mv not working with a RocketRaid 2220 Datum: Mon, 17 Dec 2007 00:15:30 +0100 Van:Jean-Louis Dupond [EMAIL PROTECTED] Aan:[EMAIL PROTECTED] Hello, I'm trying to get my HighPoint RocketRaid Controller

Re: CMD646 cdrom: drive appears confused drive not ready for command

2007-12-17 Thread Meelis Roos
So when did thi start? Is 2.6.23 OK? I have 2.6.23 running now and will see if something happens. Are there any other consequences apart from log spam? Any CD communication seems to be impossible after this starts. Will retest when it happens again. -- Meelis Roos ([EMAIL PROTECTED]) -

Re: [PATCH 2/3] Add GD-Rom support to the SEGA Dreamcast

2007-12-17 Thread Adrian McMenamin
On Mon, December 17, 2007 2:06 pm, Jens Axboe wrote: On Sun, Dec 16 2007, Adrian McMenamin wrote: Few notes: Thanks for these, very helpful. - Compare rq_data_dir() with WRITE, don't just assume that any non-zero will be a write. - You need to offload this request handling to a

Re: ATA bus error with external hd on esata

2007-12-17 Thread Greg Freemyer
On Dec 17, 2007 5:53 AM, Andrew Morton [EMAIL PROTECTED] wrote: On Sat, 15 Dec 2007 21:10:47 +0100 Zsolt Barat [EMAIL PROTECTED] wrote: Zsolt Barat schrieb: hi list, Let's cc the IDE development list. i just bought a MyBook called external HD with a fixed enclosure, from WD.

Re: ATA bus error with external hd on esata

2007-12-17 Thread Jean-Louis Dupond
Greg Freemyer schreef: On Dec 17, 2007 5:53 AM, Andrew Morton [EMAIL PROTECTED] wrote: On Sat, 15 Dec 2007 21:10:47 +0100 Zsolt Barat [EMAIL PROTECTED] wrote: Zsolt Barat schrieb: hi list, Let's cc the IDE development list. i just bought a MyBook called

[PATCH] drivers/ide/: Spelling fixes

2007-12-17 Thread Joe Perches
Signed-off-by: Joe Perches [EMAIL PROTECTED] --- drivers/ide/pci/cs5535.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/ide/pci/cs5535.c b/drivers/ide/pci/cs5535.c index 9094916..ddcbeba 100644 --- a/drivers/ide/pci/cs5535.c +++ b/drivers/ide/pci/cs5535.c @@

[PATCH] drivers/ata/: Spelling fixes

2007-12-17 Thread Joe Perches
Signed-off-by: Joe Perches [EMAIL PROTECTED] --- drivers/ata/ata_piix.c|2 +- drivers/ata/libata-core.c |4 ++-- drivers/ata/pata_at32.c |2 +- drivers/ata/pata_efar.c |2 +- drivers/ata/pata_it8213.c |2 +- drivers/ata/pata_sis.c|4 ++-- 6 files changed, 8

Re: [PATCH] Fix build break caused by ide: remove ideprobe_init()

2007-12-17 Thread Bartlomiej Zolnierkiewicz
Hi, On Friday 14 December 2007, Olof Johansson wrote: Fix build break of powerpc holly_defconfig: Sorry for breaking the hol[l]y powerpc platform. ;) In file included from arch/powerpc/platforms/embedded6xx/holly.c:24: include/linux/ide.h:1206: error: 'CONFIG_IDE_MAX_HWIFS' undeclared here

Re: [PATCH] drivers/ide/: Spelling fixes

2007-12-17 Thread Bartlomiej Zolnierkiewicz
On Monday 17 December 2007, Joe Perches wrote: Signed-off-by: Joe Perches [EMAIL PROTECTED] applied - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH pata-2.6] hpt366: merge set_dma_mode() methods

2007-12-17 Thread Bartlomiej Zolnierkiewicz
On Friday 14 December 2007, Sergei Shtylyov wrote: Group the array of pointers to the timing tables with the timing register masks which allows us to merge HPT36x/HPT37x set_dma_mode() methods into one. Signed-off-by: Sergei Shtylyov [EMAIL PROTECTED] applied - To unsubscribe from this

[PATCH] libata-core: blacklist drives from using NCQ

2007-12-17 Thread David Milburn
Blacklist HITACHI HDS7225SCSUN250G* and SEAGATE STN7225SASUN250G* drives from using NCQ. Signed-off-by David Milburn [EMAIL PROTECTED] --- libata-core.c |2 ++ 1 files changed, 2 insertions(+) diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c index 597e07c..c117afa 100644

Re: sata_mv not working with a RocketRaid 2220

2007-12-17 Thread Mark Lord
Jean-Louis Dupond wrote: Added CC to linux-ide Originele bericht Onderwerp: sata_mv not working with a RocketRaid 2220 Datum: Mon, 17 Dec 2007 00:15:30 +0100 Van: Jean-Louis Dupond [EMAIL PROTECTED] Aan: [EMAIL PROTECTED] Hello, I'm trying to get my

Re: [PATCH] Fix build break caused by ide: remove ideprobe_init()

2007-12-17 Thread Olof Johansson
On Mon, Dec 17, 2007 at 09:53:31PM +0100, Bartlomiej Zolnierkiewicz wrote: Hi, applied but... --- On Sun, Nov 18, 2007 at 11:25:09PM +0100, Bartlomiej Zolnierkiewicz wrote: * Rename ide_device_add() to ide_device_add_all() and make it accept 'u8 idx[MAX_HWIFS]' instead

Re: [PATCH 2/3] Add GD-Rom support to the SEGA Dreamcast

2007-12-17 Thread Jan Engelhardt
On Dec 16 2007 18:50, Paul Mundt wrote: On Sun, Dec 16, 2007 at 12:21:21AM +, Adrian McMenamin wrote: +/* GD Rom registers */ +#define GDROM_BASE_REG 0xA05F7000 +#define GDROM_ALTSTATUS_REG GDROM_BASE_REG + 0x18 +#define GDROM_DATA_REG GDROM_BASE_REG + 0x80 +#define GDROM_ERROR_REG

Re: [PATCH] libata-core: blacklist drives from using NCQ

2007-12-17 Thread Alan Cox
On Mon, 17 Dec 2007 16:17:59 -0600 David Milburn [EMAIL PROTECTED] wrote: Blacklist HITACHI HDS7225SCSUN250G* and SEAGATE STN7225SASUN250G* drives from using NCQ. Signed-off-by David Milburn [EMAIL PROTECTED] Tejun fixed the bug causing the false reporting of NCQ errors so these blacklist

Re: [patch 3/9] libata: xfer_mask is unsigned int not unsigned long

2007-12-17 Thread Jeff Garzik
[EMAIL PROTECTED] wrote: From: Tejun Heo [EMAIL PROTECTED] xfer_mask is unsigned int not unsigned long. Change -mode_filter to take and return unsigned int. While at it, rename @adev of ata_pci_default_filter() to @dev for consistency. [EMAIL PROTECTED]: fix types] Signed-off-by: Tejun Heo

Re: [PATCH 01/10] libata-acpi: adjust constness in ata_acpi_gtm/stm() parameters

2007-12-17 Thread Jeff Garzik
Tejun Heo wrote: * No internal function uses const ata_port. Drop const from @ap. * Make ata_acpi_stm() copy @stm before using it and change @stm to const. Signed-off-by: Tejun Heo [EMAIL PROTECTED] --- drivers/ata/libata-acpi.c |7 --- include/linux/libata.h|4 ++-- 2

Re: [PATCH 01/10] libata-acpi: adjust constness in ata_acpi_gtm/stm() parameters

2007-12-17 Thread Jeff Garzik
Tejun Heo wrote: * No internal function uses const ata_port. Drop const from @ap. * Make ata_acpi_stm() copy @stm before using it and change @stm to const. for the record, I -would- use const ata_port where feasible; its just so rarely feasible, since members of that struct are often

Re: [PATCH #upstream-fixes] sata_sil: fix spurious IRQ handling

2007-12-17 Thread Jeff Garzik
Tejun Heo wrote: Interestingly, sata_sil raises spurious interrupts if it's coupled with Sil SATA_PATA bridge. Currently, sata_sil interrupt handler is strict about spurious interrupts and freezes the port when it occurs. This patch makes it more forgiving. * On SATA PHY event interrupt,

Re: [PATCH #upstream-fixes] libata: clear link-eh_info.serror from ata_std_postreset()

2007-12-17 Thread Jeff Garzik
Tejun Heo wrote: link-eh_info.serror is used to cache SError for controllers which need it cleared from interrupt handler to clear IRQ. It also should be cleared after reset just like SError itself. Make ata_std_postreset() clear link-eh_info.serror too and update sata_sil such that it doesn't

Re: [PATCH #upstream-fixes] libata: add ST3160023AS / 3.42 to NCQ blacklist

2007-12-17 Thread Jeff Garzik
Tejun Heo wrote: Like ST380817AS / 3.42, ST3160023AS / 3.42 times out commands if NCQ is used. Blacklist it. This is reported by Matheus Izvekov in the following thread. http://thread.gmane.org/gmane.linux.ide/24202 Signed-off-by: Tejun Heo [EMAIL PROTECTED] Cc: Matheus Izvekov [EMAIL

Re: [PATCH #upstream-fixes] libata: update atapi_eh_request_sense() such that lbam/lbah contains buffer size

2007-12-17 Thread Jeff Garzik
Tejun Heo wrote: While updating lbam/h for ATAPI commands, atapi_eh_request_sense() was left out. Update it. Signed-off-by: Tejun Heo [EMAIL PROTECTED] --- This patch is from improve-ATAPI-data-xfer patchset pending for #upstream. drivers/ata/libata-eh.c |4 ++-- 1 file changed, 2

Re: [PATCH #upstream-fixes] libata: fix ATAPI draining

2007-12-17 Thread Jeff Garzik
Tejun Heo wrote: With ATAPI transfer chunk size properly programmed, libata PIO HSM should be able to handle full spurious data chunks. Also, it's a good idea to suppress trailing data warning for misc ATAPI commands as there can be many of them per command - for example, if the chunk size is

Re: git repo and #upstream merging

2007-12-17 Thread Jeff Garzik
Tejun Heo wrote: Tejun Heo wrote: This is the second take of improve-ACPI-corner-case-handling patchset and contains the following ten patches. Jeff, this patchset can also be pulled from the following git tree. master.kernel.org:/pub/scm/linux/kernel/git/tj/libata-dev.git acpi-fixes

[git patches] libata fixes

2007-12-17 Thread Jeff Garzik
In 2.6.24, we turned on ACPI support in libata. This is needed in order to support suspend/resume and BIOS passworded drives, but it inevitably brought with it a host of new regressions -- which is what happens anytime you blindly accept ATA commands the BIOS has decided to toss your way. :)

Re: [patch 3/9] libata: xfer_mask is unsigned int not unsigned long

2007-12-17 Thread Andrew Morton
On Mon, 17 Dec 2007 20:30:33 -0500 Jeff Garzik [EMAIL PROTECTED] wrote: [EMAIL PROTECTED] wrote: From: Tejun Heo [EMAIL PROTECTED] xfer_mask is unsigned int not unsigned long. Change -mode_filter to take and return unsigned int. While at it, rename @adev of

Re: [patch 3/9] libata: xfer_mask is unsigned int not unsigned long

2007-12-17 Thread Jeff Garzik
Andrew Morton wrote: On Mon, 17 Dec 2007 20:30:33 -0500 Jeff Garzik [EMAIL PROTECTED] wrote: [EMAIL PROTECTED] wrote: From: Tejun Heo [EMAIL PROTECTED] xfer_mask is unsigned int not unsigned long. Change -mode_filter to take and return unsigned int. While at it, rename @adev of

[PATCH 2/5] libata: fix ata_acpi_gtm_xfermask()

2007-12-17 Thread Tejun Heo
ata_acpi_gtm_xfermask() as separated out from pacpi_discover_modes() has various bugs. Fix them. * The wrong comparison operator is used when finding for matching cycle resulting totally bogus result. * With the comparion operator fixed, boundary condtion handling is clumsy. * Setting of

[PATCH 1/5] libata: separate out ata_acpi_gtm_xfermask() from pacpi_discover_modes()

2007-12-17 Thread Tejun Heo
Finding out matching transfer mode from ACPI GTM values is useful for other purposes too. Separate out the function and timing tables from pata_acpi::pacpi_discover_modes(). Other than checking shared-configuration bit after doing ata_acpi_gtm() in pacpi_discover_modes() which should be safe,

[PATCH 3/5] libata: implement ata_timing_cycle2mode() and use it in libata-acpi and pata_acpi

2007-12-17 Thread Tejun Heo
libata-acpi is using separate timing tables for transfer modes although libata-core has the complete ata_timing table. Implement ata_timing_cycle2mode() to look for matching mode given transfer type and cycle duration and use it in libata-acpi and pata_acpi to replace private timing tables.

[PATCH 4/5] libata: reimplement ata_acpi_cbl_80wire() using ata_acpi_gtm_xfermask()

2007-12-17 Thread Tejun Heo
Reimplement ata_acpi_cbl_80wire() using ata_acpi_gtm_xfermask() and while at it relocate the function below ata_acpi_gtm_xfermask(). New ata_acpi_cbl_80wire() implementation takes @gtm, in both pata_via and pata_amd, use the initial GTM value. Both are trying to peek initial BIOS configuration,

[PATCH 5/5] pata_amd: update mode selection for NV PATAs

2007-12-17 Thread Tejun Heo
Cable detection on NV PATA hosts isn't implemented and the CBLID- cable isn't wired according to the sepc either, so both host-side and generic drive-side cable detections are broken. Till now, nv_cable_detect() relied on peeking BIOS and ACPI configurations to upgrade to 80C but this often

RE: Questions about SATA hotplug in linux 2.6

2007-12-17 Thread Shane Huang
Hi Jeff and Tejun: I want to continue this discussion with some questions: From: Tejun Heo wrote: Jeff Garzik wrote: Shane Huang wrote: 1. If users unplug one SATA HDD(no-root partition) or SATA ODD when the system is running, then plug it back to the same SATA port, Should the