Re: ide/arm/bast-ide.c compile error

2008-02-10 Thread Russell King
FYI, from maintainers: SIMTEC EB2410ITX (BAST) P: Ben Dooks P: Vincent Sanders M: [EMAIL PROTECTED] W: http://www.simtec.co.uk/products/EB2410ITX/ S: Supported On Sat, Feb 09, 2008 at 02:15:15AM +0200, Adrian Bunk wrote: Commit 9e016a719209d95338e314b46c3012cc7feaaeec

Re: Current git -- kaboom [bisect] seems IDE related.

2008-02-10 Thread Bartlomiej Zolnierkiewicz
On Sunday 10 February 2008, Christoph Hellwig wrote: On Sun, Feb 10, 2008 at 12:06:10AM +0100, Bartlomiej Zolnierkiewicz wrote: Please try booting with hdx=noflush kernel parameter or please try the attached patch which should fix the issue (if my theory is correct). hda=noflush

Re: Current git -- kaboom [bisect] seems IDE related.

2008-02-10 Thread James Bottomley
On Sun, 2008-02-10 at 14:38 +0100, Bartlomiej Zolnierkiewicz wrote: On Sunday 10 February 2008, Christoph Hellwig wrote: On Sun, Feb 10, 2008 at 12:06:10AM +0100, Bartlomiej Zolnierkiewicz wrote: Please try booting with hdx=noflush kernel parameter or please try the attached patch which

Re: Current git -- kaboom [bisect] seems IDE related.

2008-02-10 Thread Christoph Hellwig
On Sun, Feb 10, 2008 at 02:38:46PM +0100, Bartlomiej Zolnierkiewicz wrote: The OOPS is most likely (again) my fault - I was rushing out to push out the fix and memset() line didn't get converted. The new patch works fine for me. I prepared the new patch, documented it and started looking into

Re: Current git -- kaboom [bisect] seems IDE related.

2008-02-10 Thread Boaz Harrosh
On Sun, Feb 10 2008 at 16:43 +0200, Christoph Hellwig [EMAIL PROTECTED] wrote: On Sun, Feb 10, 2008 at 02:38:46PM +0100, Bartlomiej Zolnierkiewicz wrote: The OOPS is most likely (again) my fault - I was rushing out to push out the fix and memset() line didn't get converted. The new patch

Re: [PATCH 7/8] ide: add struct ide_port_info instances to legacy host drivers

2008-02-10 Thread Bartlomiej Zolnierkiewicz
On Sunday 10 February 2008, Atsushi Nemoto wrote: On Sun, 06 Jan 2008 18:03:10 +0100, Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] wrote: + /* reset DMA masks only for SFF-style DMA controllers */ + if ((d-host_flags IDE_HFLAG_NO_DMA) == 0 hwif-dma_base == 0) +

Re: [PATCH 7/8] ide: add struct ide_port_info instances to legacy host drivers

2008-02-10 Thread Atsushi Nemoto
On Sun, 06 Jan 2008 18:03:10 +0100, Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] wrote: + /* reset DMA masks only for SFF-style DMA controllers */ + if ((d-host_flags IDE_HFLAG_NO_DMA) == 0 hwif-dma_base == 0) + hwif-swdma_mask = hwif-mwdma_mask = hwif-ultra_mask = 0; It

Re: Current git -- kaboom [bisect] seems IDE related.

2008-02-10 Thread Bartlomiej Zolnierkiewicz
On Sunday 10 February 2008, James Bottomley wrote: On Sun, 2008-02-10 at 14:38 +0100, Bartlomiej Zolnierkiewicz wrote: On Sunday 10 February 2008, Christoph Hellwig wrote: On Sun, Feb 10, 2008 at 12:06:10AM +0100, Bartlomiej Zolnierkiewicz wrote: Please try booting with hdx=noflush

Re: [PATCH] ide: introduce CONFIG_BLK_DEV_IDEDMA_SFF option

2008-02-10 Thread Bartlomiej Zolnierkiewicz
On Saturday 09 February 2008, Sergei Shtylyov wrote: Introduce new option CONFIG_BLK_DEV_IDEDMA_SFF for non-PCI SFF-8038i compatible bus mastering IDE controllers (which there are a few known), thus fixing a hack made for Palmchip BK3710 controller... Signed-off-by: Sergei Shtylyov

Current qc_defer implementation may lead to infinite recursion

2008-02-10 Thread Elias Oltmanns
Hi Tejun, due to your commit 31cc23b34913bc173680bdc87af79e551bf8cc0d libata now sets max_host_blocked and max_device_blocked to 1 for all devices it manages. Under certain conditions this may lead to system lockups due to infinite recursion as I have explained to James on the scsi list (kept you

[PATCH 3/3] scsi: varlen extended and vendor-specific cdbs

2008-02-10 Thread Boaz Harrosh
Add support for variable-length, extended, and vendor specific CDBs to scsi-ml. It is now possible for initiators and ULD's to issue these types of commands. LLDs need not change much. All they need is to raise the .max_cmd_len to the longest command they support (see iscsi patches). - clean-up

[PATCH 2/3] block layer varlen-cdb

2008-02-10 Thread Boaz Harrosh
- add varlen_cdb and varlen_cdb_len to hold a large user cdb if needed. They start as empty. Allocation of buffer must be done by user and held until request execution is done. - Since there can be either a fix_length command up to 16 bytes or a variable_length, larger then 16 bytes,

[PATCHSET 0/3] varlen extended and vendor-specific cdbs

2008-02-10 Thread Boaz Harrosh
Submitted is a patchset for adding support for variable-length, extended, and vendor specific CDBs. It should now cover the entire range of the SCSI standard. (and/or any other use of command packets in block devices) They are based on scsi-misc. Difference from last time, is at struct request.

Subject: [PATCH 1/3] Let scsi_cmnd-cmnd use request-cmd buffer

2008-02-10 Thread Boaz Harrosh
- struct scsi_cmnd had a 16 bytes command buffer of its own. This is an unnecessary duplication and copy of request's cmd. It is probably left overs from the time that scsi_cmnd could function without a request attached. So clean that up. - Once above is done, few places, apart from

is there a value to CONFIG_NO_ATA_LEGACY?

2008-02-10 Thread Robert P. J. Day
in drivers/ata/libata-sff.c: ... #if defined(CONFIG_NO_ATA_LEGACY) /* Some platforms with PCI limits cannot address compat port space. In that case we punt if their firmware has left a device in compatibility mode */ if

Re: Current git -- kaboom [bisect] seems IDE related.

2008-02-10 Thread Sebastian Siewior
* Bartlomiej Zolnierkiewicz | 2008-02-10 19:32:06 [+0100]: Sebastian/Christoph, please test the final patch (after your ACK I'll push it to Linus together with the rest of pending IDE fixes). This seems to work. Sebastian - To unsubscribe from this list: send the line unsubscribe linux-ide in

[PATCH] libata: Forcing PIO0 mode on reset must not freeze system

2008-02-10 Thread Holger Macht
Calling ap-ops-set_piomode(ap, dev) on a device/controller which got already removed, locks the system hard. Reproducibly on an X60 attached to a dock station containing a cdrom device with doing $ echo 1 /sys/devices/platform/dock.0/undock echo 123 /dev/sr0 This calls ata_eh_reset(...)

Re: (fwd) Bug#11922: I/O error on blank tapes

2008-02-10 Thread Kai Makisara
On Tue, 5 Feb 2008, Kai Makisara wrote: On Mon, 4 Feb 2008, James Bottomley wrote: On Mon, 2008-02-04 at 22:28 +0100, Borislav Petkov wrote: On Mon, Feb 04, 2008 at 03:22:06PM +0100, maximilian attems wrote: (Added Bart to CC) hello borislav, ... This does still

RE: About forcing 32bit DMA patch for AMD690G(SB600)

2008-02-10 Thread Srihari Vijayaraghavan
Shane Huang [EMAIL PROTECTED] wrote: Dear Tejun: My 5 cents: Just order the board. These stock PC hardware are too cheap these days, it doesn't make any sense to try to debug somewhat difficult problem remotely if the hardware is available on the market. Even if you have to

[PATCH] sata_mv: platform driver allocs dma without create

2008-02-10 Thread Byron Bradley
When the sata_mv driver is used as a platform driver, mv_create_dma_pools() is never called so it fails when trying to alloc in mv_pool_start(). Signed-off-by: Byron Bradley [EMAIL PROTECTED] Acked-by: Mark Lord [EMAIL PROTECTED] --- Mark, based on the comment from Andrew Morton on the sata_mv:

Re: 2.6.26-git0: IDE oops during boot

2008-02-10 Thread Nish Aravamudan
On 2/7/08, Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] wrote: On Thursday 07 February 2008, Kamalesh Babulal wrote: Bartlomiej Zolnierkiewicz wrote: Hi, On Wednesday 06 February 2008, Pavel Machek wrote: On Wed 2008-02-06 11:53:34, Pavel Machek wrote: Hi! Trying to boot

Re: is there a value to CONFIG_NO_ATA_LEGACY?

2008-02-10 Thread Alan Cox
On Sun, 10 Feb 2008 14:44:16 -0500 (EST) Robert P. J. Day [EMAIL PROTECTED] wrote: in drivers/ata/libata-sff.c: ... #if defined(CONFIG_NO_ATA_LEGACY) /* Some platforms with PCI limits cannot address compat port space. In that case we punt if their

Re: is there a value to CONFIG_NO_ATA_LEGACY?

2008-02-10 Thread Robert P. J. Day
On Sun, 10 Feb 2008, Alan Cox wrote: On Sun, 10 Feb 2008 14:44:16 -0500 (EST) Robert P. J. Day [EMAIL PROTECTED] wrote: in drivers/ata/libata-sff.c: ... #if defined(CONFIG_NO_ATA_LEGACY) /* Some platforms with PCI limits cannot address compat

Re: [PATCH 7/8] ide: add struct ide_port_info instances to legacy host drivers

2008-02-10 Thread Bartlomiej Zolnierkiewicz
On Sunday 10 February 2008, Bartlomiej Zolnierkiewicz wrote: On Sunday 10 February 2008, Atsushi Nemoto wrote: On Sun, 06 Jan 2008 18:03:10 +0100, Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] wrote: + /* reset DMA masks only for SFF-style DMA controllers */ + if ((d-host_flags

[PATCH] ide: fix comment in init_irq()

2008-02-10 Thread Bartlomiej Zolnierkiewicz
APUS support is gone... Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-probe.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: b/drivers/ide/ide-probe.c === ---

Re: Current git -- kaboom [bisect] seems IDE related.

2008-02-10 Thread Bartlomiej Zolnierkiewicz
On Sunday 10 February 2008, Sebastian Siewior wrote: * Bartlomiej Zolnierkiewicz | 2008-02-10 19:32:06 [+0100]: Sebastian/Christoph, please test the final patch (after your ACK I'll push it to Linus together with the rest of pending IDE fixes). This seems to work. Thanks. - To unsubscribe

[PATCH] ide: remove stale comment from ide-lib.c

2008-02-10 Thread Bartlomiej Zolnierkiewicz
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-lib.c |9 - 1 file changed, 9 deletions(-) Index: b/drivers/ide/ide-lib.c === --- a/drivers/ide/ide-lib.c +++ b/drivers/ide/ide-lib.c @@

[git patches] IDE fixes

2008-02-10 Thread Bartlomiej Zolnierkiewicz
Hi, We merged _a_lot_ of IDE patches for 2.6.25 so no wonder that a few bugs showed up (yes, mostly brown paper ones of mine :). This update should put it under control again (there are two more open regression bugreports left and they are going to be addressed as soon as we have more data). -

[PATCH] Prevent IDE boot ops on NUMA system in mainline

2008-02-10 Thread Andi Kleen
Without this patch a Opteron test system here oopses at boot with currentg git. Calling to_pci_dev() on a NULL pointer gives a negative value so the following NULL pointer check never triggers and then an illegal address is referenced. Check the unadjusted original device pointer for NULL

Re: [PATCH] libata: Forcing PIO0 mode on reset must not freeze system

2008-02-10 Thread Tejun Heo
Hello, Holger Macht wrote: Calling ap-ops-set_piomode(ap, dev) on a device/controller which got already removed, locks the system hard. Reproducibly on an X60 attached to a dock station containing a cdrom device with doing $ echo 1 /sys/devices/platform/dock.0/undock echo 123 /dev/sr0

Re: [PATCH] scsi: ses fix mem leaking when fail to add intf

2008-02-10 Thread Yinghai Lu
On Sunday 10 February 2008 08:28:38 pm James Bottomley wrote: On Sat, 2008-02-09 at 15:15 -0800, Yinghai Lu wrote: [PATCH] scsi: ses fix mem leaking when fail to add intf fix leaking with scomp leaking when failing. also remove one extra space. There are still a few extraneous code

Re: [PATCH] scsi: ses fix mem leaking when fail to add intf

2008-02-10 Thread James Bottomley
On Sat, 2008-02-09 at 15:15 -0800, Yinghai Lu wrote: [PATCH] scsi: ses fix mem leaking when fail to add intf fix leaking with scomp leaking when failing. also remove one extra space. There are still a few extraneous code moves in this one. This is about the correct minimal set, isn't it?

Re: Current qc_defer implementation may lead to infinite recursion

2008-02-10 Thread Elias Oltmanns
Tejun Heo [EMAIL PROTECTED] wrote: Elias Oltmanns wrote: Hi Tejun, due to your commit 31cc23b34913bc173680bdc87af79e551bf8cc0d libata now sets max_host_blocked and max_device_blocked to 1 for all devices it manages. Under certain conditions this may lead to system lockups due to infinite

Re: 2.6.26-git0: IDE oops during boot

2008-02-10 Thread Kamalesh Babulal
Nish Aravamudan wrote: On 2/7/08, Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] wrote: On Thursday 07 February 2008, Kamalesh Babulal wrote: Bartlomiej Zolnierkiewicz wrote: Hi, On Wednesday 06 February 2008, Pavel Machek wrote: On Wed 2008-02-06 11:53:34, Pavel Machek wrote: Hi! Trying to

[SCSI] ses: fix memory leaks

2008-02-10 Thread Yinghai Lu
please check it... --- From: Yinghai Lu [EMAIL PROTECTED] [SCSI] ses: fix memory leaks fix leaking with scomp leaking when failing. Also free page10 on driver removal  and remove one extra space. Signed-off-by: Yinghai Lu [EMAIL PROTECTED] Signed-off-by: James Bottomley [EMAIL PROTECTED] ---

Re: Current qc_defer implementation may lead to infinite recursion

2008-02-10 Thread Tejun Heo
Elias Oltmanns wrote: Hi Tejun, due to your commit 31cc23b34913bc173680bdc87af79e551bf8cc0d libata now sets max_host_blocked and max_device_blocked to 1 for all devices it manages. Under certain conditions this may lead to system lockups due to infinite recursion as I have explained to