Re: new regression in 2.6.25-rc3: can't resume from suspend to ram, ata1 errors

2008-02-25 Thread Bartlomiej Zolnierkiewicz
On Monday 25 February 2008, Rafael J. Wysocki wrote: On Monday, 25 of February 2008, Michael S. Tsirkin wrote: On my T61p, 2.6.25-rc2 seems to wake up fine from suspend to ram. Not so 2.6.25-rc3: it hangs on suspend to ram, with a blank screen. Thanks for the report. At one point I got

Re: [Fixed PATCH] hpt366: fix section mismatch warnings

2008-02-24 Thread Bartlomiej Zolnierkiewicz
them __devinitconst would cause a section type conflict error when build for 64 bit powerpc. Signed-off-by: Sam Ravnborg [EMAIL PROTECTED] Cc: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Cc: Sergei Shtylyov [EMAIL PROTECTED] --- thanks, applied The first patch I posted caused a section

Re: [PATCH 00/10] IDE: Coding Style Fixes

2008-02-24 Thread Bartlomiej Zolnierkiewicz
On Saturday 23 February 2008, Paolo Ciarrocchi wrote: Hi Bartlomiej, The following 10 patches remove a huge number of errors and warnings reported by checkpatch.pl from the IDE subsystem. [...] Thanks! I applied everything (patch #8 with fixes based on comments from Adrian Cyrill + patches

Re: [PATCH 0/6] IDE: new series of Coding Style Fixes

2008-02-24 Thread Bartlomiej Zolnierkiewicz
On Saturday 23 February 2008, Paolo Ciarrocchi wrote: Bart, here is a new series of patches that remove some errors and warnings reported by checkpatch.pl from the IDE subsystem. All the patches have been compile tested and are against this morning (CET time :-) linux-next Paolo

Re: [git patches] libata fixes

2008-02-24 Thread Bartlomiej Zolnierkiewicz
On Sunday 24 February 2008, Jeff Garzik wrote: [...] Alan Cox (1): pata_atiixp: Use 255 sector limit AHCI needs sorting too but this deals with the old interface Signed-off-by: Alan Cox [EMAIL PROTECTED] Signed-off-by: Jeff Garzik [EMAIL PROTECTED] [...] diff --git

Re: [git patches] libata fixes

2008-02-24 Thread Bartlomiej Zolnierkiewicz
On Sunday 24 February 2008, Alan Cox wrote: From the patch description it can't be told whether the patch itself is correct and only the patch description is bogus... zero length PRD misparsing. If I remember rightly old IDE never generates 64K PRD slots because other hardware can't handle

Re: IDE cdrom problem with PLEXTOR DVDR PX-608AL

2008-02-24 Thread Bartlomiej Zolnierkiewicz
On Sunday 24 February 2008, Borislav Petkov wrote: On Sun, Feb 24, 2008 at 03:38:34PM +1000, Brad Rosser wrote: [...] kernel: hda: cdrom_pc_intr: The drive appears confused (ireason = 0x01). Trying to recover by ending request. last message repeated 3 times kernel: ide: failed opcode

[PATCH] qd65xx: fix setup of QD6580 Control register

2008-02-23 Thread Bartlomiej Zolnierkiewicz
Control register of QD6580 should be setup before probing for devices. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- goes after ide: skip probing port if hdx=noprobe was used for both devices on it patch in the IDE quilt tree drivers/ide/legacy/qd65xx.c |6 ++ 1 file

[PATCH 1/2] qd65xx: always use -selectproc method

2008-02-23 Thread Bartlomiej Zolnierkiewicz
qd_select() checks itself whether timings should be reprogrammed so remove superfluous qd_timing_ok() and always use -selectproc method (rename qd_select() to qd65xx_select() while at it). Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/legacy/qd65xx.c | 37

[PATCH 2/2] qd65xx: use IDE_HFLAG_SINGLE host flag

2008-02-23 Thread Bartlomiej Zolnierkiewicz
) and remove no longer needed QD_CONTROL() macro. * Cache QD65xx base address in hwif-config_data (bits 8-15) instead of hwif-select_data. * Set hwif-config_data in qd_probe() and remove qd_setup() helper. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/legacy/qd65xx.c

[PATCH 1/4] it821x: fix kzalloc() failure handling

2008-02-23 Thread Bartlomiej Zolnierkiewicz
Allocate 'struct it821x_dev' objects for both ports in it821x_init_one(). Fixes potential OOPS in it821x_quirkproc() (uses 'itdev' unconditionally) and other problems ('itdev' is needed for correct operation of the driver). Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers

[PATCH 2/4] sis5513: fail early for unsupported chipsets

2008-02-23 Thread Bartlomiej Zolnierkiewicz
. * Remove no longer need -ultra_mask setting from init_hwif_sis5513(). Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/pci/sis5513.c | 27 +++ 1 file changed, 15 insertions(+), 12 deletions(-) Index: b/drivers/ide/pci/sis5513.c

[PATCH 3/4] ide: sanitize handling of IDE_HFLAG_NO_SET_MODE host flag

2008-02-23 Thread Bartlomiej Zolnierkiewicz
(). This is a part of preparations for adding 'struct ide_port_ops'. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-dma.c |3 --- drivers/ide/ide-io.c |4 drivers/ide/ide-lib.c | 12 ++-- drivers/ide/ide.c |4 +++- 4 files changed, 13 insertions

Re: 2.6.25-rc2 + smartd = hang

2008-02-23 Thread Bartlomiej Zolnierkiewicz
Hi, On Saturday 23 February 2008, Anders Eriksson wrote: [EMAIL PROTECTED] said: But at this point libata is working much better than the old IDE stuff, and it really is worth moving things over if you can. Ok, I'll take a stab at that tomorrow. Two things... Having switched to

Re: [PATCH] hpt366: fix section mismatch warnings

2008-02-22 Thread Bartlomiej Zolnierkiewicz
On Friday 22 February 2008, Sergei Shtylyov wrote: Sam Ravnborg wrote: hpt366: fix section mismatch warnings Fix following warnings: WARNING: o-sparc64/vmlinux.o(.data+0x195a38): Section mismatch in reference from the variable hpt37x_info.0 to the variable .devinit.data:hpt370

[PATCH] qd65xx: remove commented out code

2008-02-22 Thread Bartlomiej Zolnierkiewicz
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/legacy/qd65xx.c | 37 - 1 file changed, 37 deletions(-) Index: b/drivers/ide/legacy/qd65xx.c === --- a/drivers/ide

[PATCH] ide: remove stale comments from ide-dma.c

2008-02-22 Thread Bartlomiej Zolnierkiewicz
- ide-dma.c is not a separate module - ide-dma.c is not PCI specific anymore - DMA is enabled by default nowadays - link for Intel Zappa BIOS is dead etc. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-dma.c | 48

[PATCH] ide: remove ide-tape documentation from Documentation/ide.txt

2008-02-22 Thread Bartlomiej Zolnierkiewicz
More complete documentation is available in Documentation/ide/ide-tape.txt. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- Documentation/ide.txt | 47 --- 1 file changed, 47 deletions(-) Index: b/Documentation/ide.txt

[PATCH] ide: remove redundant comment from ide_unregister()

2008-02-22 Thread Bartlomiej Zolnierkiewicz
Identical comment is present in ide_hwif_release_regions() documentation. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- goes after hpt366: fix section mismatch warnings patch in IDE quilt tree drivers/ide/ide.c |5 - 1 file changed, 5 deletions(-) Index: b/drivers/ide

[PATCH] ide: skip probing port if hdx=noprobe was used for both devices on it

2008-02-22 Thread Bartlomiej Zolnierkiewicz
* Skip probing port if hdx=noprobe parameter was used for both devices on it. * Obsolete idex=noprobe parameter - it only works for ide_generic, cmd640 and PCI hosts in Compatibility mode (on alpha/x86/ia64/m32r/mips/ppc32). Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- goes

[PATCH] ide: remove obsoleted idex=noprobe kernel parameter

2008-02-22 Thread Bartlomiej Zolnierkiewicz
* Remove obsoleted idex=noprobe kernel parameter. * Remove no longer needed hwif-noprobe quirk from ide_hwif_configure() and hwif-noprobe checking from cmd640.c. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- goes before ide: move default IDE ports setup to ide_generic host

Re: [PATCH] ide: remove stale comments from ide-dma.c

2008-02-22 Thread Bartlomiej Zolnierkiewicz
On Friday 22 February 2008, Mark Lord wrote: Bartlomiej Zolnierkiewicz wrote: - ide-dma.c is not a separate module - ide-dma.c is not PCI specific anymore - DMA is enabled by default nowadays - link for Intel Zappa BIOS is dead etc. Signed-off-by: Bartlomiej

Re: [BUG] next-20080219 - ide oops while bootup at ide_device_add_all ()

2008-02-20 Thread Bartlomiej Zolnierkiewicz
Hi, On Wednesday 20 February 2008, Kamalesh Babulal wrote: Hi, The next-20080219 kernel oops while booting up on x86_64 box. This bug was fixed in the 2.6.24-git(s) with the patch posted at http://lkml.org/lkml/2008/2/11/350 ide0 at 0x1f0-0x1f7,0x3f6 on irq 14 BUG: unable to handle

Re: [PATCH] ide-generic: Fix no initalization of idx in some case

2008-02-20 Thread Bartlomiej Zolnierkiewicz
Soden [EMAIL PROTECTED] CC: Sergei Shtylyov [EMAIL PROTECTED] Thanks! I integrated it with the original patch to preserve bisectability: From: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Subject: [PATCH] ide-generic: use ide_find_port() (take 3) There should be no functional changes caused

Re: [PATCH] falconide: fix resources reservation

2008-02-20 Thread Bartlomiej Zolnierkiewicz
On Wednesday 20 February 2008, Geert Uytterhoeven wrote: On Wed, 20 Feb 2008, Bartlomiej Zolnierkiewicz wrote: * Tell IDE layer to not manage resources by setting hwif-mmio flag and request resources in falconide_init(). * Use request_mem_region() for resources reservation. * Use

[PATCH 1/2] ide: fix enabling DMA on it821x in smart mode

2008-02-20 Thread Bartlomiej Zolnierkiewicz
ide_tune_dma() should return '1' if IDE_HFLAG_NO_SET_MODE host flag is set. Cc: Sergei Shtylyov [EMAIL PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- I wonder how this could have slipped in :( Sergei, please double-check this patch. Thanks! drivers/ide/ide-dma.c

[PATCH 2/2] ide: remove IDE_HFLAG_CY82C693 host flag

2008-02-20 Thread Bartlomiej Zolnierkiewicz
Sergei suggested that it shouldn't be necessary + it had no effect anyway since ide_id_dma_bug() is called earlier in ide_tune_dma(). Cc: Sergei Shtylyov [EMAIL PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- I went ahead since I urgently needed to re-cycle one host flag

[PATCH] ide: remove hwif-straight8 flag

2008-02-20 Thread Bartlomiej Zolnierkiewicz
All host drivers now either set hwif-mmio or reserve continuous I/O resources so remove no longer needed hwif-straight8 flag and never reached code for 'hwif-straight8 == 0' case. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide.c | 36

Re: Optiarc DVD RW AD-5200A audio playing

2008-02-19 Thread Bartlomiej Zolnierkiewicz
On Tuesday 19 February 2008, Borislav Petkov wrote: [...] Author: Borislav Petkov [EMAIL PROTECTED] Date: Sat Feb 16 09:56:36 2008 +0100 ide-cd: Enable audio play quirk for Optiarc DVD RW AD-5200A drive Reported-by: Stefan Bader [EMAIL PROTECTED] Signed-off-by:

Re: [PATCH] ide-cd: remove the internal 64k buffer

2008-02-19 Thread Bartlomiej Zolnierkiewicz
Hi, On Tuesday 19 February 2008, Borislav Petkov wrote: Hi Bart, here's one more item from my TODO list. The removal is straight forward, after testing it with all my cdrom drives they all seem even to rotate quieter due to the automatic speed adjustment of the drive to the continuous

Re: [PATCH 4/5] ide-generic: use ide_find_port()

2008-02-19 Thread Bartlomiej Zolnierkiewicz
On Tuesday 19 February 2008, Sergei Shtylyov wrote: Bartlomiej Zolnierkiewicz wrote: There should be no functional changes caused by this patch. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] Index: b/drivers/ide/ide-generic.c

Re: [PATCH 03/12] ide: add ide-4drives host driver

2008-02-19 Thread Bartlomiej Zolnierkiewicz
On Tuesday 19 February 2008, Sergei Shtylyov wrote: Bartlomiej Zolnierkiewicz wrote: CONFIG_BLK_DEV_4DRIVES deserves its own host driver: * Add drivers/ide/legacy/ide-4drives.c and move 4drives support there. * Add ide-4drives.o in the link order after all other legacy host

[PATCH] ide_platform: fix resources handling

2008-02-19 Thread Bartlomiej Zolnierkiewicz
Tell IDE layer to not manage resources by always setting hwif-mmio flag (resources are handled by a platform device). Cc: Anton Vorontsov [EMAIL PROTECTED] Cc: Vitaly Bordug [EMAIL PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/legacy/ide_platform.c |5

[PATCH] delkin_cb: fix resources handling

2008-02-19 Thread Bartlomiej Zolnierkiewicz
Tell IDE layer to not manage resources by setting hwif-mmio flag. Cc: Mark Lord [EMAIL PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/pci/delkin_cb.c |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) Index: b/drivers/ide/pci/delkin_cb.c

[PATCH] bast-ide: fix resources reservation

2008-02-19 Thread Bartlomiej Zolnierkiewicz
* Tell IDE layer to not manage resources by setting hwif-mmio flag and request resources in bastide_init(). * Use request_mem_region() for resources reservation. * Use driver name for resources reservation. Cc: Ben Dooks [EMAIL PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL

[PATCH 2/2] ide-mpc8xx: fix resources reservation

2008-02-19 Thread Bartlomiej Zolnierkiewicz
* Tell IDE layer to not manage resources by setting hwif-mmio flag and request resources in m8xx_ide_init_ports(). * Use request_mem_region() for resources reservation. * Use driver name for resources reservation. Cc: Vitaly Bordug [EMAIL PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz

[PATCH] falconide: fix resources reservation

2008-02-19 Thread Bartlomiej Zolnierkiewicz
] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/legacy/falconide.c |7 +++ 1 file changed, 7 insertions(+) Index: b/drivers/ide/legacy/falconide.c === --- a/drivers/ide/legacy/falconide.c +++ b/drivers

Re: [PATCH 1/5] ide: remove PIO downgrade quirk

2008-02-18 Thread Bartlomiej Zolnierkiewicz
Hi Sergei, On Feb 18, 2008 5:06 PM, Sergei Shtylyov [EMAIL PROTECTED] wrote: Bartlomiej Zolnierkiewicz wrote: No need for it nowadays Since which moment, could you elaborate We fixed: - PIO auto-tuning in core code - PIO programming in host drivers - IORDY handling in core code

Re: [PATCH] next-20080218 build failure at pmac_ide_macio_attach ()

2008-02-18 Thread Bartlomiej Zolnierkiewicz
to preserve bisectability. From: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Subject: [PATCH] ide-pmac: dynamically allocate struct pmac_ide_hwif instances (take 2) * Dynamically allocate struct pmac_ide_hwif instances in pmac_ide_macio_attach() and pmac_ide_pci_attach(), then remove no longer

Re: Optiarc DVD RW AD-5200A audio playing

2008-02-18 Thread Bartlomiej Zolnierkiewicz
On Monday 18 February 2008, Stefan Bader wrote: Borislav Petkov wrote: On Sat, Feb 16, 2008 at 04:24:01PM +0100, Bartlomiej Zolnierkiewicz wrote: Hi, On Saturday 16 February 2008, Borislav Petkov wrote: On Fri, Feb 15, 2008 at 02:53:27PM -0500, Stefan Bader wrote: Hello Borislav

Re: [PATCH ht6560b] Force prefetch for some devices

2008-02-18 Thread Bartlomiej Zolnierkiewicz
On Monday 18 February 2008, Jan Evert van Grootheest wrote: Prefetch needs to be set for some ide devices to work when connected to a ht6560b interface. This was not always done properly, causing a system with a HD and CD on the primary interface to not work properly. Or, in effect, hang hard.

Re: [PATCH] ht6560b can only do up to PIO mode 4

2008-02-18 Thread Bartlomiej Zolnierkiewicz
[EMAIL PROTECTED] Subject: [PATCH] ht6560b can only do up to PIO mode 4 According to the datasheet, ht6560b only supports up to PIO mode 4. [bart: manually ported it over 2.6.25-rc2] Signed-off-by: Jan Evert van Grootheest [EMAIL PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL

[git patches] IDE fixes

2008-02-18 Thread Bartlomiej Zolnierkiewicz
+ include/linux/Kbuild |2 +- include/linux/hdsmart.h|4 ++-- include/linux/pci_ids.h|1 + 12 files changed, 34 insertions(+), 21 deletions(-) Andrew Smith (1): via82cxxx: add new PCI id for cx700 Bartlomiej Zolnierkiewicz (2): falconide: locking

[PATCH] falconide: locking bugfix

2008-02-17 Thread Bartlomiej Zolnierkiewicz
] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-generic.c |6 -- drivers/ide/legacy/falconide.c |2 ++ 2 files changed, 2 insertions(+), 6 deletions(-) Index: b/drivers/ide/ide-generic.c

Re: PROBLEM: Corruption problems in pata_via for Via NanoBook owners (Cloudbook, EasyNote XS etc.)

2008-02-17 Thread Bartlomiej Zolnierkiewicz
] Subject: [PATCH] via82cxxx: add new PCI id for cx700 [bart: manually ported it over via82cxxx changes] From: Andrew Smith [EMAIL PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/pci/via82cxxx.c |1 + include/linux/pci_ids.h |1 + 2 files changed, 2

Re: [PATCH 03/12] ide: add ide-4drives host driver

2008-02-17 Thread Bartlomiej Zolnierkiewicz
On Saturday 16 February 2008, Randy Dunlap wrote: [...] +You also need to use probe kernel paramater for ide-4drives driver parameter thanks, fixed in take 2 - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message

Re: [PATCH 1/4] : More use DIV_ROUND_UP

2008-02-17 Thread Bartlomiej Zolnierkiewicz
On Saturday 16 February 2008, Julia Lawall wrote: From: Julia Lawall [EMAIL PROTECTED] The kernel.h macro DIV_ROUND_UP performs the computation (((n) + (d) - 1) / (d)) but is perhaps more readable. An extract of the semantic patch that makes this change is as follows:

[PATCH 1/5] ide: remove PIO downgrade quirk

2008-02-17 Thread Bartlomiej Zolnierkiewicz
No need for it nowadays so remove quirk code from ide_get_best_pio_mode() and IDE_HFLAG_PIO_DOWNGRADE host flag. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-lib.c | 10 -- drivers/ide/pci/amd74xx.c |1 - drivers/ide/pci/via82cxxx.c |1

[PATCH 2/5] ide: merge ide_match_hwif() and ide_find_port()

2008-02-17 Thread Bartlomiej Zolnierkiewicz
(). There should be no functional changes caused by this patch. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-probe.c | 46 ++ drivers/ide/ide.c | 15 --- drivers/ide/setup-pci.c | 48

[PATCH 5/5] ide: unexport ide_hwifs[]

2008-02-17 Thread Bartlomiej Zolnierkiewicz
All modular users have been fixed to not reference ide_hwifs[] directly. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide.c |5 - 1 file changed, 5 deletions(-) Index: b/drivers/ide/ide.c

[PATCH 3/5] ide: use ide_find_port() in legacy VLB host drivers

2008-02-17 Thread Bartlomiej Zolnierkiewicz
in qd65xx host driver to not use hwif-name. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-probe.c |4 +- drivers/ide/legacy/ali14xx.c | 19 --- drivers/ide/legacy/dtc2278.c | 22 +++-- drivers/ide/legacy/ht6560b.c | 31

[PATCH 4/5] ide-generic: use ide_find_port()

2008-02-17 Thread Bartlomiej Zolnierkiewicz
There should be no functional changes caused by this patch. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-generic.c | 17 + 1 file changed, 13 insertions(+), 4 deletions(-) Index: b/drivers/ide/ide-generic.c

[PATCH 4/4] ide-disk: fix issues found by checkpatch.pl

2008-02-17 Thread Bartlomiej Zolnierkiewicz
There are no changes to the resulting drivers/ide/ide-disk.o binary file (md5sum-s after and before the patch match). Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-disk.c | 120 - 1 file changed, 70 insertions

[PATCH 2/4] ide-disk: add missing printk() KERN_* levels

2008-02-17 Thread Bartlomiej Zolnierkiewicz
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-disk.c |5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) Index: b/drivers/ide/ide-disk.c === --- a/drivers/ide/ide-disk.c +++ b/drivers/ide

[PATCH 3/4] ide-disk: add proc_idedisk_read_smart() helper

2008-02-17 Thread Bartlomiej Zolnierkiewicz
caused by this patch. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-disk.c | 39 +-- 1 file changed, 17 insertions(+), 22 deletions(-) Index: b/drivers/ide/ide-disk.c

[PATCH 1/4] ide: fix sparse warning about shadowing 'flags' symbol

2008-02-17 Thread Bartlomiej Zolnierkiewicz
drivers/ide/ide.c:801:18: warning: symbol 'flags' shadows an earlier one drivers/ide/ide.c:732:16: originally declared here Also fix some whitespace damage while at it. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide.c | 13 + 1 file changed, 5

Re: [PATCH] MAINTAINERS: update ide-cd maintainer's email address

2008-02-16 Thread Bartlomiej Zolnierkiewicz
On Saturday 16 February 2008, Borislav Petkov wrote: commit c65b97fdbb9f3075a37f711aa6b388a48a27d3f4 Author: Borislav Petkov [EMAIL PROTECTED] Date: Sat Feb 16 09:10:46 2008 +0100 MAINTAINERS: update ide-cd maintainer's email address Signed-off-by: Borislav Petkov [EMAIL

[PATCH 09/12] ide: move default IDE ports setup to ide_generic host driver

2008-02-16 Thread Bartlomiej Zolnierkiewicz
CONFIG_IDE_ARCH_OBSOLETE_DEFAULTS. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/Kconfig |4 +--- drivers/ide/ide-generic.c | 16 +--- drivers/ide/ide.c | 18 -- 3 files changed, 14 insertions(+), 24 deletions(-) Index: b/drivers

[PATCH 10/12] ide: remove ide_init_default_irq() macro

2008-02-16 Thread Bartlomiej Zolnierkiewicz
* Use ide_default_irq() instead of ide_init_default_irq() in ide_generic host driver (so the correct IRQ is always set regardless of CONFIG_PCI / CONFIG_BLK_DEV_IDEPCI). * Remove no longer needed ide_init_default_irq() macro. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED

[PATCH 11/12] ide: cleanup ide_match_hwif()

2008-02-16 Thread Bartlomiej Zolnierkiewicz
* Remove no longer needed matching against I/O base and 'io_base' argument. * Move printk() to the caller and remove 'name' argument. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/setup-pci.c | 47 +++ 1 file changed, 15

[PATCH 12/12] ide: cleanup ide_find_port()

2008-02-16 Thread Bartlomiej Zolnierkiewicz
Remove no longer needed matching against I/O base and 'base' argument. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/arm/bast-ide.c|2 +- drivers/ide/arm/icside.c |2 +- drivers/ide/arm/ide_arm.c |2 +- drivers/ide/arm/palm_bk3710

[PATCH 06/12] ide: limit legacy VLB host drivers to alpha, x86 and mips

2008-02-16 Thread Bartlomiej Zolnierkiewicz
as BROKEN) [ the common sense tells me that VLB was only used on x86 but there are urban legends that one of these host drivers was needed on some other arch - thus the extra care ] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/Kconfig |2 +- 1 file changed, 1

[PATCH 03/12] ide: add ide-4drives host driver

2008-02-16 Thread Bartlomiej Zolnierkiewicz
probe itself for IDE devices instead of indirectly depending on ide_generic host driver. * Add probe module parameter to ide-4drives and update documentation. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- Documentation/ide.txt|5 ++-- drivers/ide/Kconfig

[PATCH 04/12] cmd640: cleanup setup_device_ptrs()

2008-02-16 Thread Bartlomiej Zolnierkiewicz
This loop is no longer needed. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/pci/cmd640.c | 14 ++ 1 file changed, 2 insertions(+), 12 deletions(-) Index: b/drivers/ide/pci/cmd640.c

[PATCH 07/12] ide: init hwif-{io_ports,irq} explicitly in legacy VLB host drivers

2008-02-16 Thread Bartlomiej Zolnierkiewicz
to be explicitly enabled with probe parameter. ] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/legacy/ali14xx.c | 12 drivers/ide/legacy/dtc2278.c | 12 drivers/ide/legacy/ht6560b.c | 12 drivers/ide/legacy/ide-4drives.c

Re: [BUID_FAILURE] next-20080215 Build failure caused by ide: rework PowerMac media-bay support

2008-02-16 Thread Bartlomiej Zolnierkiewicz
On Friday 15 February 2008, Kamalesh Babulal wrote: The linux-next-20080215 kernel build fails on the powerpc with following error CC arch/powerpc/platforms/powermac/setup.o In file included from arch/powerpc/platforms/powermac/setup.c:66: include/asm/mediabay.h:29: error: syntax

[PATCH 01/12] ide: remove ide_default_io_ctl() macro

2008-02-16 Thread Bartlomiej Zolnierkiewicz
It is always == '((base) + 0x206)' if CONFIG_IDE_ARCH_OBSOLETE_DEFAULTS=y and it is not needed otherwise (arm, blackfin, parisc, ppc64, sh, sparc[64]). Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide.c |2 +- include/asm-alpha/ide.h

[PATCH 05/12] cmd640: init hwif-{io_ports,irq} explicitly

2008-02-16 Thread Bartlomiej Zolnierkiewicz
Do explicit port setup instead of depending on init_ide_data(). This way hwif-io_ports[] and hwif-irq are always correctly set regardless of CONFIG_PCI / CONFIG_BLK_DEV_IDEPCI. [ Remember to not break idex=noprobe parameter. ] While at it fix printk(). Signed-off-by: Bartlomiej Zolnierkiewicz

[PATCH 02/12] ide: remove ppc ifdef from init_ide_data()

2008-02-16 Thread Bartlomiej Zolnierkiewicz
On PPC32 ide_init_default_irq() is non-zero only for PPLUS and PPC_PREP (the latter marked as BROKEN currently) so this ifdef can be removed. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide.c |2 -- 1 file changed, 2 deletions(-) Index: b/drivers/ide/ide.c

Re: IDE cdrom problem

2008-02-16 Thread Bartlomiej Zolnierkiewicz
On Saturday 16 February 2008, Borislav Petkov wrote: On Sat, Feb 16, 2008 at 04:24:46PM +0100, Bartlomiej Zolnierkiewicz wrote: [ added Borislav (ide-cd maintainer) to cc: ] Hi, Unless there are some very important reasons to keep the discussion private please always cc: linux

Re: Optiarc DVD RW AD-5200A audio playing

2008-02-16 Thread Bartlomiej Zolnierkiewicz
On Saturday 16 February 2008, Borislav Petkov wrote: On Sat, Feb 16, 2008 at 04:24:01PM +0100, Bartlomiej Zolnierkiewicz wrote: Hi, On Saturday 16 February 2008, Borislav Petkov wrote: On Fri, Feb 15, 2008 at 02:53:27PM -0500, Stefan Bader wrote: Hello Borislav, I worked

Re: Optiarc DVD RW AD-5200A audio playing

2008-02-16 Thread Bartlomiej Zolnierkiewicz
On Saturday 16 February 2008, Borislav Petkov wrote: On Sat, Feb 16, 2008 at 06:48:24PM +0100, Bartlomiej Zolnierkiewicz wrote: On Saturday 16 February 2008, Borislav Petkov wrote: On Sat, Feb 16, 2008 at 04:24:01PM +0100, Bartlomiej Zolnierkiewicz wrote: Hi, On Saturday 16

Re: [PATCH 5/13] cy82c693: add -set_dma_mode method

2008-02-16 Thread Bartlomiej Zolnierkiewicz
[ Sorry for the late reply. ] On Friday 04 January 2008, Sergei Shtylyov wrote: Bartlomiej Zolnierkiewicz wrote: * Fix SWDMA/MWDMA masks in cy82c693_chipset. * Add IDE_HFLAG_CY82C693 host flag and use it in ide_tune_dma() to check whether the DMA should be enabled even

[PATCH 2/2] ide-pmac: use ide_find_port()

2008-02-16 Thread Bartlomiej Zolnierkiewicz
Cc: Benjamin Herrenschmidt [EMAIL PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ppc/pmac.c | 44 +++- 1 file changed, 19 insertions(+), 25 deletions(-) Index: b/drivers/ide/ppc/pmac.c

[PATCH 1/2] ide-pmac: dynamically allocate struct pmac_ide_hwif instances

2008-02-16 Thread Bartlomiej Zolnierkiewicz
Dynamically allocate struct pmac_ide_hwif instances in pmac_ide_macio_attach() and pmac_ide_pci_attach(), then remove no longer needed pmac_ide[]. Cc: Benjamin Herrenschmidt [EMAIL PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ppc/pmac.c | 49

Re: Optiarc DVD RW AD-5200A audio playing

2008-02-16 Thread Bartlomiej Zolnierkiewicz
On Saturday 16 February 2008, Borislav Petkov wrote: On Sat, Feb 16, 2008 at 07:23:58PM +0100, Bartlomiej Zolnierkiewicz wrote: On Saturday 16 February 2008, Borislav Petkov wrote: On Sat, Feb 16, 2008 at 06:48:24PM +0100, Bartlomiej Zolnierkiewicz wrote: On Saturday 16 February 2008

[PATCH 6/9] umc8672: don't use ide_hwifs[] in umc_set_pio_mode()

2008-02-16 Thread Bartlomiej Zolnierkiewicz
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/legacy/umc8672.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Index: b/drivers/ide/legacy/umc8672.c === --- a/drivers/ide/legacy/umc8672.c

[PATCH 5/9] scc_pata: store 'hwif' pointer in struct scc_ports

2008-02-16 Thread Bartlomiej Zolnierkiewicz
Replace 'unsigned char hwif_id' by 'ide_hwif_t *hwif' in struct scc_ports. This allows us to remove ide_hwifs[] usage from scc_remove(). There should be no functional changes caused by this patch. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/pci/scc_pata.c |6

[PATCH 4/9] cmd640: use ide_find_port()

2008-02-16 Thread Bartlomiej Zolnierkiewicz
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/pci/cmd640.c | 30 ++ 1 file changed, 18 insertions(+), 12 deletions(-) Index: b/drivers/ide/pci/cmd640.c === --- a/drivers/ide

[PATCH 8/9] qd65xx: return error value in qd_probe()

2008-02-16 Thread Bartlomiej Zolnierkiewicz
Return error value in qd_probe() and use it in qd65xx_init() instead of checking ide_hwifs[].chipset. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/legacy/qd65xx.c | 25 +++-- 1 file changed, 15 insertions(+), 10 deletions(-) Index: b/drivers

[PATCH 7/9] ht6560b: use driver name for resource allocation

2008-02-16 Thread Bartlomiej Zolnierkiewicz
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/legacy/ht6560b.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) Index: b/drivers/ide/legacy/ht6560b.c === --- a/drivers/ide/legacy/ht6560b.c

[PATCH 1/9] sgiioc4: use ide_find_port()

2008-02-16 Thread Bartlomiej Zolnierkiewicz
There should be no functional changes caused by this patch. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/pci/sgiioc4.c | 12 ++-- 1 file changed, 2 insertions(+), 10 deletions(-) Index: b/drivers/ide/pci/sgiioc4.c

[PATCH 9/9] ide: IDE_HFLAG_BOOTABLE - IDE_HFLAG_NON_BOOTABLE

2008-02-16 Thread Bartlomiej Zolnierkiewicz
bootable should be the default behavior so replace IDE_HFLAG_BOOTABLE host flag with IDE_HFLAG_NON_BOOTABLE. There should be no functional changes caused by this patch. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/pci/aec62xx.c |3 ++- drivers/ide/pci

[PATCH 2/9] au1xxx-ide: use ide_find_port()

2008-02-16 Thread Bartlomiej Zolnierkiewicz
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/mips/au1xxx-ide.c |8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) Index: b/drivers/ide/mips/au1xxx-ide.c === --- a/drivers/ide/mips/au1xxx

[PATCH 3/9] cmd640: remove cmd_drives[]

2008-02-16 Thread Bartlomiej Zolnierkiewicz
* Pass 'ide_drive_t *drive' to check_prefetch(), set_prefetch_mode(), program_drive_counts() and cmd640_set_mode(). * Remove no longer needed cmd_drives[]. * Inline setup_device_ptrs() helper in cmd640x_init(). Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/pci

mount: could not find filesystem - aacraid? (was: Re: 2.6.26-git0: IDE oops during boot)

2008-02-14 Thread Bartlomiej Zolnierkiewicz
Hi, On Thursday 14 February 2008, Kamalesh Babulal wrote: Bartlomiej Zolnierkiewicz wrote: Hi, On Tuesday 12 February 2008, Kamalesh Babulal wrote: Bartlomiej Zolnierkiewicz wrote: Hi, On Monday 11 February 2008, Kamalesh Babulal wrote: Nish Aravamudan wrote: On 2/7/08

Re: mount: could not find filesystem - aacraid? (was: Re: 2.6.26-git0: IDE oops during boot)

2008-02-14 Thread Bartlomiej Zolnierkiewicz
On Thursday 14 February 2008, Bartlomiej Zolnierkiewicz wrote: Hi, On Thursday 14 February 2008, Kamalesh Babulal wrote: Bartlomiej Zolnierkiewicz wrote: Hi, On Tuesday 12 February 2008, Kamalesh Babulal wrote: Bartlomiej Zolnierkiewicz wrote: Hi, On Monday 11

Re: IDE cdrom problem with PLEXTOR DVDR PX-608AL

2008-02-14 Thread Bartlomiej Zolnierkiewicz
On Thursday 14 February 2008, Borislav Petkov wrote: On Thu, Feb 14, 2008 at 12:37:50AM +0100, Hans-Peter Jansen wrote: [Added Bart to CC] Am Dienstag, 12. Februar 2008 schrieb Borislav Petkov: On Tue, Feb 12, 2008 at 10:26:17AM +0100, Hans-Peter Jansen wrote: Hi, I suffer

Re: [discuss] pci_get_device_reverse(), why does Calgary need this?

2008-02-14 Thread Bartlomiej Zolnierkiewicz
On Thursday 14 February 2008, Andreas Jaeger wrote: Greg KH [EMAIL PROTECTED] writes: How does the patch below look? I didn't want to remove the whole config option, as there is more to the logic than just the reverse order stuff there. I think you miss Documentation - it's mentioned

Re: [PATCH] ide-floppy: merge callbacks

2008-02-14 Thread Bartlomiej Zolnierkiewicz
On Thursday 14 February 2008, Borislav Petkov wrote: On Wed, Feb 13, 2008 at 11:04:23PM +0100, Bartlomiej Zolnierkiewicz wrote: On Wednesday 13 February 2008, Borislav Petkov wrote: commit d1f1f84f413ab00cb2fec48170d022fcd900e214 Author: Borislav Petkov [EMAIL PROTECTED] Date: Wed

[PATCH 2/2] ide: remove CONFIG_IDE_ARCH_OBSOLETE_INIT

2008-02-14 Thread Bartlomiej Zolnierkiewicz
* Use CONFIG_IDE_ARCH_OBSOLETE_DEFAULTS instead of CONFIG_IDE_ARCH_OBSOLETE_INIT in init_ide_data(). * Remove no longer needed CONFIG_IDE_ARCH_OBSOLETE_INIT. There should be no functional changes caused by this patch. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide

[PATCH 1/2] ide: add CONFIG_IDE_ARCH_OBSOLETE_DEFAULTS

2008-02-14 Thread Bartlomiej Zolnierkiewicz
Add CONFIG_IDE_ARCH_OBSOLETE_DEFAULTS to drivers/ide/Kconfig and use it instead of defining IDE_ARCH_OBSOLETE_DEFAULTS in arch/ide.h. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/Kconfig |3 +++ drivers/ide/ide.c |5

Re: [PATCH 1/2] ide: add CONFIG_IDE_ARCH_OBSOLETE_DEFAULTS

2008-02-14 Thread Bartlomiej Zolnierkiewicz
Hi, On Thursday 14 February 2008, Sam Ravnborg wrote: Hi Bart. On Thu, Feb 14, 2008 at 09:55:50PM +0100, Bartlomiej Zolnierkiewicz wrote: Add CONFIG_IDE_ARCH_OBSOLETE_DEFAULTS to drivers/ide/Kconfig and use it instead of defining IDE_ARCH_OBSOLETE_DEFAULTS in arch/ide.h. Signed-off

Re: [PATCH 09/18] ide: rework PowerMac media-bay support

2008-02-13 Thread Bartlomiej Zolnierkiewicz
Hi, On Wednesday 13 February 2008, Michael Ellerman wrote: On Fri, 2008-02-08 at 01:45 +0100, Bartlomiej Zolnierkiewicz wrote: Rework PowerMac media-bay support in such way that instead of un/registering the IDE interface we un/register IDE devices: * Add ide_port_scan() helper

Re: pci_get_device_reverse(), why does Calgary need this?

2008-02-13 Thread Bartlomiej Zolnierkiewicz
On Wednesday 13 February 2008, Greg KH wrote: On Wed, Feb 13, 2008 at 02:17:37AM +, Alan Cox wrote: Why does the calgary driver need this? Can we just use pci_get_device() instead? Why do you need to walk the device list backwards? Do you get false positives going forward? It

Re: [RFC PATCH] ide-floppy: use rq-cmd for preparing and sending packet cmds to the drive

2008-02-13 Thread Bartlomiej Zolnierkiewicz
Hi, On Wednesday 13 February 2008, Borislav Petkov wrote: On Tue, Feb 12, 2008 at 10:39:22PM +0100, Bartlomiej Zolnierkiewicz wrote: Hi Bart, I think that this _really_ should be done _after_ unifying ATAPI handling [*]. Otherwise you will be making some of the same changes

Re: [PATCH 1/2] ide: use generic ATAPI packet command flags in ide-{floppy,tape,scsi}

2008-02-13 Thread Bartlomiej Zolnierkiewicz
On Feb 13, 2008 5:18 PM, Borislav Petkov [EMAIL PROTECTED] wrote: This is done in one single patch in order not to cause git breakage. Signed-off-by: Borislav Petkov [EMAIL PROTECTED] Looks good but could you please reorder patches and move PC_* - PC_FLAG * rename in ide-scsi to the patch

Re: [PATCH 1/2] ide: use generic ATAPI packet command flags in ide-{floppy,tape}

2008-02-13 Thread Bartlomiej Zolnierkiewicz
On Wednesday 13 February 2008, Borislav Petkov wrote: Signed-off-by: Borislav Petkov [EMAIL PROTECTED] applied - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/2] ide-scsi: do non-atomic pc-flags testing

2008-02-13 Thread Bartlomiej Zolnierkiewicz
On Wednesday 13 February 2008, Borislav Petkov wrote: ...also, convert ide-scsi to using the generic pc-flags defines. Signed-off-by: Borislav Petkov [EMAIL PROTECTED] applied - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED]

Re: [PATCH] ide-floppy: merge callbacks

2008-02-13 Thread Bartlomiej Zolnierkiewicz
On Wednesday 13 February 2008, Borislav Petkov wrote: commit d1f1f84f413ab00cb2fec48170d022fcd900e214 Author: Borislav Petkov [EMAIL PROTECTED] Date: Wed Feb 13 20:26:56 2008 +0100 ide-floppy: merge callbacks The appropriate functionality of the callback is established

  1   2   3   4   5   6   7   8   9   10   >