[PATCH 9/15] ide: factor out code removing port from hwgroup from ide_unregister()

Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide.c | 65 +- 1 file changed, 36 insertions(+), 29 deletions(-) Index: b/drivers/ide/ide.c

[PATCH 8/15] ide: I/O resources are released too early in ide_unregister()

Release I/O resources after releasing DMA. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) Index: b/drivers/ide/ide.c

[PATCH 4/15] ide_platform: remove struct hwif_prop

]_mapbase in plat_ide_probe() and remove no longer needed struct hwif_prop. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- -150 bytes drivers/ide/legacy/ide_platform.c | 34 -- 1 file changed, 8 insertions(+), 26 deletions(-) Index: b/drivers/ide

[PATCH 2/15] ide: move wait_hwif_ready() documentation in the right place

* Move wait_hwif_ready() documentation before this function. * Fix trailing whitespaces. * s/wait-for-busy/wait-for-non-busy/ * Remove no longer valid comment about the current code behavior. * Docbook-ize it. * Rename wait_hwif_ready() to ide_port_wait_ready(). Signed-off-by: Bartlomiej

[PATCH 1/15] ide: fix handling of busy I/O resources in probe_hwif()

It could be that I/O resources are busy because some other host driver has already claimed them so don't unregister the devices. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- -94 bytes drivers/ide/ide-probe.c | 13 + 1 file changed, 1 insertion(+), 12 deletions

[PATCH 3/15] ide: remove hwif-present manipulations from hwif_init()

* Call hwif_init() only if hwif-present is set. * If hwif_init() fails clear hwif-present. * Remove hwif-present manipulations from hwif_init(). Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- -24 bytes drivers/ide/ide-probe.c | 18 ++ 1 file changed, 6

[PATCH 5/15] ide: remove unused ide_hwgroup_t fields

Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- include/linux/ide.h | 14 +++--- 1 file changed, 3 insertions(+), 11 deletions(-) Index: b/include/linux/ide.h === --- a/include/linux/ide.h +++ b/include

[PATCH 6/15] ide: remove needless zeroing of hwgroup fields from init_irq()

Since kmalloc_node() is called with __GFP_ZERO flag there is no need to explicitly zero hwgroup fields. While at it: * Use 'hwif' instead of 'hwif-drives[0].hwif' for kmalloc_node() call. * Fix whitespace damage. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- -27 bytes drivers

[PATCH 7/15] ide: cleanup ide_system_bus_speed()

ide_system_bus_speed() in system_bus_clock(). Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- -39 bytes drivers/ide/ide.c | 28 +++- 1 file changed, 11 insertions(+), 17 deletions(-) Index: b/drivers/ide/ide.c

[PATCH 11/15] ide: use ide_remove_port_from_hwgroup in init_irq()

There should be no functionality changes caused by this patch. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- -77 bytes drivers/ide/ide-probe.c | 18 +- drivers/ide/ide.c |2 +- include/linux/ide.h |1 + 3 files changed, 3 insertions(+), 18

[PATCH 12/15] ide: make probe_hwif() return an error value

Make probe_hwif() return an error value. While at it: * Remove comment about MAX_DRIVES == 2 limitation (it is not special to probe_hwif(), it is a general assumption taken by a lot of IDE code). * Rename probe_hwif() to ide_probe_port(). Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL

[PATCH 14/15] ide: factor out code for tuning devices from ide_probe_port()

* Factor out code for tuning devices from ide_probe_port() to ide_port_tune_devices(). * Move ide_port_tune_devices() call from ide_probe_port() to ide_device_add_all(). There should be no functionality changes caused by this patch. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED

[PATCH 15/15] ide: move hwif_register() call out of ide_probe_port()

) - port reset (if hwif-reset is set) - restoring local IRQs state and re-enabling port IRQ While at it: * Rename hwif_register() to ide_register_port(). Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- +17 bytes drivers/ide/ide-probe.c | 27 +-- 1 file

Re: [RESEND PATCH 02/10] ide-floppy: move ide-floppy struct and macro defs into its own header. While at it

Hi, Hmm, contrary to ide-cd.c case there doesn't seem to be a need currently for moving code out of ide-floppy.c (and this patch series doesn't change that). Besides it would be better to just remove some structs like it has been done with i.e. struct atapi_capabilities_page in ide-cd.c case

Re: [RESEND PATCH 01/10] move ide-floppy historical changelog to Documentation/ide/ChangeLog.ide-floppy.1996-2002;

On Thursday 03 January 2008, Borislav Petkov wrote: Signed-off-by: Borislav Petkov [EMAIL PROTECTED] applied with two minor fixes (and sorry for being such a pedant ;): * Summary line moved to patch description and ide-floppy: cleanup header used instead. Please try to keep summary line

Re: [RESEND PATCH 0/10] ide-floppy redux p1

Hi, On Thursday 03 January 2008, Borislav Petkov wrote: Hi Bart, here's the unfinished redux of ide-floppy which i'm REsending now so that we could sinchronize trees. The original send got busted in vger's filters due to syntax error in the Message-ID tag.

Re: [RESEND PATCH 03/10] ide-floppy: convert to generic packet commands

On Thursday 03 January 2008, Borislav Petkov wrote: Replace the ide-floppy packet commands opcode defines with the generic ones. Add a missing GPCMD_WRITE_12 (opcode 0xaa) to the generic ones in cdrom.h. The last one can be found in the current version of INF-8090, p.905. CC: Jens Axboe

Re: [RESEND PATCH 04/10] ide-floppy: cleanup debugging macros

On Thursday 03 January 2008, Borislav Petkov wrote: There should be no functional change resulting from this patch. the patch is fine but the description is a bit inaccurate: * some debug_log() calls were not using ide-floppy: prefix * a few used printk levels different than KERN_INFO

Re: [RESEND PATCH 10/10] ide-floppy: replace ntoh{s,l} and hton{s,l} calls with the generic byteorder macros

On Thursday 03 January 2008, Borislav Petkov wrote: Signed-off-by: Borislav Petkov [EMAIL PROTECTED] minor thing: WARNING: line over 80 characters #88: FILE: drivers/ide/ide-floppy.c:759: + put_unaligned(cpu_to_be16(blocks), (unsigned short *) pc-c[7]); seems like it can be

Re: [RESEND PATCH 07/10] ide-floppy: remove unnecessary -handler != NULL check

On Thursday 03 January 2008, Borislav Petkov wrote: This BUG_ON is unneeded since the -handler != NULL check is performed in ide_set_handler(). Signed-off-by: Borislav Petkov [EMAIL PROTECTED] looks good, please move it at the beginning of the patch series - To unsubscribe from this list:

Re: [PATCH] pata_pdc202xx_old: Further fixups

On Friday 04 January 2008, Alan Cox wrote: Turns out distros always enabled burst mode and it is pretty essential so Yeah and datasheet confirms that so burst mode config option should die (now if somebody could hit me with a patch)... Bart - To unsubscribe from this list: send the line

Re: [PATCH 1/3] ide: use MODULE_VERSION()

On Wednesday 02 January 2008, Matt Domsch wrote: On Tue, Jan 01, 2008 at 09:32:36PM -0500, Jon Masters wrote: On Tue, 2008-01-01 at 19:33 +0100, Bartlomiej Zolnierkiewicz wrote: On the second thought: maybe we will be better off with limiting MODULE_VERSION() to the device drivers

[PATCH] ide: delete filenames/versions from comments

-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- a replacement patch for ide: delete filenames from comments one drivers/ide/arm/bast-ide.c |3 +-- drivers/ide/arm/icside.c |2 -- drivers/ide/arm/rapide.c |2 -- drivers/ide/cris/ide-cris.c|3 +-- drivers/ide

Re: [PATCH 1/2] trm290: cannot call ide_setup_dma()

On Sunday 30 December 2007, Sergei Shtylyov wrote: The TRM-290 chip is *not* SFF-8038i compatible and therefore can *not* call ide_setup_dma() -- fix this and also cleanup the code a bit... Signed-off-by: Sergei Shtylyov [EMAIL PROTECTED] applied - To unsubscribe from this list: send the

Re: [PATCH 2/2] ide_setup_dma() assumes 8 ports

On Sunday 30 December 2007, Sergei Shtylyov wrote: According to http://marc.info/?l=linux-idem=114346138611631, the drivers must always register 8 DMA ports with ide_setup_dma(), so its last argument is not needed. While at it, kill some useless parens in that function... Signed-off-by:

[PATCH 1/3] ide: use MODULE_VERSION()

/drivers/ide/pci/it821x.c Version 0.16Jul 3 2007 + * linux/drivers/ide/pci/it821x.c * * Copyright (C) 2004 Red Hat [EMAIL PROTECTED] * Copyright (C) 2007 Bartlomiej Zolnierkiewicz @@ -73,6 +73,8 @@ #include asm/io.h +#define DRV_VERSION0.16 + struct

[PATCH 3/3] ide: update/add my Copyrights

The last years stuff and a trip down memory lane... Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-cd.c |8 drivers/ide/ide-disk.c |9 + drivers/ide/ide-dma.c |7 +++ drivers/ide/ide-floppy.c |5 +++-- drivers

[PATCH 2/3] ide: delete filenames from comments

Delete filenames from comments. While at it: * Delete versions from comments in ide-dma.c, ide-iops.c, ide-probe.c, ide-proc.c, ide-taskfile.c, and setup-pci.c (all these files are a part of IDE core module), and also ide-timing.h. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED

Re: [PATCH 1/3] ide: use MODULE_VERSION()

On Tuesday 01 January 2008, Adrian Bunk wrote: On Tue, Jan 01, 2008 at 06:40:38PM +0100, Bartlomiej Zolnierkiewicz wrote: * Replace driver versions in comments by DRV_VERSION define. * Add MODULE_VERSION(DRV_VERSION) to drivers defining DRV_VERSION. ... Could you limit

Re: [PATCH 3/3] ide: add IDE_HFLAG_NO_DSC host flag

On Saturday 29 December 2007, Sergei Shtylyov wrote: Bartlomiej Zolnierkiewicz wrote: * Add IDE_HFLAG_NO_DSC host flag for hosts that doesn't support DSC overlap. * Set it in aec62xx (for ATP850UF only) and hpt34x host drivers. * Convert ide-tape device driver to check

[PATCH 1/3] au1xxx-ide: device tree bugfix

Add missing hw.dev setup (so hwif-gendev.parent will be set by ide_init_port_hw() to point to the parent device). Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/mips/au1xxx-ide.c |1 + 1 file changed, 1 insertion(+) Index: b/drivers/ide/mips/au1xxx-ide.c

Re: [PATCH 1/9] piix: remove stale comments

On Friday 28 December 2007, Sergei Shtylyov wrote: Hello. Bartlomiej Zolnierkiewicz wrote: Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] Index: b/drivers/ide/pci/piix.c

[PATCH 2/3] ide-pmac: macio resource freeing bugfix

Release DMA resource before zeroing pmif. Cc: Benjamin Herrenschmidt [EMAIL PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ppc/pmac.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) Index: b/drivers/ide/ppc/pmac.c

[PATCH 3/3] au1xxx-ide/rapide: use hwif-index for ide_unregister()

Cc: Russell King [EMAIL PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/arm/rapide.c |4 ++-- drivers/ide/mips/au1xxx-ide.c |2 +- 2 files changed, 3 insertions(+), 3 deletions(-) Index: b/drivers/ide/arm/rapide.c

Re: [PATCH] ide-cd: move the remaining cdrom.c ioctl handling code to ide-cd_ioctl.c

On Wednesday 26 December 2007, Borislav Petkov wrote: On Wed, Dec 26, 2007 at 09:50:14PM +0100, Borislav Petkov wrote: Actually you should drop the previous one for it wasn't incomplete. Here's, hopefully, a better one :). -- From: Borislav Petkov [EMAIL PROTECTED] There should be no

Re: [PATCH] trm290: do hook dma_host_{on,off} methods (take 2)

On Thursday 27 December 2007, Sergei Shtylyov wrote: Using default methods caused the chip's DMA PRD count registers, inadvertently starting DMA! While fixing it, also do: nasty, this could possibly explain the following trm290.c hack: ... #if 0 /* play it safe for now */

[PATCH 1/3] amd74xx: remove amd_ide_chips table

-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- -305 bytes drivers/ide/pci/amd74xx.c | 275 -- 1 file changed, 124 insertions(+), 151 deletions(-) Index: b/drivers/ide/pci/amd74xx.c

[PATCH 2/3] ide: add IDE_HFLAG_CLEAR_SIMPLEX host flag

Device IDs was used by some other vendor for PCI IDE controller). Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/pci/alim15x3.c|7 ++- drivers/ide/pci/amd74xx.c |1 drivers/ide/pci/cmd64x.c |4 +- drivers/ide/pci/generic.c |3 + drivers

[PATCH 3/3] ide: add IDE_HFLAG_NO_DSC host flag

* Add IDE_HFLAG_NO_DSC host flag for hosts that doesn't support DSC overlap. * Set it in aec62xx (for ATP850UF only) and hpt34x host drivers. * Convert ide-tape device driver to check for IDE_HFLAG_NO_DSC flag. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide

[PATCH 9/9] ide: use ide_build_sglist() and ide_destroy_dmatable() in non-PCI host drivers

by this patch. Cc: Russell King [EMAIL PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/arm/icside.c | 21 ++--- drivers/ide/ide-dma.c |4 +++- drivers/ide/mips/au1xxx-ide.c | 28 +++- include/linux/ide.h

[PATCH 8/9] ide: switch to DMA-mapping API

] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- It seems like blackfin arch should be using asm-generic/pci-dma-compat.h in asm-blackfin/pci.h or drivers still using PCI DMA-mapping API instead of the generic one won't work but I'll leave this to blackfin gurus... [ Bryan, could you

[PATCH 2/9] ide: fix ide_intr() for non-PCI devices and CONFIG_BLK_DEV_IDEPCI=y

'hwif-pci_dev !hwif-pci_dev-vendor' condition is never true, check for 'hwif-chipset != ide_pci' instead. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-io.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: b/drivers/ide/ide-io.c

[PATCH 0/9] ide: switch to generic DMA-mapping API

Make IDE core PCI independent by replacing hwif-pci_dev (struct pci_dev *) with hwif-dev (struct device *) and switch to using generic DMA-mapping API. This is on top of IDE quilt tree + 3 patches posted today. diffstat: drivers/ide/arm/icside.c | 52

[PATCH 1/9] piix: remove stale comments

Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/pci/piix.c | 47 +-- 1 file changed, 1 insertion(+), 46 deletions(-) Index: b/drivers/ide/pci/piix.c

[PATCH 3/9] ide: remove BUG_ON() from ide_build_sglist()

do_rw_taskfile() has been fixed to check the return value of -dma_setup method so this BUG_ON() is no longer needed. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-dma.c |2 -- 1 file changed, 2 deletions(-) Index: b/drivers/ide/ide-dma.c

[PATCH 4/9] ide: use ide_destroy_dmatable() instead of pci_unmap_sg()

Use ide_destroy_dmatable() in: * ide-dma.c::ide_build_dmatable() * sgiioc4.c::sgiioc4_build_dma_table() * pmac.c::pmac_ide_{build,destroy}_dmatable() There should be no functionality changes caused by this patch. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide

[PATCH 6/9] au1xxx-ide: use hwif-dev

* Setup hwif-dev in au_ide_probe(). * Use hwif-dev instead of ahwif-dev in auide_build_sglist(), auide_build_dmatable(), auide_dma_end() and auide_ddma_init(). * Remove no longer needed 'dev' field from _auide_hwif type. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers

[PATCH 7/9] icside: use hwif-dev

* Setup hwif-dev in icside_setup(). * Use hwif-dev instead of state-dev in icside_build_sglist(), icside_dma_end(), icside_dma_start() and icside_dma_setup(). * Remove no longer needed 'dev' field from struct icside_state. Cc: Russell King [EMAIL PROTECTED] Signed-off-by: Bartlomiej

[PATCH] cmd64x: fix hwif-chipset setup

are identical except for 'name' field). Fix it and bump driver version. Cc: Sergei Shtylyov [EMAIL PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/pci/cmd64x.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Index: b/drivers/ide/pci/cmd64x.c

[git patches] IDE fixes

(-) Bartlomiej Zolnierkiewicz (10): ide-cd: fix SAMSUNG CD-ROM SCR-3231 quirk ide-cd: fix ACER/AOpen 24X CDROM speed reporting on big-endian machines ide-cd: use ide_cd_release() in ide_cd_probe() ide-cd: fix error messages in cdrom_{read,write}_check_ireason() ide-cd: add

Re: [git patches] IDE fixes

[ added Linus to Cc: ] On Monday 24 December 2007, Bartlomiej Zolnierkiewicz wrote: cmd64x regression bugfix, few obvious ide-cd fixes from the redux patch peries and ide-cd MAINTAINERS entry update (Borislav, welcome on board!). Oh yes, I would forget... Merry Christmas! Well, I

[PATCH 1/2] ide: add ide_dump_identify() debug helper

* Add ide_dump_identify() debug helper for dumping raw identify data in the hdparm friendly format (== the identify data can be extracted from dmesg output and passed to hdparm --Istdin). * Dump identify data in ide-probe.c::do_identify() if DEBUG is enabled. Signed-off-by: Bartlomiej

[PATCH 2/2] ide-{floppy,tape}: remove debug code for dumping identify data

IDE core supports dumping raw identify data in hdparm friendly format now so verbose identify dumping in ide-{floppy,tape}.c device drivers (done iff IDE{FLOPPY,TAPE}_DEBUG_INFO is defined to '1' and it is '0' by default) is no longer nedeed. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL

Re: [PATCH 00/63] ide-cd: redux

On Sunday 23 December 2007, Borislav Petkov wrote: On Fri, Dec 21, 2007 at 08:57:49PM +0100, Bartlomiej Zolnierkiewicz wrote: On Thursday 20 December 2007, Borislav Petkov wrote: On Thu, Dec 20, 2007 at 01:48:49AM +0100, Bartlomiej Zolnierkiewicz wrote: Hi Bart, Hi all, PS ide

Re: [PATCH 00/63] ide-cd: redux

On Thursday 20 December 2007, Borislav Petkov wrote: On Thu, Dec 20, 2007 at 01:48:49AM +0100, Bartlomiej Zolnierkiewicz wrote: Hi Bart, Hi all, PS ide-cd Maintainer position is still open... i'd like to take that position if nobody objects. I've done some work around the kernel here

Re: [PATCH 00/63] ide-cd: redux

On Thursday 20 December 2007, Phillip Susi wrote: Bartlomiej Zolnierkiewicz wrote: Hi, This patch series is a major rework of the ide-cd driver. Hi, in the future could you please post big patchbombs like this as replies to the first one so they fold nicely into one thread? IIRC

[PATCH 00/63] ide-cd: redux

Hi, This patch series is a major rework of the ide-cd driver. The motivations behind it are twofold: * ide-cd is still in use but because it has been out of luck for maintainers lately the code become quite hard to debug and maintain - this puts it back into the shape * aid efforts of

[PATCH 02/63] ide-cd: fix ACER/AOpen 24X CDROM speed reporting on big-endian machines

* Fix ACER/AOpen 24X CDROM speed reporting on big-endian machines by adding missing le16_to_cpu() calls. While at it: * Replace ntohs() by be16_to_cpu(). Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-cd.c |8 1 file changed, 4 insertions(+), 4

[PATCH 01/63] ide-cd: fix SAMSUNG CD-ROM SCR-3231 quirk

cdi-mask is cleared by ide_cdrom_register() which is called after the quirk. Fix it by adding new -no_speed_select flag to struct ide_cd_config_flags and using it in ide_cdrom_register() to set CDC_SELECT_SPEED flag. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide

[PATCH 03/63] ide-cd: use ide_cd_release() in ide_cd_probe()

Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- -164 bytes drivers/ide/ide-cd.c |9 + 1 file changed, 1 insertion(+), 8 deletions(-) Index: b/drivers/ide/ide-cd.c === --- a/drivers/ide/ide-cd.c +++ b/drivers

[PATCH 04/63] ide-cd: fix error messages in cdrom_{read,write}_check_ireason()

Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-cd.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) Index: b/drivers/ide/ide-cd.c === --- a/drivers/ide/ide-cd.c +++ b/drivers

[PATCH 08/63] ide-cd: fix error message in cdrom_pc_intr()

Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-cd.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: b/drivers/ide/ide-cd.c === --- a/drivers/ide/ide-cd.c +++ b/drivers/ide/ide-cd.c

[PATCH 10/63] ide-cd: use xfer_func_t in cdrom_pc_intr()

Unify writing and reading handling in cdrom_pc_intr() using xfer_func_t. There should be no functionality changes caused by this patch. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-cd.c | 47 +-- 1 file changed, 17

[PATCH 09/63] ide-cd: fix 'ireason' reporting in cdrom_pc_intr()

Mask 'ireason' variable so only the valid interrupt reason bits will be reported on drive appears confused error. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-cd.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) Index: b/drivers/ide/ide-cd.c

[PATCH 13/63] ide-cd: fix DMA error handling in cdrom_newpc_intr()

Make cdrom_newpc_intr() match cdrom_{read,write}_intr() w.r.t. handling DMA errors: * disable DMA before cdrom_decode_status() call * log the device name and the type of the request (read/write) Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-cd.c | 10

[PATCH 15/63] ide-cd: move historical changelog to Documentation/ide/ChangeLog.ide-cd.1994-2004

Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- Documentation/ide/ChangeLog.ide-cd.1994-2004 | 268 ++ drivers/ide/ide-cd.c | 274 --- 2 files changed, 272 insertions(+), 270 deletions(-) Index: b

[PATCH 16/63] ide-cd: remove stale cdrom_transfer_packet_command() comment

Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-cd.c |4 1 file changed, 4 deletions(-) Index: b/drivers/ide/ide-cd.c === --- a/drivers/ide/ide-cd.c +++ b/drivers/ide/ide-cd.c @@ -684,10

[PATCH 18/63] ide-cd: remove dead code from cdrom_pc_intr()

Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-cd.c |7 --- 1 file changed, 7 deletions(-) Index: b/drivers/ide/ide-cd.c === --- a/drivers/ide/ide-cd.c +++ b/drivers/ide/ide-cd.c @@ -1201,13

[PATCH 19/63] ide-cd: remove unused struct atapi_cdrom_subchnl

Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-cd.h | 32 1 file changed, 32 deletions(-) Index: b/drivers/ide/ide-cd.h === --- a/drivers/ide/ide-cd.h +++ b/drivers

[PATCH 12/63] ide-cd: fix missing data handling in cdrom_pc_intr()

If drive still wants to transfer the data we need to pad the transfer instead of just finishing the request. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-cd.c |7 --- 1 file changed, 4 insertions(+), 3 deletions(-) Index: b/drivers/ide/ide-cd.c

[PATCH 20/63] ide-cd: remove needless zeroing of 'info' fields from ide_cdrom_setup()

ide_cd_probe() zeroes 'info' prior to calling ide_cdrom_setup() so there is no need to explicitly zero 'info' fields in the latter function. Ditto for fields of CDROM_STATE_FLAGS(), CDROM_CONFIG_FLAGS() and 'cdi' (all are embedded in 'info'). Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL

[PATCH 21/63] ide-cd: remove unused and write-only struct ide_cd_config_flags fields

unused fields: * -writing * -reserved write-only fields: * -playmsf_as_bcd * -subchan_as_bcd * -test_write * -supp_disc_present Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- -120 bytes drivers/ide/ide-cd.c | 18 ++ drivers/ide/ide-cd.h |7 --- 2 files

[PATCH 22/63] ide-cd: remove struct atapi_{mechstat_header,changer_info,slot}

* Remove -changer_info from struct cdrom_info (it is never allocated). * Remove unused struct atapi_{mechstat_header,changer_info,slot}. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- -11 bytes drivers/ide/ide-cd.c |1 drivers/ide/ide-cd.h | 55

[PATCH 23/63] ide-cd: cleanup ide_cdrom_update_speed()

Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- -39 bytes drivers/ide/ide-cd.c | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) Index: b/drivers/ide/ide-cd.c === --- a/drivers/ide/ide-cd.c

[PATCH 25/63] ide-cd: remove redundant config flags

* Use CDC_* flags directly and remove redundant flags from -config_flags. While at it: * Add KERN_CONT to printk()-s in ide_cdrom_probe_capabilities(). Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- -294 bytes drivers/ide/ide-cd.c | 102

[PATCH 27/63] ide-cd: kill CDROM_STATE_FLAGS() macro

While at it rename 'info' variable to 'cd' in cdrom_saw_media_change(). Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- -49 bytes drivers/ide/ide-cd.c | 44 drivers/ide/ide-cd.h |2 -- 2 files changed, 24 insertions(+), 22

[PATCH 30/63] ide-cd: remove NO_DOOR_LOCKING define

Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-cd.c |3 --- drivers/ide/ide-cd.h |7 --- 2 files changed, 10 deletions(-) Index: b/drivers/ide/ide-cd.c === --- a/drivers/ide/ide-cd.c

[PATCH 31/63] ide-cd: remove STANDARD_ATAPI define

Remove STANDARD_ATAPI define + drive-by coding style fixes. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-cd.c | 43 ++- drivers/ide/ide-cd.h | 10 -- 2 files changed, 10 insertions(+), 43 deletions(-) Index

[PATCH 33/63] ide-cd: re-organize handling of quirky devices

by this patch. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-cd.c | 138 --- drivers/ide/ide-cd.h | 10 ++- 2 files changed, 84 insertions(+), 64 deletions(-) Index: b/drivers/ide/ide-cd.c

[PATCH 36/63] ide-cd: move VERBOSE_IDE_CD_ERRORS code to ide-cd_verbose.c

after the patch w/ CONFIG_BLK_DEV_IDECD_VERBOSE_ERRORS=n: textdata bss dec hex filename 15091 3601056 16507407b drivers/ide/ide-cd_mod.o Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/Kconfig |9 + drivers/ide/Makefile

[PATCH 38/63] ide-cd: merge cdrom_play_audio() into ide_cd_fake_play_trkind()

Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-cd.c | 26 ++ 1 file changed, 10 insertions(+), 16 deletions(-) Index: b/drivers/ide/ide-cd.c === --- a/drivers/ide/ide-cd.c

[PATCH 39/63] ide-cd: merge cdrom_read_subchannel() into ide_cdrom_get_mcn()

Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- -19 bytes drivers/ide/ide-cd.c | 53 --- 1 file changed, 21 insertions(+), 32 deletions(-) Index: b/drivers/ide/ide-cd.c

[PATCH 11/63] ide-cd: add ide_cd_pad_transfer() helper

Add ide_cd_pad_transfer() helper and use it in cdrom_[new]pc_intr() and cdrom_{read,write}_check_ireason(). There should be no functionality changes caused by this patch. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- -39 bytes drivers/ide/ide-cd.c | 51

[PATCH 44/63] ide-cd: move code handling cdrom.c IOCTLs to ide-cd_ioctl.c

There should be no functionality changes caused by this patch. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/Makefile |2 drivers/ide/ide-cd.c | 271 + drivers/ide/ide-cd.h | 17 ++ drivers/ide

[PATCH 46/63] ide-cd: call blk_dump_rq_flags() on missing data in cdrom_newpc_intr()

Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-cd.c |6 +- 1 file changed, 5 insertions(+), 1 deletion(-) Index: b/drivers/ide/ide-cd.c === --- a/drivers/ide/ide-cd.c +++ b/drivers/ide/ide

[PATCH 63/63] ide-cd: update driver version, comments and copyrights

* Bump driver version. * Remove filename and stale TODO from comments. * Add my copyrights. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-cd.c | 17 - 1 file changed, 4 insertions(+), 13 deletions(-) Index: b/drivers/ide/ide-cd.c

[PATCH 61/63] ide-cd: merge cdrom_write_check_ireason() and cdrom_read_check_ireason()

Add 'rw' parameter to cdrom_read_check_ireason(), make it handle both read and write checking, rename it to ide_cd_check_ireason(), finally remove no longer needed cdrom_write_check_ireason(). There should be no functionality changes caused by this patch. Signed-off-by: Bartlomiej

[PATCH 60/63] ide-cd: merge cdrom_rw_intr() and cdrom_newpc_intr()

Add handling of fs read/write requests to cdrom_nepwc_intr() and remove no longer needed cdrom_rw_intr(). There should be no functionality changes caused by this patch. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- -496 bytes drivers/ide/ide-cd.c | 272

[PATCH 59/63] ide-cd: call blk_dump_rq_flags() on missing data in cdrom_rw_intr()

Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-cd.c |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) Index: b/drivers/ide/ide-cd.c === --- a/drivers/ide/ide-cd.c +++ b/drivers/ide/ide-cd.c

[PATCH 58/63] ide-cd: prepare cdrom_rw_intr() and cdrom_newpc_intr() to be merged

' in 'ptr' variable * check for 'rq-bio' before setting 'ptr' and 'blen' * check for 'ptr' instead of 'rq-current_nr_sectors' There should be no functionality changes caused by this patch. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- +54 bytes drivers/ide/ide-cd.c | 45

[PATCH 57/63] ide-cd: unify moving to the next buffer in cdrom_rw_intr()

Use the fact that for the first loop rq-current_nr_sectors is always set and unify moving to the next buffer for read/write requests. There should be no functionality changes caused by this patch. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- -46 bytes drivers/ide/ide-cd.c

[PATCH 56/63] ide-cd: merge cdrom_start_read() and cdrom_start_write()

Add handling of read requests to cdrom_start_write(), rename it to cdrom_start_rw() and remove no longer needed cdrom_start_read(). There should be no functionality changes caused by this patch. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- -20 bytes drivers/ide/ide-cd.c

[PATCH 55/63] ide-cd: merge cdrom_start_read_continuation() and cdrom_start_rw_cont()

. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- -51 bytes drivers/ide/ide-cd.c | 74 --- 1 file changed, 35 insertions(+), 39 deletions(-) Index: b/drivers/ide/ide-cd.c

[PATCH 54/63] ide-cd: merge cdrom_read_intr() and cdrom_write_intr()

Add handling of read requests to cdrom_write_intr(), rename it to cdrom_rw_intr() and remove no longer needed cdrom_read_intr(). There should be no functionality changes caused by this patch. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- -368 bytes drivers/ide/ide-cd.c | 207

[PATCH 53/63] ide-cd: factor out transfer size checking from cdrom_read_intr()

This is a preparation for cdrom_read_intr() and cdrom_write_intr() merge. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- +26 bytes drivers/ide/ide-cd.c | 38 ++ 1 file changed, 26 insertions(+), 12 deletions(-) Index: b/drivers/ide/ide-cd.c

[PATCH 52/63] ide-cd: add ide_cd_drain_data() helper

Add ide_cd_drain_data() and use it in cdrom_{buffer_sectors,read_intr}() (as a nice side-effect this cuts 0.5kB of code from ide-cd.o). There should be no functionality changes caused by this patch. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- -511 bytes drivers/ide/ide-cd.c

[PATCH 50/63] ide-cd: remove cdrom_do_pc_continuation()

cdrom_do_pc_continuation() is now identical to cdrom_do_newpc_cont() so just always use the latter function. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- -49 bytes drivers/ide/ide-cd.c | 15 ++- 1 file changed, 2 insertions(+), 13 deletions(-) Index: b/drivers

[PATCH 49/63] ide-cd: merge cdrom_pc_intr() and cdrom_newpc_intr()

-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- -264 bytes drivers/ide/ide-cd.c | 159 +-- 1 file changed, 55 insertions(+), 104 deletions(-) Index: b/drivers/ide/ide-cd.c === --- a/drivers/ide

[PATCH 48/63] ide-cd: unify request end exit path in cdrom_pc_intr()

This is a preparation for cdrom_pc_intr() and cdrom_newpc_intr() merge. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- +10 bytes drivers/ide/ide-cd.c | 23 +++ 1 file changed, 11 insertions(+), 12 deletions(-) Index: b/drivers/ide/ide-cd.c

[PATCH 47/63] ide-cd: factor out request sense fixup from cdrom_pc_intr()

This is a preparation for cdrom_pc_intr() and cdrom_newpc_intr() merge. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-cd.c | 25 +++-- 1 file changed, 15 insertions(+), 10 deletions(-) Index: b/drivers/ide/ide-cd.c

<    1   2   3   4   5   6   7   8   9   10   >