[PATCH 3/21] macide/q40ide: add missing __init tag to {macide,q40ide}_init()

2007-11-18 Thread Bartlomiej Zolnierkiewicz
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/legacy/macide.c |2 +- drivers/ide/legacy/q40ide.c |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) Index: b/drivers/ide/legacy/macide.c

[PATCH 4/21] ide/Kconfig: fix mpc8xx host driver dependencies

2007-11-18 Thread Bartlomiej Zolnierkiewicz
Only LWMON, IVMS8, IVML24 and TQM8xxL platforms have the needed defines (IDE0_BASE_OFFSET and friends) in the platform header file. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/Kconfig |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: b/drivers/ide

[PATCH 5/21] ide: add CONFIG_IDE_H8300 config option

2007-11-18 Thread Bartlomiej Zolnierkiewicz
Add a separate config option for ide-8300 host driver instead of depending on CONFIG_H8300. This change is a preparation for the future changes and also allows ide-h8300 to be disabled if needed. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/Kconfig |9

[PATCH 6/21] ide: move CONFIG_IDE_ETRAX to drivers/ide/Kconfig

2007-11-18 Thread Bartlomiej Zolnierkiewicz
currently). Cc: Mikael Starvik [EMAIL PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- arch/cris/arch-v10/drivers/Kconfig | 39 - arch/cris/arch-v32/drivers/Kconfig | 12 --- drivers/ide/Kconfig| 35

[PATCH 7/21] ide-cris: don't override ide_register_hw() result

2007-11-18 Thread Bartlomiej Zolnierkiewicz
* Don't override ide_register_hw() result and check if there is a hwif available to use. * MAX_HWIFS is user configurable nowadays so replace it by hard-coded value. * Remove the comment about ide_hwifs[]. Cc: Mikael Starvik [EMAIL PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL

[PATCH 8/21] ide: don't try to unregister interfaces if 'initializing' in ide_register_hw()

2007-11-18 Thread Bartlomiej Zolnierkiewicz
it). Also skip hwif-hold check if 'initializing == 1' since it is set only by: * pmac - PPC PMAC specific = no ISA * au1xxx-ide - MIPS SOC_AU1200 specific = no ISA and use ide_find_port() helper to find free ide_hwifs[] slot. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED

[PATCH 9/21] ide: kill probe_hwif_init()

2007-11-18 Thread Bartlomiej Zolnierkiewicz
There should be no functionality changes caused by this patch. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-probe.c | 38 +- 1 file changed, 17 insertions(+), 21 deletions(-) Index: b/drivers/ide/ide-probe.c

[PATCH 10/21] ide: fix probing for hosts with serialized or IRQ sharing interfaces

2007-11-18 Thread Bartlomiej Zolnierkiewicz
. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-probe.c | 16 ++-- 1 file changed, 14 insertions(+), 2 deletions(-) Index: b/drivers/ide/ide-probe.c === --- a/drivers/ide/ide-probe.c +++ b

[PATCH 11/21] rapide: set hwif-chipset

2007-11-18 Thread Bartlomiej Zolnierkiewicz
hwif-chipset should be set if the hwif is claimed by host driver. Cc: Russell King [EMAIL PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/arm/rapide.c |1 + 1 file changed, 1 insertion(+) Index: b/drivers/ide/arm/rapide.c

[PATCH 13/21] ide: add hwif-chipset fixup to ide_device_add()

2007-11-18 Thread Bartlomiej Zolnierkiewicz
Add hwif-chipset fixup identical to the one in ideprobe_init() to ide_device_add(). Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-probe.c |6 +- 1 file changed, 5 insertions(+), 1 deletion(-) Index: b/drivers/ide/ide-probe.c

[PATCH 14/21] ide: remove ideprobe_init()

2007-11-18 Thread Bartlomiej Zolnierkiewicz
(). There should be no functionality changes caused by this patch. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-generic.c |8 +- drivers/ide/ide-probe.c | 54 +- include/linux/ide.h |3 -- 3 files changed

[PATCH 15/21] sgiioc4: always init hwif-io_ports

2007-11-18 Thread Bartlomiej Zolnierkiewicz
'if (hwif-io_ports[IDE_DATA_OFFSET] != cmd_base)' is always true. Cc: Jeremy Higdon [EMAIL PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/pci/sgiioc4.c | 15 ++- 1 file changed, 6 insertions(+), 9 deletions(-) Index: b/drivers/ide/pci

[PATCH 16/21] ide: add ide_init_port_hw() helper

2007-11-18 Thread Bartlomiej Zolnierkiewicz
King [EMAIL PROTECTED] Cc: Anton Vorontsov [EMAIL PROTECTED] Cc: Jeremy Higdon [EMAIL PROTECTED] Cc: Benjamin Herrenschmidt [EMAIL PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/arm/rapide.c | 34 +++ drivers/ide/ide.c

[PATCH 17/21] ide: drop 'initializing' argument from ide_register_hw()

2007-11-18 Thread Bartlomiej Zolnierkiewicz
no need for init_hwif_default() call since the setup done by it gets over-ridden by ide_init_port_data() call). * Drop 'initializing' argument from ide_register_hw(). Cc: Geert Uytterhoeven [EMAIL PROTECTED] Cc: Roman Zippel [EMAIL PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED

[PATCH 19/21] cmd640: fix dependency on IDE_GENERIC

2007-11-18 Thread Bartlomiej Zolnierkiewicz
Make BLK_DEV_CMD640 select IDE_GENERIC. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/Kconfig |1 + 1 file changed, 1 insertion(+) Index: b/drivers/ide/Kconfig === --- a/drivers/ide/Kconfig +++ b

[PATCH 20/21] ide: fix host drivers depending on ide_generic to probe for interfaces

2007-11-18 Thread Bartlomiej Zolnierkiewicz
ide/Kconfig accordingly. Cc: Mikael Starvik [EMAIL PROTECTED] Cc: Geert Uytterhoeven [EMAIL PROTECTED] Cc: Roman Zippel [EMAIL PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/Kconfig| 11 --- drivers/ide/arm/ide_arm.c |4

[PATCH 21/21] ide: make remaining built-in only IDE host drivers modular

2007-11-18 Thread Bartlomiej Zolnierkiewicz
[EMAIL PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- Documentation/ide.txt |9 +- drivers/ide/Kconfig| 26 drivers/ide/Makefile | 64 +++- drivers/ide/arm/Makefile |4 + drivers/ide/arm/ide_arm.c

Re: [PATCH 21/21] ide: make remaining built-in only IDE host drivers modular

2007-11-18 Thread Bartlomiej Zolnierkiewicz
Hi, On Monday 19 November 2007, Benjamin Herrenschmidt wrote: On Sun, 2007-11-18 at 23:41 +0100, Bartlomiej Zolnierkiewicz wrote: * Make remaining built-in only IDE host drivers modular, add ide-scan-pci.c file for probing PCI host drivers registered with IDE core (special case

Re: [PATCH] siimage: remove resetproc() method

2007-11-16 Thread Bartlomiej Zolnierkiewicz
On Friday 16 November 2007, Sergei Shtylyov wrote: The intent behind siimage_reset() was probably to hard reset the interface and the SATA PHY but as the code writes to two reserved bits instead, it obviously has been ineffective from the start. So, just remove it. Signed-off-by: Sergei

Re: [PATCH 6/13] sgiioc4: add ide_toggle_bounce() calls

2007-11-16 Thread Bartlomiej Zolnierkiewicz
On Friday 16 November 2007, Jeremy Higdon wrote: On Tue, Nov 13, 2007 at 02:20:02PM +0300, Sergei Shtylyov wrote: Bartlomiej Zolnierkiewicz wrote: Add ide_toggle_bounce() call to -ide_dma_on/-dma_off_quietly methods so they match generic __ide_dma_on()/ide_dma_off_quietly(). Cc

Re: [PATCH] ide: don't set PIO mode on pre-EIDE drives

2007-11-16 Thread Bartlomiej Zolnierkiewicz
On Friday 16 November 2007, Sergei Shtylyov wrote: Fix handling of the PIO modes for the pre-EIDE drives that did not support the PIO Flow Control Transfer Mode value (1 nnn) of the Set Transfer Mode feature by skipping the actual mode programming. Signed-off-by: Sergei Shtylyov [EMAIL

Re: [PATCH][RESUBMIT] drivers/ide/ide-probe.c, kernel 2.6.23.1

2007-11-16 Thread Bartlomiej Zolnierkiewicz
On Friday 16 November 2007, Jonas Stare wrote: Resubmit of IDE-probing-patch. It now checks hwif-drives[unit].present instead of forced_geom and there is also an if-statement so it doesn't change back to the master unless it have to. I choose to put it inside the if-statement that checks

Re: [PATCH] sis5513.c: Add Packard Bell EasyNote K5305 to laptops

2007-11-15 Thread Bartlomiej Zolnierkiewicz
On Tuesday 13 November 2007, Gabriel C wrote: Hi, With newer kernels HDD in my old laptop is limited to UDMA 33. With this patch I get UDMA 100 again. Signed-off-by: Gabriel Craciunescu [EMAIL PROTECTED] applied - To unsubscribe from this list: send the line unsubscribe linux-ide in the

Re: [PATCH 10/13] ide-cris: fix DMA methods

2007-11-15 Thread Bartlomiej Zolnierkiewicz
On Wednesday 14 November 2007, Sergei Shtylyov wrote: Bartlomiej Zolnierkiewicz wrote: * Rename cris_dma_{on,off}() to cris_dma_host_{on,off}(). Haven't you killed dma_on/dma_off_quietly() methods in the previosu patch? Yes, I did. I left fixing ide-cris after kill dma_on

Re: [PATCH 14/18] ide: add IDE_HFLAG_ABUSE_SET_DMA_MODE host flag

2007-11-15 Thread Bartlomiej Zolnierkiewicz
Hi, On Thursday 15 November 2007, Sergei Shtylyov wrote: Hello, I wrote: It's tome that I go and make a patch which deals with 0x00 (default s/tome/time/ PIO mode)... But I'm unsure how this value could reach us form userspace because of the argument check present

Re: [PATCH] drivers/ide/ide-probe.c, kernel 2.6.23.1

2007-11-15 Thread Bartlomiej Zolnierkiewicz
Hi, On Thursday 15 November 2007, Jonas Stare wrote: Hi, thanks for the reply. :) Bartlomiej Zolnierkiewicz wrote: Hi, On Monday 12 November 2007, Andrew Morton wrote: On Fri, 09 Nov 2007 11:22:41 +0100 Jonas Stare [EMAIL PROTECTED] wrote: Hi. This week I ran into a strange

Re: [BUG] New Kernel Bugs

2007-11-13 Thread Bartlomiej Zolnierkiewicz
On Nov 13, 2007 12:15 PM, Andrew Morton [EMAIL PROTECTED] wrote: On Mon, 12 Nov 2007 22:42:32 -0800 Natalie Protasevich [EMAIL PROTECTED] wrote: This is the listing of the open bugs that are relatively new, around 2.6.22 and up. They are vaguely classified by specific area. (not a full

[PATCH] it821x/jmicron: fix return value of {it821x,jmicron}_init_one()

2007-11-13 Thread Bartlomiej Zolnierkiewicz
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/pci/it821x.c |3 +-- drivers/ide/pci/jmicron.c |3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) Index: b/drivers/ide/pci/it821x.c

[PATCH] ide: remove stale/incorrect comment from setup-pci.c

2007-11-13 Thread Bartlomiej Zolnierkiewicz
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/setup-pci.c |5 - 1 file changed, 5 deletions(-) Index: b/drivers/ide/setup-pci.c === --- a/drivers/ide/setup-pci.c +++ b/drivers/ide/setup-pci.c

[git patches] IDE fixes

2007-11-13 Thread Bartlomiej Zolnierkiewicz
/ppc/pmac.c |1 + drivers/ide/setup-pci.c |5 - 12 files changed, 11 insertions(+), 27 deletions(-) Adrian Bunk (1): ide: BLK_DEV_IDECD help: remove outdated note Bartlomiej Zolnierkiewicz (6): ide-pmac: skip conservative PIO downgrade ide: add missing HOB

Re: [PATCH 12/13] ide: move drive-using_dma check to callers of -dma_host_on method

2007-11-13 Thread Bartlomiej Zolnierkiewicz
On Tuesday 13 November 2007, Sergei Shtylyov wrote: Bartlomiej Zolnierkiewicz wrote: Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei Index: b/drivers/ide/ide-dma.c

Re: [PATCH 1/13] serverworks: cleanup -set_dma_mode method

2007-11-13 Thread Bartlomiej Zolnierkiewicz
On Tuesday 13 November 2007, Sergei Shtylyov wrote: [...] Index: b/drivers/ide/pci/serverworks.c === --- a/drivers/ide/pci/serverworks.c +++ b/drivers/ide/pci/serverworks.c @@ -164,25 +164,12 @@ static void

[PATCH 1/13] serverworks: cleanup -set_dma_mode method

2007-11-12 Thread Bartlomiej Zolnierkiewicz
IDE core guarantees that -set_dma_mode will be called only for DMA modes set in SWDMA/MWDMA/UDMA masks. There should be no functionality changes caused by this patch. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/pci/serverworks.c | 25

[PATCH 3/13] ide: (hopefully) fix VDMA for CS5520

2007-11-12 Thread Bartlomiej Zolnierkiewicz
-dma_host_off method). Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-iops.c |2 +- drivers/ide/pci/cs5520.c | 29 + drivers/ide/setup-pci.c | 10 +++--- 3 files changed, 25 insertions(+), 16 deletions(-) Index: b/drivers/ide/ide

[PATCH 4/13] cy82c693: correct DMA modes clipping

2007-11-12 Thread Bartlomiej Zolnierkiewicz
version. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/pci/cy82c693.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) Index: b/drivers/ide/pci/cy82c693.c === --- a/drivers/ide/pci

[PATCH 7/13] icside: add ide_toggle_bounce() calls

2007-11-12 Thread Bartlomiej Zolnierkiewicz
Add ide_toggle_bounce() call to -ide_dma_on/-dma_off_quietly methods so they match generic __ide_dma_on()/ide_dma_off_quietly(). Since there is no PCI device there should be no functionality changes caused by this patch. Cc: Russell King [EMAIL PROTECTED] Signed-off-by: Bartlomiej

[PATCH 6/13] sgiioc4: add ide_toggle_bounce() calls

2007-11-12 Thread Bartlomiej Zolnierkiewicz
Add ide_toggle_bounce() call to -ide_dma_on/-dma_off_quietly methods so they match generic __ide_dma_on()/ide_dma_off_quietly(). Cc: Jeremy Higdon [EMAIL PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/pci/sgiioc4.c |2 ++ 1 file changed, 2 insertions

[PATCH 8/13] au1xxx-ide: add ide_toggle_bounce() calls

2007-11-12 Thread Bartlomiej Zolnierkiewicz
Add ide_toggle_bounce() call to -ide_dma_on/-dma_off_quietly methods so they match generic __ide_dma_on()/ide_dma_off_quietly(). Since there is no PCI device there should be no functionality changes caused by this patch. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers

[PATCH 9/13] ide: remove -ide_dma_on and -dma_off_quietly methods from ide_hwif_t

2007-11-12 Thread Bartlomiej Zolnierkiewicz
. * Remove no longer needed -ide_dma_on and -dma_off_quietly methods from ide_hwif_t. * Make ide_dma_on() void. There should be no functionality changes caused by this patch. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/arm/icside.c | 16 drivers

[PATCH 10/13] ide-cris: fix DMA methods

2007-11-12 Thread Bartlomiej Zolnierkiewicz
* Rename cris_dma_{on,off}() to cris_dma_host_{on,off}(). * Remove no longer needed -dma_off_quietly (IDE core has the needed code now). * Make cris_dma_host_on() void. Cc: Mikael Starvik [EMAIL PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/cris/ide

[PATCH 11/13] atiixp: remove -dma_host_on and -dma_host_off methods

2007-11-12 Thread Bartlomiej Zolnierkiewicz
* Enable/disable UDMA in atiixp_set_dma_mode(). * Remove no longer needed atiixp_dma_host_{on,off}() and save_mdma_mode[]. * Bump driver version. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- Needs to be tested, I'll check it with SB400 unless somebody beats me

[PATCH 13/13] ide: merge -dma_host_{on,off} methods into -dma_host_set method

2007-11-12 Thread Bartlomiej Zolnierkiewicz
Merge -dma_host_{on,off} methods into -dma_host_set method which takes 'int on' argument. There should be no functionality changes caused by this patch. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/arm/icside.c |9 +-- drivers/ide/cris/ide-cris.c

Re: [PATCH] cmd64x: don't clear the other channels interrupt

2007-11-11 Thread Bartlomiej Zolnierkiewicz
On Friday 09 November 2007, Sergei Shtylyov wrote: Make sure to not clear the other IDE channel's interrupt when clearing an IDE interrupt via the MRDMODE register. Thanks to Bart for finding a coding mistake. Could you resend with Signed-off-by: and Tested-by: tags? [ A reference to the

Re: SC1200 failure in 2.6.23 and 2.6.24-rc1-git10

2007-11-07 Thread Bartlomiej Zolnierkiewicz
On Thursday 08 November 2007, Denys Fedoryshchenko wrote: 2.6.24-rc2 not working very well dmesg [ 12.386395] Uniform Multi-Platform E-IDE driver Revision: 7.00alpha2 [ 12.405579] ide: Assuming 33MHz system bus speed for PIO modes; override with idebus=xx [ 12.430441] SC1200: IDE

Re: [PATCH 3/8] libata: factor out ata_eh_schedule_probe()

2007-11-05 Thread Bartlomiej Zolnierkiewicz
Hi, On Monday 05 November 2007, Tejun Heo wrote: Factor out ata_eh_schedule_probe() from ata_eh_handle_dev_fail() and ata_eh_recover(). This is to improve maintainability and make future changes easier. Signed-off-by: Tejun Heo [EMAIL PROTECTED] --- drivers/ata/libata-eh.c | 37

Re: [PATCH 7/15] ide: remove atapi_ireason_t

2007-11-05 Thread Bartlomiej Zolnierkiewicz
On Sunday 04 November 2007, Sergei Shtylyov wrote: Bartlomiej Zolnierkiewicz wrote: [PATCH] ide: remove atapi_ireason_t (take 2) Remove atapi_ireason_t. While at it: * replace 'HWIF(drive)' by 'drive-hwif' (or just 'hwif' where possible) v2: * v1 had CD and IO bits reversed

[PATCH] ide: fix IDE_HFLAG_NO_ATAPI_DMA handling in config_drive_for_dma()

2007-11-05 Thread Bartlomiej Zolnierkiewicz
commit 33c1002ed912ac9dacedd5d5b166da3b72d18460 incorrectly changed return value from '0' to '-1', fix it (ns87415 was the only host driver affected since it uses both IDE_HFLAG_TRUST_BIOS_FOR_DMA and IDE_HFLAG_NO_ATAPI_DMA). Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED

[git patches] IDE fixes

2007-11-05 Thread Bartlomiej Zolnierkiewicz
++-- drivers/ide/ide-probe.c|5 +++-- drivers/ide/ide-taskfile.c |3 +++ drivers/ide/pci/piix.c |1 + include/linux/ide.h|9 + 8 files changed, 39 insertions(+), 19 deletions(-) Adrian Bunk (1): ide: unexport ide_fix_driveid Bartlomiej Zolnierkiewicz

[PATCH 2/2] sl82c105: remove no longer needed -selectproc method

2007-11-05 Thread Bartlomiej Zolnierkiewicz
* Program register 0x40 in sl82c105_resetproc(). * Remove no longer needed sl82c105_selectproc() and pci_set_drvdata() calls. Cc: Sergei Shtylyov [EMAIL PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/pci/sl82c105.c | 34

[PATCH 1/2] sl82c105: program DMA/PIO timings in -dma_start/-ide_dma_end

2007-11-05 Thread Bartlomiej Zolnierkiewicz
and in sl82c105_set_dma_mode() only cache the new timings. * Remove no longer needed sl82c105_{ide_dma_on,off_quietly}(). Cc: Sergei Shtylyov [EMAIL PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/pci/sl82c105.c | 55

[PATCH 1/18] ide: fix ide_find_dma_mode() to print human-readable info

2007-11-04 Thread Bartlomiej Zolnierkiewicz
Problem reported by Mikael. Cc: Mikael Pettersson [EMAIL PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-dma.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) Index: b/drivers/ide/ide-dma.c

[PATCH 2/18] ide-pmac: skip conservative PIO downgrade

2007-11-04 Thread Bartlomiej Zolnierkiewicz
We can skip conservative PIO downgrade (PIO3 becomes PIO2 etc.) on PMAC. Problem reported by Mikael. Cc: Mikael Pettersson [EMAIL PROTECTED] Cc: Benjamin Herrenschmidt [EMAIL PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ppc/pmac.c |1 + 1 file

[PATCH 3/18] ide: add missing #ifdef/#endif CONFIG_IDE_TASK_IOCTL

2007-11-04 Thread Bartlomiej Zolnierkiewicz
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-taskfile.c |2 ++ 1 file changed, 2 insertions(+) Index: b/drivers/ide/ide-taskfile.c === --- a/drivers/ide/ide-taskfile.c +++ b/drivers/ide/ide

[PATCH 4/18] ide: move ide_fixstring() documentation to ide-iops.c from ide.h

2007-11-04 Thread Bartlomiej Zolnierkiewicz
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-iops.c |7 +++ include/linux/ide.h|9 + 2 files changed, 8 insertions(+), 8 deletions(-) Index: b/drivers/ide/ide-iops.c

[PATCH 5/18] ide: add missing HOB bit clearing to ide_dump_ata_status()

2007-11-04 Thread Bartlomiej Zolnierkiewicz
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-lib.c |1 + 1 file changed, 1 insertion(+) Index: b/drivers/ide/ide-lib.c === --- a/drivers/ide/ide-lib.c +++ b/drivers/ide/ide-lib.c @@ -512,6

[PATCH 6/18] ide: fix registers loading order in ide_dump_ata_status()

2007-11-04 Thread Bartlomiej Zolnierkiewicz
cleanups). Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-iops.c |4 ++-- drivers/ide/ide-lib.c | 23 ++- 2 files changed, 16 insertions(+), 11 deletions(-) Index: b/drivers/ide/ide-iops.c

[PATCH 7/18] ide: add ide_tf_read() helper

2007-11-04 Thread Bartlomiej Zolnierkiewicz
ide_read_24(). The only change in functionality caused by this patch is that ide_dump_ata_status() no longer prints high/low parts of LBA48 sector address (of course LBA48 sector address is still printed). Cc: Sergei Shtylyov [EMAIL PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED

[PATCH 8/18] ide-disk: use ide_get_lba_addr()

2007-11-04 Thread Bartlomiej Zolnierkiewicz
PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-disk.c | 26 -- drivers/ide/ide-lib.c |3 ++- include/linux/ide.h|1 + 3 files changed, 7 insertions(+), 23 deletions(-) Index: b/drivers/ide/ide-disk.c

[PATCH 10/18] ide: make 'extra' field in struct ide_port_info u8

2007-11-04 Thread Bartlomiej Zolnierkiewicz
The maximum value used currently for 'extra' field in struct ide_port_info is 240. Make 'extra' u8 so it packs nicely together with enablebits[] and 'chipset' fields (ide_pci_enablebit_t is 3 bytes and hwif_chipset_t is 1 byte). Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED

[PATCH 9/18] ide: kill duplicate code in ide_dump_{ata,atapi}_status()

2007-11-04 Thread Bartlomiej Zolnierkiewicz
* Move the common code from ide_dump_{ata,atapi}_status() to ide_dump_status(). * ide_dump_{ata,atapi}_status() - ide_dump_{ata,atapi}_error(). There should be no functionality changes caused by this patch. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-lib.c

[PATCH 11/18] pdc202xx_new: move PIO programming code to pdcnew_set_pio_mode()

2007-11-04 Thread Bartlomiej Zolnierkiewicz
* Move PIO programming code from pdcnew_set_mode() to pdcnew_set_pio_mode(). * Rename pdcnew_set_mode() to pdcnew_set_dma_mode(). There should be no functionality changes caused by this patch. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/pci/pdc202xx_new.c | 26

[PATCH 12/18] sis5513: factor out UDMA programming code

2007-11-04 Thread Bartlomiej Zolnierkiewicz
by this patch. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/pci/sis5513.c | 78 ++ 1 file changed, 45 insertions(+), 33 deletions(-) Index: b/drivers/ide/pci/sis5513.c

[PATCH 13/18] ide: don't BUG() on unsupported transfer modes

2007-11-04 Thread Bartlomiej Zolnierkiewicz
Fix ide-cris, cs5530, sc1200 and sis5513 host drivers to just return instead of OOPS-ing for unsupported modes in -set_dma_mode methods. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/cris/ide-cris.c |3 +-- drivers/ide/pci/cs5530.c|3 +-- drivers/ide/pci

[PATCH 14/18] ide: add IDE_HFLAG_ABUSE_SET_DMA_MODE host flag

2007-11-04 Thread Bartlomiej Zolnierkiewicz
/serverworks host driver. There should be no functionality changes caused by this patch. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/arm/icside.c |2 - drivers/ide/cris/ide-cris.c|2 - drivers/ide/ide-lib.c |6 + drivers/ide/mips

[PATCH 15/18] sc1200: move DMA timings to timing tables

2007-11-04 Thread Bartlomiej Zolnierkiewicz
Based on pata_sc1200.c. There should be no functionality changes caused by this patch. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/pci/sc1200.c | 62 --- 1 file changed, 17 insertions(+), 45 deletions(-) Index: b

[PATCH 16/18] ide: remove redundant -ide_dma_on call from set_using_dma()

2007-11-04 Thread Bartlomiej Zolnierkiewicz
ide_set_dma() calls -ide_dma_on method itself and returns zero only if -ide_dma_on call succeeded. There should be no functionality changes caused by this patch. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide.c |2 +- 1 file changed, 1 insertion(+), 1

[PATCH 17/18] ide: cleanup ide_set_dma()

2007-11-04 Thread Bartlomiej Zolnierkiewicz
dead code for other cases. There should be no functionality changes caused by this patch. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-dma.c | 25 +++-- drivers/ide/ide-io.c|1 - drivers/ide/ide-probe.c | 10 +- drivers

[PATCH 18/18] ide: remove redundant DMA blacklist check from __ide_dma_on()

2007-11-04 Thread Bartlomiej Zolnierkiewicz
changes caused by this patch. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-dma.c |4 1 file changed, 4 deletions(-) Index: b/drivers/ide/ide-dma.c === --- a/drivers/ide/ide-dma.c +++ b

Re: [PATCH 6/9] ide: remove 'handler' field from ide_task_t

2007-11-03 Thread Bartlomiej Zolnierkiewicz
On Friday 02 November 2007, Bartlomiej Zolnierkiewicz wrote: * Add IDE_TFLAG_CUSTOM_HANDLER taskfile flag and use it for internal requests which require custom handlers. Check the flag in do_rw_taskfile() and set handler accordingly. * Cleanup ide_init_{specify,restore,setmult}_cmd

Re: [PATCH 4/15] ide: remove atapi_error_t

2007-11-02 Thread Bartlomiej Zolnierkiewicz
Hi, On Thursday 01 November 2007, Sergei Shtylyov wrote: Hello. Bartlomiej Zolnierkiewicz wrote: Remove atapi_error_t. While at it: * replace 'HWIF(drive)' by 'drive-hwif' Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-floppy.c |3

Re: [PATCH 7/15] ide: remove atapi_ireason_t

2007-11-02 Thread Bartlomiej Zolnierkiewicz
On Wednesday 31 October 2007, Bartlomiej Zolnierkiewicz wrote: Remove atapi_ireason_t. While at it: * replace 'HWIF(drive)' by 'drive-hwif' (or just 'hwif' where possible) Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] [...] [PATCH] ide: remove atapi_ireason_t (take 2

[PATCH 2/9] ide-disk: guarantee 400ns delay after writing command register

2007-11-02 Thread Bartlomiej Zolnierkiewicz
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-disk.c |1 + 1 file changed, 1 insertion(+) Index: b/drivers/ide/ide-disk.c === --- a/drivers/ide/ide-disk.c +++ b/drivers/ide/ide-disk.c @@ -274,6

[PATCH 3/9] ide: merge flagged_taskfile() into do_rw_taskfile()

2007-11-02 Thread Bartlomiej Zolnierkiewicz
Based on the earlier work by Tejun Heo. task-data_phase == TASKFILE_MULTI_{IN,OUT} vs drive-mult_count == 0 check is needed also for ide_taskfile_ioctl() requests that don't have IDE_TFLAG_FLAGGED taskfile flag set. Cc: Tejun Heo [EMAIL PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL

[PATCH 1/9] ide-disk: fix __ide_do_rw_disk() to use -OUTBSYNC

2007-11-02 Thread Bartlomiej Zolnierkiewicz
Fix __ide_do_rw_disk() to use -OUTBSYNC instead of -OUTB (needed for pmac and scc_pata host drivers). Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-disk.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) Index: b/drivers/ide/ide-disk.c

[PATCH 4/9] ide: convert do_rw_taskfile() to use -data_phase

2007-11-02 Thread Bartlomiej Zolnierkiewicz
be no functionality changes caused by this patch. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-taskfile.c | 25 + include/linux/ide.h|2 -- 2 files changed, 13 insertions(+), 14 deletions(-) Index: b/drivers/ide/ide-taskfile.c

[PATCH 5/9] ide: use -data_phase to set -handler in do_rw_taskfile()

2007-11-02 Thread Bartlomiej Zolnierkiewicz
* Use -data_phase to set -handler in do_rw_taskfile() instead of setting -handler in callers of ide_raw_taskfile()/do_rw_taskfile(). * Unexport task_no_data_intr() and make it static. There should be no functionality changes caused by this patch. Signed-off-by: Bartlomiej Zolnierkiewicz

[PATCH 6/9] ide: remove 'handler' field from ide_task_t

2007-11-02 Thread Bartlomiej Zolnierkiewicz
(). * Make {set_geometry,recal,set_multmode}_intr() static. * Remove no longer needed 'handler' field from ide_task_t. There should be no functionality changes caused by this patch. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-io.c | 41

[PATCH 7/9] ide-disk: extend timeout for PIO-in commands

2007-11-02 Thread Bartlomiej Zolnierkiewicz
s/WAIT_CMD/WAIT_WORSTCASE/ to make the timeout the same as in do_rw_taskfile() Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-disk.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) Index: b/drivers/ide/ide-disk.c

[PATCH 8/9] ide-disk: add ide_tf_set_cmd() helper

2007-11-02 Thread Bartlomiej Zolnierkiewicz
() helper. There should be no functionality changes caused by this patch. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-disk.c | 85 +++-- 1 file changed, 55 insertions(+), 30 deletions(-) Index: b/drivers/ide/ide-disk.c

[PATCH 9/9] ide-disk: use do_rw_taskfile()

2007-11-02 Thread Bartlomiej Zolnierkiewicz
. * Remove incorrect comment about do_rw_taskfile() from linux/ide.h. There should be no functionality changes caused by this patch. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-disk.c | 29 ++--- drivers/ide/ide-taskfile.c | 14

Re: [PATCH 2/3] libata: extend ata_acpi_cbl_80wire() and fix cable detection in pata_via and pata_amd

2007-11-02 Thread Bartlomiej Zolnierkiewicz
On Friday 02 November 2007, Alan Cox wrote: Using the initial GTM value is the right thing to do because both are trying to check firmware setting and by the time -cable_detect runs the controller is already forced into PIO0 by reset. As we only look at the DMA bits that doesn't matter

Re: [PATCH 2/3] libata: extend ata_acpi_cbl_80wire() and fix cable detection in pata_via and pata_amd

2007-11-02 Thread Bartlomiej Zolnierkiewicz
On Saturday 03 November 2007, Bartlomiej Zolnierkiewicz wrote: On Friday 02 November 2007, Alan Cox wrote: Using the initial GTM value is the right thing to do because both are trying to check firmware setting and by the time -cable_detect runs the controller is already forced into PIO0

Re: [PATCH 2/3] drivers/ide/pci/sc1200.c: remove pointless hwif lookup loop

2007-10-31 Thread Bartlomiej Zolnierkiewicz
On Friday 26 October 2007, Jeff Garzik wrote: Bartlomiej Zolnierkiewicz wrote: On Thursday 25 October 2007, Jeff Garzik wrote: Store our hwif indices at probe time, in order to eliminate a needless and ugly loop across all hwifs, searching for our pci device. It seems that we can

Re: [IDE] Fix build bug

2007-10-30 Thread Bartlomiej Zolnierkiewicz
On Tuesday 30 October 2007, Ralf Baechle wrote: On Tue, Oct 30, 2007 at 11:34:29AM +, Denys Vlasenko wrote: On Thursday 25 October 2007 22:41, Bartlomiej Zolnierkiewicz wrote: -static const struct ide_port_info generic_chipsets[] __devinitdata = { +static struct ide_port_info

[PATCH 2/15] ide: CPU endianness doesn't matter for special_t

2007-10-30 Thread Bartlomiej Zolnierkiewicz
special_t is used only internally by the IDE subsystem (it isn't related to hardware registers and isn't exported to the user-space). Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- include/linux/ide.h | 11 --- 1 file changed, 11 deletions(-) Index: b/include/linux

[PATCH 3/15] ide: remove ata_status_t and atapi_status_t

2007-10-30 Thread Bartlomiej Zolnierkiewicz
Remove ata_status_t (unused) and atapi_status_t. While at it: * replace 'HWIF(drive)' by 'drive-hwif' (or just 'hwif' where possible) Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-floppy.c | 14 +++--- drivers/ide/ide-lib.c| 21

[PATCH 4/15] ide: remove atapi_error_t

2007-10-30 Thread Bartlomiej Zolnierkiewicz
Remove atapi_error_t. While at it: * replace 'HWIF(drive)' by 'drive-hwif' Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-floppy.c |3 +-- drivers/ide/ide-lib.c| 21 ++--- drivers/ide/ide-tape.c |3 +-- include/linux/ide.h

[PATCH 5/15] ide: remove atapi_feature_t

2007-10-30 Thread Bartlomiej Zolnierkiewicz
Remove atapi_feature_t. While at it: * replace 'HWIF(drive)' by 'hwif' Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-floppy.c | 10 +- drivers/scsi/ide-scsi.c | 11 --- include/linux/ide.h | 27 --- 3 files

[PATCH 6/15] ide: remove ata_nsector_t, ata_data_t and atapi_bcount_t

2007-10-30 Thread Bartlomiej Zolnierkiewicz
Remove ata_nsector_t, ata_data_t (unused) and atapi_bcount_t. While at it: * replace 'HWIF(drive)' by 'hwif' Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-disk.c | 12 +--- drivers/ide/ide-floppy.c | 37

[PATCH 7/15] ide: remove atapi_ireason_t

2007-10-30 Thread Bartlomiej Zolnierkiewicz
Remove atapi_ireason_t. While at it: * replace 'HWIF(drive)' by 'drive-hwif' (or just 'hwif' where possible) Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-floppy.c | 25 - drivers/ide/ide-tape.c | 27

[PATCH 10/15] ide: add ide_pktcmd_tf_load() helper

2007-10-30 Thread Bartlomiej Zolnierkiewicz
Add ide_pktcmd_tf_load() helper and convert ATAPI device drivers to use it. There should be no functionality changes caused by this patch. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-cd.c | 10 ++ drivers/ide/ide-floppy.c |9

[PATCH 8/15] ide-cd: fix register loading order in cdrom_start_packet_command()

2007-10-30 Thread Bartlomiej Zolnierkiewicz
-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-cd.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) Index: b/drivers/ide/ide-cd.c === --- a/drivers/ide/ide-cd.c +++ b/drivers/ide/ide-cd.c @@ -917,19

[PATCH 9/15] ide-{floppy,tape,scsi}: fix register loading order when issuing packet command

2007-10-30 Thread Bartlomiej Zolnierkiewicz
Load IDE_BCOUNTL_REG before IDE_BCOUNTH_REG when issuing packet command. It shouldn't affect anything (just a usual paranoia to separate changes which change the way in which hardware is accessed from code cleanups). Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide

[PATCH 11/15] ide: remove QUIRK_LIST()

2007-10-30 Thread Bartlomiej Zolnierkiewicz
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-iops.c |6 -- drivers/ide/ide-probe.c |5 - include/linux/ide.h |1 - 3 files changed, 4 insertions(+), 8 deletions(-) Index: b/drivers/ide/ide-iops.c

[PATCH 14/15] ide: remove 'command_type' field from ide_task_t

2007-10-30 Thread Bartlomiej Zolnierkiewicz
. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-disk.c | 15 +++ drivers/ide/ide-io.c |8 ++-- drivers/ide/ide-taskfile.c | 89 ++--- include/linux/hdreg.h | 13 +++--- include/linux/ide.h|5

[PATCH 15/15] ide: remove 'tf_in_flags' field from ide_task_t

2007-10-30 Thread Bartlomiej Zolnierkiewicz
ide_task_t. As the result we finally have the internals of HDIO_DRIVE_TASKFILE ioctl separated from the core IDE code. There should be no functionality changes caused by this patch. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-io.c |2 +- drivers/ide/ide

[PATCH 13/15] ide: remove hwif-intrproc

2007-10-30 Thread Bartlomiej Zolnierkiewicz
: Sergei Shtylyov [EMAIL PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- Handling of quirky drives (problems with nIEN) by hpt366 and pdc202xx_* looks suspicious... are the problems really dependent on the host type (thus hwif-quirkproc and -quirk_list == 1/2)? Shouldn't we

[PATCH 12/15] ide: remove SELECT_INTERRUPT()

2007-10-30 Thread Bartlomiej Zolnierkiewicz
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-io.c |5 - drivers/ide/ide-iops.c |8 include/linux/ide.h|1 - 3 files changed, 4 insertions(+), 10 deletions(-) Index: b/drivers/ide/ide-io.c

Re: [2.6 patch] unexport ide_fix_driveid

2007-10-27 Thread Bartlomiej Zolnierkiewicz
On Saturday 27 October 2007, Adrian Bunk wrote: ide_fix_driveid can now be unexported. Signed-off-by: Adrian Bunk [EMAIL PROTECTED] applied - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at

[PATCH] ide/Kconfig: fix BLK_DEV_OFFBOARD dependencies

2007-10-27 Thread Bartlomiej Zolnierkiewicz
This config option is effective only for host drivers that use IDE_HFLAG_OFF_BOARD host flag (aec62xx, generic, hpt34x, hpt366, pdc202xx_new, pdc202xx_old and tc86c001). Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/Kconfig |3 ++- 1 file changed, 2 insertions

<    1   2   3   4   5   6   7   8   9   10   >