libata broken on Pegasos PPC platform (was: Re: IDE broken on Pegasos PPC platform)

2007-09-24 Thread Bartlomiej Zolnierkiewicz
:) and is the way to go Acked-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- arch/powerpc/kernel/prom_init.c | 11 --- arch/powerpc/platforms/chrp/pci.c | 29 + 2 files changed, 37 insertions(+), 3 deletions(-) --- a/arch/powerpc/kernel/prom_init.c

[PATCH] ide: remove -ide_dma_check (take 2)

2007-09-20 Thread Bartlomiej Zolnierkiewicz
() comment. There should be no functionality changes caused by this patch. Cc: Sergei Shtylyov [EMAIL PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- replacement patch for the one currently in IDE quilt tree Sergei: re-review is needed drivers/ide/arm/icside.c |9

[PATCH] ide: add -mwdma_mask and -swdma_mask to ide_pci_device_t (take 2)

2007-09-20 Thread Bartlomiej Zolnierkiewicz
masks. While at it: * Use ATA_{UDMA,MWDMA,SWDMA}* defines. * hpt34x.c: add separate ide_pci_device_t instances for HPT343 and HPT345. * serverworks.c: fix DMA masks being set before checking DMA base. v2: * Add missing masks to DECLARE_GENERIC_PCI_DEV() macro. Signed-off-by: Bartlomiej

[PATCH] ide: move ide_rate_filter() calls to the upper layer (take 2)

2007-09-20 Thread Bartlomiej Zolnierkiewicz
] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- replacement patch for the one currently in IDE quilt tree Sergei: since v2's change is purely cosmetic I kept your ACK drivers/ide/arm/icside.c |7 +-- drivers/ide/cris/ide-cris.c|4 +--- drivers/ide/ide-lib.c

[PATCH] ide: use only -set_pio_mode method for programming PIO modes (take 2)

2007-09-20 Thread Bartlomiej Zolnierkiewicz
by this patch. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- replacement patch for the one currently in IDE quilt tree drivers/ide/cris/ide-cris.c |5 - drivers/ide/ide-lib.c | 12 drivers/ide/mips/au1xxx-ide.c |5 - drivers/ide/pci/alim15x3.c

[PATCH 2/3] ide: remove redundant comments from ide.h

2007-09-19 Thread Bartlomiej Zolnierkiewicz
There is better documentation for these functions in drivers/ide/. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- include/linux/ide.h | 41 - 1 file changed, 41 deletions(-) Index: b/include/linux/ide.h

Re: [PATCH] [POWERPC] Remove unused variabls from drivers/ide/ppc/pmac.c

2007-09-17 Thread Bartlomiej Zolnierkiewicz
On Monday 17 September 2007, Stephen Rothwell wrote: Removes these warnings: /home/sfr/kernels/linus/drivers/ide/ppc/pmac.c: In function 'pmac_ide_dma_check': /home/sfr/kernels/linus/drivers/ide/ppc/pmac.c:1807: warning: unused variable 'map'

Re: [PATCH] ide: call udma_filter() before resorting to the UltraDMA mask

2007-09-17 Thread Bartlomiej Zolnierkiewicz
On Saturday 15 September 2007, Sergei Shtylyov wrote: Give the udma_filter() method call taking precedence over using the mode masks. Signed-off-by: Sergei Shtylyov [EMAIL PROTECTED] applied with s/taking// --- Posting this change separately as have been asked. Should apply to the

[git patches] IDE fixes

2007-09-17 Thread Bartlomiej Zolnierkiewicz
Please pull from: master.kernel.org:/pub/scm/linux/kernel/git/bart/ide-2.6.git/ to receive the following updates: drivers/ide/ide-disk.c |1 + drivers/ide/ppc/pmac.c |2 -- 2 files changed, 1 insertions(+), 2 deletions(-) Jorge Juan Chico (1): ide: ST320413A has the same

Re: [PATCH 7/10] ide: add -chipset field to ide_pci_device_t

2007-09-17 Thread Bartlomiej Zolnierkiewicz
On Saturday 15 September 2007, Sergei Shtylyov wrote: Bartlomiej Zolnierkiewicz wrote: Add -chipset field to ide_pci_device_t and use it in ide_hwif_configure() to set hwif-chipset. Convert cmd64x, cy82c693, rz1000 and trm290 host drivers to use this new ability. While at it define

[PATCH 6/6] ide: add ide_device_add()

2007-09-17 Thread Bartlomiej Zolnierkiewicz
it static. * Unexport ide_proc_register_port(). There should be no functionality changes caused by this patch (sgiioc4.c: ide_proc_register_port() requires hwif-present to be set and it won't be set if probe_hwif_init() fails). Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED

[PATCH 1/6] alim15x3: fix CD_ROM DMA and PIO FIFO settings setup

2007-09-17 Thread Bartlomiej Zolnierkiewicz
when idex=ata66 kernel parameter is used. * While at it move also chip_is_1543c_e setup from ata66_ali15x3() to init_chipset_ali15x3() and check if isa_dev exists before accessing it. * Bump driver version. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/pci/alim15x3.c

[PATCH 2/6] alim15x3: use -host_flags and -udma_mask fields from ide_pci_device_t

2007-09-17 Thread Bartlomiej Zolnierkiewicz
* Make a local copy of ali15x3_chipset in alim15x3_init_one() and set -host_flags / -udma_mask according to the controller capabilities. * Cleanup init_hwif_common_ali15x3(). * Bump driver version. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/pci/alim15x3.c

[PATCH 3/6] aec62xx: remove aec62xx_dma_lost_irq()

2007-09-17 Thread Bartlomiej Zolnierkiewicz
* Remove aec62xx_dma_lost_irq() (generic ide_dma_lost_irq() will be used now). * Bump driver version. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/pci/aec62xx.c | 17 + 1 file changed, 1 insertion(+), 16 deletions(-) Index: b/drivers/ide/pci

[PATCH 4/6] siimage: separate PATA and SATA methods

2007-09-17 Thread Bartlomiej Zolnierkiewicz
sil_sata_reset_poll() a bit. * Cache is_sata() result in init_hwif_siimage() Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/pci/siimage.c | 79 ++ 1 file changed, 39 insertions(+), 40 deletions(-) Index: b/drivers/ide/pci/siimage.c

[PATCH 5/6] ide: add -fixup method to ide_hwif_t

2007-09-17 Thread Bartlomiej Zolnierkiewicz
, update all ide_register_hw() users accordingly. * Convert ide-cs/delkin_cb host drivers to use ide_register_hw(). * Restore hwif-fixup in ide_hwif_restore(). * Remove ide_register_hw_with_fixup(), probe_hwif_init_with_fixup() and 'fixup' argument from probe_hwif(). Signed-off-by: Bartlomiej

Re: [PATCH 5/10] hpt366: remove -init_setup

2007-09-14 Thread Bartlomiej Zolnierkiewicz
Hi, On Friday 14 September 2007, Sergei Shtylyov wrote: Hello. Bartlomiej Zolnierkiewicz wrote: * Split off hpt{374,371,366}_init() helper from init_setup_hpt{374,371,366}(). * Merge init_setup_{374,372n,371,372a,302,366}() into hpt366_init_one(). While at it: * Use HPT36x name

Re: [PATCH] libata: Add a drivers/ide style DMA disable

2007-09-14 Thread Bartlomiej Zolnierkiewicz
On Friday 14 September 2007, Chuck Ebbert wrote: On 09/07/2007 06:47 PM, Jeff Garzik wrote: This is useful when debugging, handling problem systems, or for distributions just to get the system installed so it can be sorted out later. This is a bit smarter than the old IDE one and lets

Re: libata not working for sis5533

2007-09-12 Thread Bartlomiej Zolnierkiewicz
Hi, On Wednesday 12 September 2007, Patrizio Bassi wrote: Jan Engelhardt ha scritto: On Sep 11 2007 15:46, Andrew Morton wrote: Patrizio Bassi [EMAIL PROTECTED] wrote: Jan Engelhardt ha scritto: On Sep 8 2007 11:38, Patrizio Bassi wrote: Jan Engelhardt

[git patches] IDE fixes for 2.6.23-rc6

2007-09-11 Thread Bartlomiej Zolnierkiewicz
files changed, 141 insertions(+), 97 deletions(-) Bartlomiej Zolnierkiewicz (1): via82cxxx: add Arima W730-K8 and other rebadgings to short cables list Daniel Exner (1): pata_ali/alim15x3: override 80-wire cable detection for Toshiba S1800-814 Kumar Gala (1): mpc8xx: Only build

Re: [PATCH 2/4] hpt366: MWDMA filter for SATA cards

2007-09-11 Thread Bartlomiej Zolnierkiewicz
On Saturday 08 September 2007, Sergei Shtylyov wrote: Hello, I wrote: Sergei Shtylyov wrote: The patch was 4/4 of course. :- Probably I was too esctatic about the code. ;-) Or rarher me. :-) The Marvell bridge chips used on HighPoint SATA cards do not seem to support

Re: [PATCH 3/4] ide: make ide_rate_filter() also respect PIO and SW/MW DMA mode masks (take 2)

2007-09-11 Thread Bartlomiej Zolnierkiewicz
Hi, On Saturday 08 September 2007, Sergei Shtylyov wrote: Once I quothed: Make ide_rate_filter() also respect PIO/SWDMA/MWDMA mode masks. While at it, make the udma_filter() method calls take precedence over using the mode masks. This one not looking to pretty -- I've geve

Re: [PATCH 5/10] hpt366: remove -init_setup

2007-09-11 Thread Bartlomiej Zolnierkiewicz
On Saturday 08 September 2007, Sergei Shtylyov wrote: Bartlomiej Zolnierkiewicz wrote: * Split off hpt{374,371,366}_init() helper from init_setup_hpt{374,371,366}(). * Merge init_setup_{374,372n,371,372a,302,366}() into hpt366_init_one(). While at it: * Use HPT36x name

Re: [-mm patch] remove ide_get_error_location()

2007-09-11 Thread Bartlomiej Zolnierkiewicz
-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Since git-block contains the patch which removes the only user of ide_get_error_location() I think that this patch should be also merged through block tree. Jens? PS none of the blkdev_issue_flush() users uses *error_sector argument so it can

[PATCH 1/10] cmd64x: always set hwif-chipset for CMD646

2007-09-11 Thread Bartlomiej Zolnierkiewicz
hwif-chipset should be set to ide_cmd646 also when DMA base is invalid. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/pci/cmd64x.c |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) Index: b/drivers/ide/pci/cmd64x.c

[PATCH 2/10] ide: fix disabled ports reporting for PCI controllers

2007-09-11 Thread Bartlomiej Zolnierkiewicz
Report all disabled ports in ide_pci_setup_ports() (prevents the bogus warning when ide_hwif_configure()-ide_match_hwif() fails to find free ide_hwifs[] slots). Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/setup-pci.c | 10 -- 1 file changed, 4 insertions

[PATCH 3/10] rz1000: set serialized flag only if mate interface exists

2007-09-11 Thread Bartlomiej Zolnierkiewicz
Setting hwif-serialized makes sense only if the mate interface exists. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/pci/rz1000.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) Index: b/drivers/ide/pci/rz1000.c

[PATCH 4/10] serverworks: remove dead code from svwks_set_dma_mode()

2007-09-11 Thread Bartlomiej Zolnierkiewicz
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/pci/serverworks.c |7 --- 1 file changed, 7 deletions(-) Index: b/drivers/ide/pci/serverworks.c === --- a/drivers/ide/pci/serverworks.c +++ b

[PATCH 5/10] ide: add hwif_register_devices() helper

2007-09-11 Thread Bartlomiej Zolnierkiewicz
Add hwif_register_devices() helper to fix code duplication between probe_hwif_init_with_fixup() and ideprobe_init(). Also remove stale comment while at it. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-probe.c | 51

[PATCH 6/10] ide: remove unused -next field from ide_pci_device_t

2007-09-11 Thread Bartlomiej Zolnierkiewicz
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- include/linux/ide.h |1 - 1 file changed, 1 deletion(-) Index: b/include/linux/ide.h === --- a/include/linux/ide.h +++ b/include/linux/ide.h @@ -1283,7 +1283,6

[PATCH 7/10] ide: add -chipset field to ide_pci_device_t

2007-09-11 Thread Bartlomiej Zolnierkiewicz
. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/pci/cmd64x.c |4 +--- drivers/ide/pci/cy82c693.c |2 +- drivers/ide/pci/rz1000.c |2 +- drivers/ide/pci/trm290.c |2 +- drivers/ide/setup-pci.c|2 +- include/linux/ide.h|7 +-- 6

[PATCH 8/10] ide: add IDE_HFLAG_FORCE_LEGACY_IRQS host flag

2007-09-11 Thread Bartlomiej Zolnierkiewicz
init_hwif_generic() (generic IDE PCI host driver). * Set d-udma_mask instead of hwif-ultra_mask (via82cxxx host driver). Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/pci/generic.c | 27 ++- drivers/ide/pci/via82cxxx.c | 20 +++- drivers

[PATCH 9/10] ide: add IDE_HFLAG_RQSIZE_256 host flag

2007-09-11 Thread Bartlomiej Zolnierkiewicz
Add IDE_HFLAG_RQSIZE_256 host flag to tell ide_pci_setup_ports() to set hwif-rqsize to 256 sectors. Convert pdc202xx_old host driver to use it. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/pci/pdc202xx_old.c | 18 ++ drivers/ide/setup-pci.c

[PATCH 10/10] ide: add IDE_HFLAG_{IO_32BIT,UNMASK_IRQS} host flags

2007-09-11 Thread Bartlomiej Zolnierkiewicz
IDE_HFLAGS_VIA define (via82cxxx host driver). Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/pci/amd74xx.c | 25 ++--- drivers/ide/pci/sl82c105.c | 12 drivers/ide/pci/via82cxxx.c | 31 ++- drivers

Re: [PATCH] drivers/firmware: const-ify DMI API and internals

2007-09-11 Thread Bartlomiej Zolnierkiewicz
have been a separate patch, but it was so small compared to the others, it was easier to roll it into this changeset. Signed-off-by: Jeff Garzik [EMAIL PROTECTED] [ a bit late ] Acked-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] - To unsubscribe from this list: send the line

[PATCH] via82cxxx: add Arima W730-K8 and other rebadgings to short cables list

2007-09-05 Thread Bartlomiej Zolnierkiewicz
Port of Alan's patch for pata_via.c. Cc: Alan Cox [EMAIL PROTECTED] Cc: Mikael Pettersson [EMAIL PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/pci/via82cxxx.c | 15 +++ 1 file changed, 11 insertions(+), 4 deletions(-) Index: b/drivers/ide

Re: [PATCH 2/10] ide: use I/O ops directly part #2

2007-09-05 Thread Bartlomiej Zolnierkiewicz
On Saturday 01 September 2007, Sergei Shtylyov wrote: Bartlomiej Zolnierkiewicz wrote: Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] Strange I thought I've already replaced everything in hpt366.c ... although we could switch

[PATCH 1/13] aec62xx: no need to disable UDMA in -init_hwif method for ATP850UF

2007-09-05 Thread Bartlomiej Zolnierkiewicz
* No need to disable UDMA in -init_hwif method for ATP850UF (and since we now always tune PIO it will be disabled by -set_pio_mode calls anyway). * Bump driver version. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/pci/aec62xx.c | 14 +- 1 file

[PATCH 2/13] pdc202xx_new: add DECLARE_PDCNEW_DEV() macro

2007-09-05 Thread Bartlomiej Zolnierkiewicz
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/pci/pdc202xx_new.c | 76 ++--- 1 file changed, 19 insertions(+), 57 deletions(-) Index: b/drivers/ide/pci/pdc202xx_new.c

[PATCH 3/13] pdc202xx_old: add DECLARE_PDC2026X_DEV() macro

2007-09-05 Thread Bartlomiej Zolnierkiewicz
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/pci/pdc202xx_old.c | 60 - 1 file changed, 19 insertions(+), 41 deletions(-) Index: b/drivers/ide/pci/pdc202xx_old.c

[PATCH 4/13] piix: add DECLARE_ICH_DEV() macro

2007-09-05 Thread Bartlomiej Zolnierkiewicz
Add DECLARE_ICH_DEV() macro. While at it: * Add init_hwif_ich() (-init_hwif method) for ICH controllers. * Rename init_chipset_piix() to init_chipset_ich() and use it only for ICH controllers. * Remove no longer needed piix_is_ichx() helper. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL

[PATCH 5/13] ide: add IDE_HFLAG_ERROR_STOPS_FIFO host flag

2007-09-05 Thread Bartlomiej Zolnierkiewicz
Add IDE_HFLAG_ERROR_STOPS_FIFO host flag and use it instead of hwif-err_stops_fifo. As a side-effect this change fixes hwif-err_stops_fifo not being restored by ide_hwif_restore(). Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-io.c |3 ++- drivers

[PATCH 6/13] ide: add IDE_HFLAG_SERIALIZE host flag

2007-09-05 Thread Bartlomiej Zolnierkiewicz
Add IDE_HFLAG_SERIALIZE host flag to tell ide_pci_setup_ports() to set hwif/mate-serialized and convert aec62xx, cs5530 and sc1200 host drivers to use it. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/pci/aec62xx.c | 10 +- drivers/ide/pci/cs5530.c |7

[PATCH 7/13] ide: add IDE_HFLAG_LEGACY_IRQS host flag

2007-09-05 Thread Bartlomiej Zolnierkiewicz
-init_hwif for MPIIX. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/pci/atiixp.c |8 +++- drivers/ide/pci/piix.c| 24 ++-- drivers/ide/pci/serverworks.c | 15 +++ drivers/ide/pci/sis5513.c |6 ++ drivers/ide

[PATCH 9/13] cs5520: always tune PIO

2007-09-05 Thread Bartlomiej Zolnierkiewicz
Since cs5520 uses VDMA best PIO mode was tuned anyway by ide_dma_check() but only if DMA was successfully initialized. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/pci/cs5520.c |7 --- 1 file changed, 4 insertions(+), 3 deletions(-) Index: b/drivers/ide

[PATCH 11/13] opti621: always tune PIO

2007-09-05 Thread Bartlomiej Zolnierkiewicz
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/pci/opti621.c |8 1 file changed, 4 insertions(+), 4 deletions(-) Index: b/drivers/ide/pci/opti621.c === --- a/drivers/ide/pci/opti621.c +++ b

[PATCH 12/13] triflex: always tune PIO

2007-09-05 Thread Bartlomiej Zolnierkiewicz
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/pci/triflex.c |3 +++ 1 file changed, 3 insertions(+) Index: b/drivers/ide/pci/triflex.c === --- a/drivers/ide/pci/triflex.c +++ b/drivers/ide/pci

[PATCH 13/13] ide: set drive-autotune in ide_pci_setup_ports()

2007-09-05 Thread Bartlomiej Zolnierkiewicz
: * MPIIX controller (no -init_hwif method so also no -set_pio_mode method) However if there is no -set_pio_mode method there are no changes in behavior w.r.t. PIO tuning so always set drive-autotune in ide_pci_setup_ports(). Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide

[PATCH 8/13] alim15x3: always tune PIO

2007-09-05 Thread Bartlomiej Zolnierkiewicz
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/pci/alim15x3.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) Index: b/drivers/ide/pci/alim15x3.c === --- a/drivers/ide/pci/alim15x3.c

Re: [PATCH 2/4] hpt366: MWDMA filter for SATA cards

2007-09-03 Thread Bartlomiej Zolnierkiewicz
On Sunday 02 September 2007, Sergei Shtylyov wrote: Hello, I wrote: The patch was 4/4 of course. :- Probably I was too esctatic about the code. ;-) The Marvell bridge chips used on HighPoint SATA cards do not seem to support the MWDMA modes (at least that caould be seen in

Re: [PATCH 3/4] ide: make ide_rate_filter() also respect PIO and SW/MW DMA mode masks (take 2)

2007-09-03 Thread Bartlomiej Zolnierkiewicz
Hi, On Sunday 02 September 2007, Sergei Shtylyov wrote: Make ide_rate_filter() also respect PIO/SWDMA/MWDMA mode masks. While at it, Hm, this seems to be already dealt with by:

[PATCH 1/10] ide: use pci_dev-revision

2007-08-29 Thread Bartlomiej Zolnierkiewicz
Some places were using PCI_CLASS_REVISION instead of PCI_REVISION_ID so they were not converted by commit 44c10138fd4bbc4b6d6bff0873c24902f2a9da65. Cc: Auke Kok [EMAIL PROTECTED] Cc: Greg Kroah-Hartman [EMAIL PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- Quick grep

[PATCH 2/10] ide: use I/O ops directly part #2

2007-08-29 Thread Bartlomiej Zolnierkiewicz
Cc: Sergei Shtylyov [EMAIL PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/pci/hpt366.c | 43 --- drivers/ide/pci/piix.c |4 ++-- drivers/ide/pci/tc86c001.c | 12 ++-- 3 files changed, 28

[PATCH 3/10] aec62xx: remove -init_setup

2007-08-29 Thread Bartlomiej Zolnierkiewicz
Merge init_setup_{aec62xx,aec6x80}() into aec62xx_init_one(). While at it: * Use id-driver_data instead of dev-device. * Use ATA_UDMA6 define. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/pci/aec62xx.c | 39 ++- 1 file

[PATCH 4/10] cmd64x: remove -init_setup

2007-08-29 Thread Bartlomiej Zolnierkiewicz
Merge init_setup_{cmd64x,cmd646}() into cmd64x_init_one(). Cc: Sergei Shtylyov [EMAIL PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/pci/cmd64x.c | 39 --- 1 file changed, 12 insertions(+), 27 deletions(-) Index: b

[PATCH 6/10] pdc202xx_new: remove -init_setup

2007-08-29 Thread Bartlomiej Zolnierkiewicz
* Split off pdc20270_get_dev2() helper from init_setup_pdc20270(). * Merge init_setup_{pdcnew,pdc20270,pdc20276}() into pdc202new_init_one(). While at it: * Change KERN_ level of interrupt fixup message from KERN_WARNING to KERN_INFO. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED

[PATCH 5/10] hpt366: remove -init_setup

2007-08-29 Thread Bartlomiej Zolnierkiewicz
and fix .enablebits/.host_flags for HPT36x hpt366_chipsets[] entry. * Bump driver version. Cc: Sergei Shtylyov [EMAIL PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/pci/hpt366.c | 306 +++ 1 file changed, 127 insertions

[PATCH 7/10] pdc202xx_old: remove -init_setup

2007-08-29 Thread Bartlomiej Zolnierkiewicz
* Split off pdc202ata4_fixup_irq() helper from init_setup_pdc202ata4(). * Merge init_setup_{pdc202ata4,pdc20265,pdc202xx}() into pdc202xx_init_one(). Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/pci/pdc202xx_old.c | 57

[PATCH 9/10] serverworks: remove -init_setup

2007-08-29 Thread Bartlomiej Zolnierkiewicz
Merge init_setup_{svwks,csb6}() into svwks_init_one(). While at it: * Remove redundant dev-device checks. * Operate on a local copy of serverworks_chipsets[] entry. * Use pci_resource_start(). Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/pci/serverworks.c

[PATCH 10/10] ide: remove .init_setup from ide_pci_device_t

2007-08-29 Thread Bartlomiej Zolnierkiewicz
Now that all users were fixed we can safely remove it. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- include/linux/ide.h |1 - 1 file changed, 1 deletion(-) Index: b/include/linux/ide.h === --- a/include/linux

Re: [PATCH 1/10] ide: use pci_dev-revision

2007-08-29 Thread Bartlomiej Zolnierkiewicz
On Wednesday 29 August 2007, Kok, Auke wrote: Bartlomiej Zolnierkiewicz wrote: Some places were using PCI_CLASS_REVISION instead of PCI_REVISION_ID so they were not converted by commit 44c10138fd4bbc4b6d6bff0873c24902f2a9da65. that's actually another effort that I'm working on atm. You

Re: [PATCH] mpc8xx: Only build mpc8xx on arch/ppc

2007-08-27 Thread Bartlomiej Zolnierkiewicz
On Thursday 23 August 2007, Kumar Gala wrote: Currently the mpc8xx ide driver will only work on arch/ppc so only allow it to be built there. Also, killed a minor include that isn't actually used by the driver. Signed-off-by: Kumar Gala [EMAIL PROTECTED] applied - To unsubscribe from this

Re: [PATCH 2/4] hpt366: UltraDMA filter for SATA cards (take 3)

2007-08-27 Thread Bartlomiej Zolnierkiewicz
Hello, On Saturday 25 August 2007, Sergei Shtylyov wrote: The Marvell bridge chips used on HighPoint SATA cards do not seem to support the UltraDMA modes 1, 2, and 3 as well as any MWDMA modes, so the driver needs to account for this in the udma_filter() method. In order to achieve that, do

Re: [PATCH 1/4] ide: add ide_dev_is_sata() helper (take 2)

2007-08-27 Thread Bartlomiej Zolnierkiewicz
On Saturday 25 August 2007, Sergei Shtylyov wrote: Make the SATA drive detection code from eighty_ninty_three() into inline ide_dev_is_sata() helper fixing it along the way to be more strict while checking word 80 for the reserved values... Signed-off-by: Sergei Shtylyov [EMAIL PROTECTED]

Re: [PATCH 2/2] hpt366: UltraDMA filtering for SATA cards

2007-08-27 Thread Bartlomiej Zolnierkiewicz
On Saturday 25 August 2007, Sergei Shtylyov wrote: Hello. Bartlomiej Zolnierkiewicz wrote: The Marvell bridge chips used on HighPoint SATA cards do not seem to support the UltraDMA modes 1, 2, and 3 (as well as any MWDMA modes), so the driver needs to account for this in the udma_filter

Re: [PATCH 1/2] pdc202xx_new: fix PCI refcounting

2007-08-27 Thread Bartlomiej Zolnierkiewicz
On Sunday 26 August 2007, Sergei Shtylyov wrote: Bartlomiej Zolnierkiewicz wrote: The driver erroneously lets go the mate IDE chip in init_setup_pdc20270() when ide_setup_pci_devices() call succeeds -- fix this, and drop a couple of useless assignments in this function while

[PATCH 2/8] amd74xx: remove /proc/ide/amd74xx

2007-08-27 Thread Bartlomiej Zolnierkiewicz
This belongs to user-space (and only if really needed). textdata bss dec hex filename 67232000 288751222f drivers/ide/pci/amd74xx.o.before 38332000 16584916d9 drivers/ide/pci/amd74xx.o.after Signed-off-by: Bartlomiej Zolnierkiewicz

[PATCH 4/8] ide: add IDE_HFLAG_BOOTABLE host flag

2007-08-27 Thread Bartlomiej Zolnierkiewicz
Add IDE_HFLAG_BOOTABLE host flag and IDE_HFLAG_OFF_BOARD define. Convert all host drivers using ide_pci_device_t to use IDE_HFLAG_{BOOTABLE,OFF_BOARD} instead of d-bootable and then remove no longer needed d-bootable. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide

[PATCH 7/8] ide: add IDE_HFLAG_NO_LBA48 and IDE_HFLAG_NO_LBA48_DMA host flags

2007-08-27 Thread Bartlomiej Zolnierkiewicz
Add IDE_HFLAG_NO_LBA48[_DMA] host flags, use it instead of hwif-no_lba48[_dma] and then remove no longer needed hwif-no_lba48[_dma]. As a side-effect this change fixes hwif-no_lba48_dma not being restored by ide_hwif_restore(). Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED

[PATCH 6/8] ide: remove -init_setup_dma from ide_pci_device_t

2007-08-27 Thread Bartlomiej Zolnierkiewicz
which PCI BAR to use, remove no longer needed cs5520.c::cs5520_init_setup_dma() and ide_pci_device_t.init_setup_dma. This fixes PCI bus-mastering and DMA simplex mode not being checked for CS5510/CS5520 hosts. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/pci

[PATCH 5/8] ide: add IDE_HFLAG_NO_{DMA,AUTODMA} host flags

2007-08-27 Thread Bartlomiej Zolnierkiewicz
Add IDE_HFLAG_NO_{DMA,AUTODMA} host flags. Convert all host drivers using ide_pci_device_t to use these flags instead of d-autodma and then remove no longer needed d-autodma. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/pci/aec62xx.c |8 ++-- drivers

[PATCH 3/8] ide: add IDE_HFLAG_NO_ATAPI_DMA host flag

2007-08-27 Thread Bartlomiej Zolnierkiewicz
Add IDE_HFLAG_NO_ATAPI_DMA host flag and set it in host drivers which don't support ATAPI DMA. Then remove no longer needed hwif-atapi_dma. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/arm/icside.c |1 - drivers/ide/cris/ide-cris.c|1 + drivers

[PATCH 8/8] ata: add ATA_MWDMA* and ATA_SWDMA* defines

2007-08-27 Thread Bartlomiej Zolnierkiewicz
Cc: Jeff Garzik [EMAIL PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- include/linux/ata.h | 13 + 1 file changed, 13 insertions(+) Index: b/include/linux/ata.h === --- a/include/linux/ata.h

[PATCH 10/8] ide: add -mwdma_mask and -swdma_mask to ide_pci_device_t

2007-08-27 Thread Bartlomiej Zolnierkiewicz
masks. While at it: * Use ATA_{UDMA,MWDMA,SWDMA}* defines. * hpt34x.c: add separate ide_pci_device_t instances for HPT343 and HPT345. * serverworks.c: fix DMA masks being set before checking DMA base. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- Yes, you guessed right! patch #10

Re: [PATCH 2.6.23-rc3] pata_pdc2027x: PLL detection fixes

2007-08-24 Thread Bartlomiej Zolnierkiewicz
On Friday 24 August 2007, Sergei Shtylyov wrote: Hello. Albert Lee wrote: b) puts more work [the enter test mode stuff] in between the start and and sampling points, reducing the precision of the PLL detection; I actually observed quite noticeable differences in detected PLL

Re: [PATCH] ide: fix PCI refcounting

2007-08-21 Thread Bartlomiej Zolnierkiewicz
On Saturday 18 August 2007, Sergei Shtylyov wrote: The IDE core never marked the PCI IDE devices as being in use after succesfull driver probe call (the devices were marked in use only while being probed), and so was susceptible to issues caused by unsolicited PCI hotplug device removal. So,

Re: [PATCH 1/4] ide: add ide_dev_is_sata() helper

2007-08-21 Thread Bartlomiej Zolnierkiewicz
On Sunday 19 August 2007, Sergei Shtylyov wrote: Make the SATA drive detection code from eighty_ninty_three() into inline ide_dev_is_sata() helper fixing it along the way to be more strict while checking word 80 for the reserved values... Signed-off-by: Sergei Shtylyov [EMAIL PROTECTED]

Re: [PATCH 2/4] hpt366: UltraDMA filter for SATA cards (take 2)

2007-08-21 Thread Bartlomiej Zolnierkiewicz
On Sunday 19 August 2007, Sergei Shtylyov wrote: The Marvell bridge chips used on HighPoint SATA cards do not seem to support the UltraDMA modes 1, 2, and 3 as well as any MWDMA modes, so the driver needs to account for this in the udma_filter() method. In order to achieve that, do the

[git patches] IDE fixes

2007-08-20 Thread Bartlomiej Zolnierkiewicz
|4 +- 15 files changed, 113 insertions(+), 74 deletions(-) Bartlomiej Zolnierkiewicz (12): ide: fix hidden dependencies on CONFIG_IDE_GENERIC ide-cris: fix -set_pio_mode method to set transfer mode on the device ide: config_drive_for_dma() fixes ide-pmac

[PATCH 1/7] ide: use PCI_VDEVICE() macro

2007-08-18 Thread Bartlomiej Zolnierkiewicz
While at it: - make struct pci_device_id tables const - use PCI_DEVICE_ID_ITE_8213 define in it8213.c - fix comment in generic.c Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/pci/aec62xx.c | 12 - drivers/ide/pci/alim15x3.c |6 ++-- drivers

[PATCH 2/7] ide: remove CONFIG_BLK_DEV_IDEDMA_FORCED

2007-08-18 Thread Bartlomiej Zolnierkiewicz
This code doesn't use pci_assign_resource() and ide_get_or_set_dma_base() uses pci_resource_start() to get DMA base address so it has no chance of working. Moreover this belongs to PCI quirks (in case somebody would like to fix it). Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED

[PATCH 7/7] ide: add DECLARE_GENERIC_PCI_DEV() macro to generic IDE PCI host driver

2007-08-18 Thread Bartlomiej Zolnierkiewicz
* Add DECLARE_GENERIC_PCI_DEV() macro to generic IDE PCI host driver and use it to cleanup generic_chipsets[]. * Remove dead/obsolete code while at it. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/pci/generic.c | 113

[PATCH 5/7] ide: add hdx=nodma kernel parameter

2007-08-18 Thread Bartlomiej Zolnierkiewicz
* Add hdx=nodma option allowing user to disallow DMA for a given device. * Obsolete ide=nodma option. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- Documentation/ide.txt |4 ++-- drivers/ide/ide-dma.c |2 +- drivers/ide/ide.c |7 +-- include/linux/ide.h

[PATCH 3/7] ide: remove idex=dma kernel parameter

2007-08-18 Thread Bartlomiej Zolnierkiewicz
It has been obsoleted since 1 Nov 2004, is valid only when used together with ide=nodma kernel parameter (which makes no sense) and only for aec62xx, cmd64x, cs5220, generic, hpt366, sl82c105, tc86c001 and triflex host drivers. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED

[PATCH 6/7] ide: remove CONFIG_IDEDMA_ONLYDISK

2007-08-18 Thread Bartlomiej Zolnierkiewicz
ATAPI devices with broken DMA support should be handled by DMA blacklist and for debugging purposes we have new shiny hdx=nodma kernel paremeter. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/Kconfig | 10 -- drivers/ide/ide-probe.c |5 + 2

Re: [PATCH 1/8] alim15x3: PIO fallback fix

2007-08-18 Thread Bartlomiej Zolnierkiewicz
On Saturday 18 August 2007, you wrote: Bartlomiej Zolnierkiewicz wrote: [PATCH] alim15x3: PIO fallback fix If DMA tuning fails always set the best PIO mode. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] Oh, it's

Re: [PATCH 2/2] hpt366: UltraDMA filtering for SATA cards

2007-08-18 Thread Bartlomiej Zolnierkiewicz
On Saturday 11 August 2007, Sergei Shtylyov wrote: Hello, I wrote: 101 files changed, 1880 insertions(+), 2828 deletions(-) please look at -mm or IDE quilt tree instead. :) Looking... When are you planning to push out to Linus the

Re: [PATCH 2/2] hpt366: UltraDMA filtering for SATA cards

2007-08-11 Thread Bartlomiej Zolnierkiewicz
On Saturday 11 August 2007, Sergei Shtylyov wrote: Hello. Bartlomiej Zolnierkiewicz wrote: Index: linux-2.6/drivers/ide/pci/hpt366.c === --- linux-2.6.orig/drivers/ide/pci/hpt366.c +++ linux-2.6/drivers/ide/pci/hpt366.c

Re: [PATCH 1/2] hpt366: fix PCI clock detection for HPT374

2007-08-11 Thread Bartlomiej Zolnierkiewicz
On Saturday 11 August 2007, Sergei Shtylyov wrote: Bartlomiej Zolnierkiewicz wrote: + if (chip_type == HPT374 (PCI_FUNC(dev-devfn) 1)) { + struct pci_dev *dev1 = pci_get_slot(dev-bus, +dev

Re: [PATCH 1/2] hpt366: fix PCI clock detection for HPT374

2007-08-11 Thread Bartlomiej Zolnierkiewicz
On Saturday 11 August 2007, Sergei Shtylyov wrote: Bartlomiej Zolnierkiewicz wrote: + if (chip_type == HPT374 (PCI_FUNC(dev-devfn) 1)) { + struct pci_dev *dev1 = pci_get_slot(dev-bus, + dev-devfn

Re: [PATCH 3/11] au1xxx-ide: use ide_tune_dma()

2007-08-11 Thread Bartlomiej Zolnierkiewicz
On Saturday 11 August 2007, you wrote: Bartlomiej Zolnierkiewicz wrote: Good, that's what I lacked for hpt366.c! Were you planning to push it to Linus soon? Not really but if needed I will extract MWDMA filter part and push it sooner. Erm, may I just merge it to my patch

Re: [PATCH 2/2] hpt366: UltraDMA filtering for SATA cards

2007-08-11 Thread Bartlomiej Zolnierkiewicz
On Saturday 11 August 2007, Sergei Shtylyov wrote: Bartlomiej Zolnierkiewicz wrote: Index: linux-2.6/drivers/ide/pci/hpt366.c === --- linux-2.6.orig/drivers/ide/pci/hpt366.c +++ linux-2.6/drivers/ide/pci/hpt366.c

Re: [PATCH 1/2] hpt366: fix PCI clock detection for HPT374

2007-08-11 Thread Bartlomiej Zolnierkiewicz
On Saturday 11 August 2007, Sergei Shtylyov wrote: Bartlomiej Zolnierkiewicz wrote: + if (chip_type == HPT374 (PCI_FUNC(dev-devfn) 1)) { + struct pci_dev *dev1 = pci_get_slot(dev-bus, +dev-devfn - 1

Re: [PATCH] pata_cmd64x: Set up MWDMA modes properly

2007-08-11 Thread Bartlomiej Zolnierkiewicz
On Saturday 11 August 2007, Sergei Shtylyov wrote: Hello. Alan Cox wrote: Set the MWDMA timing by updating the correct registers. Split the PIO path as this is mostly shared code. Wants testing. Cool! So much simpler than my fix to the old IDE driver... Signed-off-by: Alan Cox

Re: [PATCH 2/2] hpt366: UltraDMA filtering for SATA cards

2007-08-10 Thread Bartlomiej Zolnierkiewicz
Hi, On Friday 10 August 2007, Sergei Shtylyov wrote: Bartlomiej Zolnierkiewicz wrote: The Marvell bridge chips used on HighPoint SATA cards do not seem to support the UltraDMA modes 1, 2, and 3 (as well as any MWDMA modes), so the driver needs to account for this in the udma_filter

Re: [PATCH 1/2] hpt366: fix PCI clock detection for HPT374

2007-08-10 Thread Bartlomiej Zolnierkiewicz
On Friday 10 August 2007, Sergei Shtylyov wrote: Alan Cox wrote: + if (chip_type == HPT374 (PCI_FUNC(dev-devfn) 1)) { + struct pci_dev *dev1 = pci_get_slot(dev-bus, + dev-devfn - 1); Can be NULL Not

Re: [PATCH 3/11] au1xxx-ide: use ide_tune_dma()

2007-08-10 Thread Bartlomiej Zolnierkiewicz
On Friday 10 August 2007, Sergei Shtylyov wrote: Bartlomiej Zolnierkiewicz wrote: Good, that's what I lacked for hpt366.c! Were you planning to push it to Linus soon? Not really but if needed I will extract MWDMA filter part and push it sooner. Erm, may I just merge

[PATCH 1/4] ide: fix hidden dependencies on CONFIG_IDE_GENERIC

2007-08-09 Thread Bartlomiej Zolnierkiewicz
. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- arch/cris/arch-v10/drivers/Kconfig |1 + arch/cris/arch-v32/drivers/Kconfig |1 + drivers/ide/Kconfig|9 + 3 files changed, 11 insertions(+) Index: b/arch/cris/arch-v10/drivers/Kconfig

[PATCH 2/4] it8213/piix/slc90e66: de-couple PIO and UDMA modes

2007-08-09 Thread Bartlomiej Zolnierkiewicz
Don't force PIO4 when programming UDMA mode (suggested by Sergei). Cc: Sergei Shtylyov [EMAIL PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/pci/it8213.c |9 - drivers/ide/pci/piix.c | 11 +-- drivers/ide/pci/slc90e66.c | 10

[PATCH 3/4] sis5513: clear prefetch and postwrite for ATAPI devices

2007-08-09 Thread Bartlomiej Zolnierkiewicz
Clear prefetch and postwrite for ATAPI devices instead of depending on BIOS. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/pci/sis5513.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) Index: b/drivers/ide/pci/sis5513.c

<    3   4   5   6   7   8   9   10   11   12   >