two bugs:
- wrong cable bit was checked (0x0001 instead of 0x8000) on ATA_133 chipsets
- incorrect UDMA cycle time was reported on ATA_100a/ATA_133 chipsets
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED]
---
drivers/ide/pci/sis5513.c | 249
While at it:
On Sunday 05 August 2007, Sergei Shtylyov wrote:
Index: linux-2.6/drivers/ata/pata_hpt37x.c
===
--- linux-2.6.orig/drivers/ata/pata_hpt37x.c
+++ linux-2.6/drivers/ata/pata_hpt37x.c
@@ -8,12 +8,10 @@
this driver
present in IDE aec62xx driver.
Cc: Alan Cox [EMAIL PROTECTED]
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED]
---
drivers/ata/pata_artop.c | 19 ++-
1 file changed, 14 insertions(+), 5 deletions(-)
Index: b/drivers/ata/pata_artop.c
On Friday 10 August 2007, Alan Cox wrote:
On Thu, 9 Aug 2007 23:19:34 +0200
Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] wrote:
Maximum supported UDMA mode for AEC6280[R] is UDMA5 (not UDMA4)
and for AEC6880[R] it is UDMA6 (not UDMA5):
* Fix the problem by adding missing struct
On Sunday 05 August 2007, Sergei Shtylyov wrote:
HPT374 BIOS seems to only save f_CNT register value for the function #0 before
re-tuning DPLL causing the driver to report obviously distorted f_CNT for the
function #1 -- fix this by always reading the saved f_CNT register value from
in the
On Sunday 05 August 2007, Sergei Shtylyov wrote:
The Marvell bridge chips used on HighPoint SATA cards do not seem to support
the UltraDMA modes 1, 2, and 3 (as well as any MWDMA modes), so the driver
needs to account for this in the udma_filter() method. In order to achieve
that, do the
On Monday 06 August 2007, Sergei Shtylyov wrote:
Bartlomiej Zolnierkiewicz wrote:
Good, that's what I lacked for hpt366.c! Were you planning to push it to
Linus soon?
Not really but if needed I will extract MWDMA filter part and push it sooner.
* Add -mdma_filter to ide_hwif_t
On Monday 06 August 2007, Sergei Shtylyov wrote:
Bartlomiej Zolnierkiewicz wrote:
Index: b/drivers/ide/arm/icside.c
===
--- a/drivers/ide/arm/icside.c
+++ b/drivers/ide/arm/icside.c
@@ -309,14 +309,6 @@ static int
commit 0fc4969b866671dfe39b1a9119d0fdc7ea0f63e5
I doubt that this particular report helps in debugging ne2k-pci problem...
;)
On Saturday 04 August 2007, Andrey Borzenkov wrote:
Just noticed this; I do not remember having seen it before, but I also do not
check dmesg every time after
commit 0fc4969b866671dfe39b1a9119d0fdc7ea0f63e5
Linus, please revert it.
On Sunday 05 August 2007, Mikael Pettersson wrote:
This is on a sparc64 ultra5 with a rev 3 CMD646. Starting with kernel
2.6.23-rc2, each boot triggers a WARNING from kernel/irq/resend.c:
Uniform Multi-Platform E-IDE
On Thursday 02 August 2007, Shaohua Li wrote:
ACPI spec defines the sequence of IDE power on/off:
Powering down:
Call _GTM.
Power down drive (calls _PS3 method and turns off power planes).
Powering up:
Power up drive (calls _PS0 method if present and turns on power planes).
controller/device if the
device was ide_floppy).
Cc: Benjamin Herrenschmidt [EMAIL PROTECTED]
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED]
---
Ben, any update on the testing status of ide-pmac series?
I also merged your patch to my tree but it is lacking description:
http://kernel.org
by atiixp_set_dma_mode() and if SWDMA
mode is chosen atiixp_dma_host_on() erroneously enables UDMA, just disable
support for SWDMA modes for now.
* Enable support for MWDMA0 mode.
* Bump driver version.
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED]
---
drivers/ide/pci/atiixp.c | 53
bit not being checked
- device not being checked against generic DMA blacklist
- transfer mode not being set on device/host
* Add PIO autotune fallback to auide_dma_check().
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED]
---
drivers/ide/ide-dma.c |3 +++
drivers/ide
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED]
---
drivers/ide/pci/it8213.c | 44 +++-
drivers/ide/pci/piix.c | 44 +++-
drivers/ide/pci/slc90e66.c | 33 +++--
3
-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED]
---
drivers/ide/pci/hpt34x.c |6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
Index: b/drivers/ide/pci/hpt34x.c
===
--- a/drivers/ide/pci/hpt34x.c
+++ b/drivers/ide/pci
Several host drivers used to reset drive-init_speed in their -ide_dma_check
implementations which resulted in incorrect init speed being reported to the
user, fix it.
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED]
---
drivers/ide/pci/alim15x3.c |2 --
drivers/ide/pci
-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED]
---
drivers/ide/ide-lib.c | 15 ---
drivers/ide/pci/aec62xx.c |3 +--
drivers/ide/pci/atiixp.c |3 +--
drivers/ide/pci/cmd64x.c |3 +--
drivers/ide/pci/cs5535.c |3 +--
drivers/ide/pci
-ide_dma_check to return -1 if DMA cannot be set.
* Bump driver version.
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED]
---
drivers/ide/pci/cs5530.c |6 --
drivers/ide/pci/sc1200.c |6 --
2 files changed, 8 insertions(+), 4 deletions(-)
Index: b/drivers/ide/pci
-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED]
---
drivers/ide/ppc/pmac.c |2 ++
1 file changed, 2 insertions(+)
Index: b/drivers/ide/ppc/pmac.c
===
--- a/drivers/ide/ppc/pmac.c
+++ b/drivers/ide/ppc/pmac.c
@@ -1587,6 +1587,8
Since sl82c105 re-programs DMA/PIO timings for DMA enable/disable, and sets
-autotune this change shouldn't have any other effect than bringing sl82c105
driver in-line with other host drivers wrt -ide_dma_check implementation.
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED
config_drive_for_dma().
* Make ide_tune_dma() static.
There should be no functionality changes caused by this patch.
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED]
---
drivers/ide/arm/icside.c |9 --
drivers/ide/cris/ide-cris.c| 12
drivers/ide/ide-dma.c
Since ide-cris allows separate PIO and DMA timings, and ide-cris always sets
-autotune this change shouldn't have any other effect than bringing ide-cris
driver in-line with other host drivers wrt -ide_dma_check implementation.
Cc: Mikael Starvik [EMAIL PROTECTED]
Signed-off-by: Bartlomiej
Hi,
On Saturday 28 July 2007, Sergei Shtylyov wrote:
Hello.
Bartlomiej Zolnierkiewicz wrote:
On Fri, 27 Jul 2007 02:22:27 +0200
Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] wrote:
* Convert {ide_hwif_t,ide_pci_device_t}-host_flag to be u16.
* Add IDE_HFLAG_POST_SET_MODE host
On Saturday 04 August 2007, Alan Cox wrote:
On Fri, 3 Aug 2007 20:28:39 +0200 (MEST)
Mikael Pettersson [EMAIL PROTECTED] wrote:
The machine is an Athlon64 laptop with a K8T800 chipset. With the IDE
VIA driver the disk is detected as udma/100:
Currently old IDE via driver has a hack in
On Thursday 02 August 2007, Alan Cox wrote:
Additionally fs/partitions/check.c:rescan_partitions() should warn if the
partition exceeds device size and we are not seeing any such warning.
Why would it if there isn't anything wrong ?
Look at the __generic_make_requests() snippet (which was
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED]
---
drivers/ide/pci/sc1200.c |5 -
1 file changed, 4 insertions(+), 1 deletion(-)
Index: b/drivers/ide/pci/sc1200.c
===
--- a/drivers/ide/pci/sc1200.c
+++ b/drivers
Cc: Mikael Starvik [EMAIL PROTECTED]
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED]
---
drivers/ide/cris/ide-cris.c |2 ++
1 file changed, 2 insertions(+)
Index: b/drivers/ide/cris/ide-cris.c
===
--- a/drivers/ide
Hi,
On Monday 30 July 2007, Sergei Shtylyov wrote:
Hello.
Bartlomiej Zolnierkiewicz wrote:
* Move ide_in_drive_list() from ide-dma.c to ide-iops.c.
* Add ivb_list[] table for listening early UDMA66 devices which don't
conform
to ATA4 standard wrt cable detection (bit14 is zero
.
Thanks to Mikko for investigating the issue and testing this patch.
v2:
* Add missing export and improve patch description a bit.
Cc: Mikko Rapeli [EMAIL PROTECTED]
Cc: Alan Cox [EMAIL PROTECTED]
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED]
---
This patch depends
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED]
---
drivers/ide/pci/slc90e66.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
Index: b/drivers/ide/pci/slc90e66.c
===
--- a/drivers/ide/pci/slc90e66.c
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED]
---
drivers/ide/pci/aec62xx.c |8
1 file changed, 4 insertions(+), 4 deletions(-)
Index: b/drivers/ide/pci/aec62xx.c
===
--- a/drivers/ide/pci/aec62xx.c
+++ b
-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED]
---
drivers/ide/pci/sis5513.c | 214 ++
1 file changed, 106 insertions(+), 108 deletions(-)
Index: b/drivers/ide/pci/sis5513.c
===
--- a/drivers
Hi,
On Wednesday 01 August 2007, Sergei Shtylyov wrote:
Does this patch change anything?
Heh, did you *really* hope it will? :-D
Well, ugh, yes? :)
[PATCH] hpt366: always tune PIO
Index: b/drivers/ide/pci/hpt366.c
On Sunday 29 July 2007, Meelis Roos wrote:
Fix a couple of runtogether printks in cmd64x.c IDE driver by adding
proper newlines.
Signed-off-by: Meelis Roos [EMAIL PROTECTED]
applied
-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the body of a message to [EMAIL
On Wednesday 01 August 2007, Sergei Shtylyov wrote:
Bartlomiej Zolnierkiewicz wrote:
On Wednesday 01 August 2007, Sergei Shtylyov wrote:
Does this patch change anything?
Heh, did you *really* hope it will? :-D
Well, ugh, yes? :)
Here we have some really nasty screw-up I'm
++-
drivers/ide/pci/sis5513.c |1 +
drivers/ide/pci/slc90e66.c | 15 +--
drivers/scsi/ide-scsi.c| 10 +++
13 files changed, 85 insertions(+), 128 deletions(-)
Bartlomiej Zolnierkiewicz (7):
alim15x3: Correct HP detect
cs5520: fix PIO auto-tuning
On Thursday 02 August 2007, Alan Cox wrote:
If you fix the printk, add patch description (can use the one from my patch)
and add Signed-off-by: I would happily apply it and dump mine version.
Sorry but the patch is wrong - plain and simple. It works over the bug
but its not the real
On Thursday 02 August 2007, Bartlomiej Zolnierkiewicz wrote:
Otherwise this patch looks fine and is a bit simpler than my patch.
If you fix the printk, add patch description (can use the one from my patch)
and add Signed-off-by: I would happily apply it and dump mine version.
On the second
timings setup
* Fix typos in sis_100_set_piomode() and sis_133_set_piomode() comments.
* Bump driver version.
Cc: Alan Cox [EMAIL PROTECTED]
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED]
---
Sergei: Yes, I'm working on sis5513 IDE driver. :)
drivers/ata/pata_sis.c | 20
.
pata_hpt37x: BIOS has not set timing clocks.
hpt37x: DPLL did not stabilize.
Does this patch change anything?
[PATCH] hpt366: always tune PIO
Cc: Sergei Shtylyov [EMAIL PROTECTED]
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED]
---
drivers/ide/pci/hpt366.c |8
1 file
Hi,
On Sunday 29 July 2007, Sergei Shtylyov wrote:
Bartlomiej Zolnierkiewicz wrote:
* Check ide_config_drive_speed() return value.
* While at also call ide_config_drive_speed() if the transfer mode is
XFER_PIO_SLOW (this case happens iff the transfer mode has already been
set
On Sunday 29 July 2007, Sergei Shtylyov wrote:
Bartlomiej Zolnierkiewicz wrote:
Ok, there's a combination of things here:
- First, doing a set_pio from userland (hdparm -p XX) causes the kernel
to disable DMA, which I think is incorrect. It's not the case with
2.6.22 from my quick tests
]
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED]
---
- no other changes besides fixed printk, no need to retest
- replacement patch for the one in the IDE quilt tree
drivers/ide/ide-dma.c | 19 ---
drivers/ide/ide-iops.c | 39
Need to probe slave device first to make it release PDIAG-
(this is required for correct device side cable detection).
Based on libata commit f31f0cc2f0b7527072d94d02da332d9bb8d7d94c.
Thanks to Craig for testing this patch.
Cc: Craig Block [EMAIL PROTECTED]
Signed-off-by: Bartlomiej
Devices which don't set word 93 validation bit should be now handled by
ide-iops.c::ivb_list[] and for debugging purposes cable detection can be
completely overriden with idex=ata66 parameter.
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED]
---
drivers/ide/Kconfig| 16
On Tuesday 24 July 2007, Sergei Shtylyov wrote:
Hello.
Bartlomiej Zolnierkiewicz wrote:
[PATCH] ide: add cable detection for early UDMA66 devices
* Move ide_in_drive_list() from ide-dma.c to ide-iops.c.
* Add ivb_list[] table for listening early UDMA66 devices which don't
If -dma_base is not set (== PCI BAR4 cannot be reserved) then DMA hooks
shouldn't be initialized or bad things will happen.
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED]
---
drivers/ide/pci/cs5535.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
Index: b
If -dma_base is not set (== PCI BAR4 cannot be reserved) then DMA hooks
shouldn't be initialized or bad things will happen.
Also this host driver requires valid PCI BAR4 for normal operation so
check it in -init_chipset and fail initialization if not set.
Signed-off-by: Bartlomiej
If -dma_base is not set (== PCI BAR4 cannot be reserved) then DMA hooks
shouldn't be initialized or bad things will happen.
Also this host driver requires valid PCI BAR4 for normal operation so
check it in -init_chipset and fail initialization if not set.
Signed-off-by: Bartlomiej
If -dma_base is not set (== PCI BAR4 cannot be reserved) then DMA hooks
shouldn't be initialized or bad things will happen.
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED]
---
drivers/ide/pci/pdc202xx_old.c |9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
Index: b
If -dma_base is not set (== PCI BAR4 cannot be reserved) then DMA hooks
shouldn't be initialized or bad things will happen.
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED]
---
drivers/ide/pci/sgiioc4.c | 16 ++--
1 file changed, 10 insertions(+), 6 deletions(-)
Index
If -dma_base is not set (== PCI BAR4 cannot be reserved) then DMA hooks
shouldn't be initialized or bad things will happen.
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED]
---
drivers/ide/pci/triflex.c |3 +++
1 file changed, 3 insertions(+)
Index: b/drivers/ide/pci/triflex.c
Set hwif-ide_dma_{check,on} and hwif-autodma to 1 after checking that
-dma_base exists. If -dma_base is not set (== PCI BAR4 cannot be reserved)
then DMA hooks shouldn't be initialized or bad things will happen.
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED]
---
drivers/ide/pci
.
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED]
---
drivers/ide/pci/sc1200.c | 24 ++--
1 file changed, 14 insertions(+), 10 deletions(-)
Index: b/drivers/ide/pci/sc1200.c
===
--- a/drivers/ide/pci
init_dma_ali15x3() guarantees that hwif-dma_base will never be set for
m5229_revision 0x20 so remove redundant m5229_revision = 0x20 check from
init_hwif_common_ali15x3().
While at it remove incorrect comment.
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED]
---
drivers/ide/pci
Cc: Sergei Shtylyov [EMAIL PROTECTED]
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED]
---
Should be right thing to do nowadays?
drivers/ide/pci/hpt366.c |8
1 file changed, 4 insertions(+), 4 deletions(-)
Index: b/drivers/ide/pci/hpt366.c
On Friday 27 July 2007, Alan Cox wrote:
On Fri, 27 Jul 2007 02:22:27 +0200
Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] wrote:
* Convert {ide_hwif_t,ide_pci_device_t}-host_flag to be u16.
* Add IDE_HFLAG_POST_SET_MODE host to indicate the need to program the
host for the transfer
Jul 9 23:17:57 2007 +0200
ide-cd: replace C code with call to ARRAY_SIZE() macro
Delete the unnecessary macro ARY_LEN and use ARRAY_SIZE directly.
Signed-off-by: Robert P. J. Day [EMAIL PROTECTED]
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED]
Please always make sure
On Thursday 26 July 2007, Sergei Shtylyov wrote:
Bartlomiej Zolnierkiewicz wrote:
Set transfer mode on the device before programming the host controller for
the new timings (matches what auide_tune_chipset() is doing wrt DMA modes).
It's not that the most other drives are doing
On Thursday 26 July 2007, Sergei Shtylyov wrote:
Bartlomiej Zolnierkiewicz wrote:
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED]
Acked-by: Sergei Shtylyov [EMAIL PROTECTED]
added
-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the body of a message
On Saturday 28 July 2007, Tejun Heo wrote:
These days, CONFIG_IDE_GENERIC causes more confusion and
misconfiguration than it helps. Especially so because libata is
linked after the generic driver. Default to N.
Signed-off-by: Tejun Heo [EMAIL PROTECTED]
applied and Jeff's ACK added,
Direct port of Alan's fix for pata_ali.
Cc: Alan Cox [EMAIL PROTECTED]
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED]
---
drivers/ide/pci/alim15x3.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: b/drivers/ide/pci/alim15x3.c
On Thursday 26 July 2007, Sergei Shtylyov wrote:
Bartlomiej Zolnierkiewicz wrote:
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED]
Acked-by: Sergei Shtylyov [EMAIL PROTECTED]
added
-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the body of a message
On Friday 27 July 2007, Michal Piotrowski wrote:
IDE
Subject : ide problems: 2.6.22-git17 working, 2.6.23-rc1* is not
References : http://lkml.org/lkml/2007/7/27/298
Last known good : ?
Submitter : dth [EMAIL PROTECTED]
Caused-By : ?
Handled-By : ?
Status
On Wednesday 25 July 2007, Alan Cox wrote:
pata_platform and ide_platform are carrying same driver names,
to easily switch between these drivers, without need to touch
platform code.
Signed-off-by: Anton Vorontsov [EMAIL PROTECTED]
Signed-off-by: Vitaly Bordug [EMAIL PROTECTED]
On Tuesday 24 July 2007, Benjamin Herrenschmidt wrote:
On Tue, 2007-07-24 at 00:29 +0200, Bartlomiej Zolnierkiewicz wrote:
Use ide_config_drive_speed() instead of pmac_ide_do_setfeature() and remove
the latter, also ide-iops.c::__ide_wait_stat() could be static again.
Since for IDE PMAC
Hi,
On Wednesday 18 July 2007, Andrey Borzenkov wrote:
May be I miss something obvious but most information that was available
in /proc/ide is missing under /sys. At the very least, Mandriva hardware
detection expects /proc/ide/hdX/model; nothing close is under /sys.
It is really better to
}_speed.
* Bump driver version.
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED]
---
drivers/ide/pci/amd74xx.c | 10 +++---
drivers/ide/pci/via82cxxx.c | 10 +++---
2 files changed, 6 insertions(+), 14 deletions(-)
Index: b/drivers/ide/pci/amd74xx.c
On Friday 27 July 2007, Bartlomiej Zolnierkiewicz wrote:
* Add IDE_HFLAG_POST_SET_MODE host to indicate the need to program the
host for the transfer mode after programming the device. Set it in
au1xxx-ide/cs5530/cs5535/pdc202xx_new/sc1200/via82cxxx host drivers.
and amd74xx
Hi,
On Thursday 26 July 2007, Guennadi Liakhovetski wrote:
On Wed, 25 Jul 2007, Alan Cox wrote:
driver to using platform-device. I got a reply, that it's not worth it
now
that IDE is slowly becoming obsolete, and the pata_platform serves the
perpose perfectly well. I found this
Hi,
On Wednesday 25 July 2007, Vitaly Bordug wrote:
This is now very similar to pata_platform.c, they both use
same platform data structure and same resources.
To achieve that, byte_lanes_swapping platform data variable
and platform specified iops removed from that driver. It's fine,
icside_set_speed() (v3 got it wrong and 1 was returned instead).
v5:
* Return -1/0 in icside_set_speed() instead of icside_dma_check() return
value (just like it was before this patch).
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED]
Cc: Russell King [EMAIL PROTECTED]
Cc: Sergei
Set transfer mode on the device before programming the host controller for
the new timings (matches what auide_tune_chipset() is doing wrt DMA modes).
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED]
---
drivers/ide/mips/au1xxx-ide.c |7 +++
1 file changed, 3 insertions(+), 4
On Friday 27 July 2007, Bartlomiej Zolnierkiewicz wrote:
On Friday 27 July 2007, Bartlomiej Zolnierkiewicz wrote:
* Add IDE_HFLAG_POST_SET_MODE host to indicate the need to program the
host for the transfer mode after programming the device. Set it in
au1xxx-ide/cs5530/cs5535
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED]
---
drivers/ide/pci/cs5535.c |8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
Index: b/drivers/ide/pci/cs5535.c
===
--- a/drivers/ide/pci/cs5535.c
+++ b
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED]
---
drivers/ide/pci/pdc202xx_new.c |6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
Index: b/drivers/ide/pci/pdc202xx_new.c
===
--- a/drivers/ide/pci
Hi,
On Tuesday 24 July 2007, Jordan Crouse wrote:
The Coverity checker spotted the following array overrun in
drivers/ide/pci/cs5535.c:
-- snip --
if (speed = XFER_UDMA_0 speed = XFER_UDMA_7)
reg |= cs5535_udma_timings[speed - XFER_UDMA_0];
Not a bug per se since
On Wednesday 25 July 2007, Bartlomiej Zolnierkiewicz wrote:
Hi,
On Wednesday 25 July 2007, Michal Piotrowski wrote:
Hi,
On 24/07/07, Eric Sesterhenn / Snakebyte [EMAIL PROTECTED] wrote:
hi,
seems like the clock got screwed or something similar. During bootup the
computer
On Sunday 22 July 2007, Benjamin Herrenschmidt wrote:
On Sun, 2007-07-22 at 20:19 +0200, Bartlomiej Zolnierkiewicz wrote:
pmac_ide_tune_chipset() don't set drive-init_speed.
Fix it by setting drive-{current,init}_speed in pmac_ide_do_setfeature()
and clean up pmac_ide_{tune_chipset
On Sunday 22 July 2007, Benjamin Herrenschmidt wrote:
On Sun, 2007-07-22 at 20:20 +0200, Bartlomiej Zolnierkiewicz wrote:
kauai_lookup_timing() should always return non-zero return value:
* BUG() in kauai_lookup_timing() if the timing info cannot be found.
* Remove code checking
On Sunday 22 July 2007, Benjamin Herrenschmidt wrote:
On Sun, 2007-07-22 at 20:21 +0200, Bartlomiej Zolnierkiewicz wrote:
* Don't check check for pmif == NULL (it should never be NULL if we got
here).
* Make a local copy of the timings and set the pmif-timings[] only after
setting
On Sunday 22 July 2007, Benjamin Herrenschmidt wrote:
On Sun, 2007-07-22 at 20:22 +0200, Bartlomiej Zolnierkiewicz wrote:
* Move adjusting of cycle time for devices providing explicit DMA cycle time
from pmac_ide_mdma_enable() to set_timings_mdma().
* Remove no longer needed
by this patch.
v2:
* Fix compile by replacing id with drive-id in pmac_ide_dma_check()
(Noticed by Ben).
Cc: Benjamin Herrenschmidt [EMAIL PROTECTED]
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED]
---
replacement patch
drivers/ide/ppc/pmac.c | 103
On Monday 23 July 2007, Benjamin Herrenschmidt wrote:
On Sun, 2007-07-22 at 20:33 +0200, Bartlomiej Zolnierkiewicz wrote:
* Use __ide_wait_stat() instead of wait_for_ready() in
pmac_ide_do_setfeature().
While at it do following changes to match __ide_wait_stat() call
On Sunday 22 July 2007, Sergei Shtylyov wrote:
Hello.
Bartlomiej Zolnierkiewicz wrote:
* Use -OUTBSYNC instead of -OUTB when writing command register
(needed for scc_pata and pmac host drivers).
* Don't check DRDY bit of the status register on ATAPI devices
(ATAPI devices
Hi,
Thanks for reviewing and testing this patch series.
On Monday 23 July 2007, Benjamin Herrenschmidt wrote:
Ok, there's a combination of things here:
- First, doing a set_pio from userland (hdparm -p XX) causes the kernel
to disable DMA, which I think is incorrect. It's not the
On Monday 23 July 2007, Sergei Shtylyov wrote:
Hello.
Bartlomiej Zolnierkiewicz wrote:
* Split off checking of the status register from ide_wait_stat() to
__ide_wait_stat() helper.
* Use the new helper in ide_config_drive_speed(). The only change in the
functionality
On Sunday 22 July 2007, Sergei Shtylyov wrote:
Bartlomiej Zolnierkiewicz wrote:
Upper layers are responsible for controlling nIEN so don't clear nIEN after
command execution in pmac_ide_do_setfeature().
Cc: Benjamin Herrenschmidt [EMAIL PROTECTED]
Signed-off-by: Bartlomiej
Hi,
On Sunday 22 July 2007, Sergei Shtylyov wrote:
Bartlomiej Zolnierkiewicz wrote:
Use -set_pio_mode method to program PIO modes in ide_set_xfer_rate()
(the only place which used -speedproc to program PIO modes) and remove
handling of PIO modes from all -speedproc implementations
]
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED]
---
drivers/ide/ide-io.c | 10 +-
drivers/ide/ide-iops.c |2 -
drivers/ide/ppc/pmac.c | 80 +
include/linux/ide.h|6 +++
4 files changed, 18 insertions(+), 80 deletions
unnecessary drive-using_dma fiddling (-dma_off_quietly is always
called before ide_set_dma() call and ide_set_dma() calls -ide_dma_on if
-ide_dma_check returns 0).
Cc: Benjamin Herrenschmidt [EMAIL PROTECTED]
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED]
---
bonus patch
icside_set_speed() (v3 got it wrong and 1 was returned instead).
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED]
Cc: Russell King [EMAIL PROTECTED]
Cc: Sergei Shtylyov [EMAIL PROTECTED]
---
replacement patch for the one in IDE quilt tree
drivers/ide/arm/icside.c | 21
pmac_ide_tune_chipset() don't set drive-init_speed.
Fix it by setting drive-{current,init}_speed in pmac_ide_do_setfeature()
and clean up pmac_ide_{tune_chipset,mdma_enable,udma_enable}().
Cc: Benjamin Herrenschmidt [EMAIL PROTECTED]
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED
patch.
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED]
Cc: Benjamin Herrenschmidt [EMAIL PROTECTED]
Cc: Sergei Shtylyov [EMAIL PROTECTED]
---
replacement patch for the one in IDE quilt tree
drivers/ide/ppc/pmac.c | 15 ++-
1 file changed, 10 insertions(+), 5 deletions
kauai_lookup_timing() should always return non-zero return value:
* BUG() in kauai_lookup_timing() if the timing info cannot be found.
* Remove code checking for zero return value from all callers.
Cc: Benjamin Herrenschmidt [EMAIL PROTECTED]
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL
the transfer mode
is set on the device - this was pointed out by Sergei). This change makes
pmac_ide_tune_chipset() behavior match this of pmac_ide_{m,u}dma_enable().
Cc: Benjamin Herrenschmidt [EMAIL PROTECTED]
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED]
---
drivers/ide/ppc/pmac.c
always exist so remove redundant check.
* Make set_timings_mdma() void.
* Update pmac_ide_tune_chipset()'s comment.
Cc: Benjamin Herrenschmidt [EMAIL PROTECTED]
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED]
---
drivers/ide/ppc/pmac.c | 40
1
pmac_ide_do_setfeature() contains matching nIEN setting/clearing so this
Device Control register messing in pmac_ide_dma_check() is totally unnecessary.
Cc: Benjamin Herrenschmidt [EMAIL PROTECTED]
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED]
---
drivers/ide/ppc/pmac.c |2
by this patch.
Cc: Benjamin Herrenschmidt [EMAIL PROTECTED]
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED]
---
drivers/ide/ppc/pmac.c | 101 -
1 file changed, 2 insertions(+), 99 deletions(-)
Index: b/drivers/ide/ppc/pmac.c
801 - 900 of 1332 matches
Mail list logo
