[PATCH 6/11] ide: ide_config_drive_speed() bugfixes

2007-07-22 Thread Bartlomiej Zolnierkiewicz
PROTECTED] Cc: Akira Gouache [EMAIL PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- this patch is independent from the previous five ide-pmac patches drivers/ide/ide-iops.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Index: b/drivers/ide/ide-iops.c

[PATCH 7/11] ide: add __ide_wait_stat() helper

2007-07-22 Thread Bartlomiej Zolnierkiewicz
: Benjamin Herrenschmidt [EMAIL PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-iops.c | 96 ++--- include/linux/ide.h| 11 - 2 files changed, 45 insertions(+), 62 deletions(-) Index: b/drivers/ide/ide

[PATCH 8/11] ide-pmac: remove extra good status wait from pmac_ide_do_setfeature()

2007-07-22 Thread Bartlomiej Zolnierkiewicz
-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ppc/pmac.c | 12 +--- 1 file changed, 1 insertion(+), 11 deletions(-) Index: b/drivers/ide/ppc/pmac.c === --- a/drivers/ide/ppc/pmac.c +++ b/drivers/ide

[PATCH 9/11] ide-pmac: use __ide_wait_stat()

2007-07-22 Thread Bartlomiej Zolnierkiewicz
for good device status). Also remove no longer needed wait_for_ready() from ide-iops.c. Cc: Benjamin Herrenschmidt [EMAIL PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-iops.c | 31 +-- drivers/ide/ppc/pmac.c |9

[PATCH 10/11] ide-pmac: remove nIEN clearing from pmac_ide_do_setfeature()

2007-07-22 Thread Bartlomiej Zolnierkiewicz
Upper layers are responsible for controlling nIEN so don't clear nIEN after command execution in pmac_ide_do_setfeature(). Cc: Benjamin Herrenschmidt [EMAIL PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ppc/pmac.c |1 - 1 file changed, 1 deletion

[PATCH 11/11] ide-pmac: remove pmac_ide_do_setfeature()

2007-07-22 Thread Bartlomiej Zolnierkiewicz
changes in behavior are: * if PIO mode is set then -dma_off_queitly is called to disable DMA * if setting transfer mode fails ide_dump_status() is called to dump status Cc: Benjamin Herrenschmidt [EMAIL PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide

Re: [PATCH 3/4] sis5513: don't change UDMA settings when programming PIO

2007-07-22 Thread Bartlomiej Zolnierkiewicz
On Friday 20 July 2007, Sergei Shtylyov wrote: Bartlomiej Zolnierkiewicz wrote: Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] added - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message

Re: [PATCH 2/4] it8213/piix/slc90e66: don't change DMA settings when programming PIO

2007-07-22 Thread Bartlomiej Zolnierkiewicz
On Friday 20 July 2007, Sergei Shtylyov wrote: Bartlomiej Zolnierkiewicz wrote: Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] added Index: b/drivers/ide/pci/it8213.c

Re: [PATCH 1/4] alim15x3: PIO mode setup fixes

2007-07-22 Thread Bartlomiej Zolnierkiewicz
On Friday 20 July 2007, Sergei Shtylyov wrote: Hi. Bartlomiej Zolnierkiewicz wrote: * Return failure in -speedproc method for unsupported/invalid transfer modes passed from user-space (fixes theoretical OOPS in ali_tune_pio() and/or setting random PIO timings on host controller

[PATCH 4/4] ide: use only -set_pio_mode method for programming PIO modes

2007-07-20 Thread Bartlomiej Zolnierkiewicz
Use -set_pio_mode method to program PIO modes in ide_set_xfer_rate() (the only place which used -speedproc to program PIO modes) and remove handling of PIO modes from all -speedproc implementations. There should be no functionality changes caused by this patch. Signed-off-by: Bartlomiej

Re: [2/2] 2.6.22-git: known regressions

2007-07-19 Thread Bartlomiej Zolnierkiewicz
-By : ? Handled-By : Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Status : unknown Not a 2.6.22-git regression (CONFIG_BLOCK was added on September 2006) and Kumar should have a fix really soon - could be removed from the list IMO. Thanks, Bart - To unsubscribe from this list: send the line

Re: compile error if CONFIG_BLOCK not enabled related to linux/ide.h include

2007-07-18 Thread Bartlomiej Zolnierkiewicz
Hi, On Wednesday 18 July 2007, Kumar Gala wrote: M: [EMAIL PROTECTED] L: linux-ide@vger.kernel.org We get the following compile error if CONFIG_BLOCK isn't enabled: CC arch/powerpc/kernel/setup_32.o In file included from arch/powerpc/kernel/setup_32.c:14:

Re: block/bsg.c

2007-07-18 Thread Bartlomiej Zolnierkiewicz
On Wednesday 18 July 2007, FUJITA Tomonori wrote: They were fixed. Please check the latest code: git://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-2.6-block.git bsg We wait for Linus to pull from it. It has been merged. Thanks for fixing the mentioned issues. Thanks, Bart - To

Re: compile error if CONFIG_BLOCK not enabled related to linux/ide.h include

2007-07-18 Thread Bartlomiej Zolnierkiewicz
On Wednesday 18 July 2007, Kumar Gala wrote: On Jul 18, 2007, at 5:47 AM, Bartlomiej Zolnierkiewicz wrote: Hi, On Wednesday 18 July 2007, Kumar Gala wrote: M: [EMAIL PROTECTED] L: linux-ide@vger.kernel.org We get the following compile error if CONFIG_BLOCK isn't

Re: block/bsg.c

2007-07-18 Thread Bartlomiej Zolnierkiewicz
Hi, On Wednesday 18 July 2007, James Bottomley wrote: On Wed, 2007-07-18 at 02:43 +0200, Bartlomiej Zolnierkiewicz wrote: [ James, please remeber to cc: linux-ide on IDE patches, thanks. ] Blame Andrew ... I assumed he'd be reporting the problem to the relevant lists, so I just did

Re: [PATCH] scc_pata.c: Workaround for errata A308 (take 2)

2007-07-18 Thread Bartlomiej Zolnierkiewicz
On Tuesday 17 July 2007, Akira Iguchi wrote: Workaround for errata A308: turn down the UDMA mode and retry the DMA command when the data lost condition is detected. take2: udma_filter() hook is used to limit ATAPI UDMA mode. Signed-off-by: Kou Ishizaki [EMAIL PROTECTED] Signed-off-by:

Re: [PATCH] sc1200: remove redundant warning message from sc1200_tune_chipset()

2007-07-18 Thread Bartlomiej Zolnierkiewicz
On Saturday 14 July 2007, Sergei Shtylyov wrote: Hello. Bartlomiej Zolnierkiewicz wrote: ide_config_drive_speed() called by sc1200_set_xfer_mode() already gives a meaningful warning message in case of failure. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked

Re: [PATCH] it8213: PIO fixes (take 2)

2007-07-18 Thread Bartlomiej Zolnierkiewicz
On Saturday 14 July 2007, Sergei Shtylyov wrote: Bartlomiej Zolnierkiewicz wrote: * Rename it8213_tuneproc() to it8213_tune_pio() and add it8213_tuneproc() wrapper. Move finding of the best PIO mode to the new wrapper. * Add setting of transfer mode on the device to it8213_tuneproc

Re: [PATCH] piix/slc90e66: fix PIO1 handling in -speedproc method (take 2)

2007-07-18 Thread Bartlomiej Zolnierkiewicz
On Saturday 14 July 2007, Sergei Shtylyov wrote: Bartlomiej Zolnierkiewicz wrote: * Don't call {piix,slc90e66}_dma_2_pio() for PIO modes in {piix,slc90e66}_tune_chipset(). * Add PIO1 handling to {piix,slc90e66}_tune_chipset(). * Bump driver version. v2: * Remove PIO modes

Re: [PATCH] cs5520: don't enable VDMA in -speedproc

2007-07-18 Thread Bartlomiej Zolnierkiewicz
On Saturday 14 July 2007, Sergei Shtylyov wrote: Bartlomiej Zolnierkiewicz wrote: There is no need to do it in cs5520_tune_chipset() (-speedproc method) since it is correctly handled by cs5520_dma_on() (-ide_dma_on method). Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED

Re: [PATCH 1/6] icside: fix -speedproc to return on unsupported modes

2007-07-18 Thread Bartlomiej Zolnierkiewicz
On Saturday 14 July 2007, Sergei Shtylyov wrote: Bartlomiej Zolnierkiewicz wrote: [PATCH] icside: fix -speedproc to return on unsupported modes (take 3) * All other implementations of -speedproc return zero on success and non-zero on failure. Currently it doesn't matter for icside

Re: 40-wire/80-wire detection

2007-07-18 Thread Bartlomiej Zolnierkiewicz
Hi, On Saturday 14 July 2007, Craig Block wrote: --- Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] wrote: Please send the output of hdparm --Istdout for this drive. idex=ata66 or CONFIG_IDEDMA_IVB=y should also help but we really would I initially missed the fact that you've

Re: block/bsg.c

2007-07-17 Thread Bartlomiej Zolnierkiewicz
Hi, Some more bsg findings... block/Kconfig: endif # BLOCK Shouldn't BLK_DEV_BSG depend on BLOCK? config BLK_DEV_BSG bool Block layer SG support depends on (SCSI=y) EXPERIMENTAL default y ---help--- Saying Y here will enable generic SG (SCSI generic)

Re: block/bsg.c

2007-07-17 Thread Bartlomiej Zolnierkiewicz
On Tuesday 17 July 2007, Andrew Morton wrote: On Tue, 17 Jul 2007 22:52:25 +0200 Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] wrote: ide-{disk,scsi,tape} don't support REQ_TYPE_BLOCK_PC requests et all (so attempts to use SG_IO, CDROM_SEND_PACKET and SCSI_IOCTL_SEND_COMMAND will result

Re: [PATCH 2/6] ide-cris: fix -set_pio_mode method to set transfer mode on the device

2007-07-13 Thread Bartlomiej Zolnierkiewicz
On Wednesday 11 July 2007, Sergei Shtylyov wrote: Bartlomiej Zolnierkiewicz wrote: Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] added - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message

Re: [PATCH 9/12] sis5513: add -udma_filter method for chipset_family = ATA_133

2007-07-13 Thread Bartlomiej Zolnierkiewicz
On Thursday 12 July 2007, Sergei Shtylyov wrote: Hello. Bartlomiej Zolnierkiewicz wrote: * Add sis5513_ata133_udma_filter() for chipset_family = ATA_133, use it to filter UDMA6 mode if ATA133 bit is disabled. * Remove no longer needed UDMA6 limiting logic from sis5513_tune_chipset

Re: [PATCH 5/6] sgiioc4: use ide_tune_dma()

2007-07-13 Thread Bartlomiej Zolnierkiewicz
On Friday 13 July 2007, Sergei Shtylyov wrote: Hello. Bartlomiej Zolnierkiewicz wrote: * Add DRV_NAME define and use it instead of sgiioc4_chipset.name. * Remove no longer needed sgiioc4_chipset. * Remove needless clearing of -atapi_dma from ide_dma_sgiioc4(). * Fix

Re: [PATCH 4/12] cs5535: PIO fixes

2007-07-13 Thread Bartlomiej Zolnierkiewicz
On Friday 13 July 2007, Sergei Shtylyov wrote: Bartlomiej Zolnierkiewicz wrote: * Fix cs5535_tuneproc() to pass PIO transfer mode value instead of PIO mode number to cs5535_set_speed() (fixes random PIO timings being programmed and a possible OOPS). Do a little cleanup while

Re: [PATCH 3/6] ide-pmac: PIO fixes

2007-07-13 Thread Bartlomiej Zolnierkiewicz
On Friday 13 July 2007, Sergei Shtylyov wrote: Hello. Bartlomiej Zolnierkiewicz wrote: * Add { 0, 0 } entry to {kauai,shasta}_pio_timings[] so kauai_lookup_timing() always returns a valid PIO timing (fixes PIO timing not being set for devices with minimum PIO cycle = 120ns

Re: [PATCH 4/6] amd74xx/via82cxxx: use ide_tune_dma()

2007-07-13 Thread Bartlomiej Zolnierkiewicz
On Friday 13 July 2007, Sergei Shtylyov wrote: Bartlomiej Zolnierkiewicz wrote: * Use ide_tune_dma() in amd74xx/via82cxxx driver, this fixes following bugs: - DMA capability bit not being checked on the device - DMA blacklist not being checked - DMA mode being programmed even

[PATCH] it8213: PIO fixes (take 2)

2007-07-13 Thread Bartlomiej Zolnierkiewicz
it8213_tuneproc() in it8213_config_drive_for_dma(). v2: * Remove PIO modes from it8213_dma_2_pio(), they are no longer needed there (Noticed by Sergei) Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] --- drivers/ide/pci/it8213.c | 33

[PATCH] piix/slc90e66: fix PIO1 handling in -speedproc method (take 2)

2007-07-13 Thread Bartlomiej Zolnierkiewicz
-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] --- drivers/ide/pci/piix.c | 17 - drivers/ide/pci/slc90e66.c | 15 +++ 2 files changed, 15 insertions(+), 17 deletions(-) Index: b/drivers/ide/pci/piix.c

[PATCH] sc1200: remove redundant warning message from sc1200_tune_chipset()

2007-07-13 Thread Bartlomiej Zolnierkiewicz
ide_config_drive_speed() called by sc1200_set_xfer_mode() already gives a meaningful warning message in case of failure. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/pci/sc1200.c |4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) Index: b/drivers/ide/pci

[PATCH] siimage: fix -set_pio_mode method to select PIO data transfer

2007-07-13 Thread Bartlomiej Zolnierkiewicz
(). * Bump driver version. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/pci/siimage.c | 20 +--- 1 file changed, 17 insertions(+), 3 deletions(-) Index: b/drivers/ide/pci/siimage.c

[PATCH] cs5520: don't enable VDMA in -speedproc

2007-07-13 Thread Bartlomiej Zolnierkiewicz
There is no need to do it in cs5520_tune_chipset() (-speedproc method) since it is correctly handled by cs5520_dma_on() (-ide_dma_on method). Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/pci/cs5520.c | 13 - 1 file changed, 4 insertions(+), 9

Re: Problem with SiS Ide/Pata/Sata on 2.6.22-rc7-git4

2007-07-13 Thread Bartlomiej Zolnierkiewicz
Hi, On Tuesday 10 July 2007, Thomas Backlund wrote: Alan Cox skrev: If you modprobe only sis5513 OR If you modprobe only sis5513 and then sata_sis/pata_sis: - you get this: (the hdb drive does not get detected/usable) Don't mix old and new IDE like that. We allow both so

Re: [PATCH 1/6] icside: fix -speedproc to return on unsupported modes

2007-07-13 Thread Bartlomiej Zolnierkiewicz
On Friday 13 July 2007, Russell King wrote: On Fri, Jul 13, 2007 at 11:02:03PM +0200, Bartlomiej Zolnierkiewicz wrote: wee, take 3 I'm probably going to drop this driver as soon as the PATA people get their finger(s) out and respond to the issues I raised when merging the pata_icside

Re: [PATCH 3/6] ide-pmac: PIO fixes

2007-07-12 Thread Bartlomiej Zolnierkiewicz
On Wednesday 11 July 2007, Bartlomiej Zolnierkiewicz wrote: * Add { 0, 0 } entry to {kauai,shasta}_pio_timings[] so kauai_lookup_timing() always returns a valid PIO timing (fixes PIO timing not being set for devices with minimum PIO cycle = 120ns). * Add setting transfer mode

Re: [PATCH 5/12] it8213: PIO fixes

2007-07-10 Thread Bartlomiej Zolnierkiewicz
On Monday 09 July 2007, Sergei Shtylyov wrote: Bartlomiej Zolnierkiewicz wrote: * Rename it8213_tuneproc() to it8213_tune_pio() and add it8213_tuneproc() wrapper. Move finding of the best PIO mode to the new wrapper. * Add setting of transfer mode on the device to it8213_tuneproc

Re: [PATCH 8/12] scc_pata: PIO fixes

2007-07-10 Thread Bartlomiej Zolnierkiewicz
On Monday 09 July 2007, Sergei Shtylyov wrote: Bartlomiej Zolnierkiewicz wrote: * Use pio == 255 == auto-tune in scc_config_drive_for_dma() instead of forcing PIO4 on PIO fallback. Fix comment while at it. * Rename scc_tuneproc() to scc_tune_pio() and add scc_tuneproc() wrapper

Re: [PATCH 3/12] cs5520: fix PIO auto-tuning in -ide_dma_check method

2007-07-10 Thread Bartlomiej Zolnierkiewicz
On Monday 09 July 2007, Sergei Shtylyov wrote: Bartlomiej Zolnierkiewicz wrote: Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] added - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message

Re: [PATCH 2/12] ide: mode limiting fixes for user requested speed changes

2007-07-10 Thread Bartlomiej Zolnierkiewicz
On Monday 09 July 2007, Sergei Shtylyov wrote: Bartlomiej Zolnierkiewicz wrote: Sorry, more grammar nitpicking follows (-: * Add an extra argument to ide_max_dma_mode() for passing requested transfer mode. Use it as an upper limit when finding the best DMA for device/host

Re: [PATCH 1/12] ide: add missing ide_rate_filter() calls to -speedproc()-s

2007-07-10 Thread Bartlomiej Zolnierkiewicz
On Monday 09 July 2007, Sergei Shtylyov wrote: Hello. Bartlomiej Zolnierkiewicz wrote: * Fix icside, cris-ide, au1xxx-ide, amd74xx, via82cxxx and pmac host drivers to use ide_rate_filter(). This results in the following modes (from user requests) being clipped down

Re: Question about PATA Sil680 Bus Reset Code

2007-07-10 Thread Bartlomiej Zolnierkiewicz
On Tuesday 10 July 2007, Sergei Shtylyov wrote: Alan Cox wrote: I guess it's been blindly copied over form drivers/ide/pci/siimage.c... Yet the order of events between IDE and libata drivers is different: the old driver's resetproc() method is called just after the twiddling the

Re: [PATCH] PCMCIA: Add another MemoryCard to ide-cd/pata_pcmcia

2007-07-10 Thread Bartlomiej Zolnierkiewicz
[ please always cc: linux-ide@ on ATA patches ] ^ s/ide-cd/ide-cs/ ;-) On Tuesday 10 July 2007, Marcin Juszkiewicz wrote: From: Marcin Juszkiewicz [EMAIL PROTECTED] One card submitted by user. Signed-off-by: Marcin Juszkiewicz [EMAIL PROTECTED] This patch doesn't apply because of

[PATCH 2/6] ide-cris: fix -set_pio_mode method to set transfer mode on the device

2007-07-10 Thread Bartlomiej Zolnierkiewicz
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/cris/ide-cris.c |2 ++ 1 file changed, 2 insertions(+) Index: b/drivers/ide/cris/ide-cris.c === --- a/drivers/ide/cris/ide-cris.c +++ b/drivers/ide/cris

[PATCH 1/6] icside: fix -speedproc to return on unsupported modes

2007-07-10 Thread Bartlomiej Zolnierkiewicz
icside_set_speed() happily accepts unsupported transfer modes which results in drive-drive_data being set to the maximum value (480) and drive-current_speed being set to the unsupported transfer mode. Fix it. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Cc: Russell King [EMAIL

[PATCH 6/6] ide: config_drive_for_dma() fixes

2007-07-10 Thread Bartlomiej Zolnierkiewicz
(there should be no changes in behavior as all users of config_drive_for_dma() set both -autodma flags). Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-dma.c | 26 ++ drivers/ide/pci/ns87415.c |9 - include/linux/ide.h

Re: [PATCH 2.6.22-rc7-git1] sis5513: adding PCI-ID

2007-07-08 Thread Bartlomiej Zolnierkiewicz
On Wednesday 04 July 2007, Uwe koziolek wrote: The SiS966 has one additional PCI-ID 1180. If the chipset is using this PCI-ID, the primary channel is connected to the first PATA-port. The secondary channel is connected to SATA-ports in IDE emulation mode. The legacy IO-ports are used.

Re: [PATCH 1/2] [ide] mmio ide support

2007-07-08 Thread Bartlomiej Zolnierkiewicz
Hi, On Saturday 07 July 2007, Arnd Bergmann wrote: On Saturday 07 July 2007, Sergei Shtylyov wrote: Arnd Bergmann wrote: This adds support for MMIO IDE device like CompactFlash in TrueIDE mode. Signed-off-by: Anton Vorontsov [EMAIL PROTECTED] Signed-off-by: Vitaly Bordug

[PATCH 1/12] ide: add missing ide_rate_filter() calls to -speedproc()-s

2007-07-08 Thread Bartlomiej Zolnierkiewicz
on the device * While at it remove no longer needed checks from pmac.c driver. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- This patch series goes before ide-add-ide-set-pio-take3.patch patch ([PATCH] ide: add ide_set{_max}_pio() (take 3)) in the quilt tree. The rediffed ide-add-ide-set

[PATCH 3/12] cs5520: fix PIO auto-tuning in -ide_dma_check method

2007-07-08 Thread Bartlomiej Zolnierkiewicz
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/pci/cs5520.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: b/drivers/ide/pci/cs5520.c === --- a/drivers/ide/pci/cs5520.c +++ b/drivers/ide

[PATCH 6/12] jmicron: PIO fixes

2007-07-08 Thread Bartlomiej Zolnierkiewicz
* Set transfer mode on the device in jmicron_tuneproc(), also add pio == 255 == auto-tune handling. * Use jmicron_tuneproc() in jmicron_config_drive_for_dma(). * Remove no longer needed config_jmicron_chipset_for_pio(). Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers

[PATCH 10/12] ide: move ide_rate_filter() calls to the upper layer

2007-07-08 Thread Bartlomiej Zolnierkiewicz
* Move ide_rate_filter() calls from host drivers to IDE core. * Make ide_rate_filter() static. * Make 'speed' argument of -speedproc const. There should be no functionality changes caused by this patch. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/arm/icside.c

[PATCH 5/12] it8213: PIO fixes

2007-07-08 Thread Bartlomiej Zolnierkiewicz
it8213_tuneproc() in it8213_config_drive_for_dma(). Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/pci/it8213.c | 25 - 1 file changed, 16 insertions(+), 9 deletions(-) Index: b/drivers/ide/pci/it8213.c

[PATCH 8/12] scc_pata: PIO fixes

2007-07-08 Thread Bartlomiej Zolnierkiewicz
wrapper. * Fix scc_tune_chipset() to tune PIO modes. Do a small cleanup while at it. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/pci/scc_pata.c | 61 ++--- 1 file changed, 20 insertions(+), 41 deletions(-) Index: b/drivers

Re: [PATCH 3/6] siimage: PIO mode setup fixes

2007-07-04 Thread Bartlomiej Zolnierkiewicz
On Wednesday 04 July 2007, Sergei Shtylyov wrote: Hello. Bartlomiej Zolnierkiewicz wrote: A lot to argue about here... * Add sil_tuneproc() wrapper for siimage_tuneproc() which also sets PIO mode on the device. Planning on the global prefix change? :-) Yep. Well

Re: [PATCH 6/15] ide: ide_find_best_pio_mode() fixes

2007-07-04 Thread Bartlomiej Zolnierkiewicz
On Wednesday 04 July 2007, Sergei Shtylyov wrote: Hello. Bartlomiej Zolnierkiewicz wrote: [PATCH] ide: ide_find_best_pio_mode() fixes (take 2) * Check IORDY bit for PIO modes 2. * Some devices claim maximum PIO mode 2 in id-tPIO, they were punished too severly

Re: [PATCH 9/15] ide: add PIO masks

2007-07-04 Thread Bartlomiej Zolnierkiewicz
On Wednesday 04 July 2007, Alan Cox wrote: It doesn't need to do anything. Not true. It should call ide_config_drive_speed() at least, else PIO autotuning won't actually work. Indeed - I forgot that old-ide doesn't do this itself but leaves it up to the driver to forget 8) OK,

Re: [PATCH] ide: add ide_set{_max}_pio() (take 2)

2007-07-04 Thread Bartlomiej Zolnierkiewicz
On Wednesday 04 July 2007, Sergei Shtylyov wrote: Bartlomiej Zolnierkiewicz wrote: reporting PIO mode selected from -tuneproc implementations. * Rename -tuneproc hook to -set_pio_mode Well, tuneproc() went with speedproc() rather well. :-) -set_pio_mode goes better

Re: [PATCH 1/1] ide: pdc202xx_new PLL input clock fix

2007-07-03 Thread Bartlomiej Zolnierkiewicz
On Tuesday 03 July 2007, Albert Lee wrote: Recently the PLL input clock of Promise 2027x is sometimes detected higer than expected (e.g. 20.027 MHz compared to 16.714 MHz). It seems sometimes the mdelay() function is not as precise as it used to be. Per Alan's advice, HT or power management

Re: [PATCH 1/1] ide: pdc202xx_new PLL input clock fix

2007-07-03 Thread Bartlomiej Zolnierkiewicz
On Tuesday 03 July 2007, Sergei Shtylyov wrote: Hello. Albert Lee wrote: Recently the PLL input clock of Promise 2027x is sometimes detected higer than expected (e.g. 20.027 MHz compared to 16.714 MHz). ^ h It seems sometimes the mdelay() function is not as precise as it used

Re: [PATCH] hpt366: blacklist MAXTOR STM3320620A for UltraDMA/66

2007-07-03 Thread Bartlomiej Zolnierkiewicz
On Tuesday 03 July 2007, Linas Vepstas wrote: On Fri, Jun 29, 2007 at 11:57:17PM +0400, Sergei Shtylyov wrote: Add the MAXTOR STM3320620A drive into the UltraDMA/66 mode blacklist for the HPT36x chips. Signed-off-by: Sergei Shtylyov [EMAIL PROTECTED] Acked-by: Linas Vepstas [EMAIL

Re: [PATCH pata-2.6 fix] hpt366: use correct enablebits for HPT36x

2007-07-03 Thread Bartlomiej Zolnierkiewicz
On Tuesday 03 July 2007, Linas Vepstas wrote: Hi, On Sat, Jun 30, 2007 at 12:04:22AM +0400, Sergei Shtylyov wrote: The HPT36x chips finally turned out to have the channel enable bits -- however, badly implemented. Make use of them despite it's probably only going to burden the

Re: [PATCH 9/15] ide: add PIO masks

2007-07-03 Thread Bartlomiej Zolnierkiewicz
On Tuesday 03 July 2007, Sergei Shtylyov wrote: Hello. Bartlomiej Zolnierkiewicz wrote: * Add ATA_PIO[0-6] defines to linux/ata.h. * Add -pio_mask field to ide_pci_device_t and ide_hwif_t. * Add PIO masks to host drivers. Hm, the next logical step would be to use the mask

[git patches] IDE fixes

2007-07-03 Thread Bartlomiej Zolnierkiewicz
): ide: pdc202xx_new PLL input clock fix Andrew Morton (1): ide: ide_scan_pcibus(): check __pci_register_driver return value Bartlomiej Zolnierkiewicz (2): amd74xx: resume fix it821x: fix incorrect SWDMA mask Masatake YAMATO (1): ide: never called printk statement in ide

Re: [PATCH 8/15] ide: remove ide_find_best_pio_mode()

2007-07-03 Thread Bartlomiej Zolnierkiewicz
On Tuesday 03 July 2007, Sergei Shtylyov wrote: Bartlomiej Zolnierkiewicz wrote: * Add -host_flags to ide_hwif_t to store ide_pci_device_t.host_flags, assign it in setup-pci.c:ide_pci_setup_ports(). * Add IDE_HFLAG_PIO_NO_{BLACKLIST,DOWNGRADE} to ide_pci_device_t.host_flags

Re: [PATCH] pata_hpt3x3: Major reworking and testing

2007-07-03 Thread Bartlomiej Zolnierkiewicz
On Tuesday 03 July 2007, Sergei Shtylyov wrote: Hello. Bartlomiej Zolnierkiewicz wrote: http://www.linuxhq.com/kernel/v2.3/10/drivers/block/hpt343.c Does anybody have DOS driver for HPT343? Google doesn't have it... I have the drivers for HPT34[35] -- tried dissassembling them

Re: [PATCH 6/15] ide: ide_find_best_pio_mode() fixes

2007-07-02 Thread Bartlomiej Zolnierkiewicz
On Monday 02 July 2007, Sergei Shtylyov wrote: Hello. Bartlomiej Zolnierkiewicz wrote: * Check IORDY bit for PIO modes 2. * Some devices claim maximum PIO mode 2 in id-tPIO, they were punished too severly for this by being limited to PIO_SLOW. Limit them to PIO2 instead

Re: [PATCH 12/15] alim15x3: -speedproc, filter out invalid modes passed from user-space

2007-07-02 Thread Bartlomiej Zolnierkiewicz
On Monday 02 July 2007, Bartlomiej Zolnierkiewicz wrote: On Monday 02 July 2007, Jeff Garzik wrote: Bartlomiej Zolnierkiewicz wrote: On Monday 02 July 2007, Jeff Garzik wrote: Bartlomiej Zolnierkiewicz wrote: This would brake setups which currently work OK, i.e. BIOS set things up

Re: [PATCH 12/15] alim15x3: -speedproc, filter out invalid modes passed from user-space

2007-07-02 Thread Bartlomiej Zolnierkiewicz
On Monday 02 July 2007, Jeff Garzik wrote: Bartlomiej Zolnierkiewicz wrote: Add the new code inside #ifdef X86, marking alim15x3 X86-only would be on over-kill... My reply is taken out of context. Ugh. That's not how we do Linux development. It is better to convert the new code

[PATCH] amd74xx: resume fix

2007-07-02 Thread Bartlomiej Zolnierkiewicz
* Driver can't skip programming transfer mode on the device in amd_set_drive() (similar fix has been applied to via82cxxx driver ages ago). * While at it remove redundant warning (ide_config_drive_speed() already produces more valuable one). * Bump driver version. Signed-off-by: Bartlomiej

[PATCH] it821x: fix incorrect SWDMA mask

2007-07-02 Thread Bartlomiej Zolnierkiewicz
. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- for 2.6.22-final drivers/ide/pci/it821x.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) Index: b/drivers/ide/pci/it821x.c === --- a/drivers/ide/pci/it821x.c

[PATCH 1/15] serverworks: always tune PIO

2007-06-30 Thread Bartlomiej Zolnierkiewicz
-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/pci/serverworks.c | 76 +++--- 1 file changed, 36 insertions(+), 40 deletions(-) Index: b/drivers/ide/pci/serverworks.c === --- a/drivers/ide

[PATCH 2/15] serverworks: fix DMA

2007-06-30 Thread Bartlomiej Zolnierkiewicz
for bugreport and testing the patch goes out to Sven Niedner. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/pci/serverworks.c |8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) Index: b/drivers/ide/pci/serverworks.c

[PATCH 3/15] ide: ide_start_power_step() fix WRT disabling DMA

2007-06-30 Thread Bartlomiej Zolnierkiewicz
* Do the same thing as probe_hwif() and always disable DMA so chipset DMA enabled bit gets cleared (if the drive doesn't support DMA ide_set_dma() won't try to tune it anyway). * Add TODO comment about respecting -using_dma setting. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED

[PATCH 4/15] sc1200: remove stale Power Management code

2007-06-30 Thread Bartlomiej Zolnierkiewicz
() and ide_{start,stop}_power_step(). * Bump driver version. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Cc: Mark Lord [EMAIL PROTECTED] --- drivers/ide/pci/sc1200.c | 39 ++- 1 file changed, 2 insertions(+), 37 deletions(-) Index: b/drivers/ide/pci

[PATCH 5/15] ide: add ata_pio_cycle_time() helper

2007-06-30 Thread Bartlomiej Zolnierkiewicz
* Add ata_pio_cycle_time() helper. * Use it in ali14xx/ht6560b/qd65xx/cmd64{0,x}/sl82c105 and pmac host drivers (previously cycle time given by the device was only used for pio == 255). * Remove no longer needed ide_pio_data_t.cycle_time field. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL

[PATCH 6/15] ide: ide_find_best_pio_mode() fixes

2007-06-30 Thread Bartlomiej Zolnierkiewicz
* Check IORDY bit for PIO modes 2. * Some devices claim maximum PIO mode 2 in id-tPIO, they were punished too severly for this by being limited to PIO_SLOW. Limit them to PIO2 instead. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-timing.h | 10

[PATCH 8/15] ide: remove ide_find_best_pio_mode()

2007-06-30 Thread Bartlomiej Zolnierkiewicz
at it (drive-id is always present). * Convert amd74xx, via82cxxx and ide-timing.h to use ide_get_best_pio_mode() and then remove no longer needed ide_find_best_pio_mode(). There should be no functionality changes caused by this patch. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED

[PATCH 9/15] ide: add PIO masks

2007-06-30 Thread Bartlomiej Zolnierkiewicz
* Add ATA_PIO[0-6] defines to linux/ata.h. * Add -pio_mask field to ide_pci_device_t and ide_hwif_t. * Add PIO masks to host drivers. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/cris/ide-cris.c|1 + drivers/ide/ide.c |2 ++ drivers/ide

[PATCH 10/15] ide-cris: handle PIO auto-tuning in tune_cris_ide()

2007-06-30 Thread Bartlomiej Zolnierkiewicz
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/cris/ide-cris.c |2 ++ 1 file changed, 2 insertions(+) Index: b/drivers/ide/cris/ide-cris.c === --- a/drivers/ide/cris/ide-cris.c +++ b/drivers/ide/cris

[PATCH 11/15] atiixp: -speedproc, filter out invalid modes passed from user-space

2007-06-30 Thread Bartlomiej Zolnierkiewicz
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/pci/atiixp.c | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) Index: b/drivers/ide/pci/atiixp.c === --- a/drivers/ide/pci/atiixp.c

[PATCH 12/15] alim15x3: -speedproc, filter out invalid modes passed from user-space

2007-06-30 Thread Bartlomiej Zolnierkiewicz
* -speedproc, filter out invalid modes passed from user-space. * Add FIXME about DMA timings never being set. * Bump driver version. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/pci/alim15x3.c | 15 +++ 1 file changed, 15 insertions(+) Index: b

[PATCH 14/15] ide: remove stale changelog/comments/TODO from ide.c

2007-06-30 Thread Bartlomiej Zolnierkiewicz
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide.c | 78 -- 1 file changed, 78 deletions(-) Index: b/drivers/ide/ide.c === --- a/drivers/ide/ide.c

[PATCH 15/15] ide: remove stale changelog from setup-pci.c

2007-06-30 Thread Bartlomiej Zolnierkiewicz
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/setup-pci.c |6 -- 1 file changed, 6 deletions(-) Index: b/drivers/ide/setup-pci.c === --- a/drivers/ide/setup-pci.c +++ b/drivers/ide/setup-pci.c

Re: [PATCH 13/15] ide: add ata_set{_max}_pio()

2007-06-30 Thread Bartlomiej Zolnierkiewicz
Hi, On Saturday 30 June 2007, Jeff Garzik wrote: Bartlomiej Zolnierkiewicz wrote: * Add IDE_HFLAG_ABUSE_{PREFETCH,FAST_DEVSEL,DMA_MODES} flags and set them in ht6560, cmd640, cmd64x and sc1200 host drivers. * Add set_pio_mode_abuse() for checking if host driver has a non-standard

Re: [PATCH 13/15] ide: add ata_set{_max}_pio()

2007-06-30 Thread Bartlomiej Zolnierkiewicz
On Saturday 30 June 2007, Jeff Garzik wrote: Bartlomiej Zolnierkiewicz wrote: This has been changing recently since ide_ prefix seems to have negative emotional connotations. :-) New patches for drivers/ide should use exclusively the ata_ prefix. So this choice to be inconsistent

[PATCH] ide: add ide_dev_has_iordy() helper (take 4)

2007-06-30 Thread Bartlomiej Zolnierkiewicz
-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] Cc: Jeff Garzik [EMAIL PROTECTED] --- drivers/ide/ide-lib.c |7 +-- drivers/ide/pci/sl82c105.c | 10 +++--- include/linux/ide.h|6 +- 3 files changed, 13 insertions(+), 10

[PATCH] ide: add ide_pio_cycle_time() helper (take 2)

2007-06-30 Thread Bartlomiej Zolnierkiewicz
). Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Cc: Jeff Garzik [EMAIL PROTECTED] --- drivers/ide/ide-lib.c| 40 drivers/ide/legacy/ali14xx.c |5 ++--- drivers/ide/legacy/ht6560b.c | 10 ++ drivers/ide/legacy/qd65xx.c | 20

Re: [PATCH] ide: add ide_set{_max}_pio() (take 2)

2007-06-30 Thread Bartlomiej Zolnierkiewicz
On Sunday 01 July 2007, Jeff Garzik wrote: Bartlomiej Zolnierkiewicz wrote: * Add IDE_HFLAG_ABUSE_{PREFETCH,FAST_DEVSEL,DMA_MODES} flags and set them in ht6560, cmd640, cmd64x and sc1200 host drivers. * Add set_pio_mode_abuse() for checking if host driver has a non-standard

Re: [PATCH] ide: add ide_set{_max}_pio() (take 2)

2007-06-30 Thread Bartlomiej Zolnierkiewicz
On Sunday 01 July 2007, Alan Cox wrote: * Fix ata_ prefix (Noticed by Jeff). Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Cc: Jeff Garzik [EMAIL PROTECTED] Thanks Bart! Ditto - its really very helpful to tell people ata_ in the trace mail Jeff (or me), ide_ mail

Re: [PATCH] hpt366: blacklist MAXTOR STM3320620A for UltraDMA/66

2007-06-29 Thread Bartlomiej Zolnierkiewicz
On Friday 29 June 2007, Sergei Shtylyov wrote: Add the MAXTOR STM3320620A drive into the UltraDMA/66 mode blacklist for the HPT36x chips. Signed-off-by: Sergei Shtylyov [EMAIL PROTECTED] applied - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to

Re: [PATCH pata-2.6 fix] hpt366: use correct enablebits for HPT36x

2007-06-29 Thread Bartlomiej Zolnierkiewicz
On Friday 29 June 2007, Sergei Shtylyov wrote: The HPT36x chips finally turned out to have the channel enable bits -- however, badly implemented. Make use of them despite it's probably only going to burden the driver's code -- assuming both channels are always enabled by the HighPoint

Re: [PATCH pata-2.6] hpt366: simplify UltraDMA filtering (take 4)

2007-06-29 Thread Bartlomiej Zolnierkiewicz
-by: Sergei Shtylyov [EMAIL PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] applied - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 3/6] siimage: PIO mode setup fixes

2007-06-29 Thread Bartlomiej Zolnierkiewicz
Hi, On Tuesday 26 June 2007, Sergei Shtylyov wrote: Bartlomiej Zolnierkiewicz wrote: A lot to argue about here... * Add sil_tuneproc() wrapper for siimage_tuneproc() which also sets PIO mode on the device. Planning on the global prefix change? :-) Yep. * Add code

Re: [PATCH 5/6] ide: add ata_dev_has_iordy() helper

2007-06-29 Thread Bartlomiej Zolnierkiewicz
Hi, On Friday 29 June 2007, Sergei Shtylyov wrote: Hello. Bartlomiej Zolnierkiewicz wrote: [...] Damn, I should have re-check ATA specs before writing this. :) Yeah, never hurts... but takes time. ;-) I was thinking of checking if the drive really supports IORDY before

Re: [PATCH 5/6] ide: add ata_dev_has_iordy() helper

2007-06-27 Thread Bartlomiej Zolnierkiewicz
by Sergei: - correct patch description - fix comment in ide_get_best_pio_mode() Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] --- drivers/ide/ide-lib.c |7 +-- drivers/ide/pci/sl82c105.c | 10 +++--- include/linux/ide.h

Re: [PATCH 2/5] piix: backport short cables support from ata_piix.c

2007-06-27 Thread Bartlomiej Zolnierkiewicz
On Tuesday 26 June 2007, Sergei Shtylyov wrote: Bartlomiej Zolnierkiewicz wrote: Backport short cables support from ata_piix.c. This patch should allow UDMA 2 modes on: - Acer 5602WLMi - Acer 3682WLMi - Asus W5F - Acer Aspire 2023WLMi Signed-off-by: Bartlomiej Zolnierkiewicz

Re: [PATCH 4/5] sis5513: backport short cables support from pata_sis.c

2007-06-27 Thread Bartlomiej Zolnierkiewicz
On Tuesday 26 June 2007, Sergei Shtylyov wrote: Bartlomiej Zolnierkiewicz wrote: Backport short cables support from pata_sis.c. This patch should allow UDMA 2 modes on ASUS A6K. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED

<    5   6   7   8   9   10   11   12   13   14   >