imagine
this is what the Windows default IDE driver is doing (just using the
boot-up mode and feeding it back using GTM/STM on suspend/resume cycles).
--
Robert Hancock Saskatoon, SK, Canada
To email, remove nospam from [EMAIL PROTECTED]
Home Page: http://www.roberthancock.com
commands.
This won't handle the case where the driver is loaded after the system
was already suspended to RAM and resumed, however I don't know exactly
how one could handle that in this situation..
--
Robert Hancock Saskatoon, SK, Canada
To email, remove nospam from [EMAIL PROTECTED]
Home Page
of the same.
Please update libata as well when you udpate the blacklists.
Sure, point me at the table(s) ?
Dave
ata_device_blacklist in drivers/ata/libata-core.c
--
Robert Hancock Saskatoon, SK, Canada
To email, remove nospam from [EMAIL PROTECTED]
Home Page: http
Randy Dunlap wrote:
On Sun, 20 May 2007 11:45:03 -0600 Robert Hancock wrote:
Indan Zupancic wrote:
Everything seems to work fine without sd_resume(), so why is it needed?
Because not all disks spin up without being told to do so and like it or
not spinning disks up on resume is the default
-bit DMA addresses (where
supported by platform) and eliminates the annoying 64k DMA boundary
found in legacy PCI IDE BMDMA engines.
Looks like it doesn't allow 64-bit DMA addresses, it only gets rid of
the 64K boundary limitation.
--
Robert Hancock Saskatoon, SK, Canada
To email, remove
. See the code in ahci.c in
ahci_host_intr.
This comment still applies:
Additional/general comments:
Think you need some code to handle suspend and resume (re-enable SATA
MMIO space, etc.)
--
Robert Hancock Saskatoon, SK, Canada
To email, remove nospam from [EMAIL PROTECTED]
Home Page
Peer Chen wrote:
Add the Software NCQ support to sata_nv.c for MCP51/MCP55/MCP61 SATA
controller.
This patch base on sata_nv.c file from kernel 2.6.22-rc1
See attachment for the patch.
Signed-off-by: Kuan Luo [EMAIL PROTECTED]
Signed-off-by: Peer Chen [EMAIL PROTECTED]
Good to finally see
of this patch.
Signed-off-by: Robert Hancock [EMAIL PROTECTED]
--- linux-2.6.21.1/drivers/ata/libata-eh.c 2007-04-27 15:49:26.0
-0600
+++ linux-2.6.21.1edit/drivers/ata/libata-eh.c 2007-05-14 17:38:35.0
-0600
@@ -1523,6 +1523,27 @@ static void ata_eh_report(struct ata_por
these commands? CCing linux-ide in case anyone
knows what would cause this.
--
Robert Hancock Saskatoon, SK, Canada
To email, remove nospam from [EMAIL PROTECTED]
Home Page: http://www.roberthancock.com/
-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the body
Counter logging not supported
[GLTSD (Global Logging Target Save Disable) set. Enable Save with '-S on']
Device does not support Self Test logging
Sounds like SMART is likely disabled on that drive. You can try doing
smartctl -s on /dev/sda and see if that will turn it on.
--
Robert Hancock
of figuring out what's going on,
and neither does Joe libata Developer unless they really care to dig
through the spec and count bits to figure out what they mean. At least
with this you can see that there was a CRC error, etc. and go from that..
--
Robert Hancock Saskatoon, SK, Canada
To email
output. With libata errors, if they're at the console (which they'd have
to be to see these messages), unless something has actually caused a
panic the scrollback buffer should still be functional and they'd be
able to see the entire output..
--
Robert Hancock Saskatoon, SK, Canada
To email
looking at error
reports. Some bits that drivers/ide decoded are not decoded here, since the bits
are either command-dependent or obsolete, and properly parsing them would add
too much complexity.
Signed-off-by: Robert Hancock [EMAIL PROTECTED]
--- linux-2.6.21.1/drivers/ata/libata-eh.c 2007
ADMA status if the port has ADMA switched off because of an ATAPI device, and
it also checks to see if any ADMA interrupt has been raised even when we are in
port-register mode.
Signed-off-by: Robert Hancock [EMAIL PROTECTED]
--- linux-2.6.21.1/drivers/ata/sata_nv.c2007-04-27 15:49
.
Sometimes I even have to completely power down the machine to be able to
boot again.
Power problems would be another possibility..
--
Robert Hancock Saskatoon, SK, Canada
To email, remove nospam from [EMAIL PROTECTED]
Home Page: http://www.roberthancock.com/
-
To unsubscribe from this list: send
pore
through the SATA spec and count bits). First thing you should try is
replacing the SATA cable to that drive.
--
Robert Hancock Saskatoon, SK, Canada
To email, remove nospam from [EMAIL PROTECTED]
Home Page: http://www.roberthancock.com/
-
To unsubscribe from this list: send the line
kernels are supposed to
switch it off automatically after too many errors..
--
Robert Hancock Saskatoon, SK, Canada
To email, remove nospam from [EMAIL PROTECTED]
Home Page: http://www.roberthancock.com/
-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the body
Tejun Heo wrote:
libata didn't use to spin down disks properly on shutdown and userland
shutdown(8) worked around it by synchronizing cache and spinning down
by itself before telling the kernel to shutdown. However, this
userland work around collides with libata shutdown because some drives
of the drive and controller just not getting along,
but you might want to try a different SATA cable as well.
--
Robert Hancock Saskatoon, SK, Canada
To email, remove nospam from [EMAIL PROTECTED]
Home Page: http://www.roberthancock.com/
-
To unsubscribe from this list: send the line unsubscribe linux
- Original Message -
From: Kyle McMartin [EMAIL PROTECTED]
Date: Friday, April 13, 2007 10:47 am
Subject: Re: [PATCH] libata: HPA support
[Adding Robert to the CC incase he doesn't follow linux-ide]
On Fri, Apr 13, 2007 at 12:33:41PM -0400, Kyle McMartin wrote:
On Fri, Apr 13, 2007
taskfile (which
can't be done in ADMA mode). The patch in libata-dev which I mentioned
in another email will ensure that we don't try to use ADMA for such
commands, so this patch should not be needed.
--
Robert Hancock Saskatoon, SK, Canada
To email, remove nospam from [EMAIL PROTECTED
Jeff Garzik wrote:
Robert Hancock wrote:
This adds some NCQ blacklist entries taken from the Silicon Image
3124/3132
Windows driver .inf files. There are some confirming reports of problems
with these drives under Linux (for example
http://lkml.org/lkml/2007/3/4/178)
so let's disable NCQ
This adds some NCQ blacklist entries taken from the Silicon Image 3124/3132
Windows driver .inf files. There are some confirming reports of problems
with these drives under Linux (for example http://lkml.org/lkml/2007/3/4/178)
so let's disable NCQ on these drives.
Signed-off-by: Robert Hancock
and the controller is still waiting for a
response.
Could be that this is another drive that needs to be added to the NCQ
blacklist, some similar Maxtor models seem to have issues..
--
Robert Hancock Saskatoon, SK, Canada
To email, remove nospam from [EMAIL PROTECTED]
Home Page: http
Jeff Garzik wrote:
[EMAIL PROTECTED] wrote:
From: Robert Hancock [EMAIL PROTECTED]
Reading from the ATA shadow registers while we are in ADMA mode may cause
undefined behavior. Don't read the ATA status register when completing
commands for this reason, it shouldn't be needed
should be able to.
--
Robert Hancock Saskatoon, SK, Canada
To email, remove nospam from [EMAIL PROTECTED]
Home Page: http://www.roberthancock.com/
-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http
-by: Robert Hancock [EMAIL PROTECTED]
--- linux-2.6.21-rc3-git3/drivers/ata/sata_nv.c 2007-03-08 17:15:25.0
-0600
+++ linux-2.6.21-rc3-git3edit/drivers/ata/sata_nv.c 2007-03-08
17:19:42.0 -0600
@@ -874,8 +874,14 @@
if (status (NV_ADMA_STAT_DONE
requested
to execute in ADMA mode, since that requires accessing the shadow registers.
We also still need to override tf_read since libata will read the result
taskfile on a command failure, and we need to go into port register mode
before allowing this.
Signed-off-by: Robert Hancock [EMAIL
..
--
Robert Hancock Saskatoon, SK, Canada
To email, remove nospam from [EMAIL PROTECTED]
Home Page: http://www.roberthancock.com/
-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org
active_tag -84148995 sactive 0xf)
Sounds like those are some that we should be blacklisting as well,
unless Eric has a good reason why not (CCing). Can you provide the full
firmware revision strings from those drives, i.e. from hdparm -I?
--
Robert Hancock Saskatoon, SK, Canada
To email
(especially the latter) seem to be very popular models.
Likely Seagate didn't implement that command since they figured nobody
would use that if they had NCQ..
--
Robert Hancock Saskatoon, SK, Canada
To email, remove nospam from [EMAIL PROTECTED]
Home Page: http://www.roberthancock.com
This patch adds in some NCQ blacklist entries taken from the Silicon
Image Windows drivers' .inf files for the 3124 and 3132 controllers.
These entries were marked as DisableSataQueueing. Assume these are
in their blacklist for a reason and disable NCQ on these drives.
Signed-off-by: Robert
outstanding, since the drive may be issuing spurious completions.
Signed-off-by: Robert Hancock [EMAIL PROTECTED]
--- linux-2.6.21-rc1edit/drivers/ata/sata_nv.c.prev 2007-02-21
22:17:31.0 -0600
+++ linux-2.6.21-rc1edit/drivers/ata/sata_nv.c 2007-02-21 22:22:14.0
-0600
@@ -740,6
.
The only thing we need to override as far as ADMA and BMDMA is the
post_internal_cmd callback, where we should only call ata_post_internal_cmd
if we are in port-register mode.
Signed-off-by: Robert Hancock [EMAIL PROTECTED]
--- linux-2.6.20-git14edit/drivers/ata/sata_nv.c.before_cleanup 2007-02-20
, just go for the regular non-NCQ
FUA write. I think that should be safe.
Aside from the issue above, as I mentioned elsewhere, lots of NCQ drives
don't support non-NCQ FUA writes..
--
Robert Hancock Saskatoon, SK, Canada
To email, remove nospam from [EMAIL PROTECTED]
Home Page: http
-by: Robert Hancock [EMAIL PROTECTED]
--- linux-2.6.20-git6edit/drivers/ata/sata_nv.c.before_hacking 2007-02-15
18:19:13.0 -0600
+++ linux-2.6.20-git6edit/drivers/ata/sata_nv.c 2007-02-15 22:36:02.0
-0600
@@ -219,6 +219,7 @@
void __iomem * gen_block;
void __iomem
. Also, it's been inadvertently tested (it seems that
pata_amd Nvidia cable detection is broken in current -git..)
Signed-off-by: Robert Hancock [EMAIL PROTECTED]
--- linux-2.6.20-git6/drivers/ata/libata-core.c 2007-02-11 17:31:19.0
-0600
+++ linux-2.6.20-git6edit/drivers/ata/libata
This patch series contains several fixes for issues I noticed while
debugging some command timeout problems. None of these proved to be
related to that issue, but they fall into the category of things
we should be doing anyway.
Split into separate patches to ease bisecting in case of issues.
Clean up the initialization of the CPB and APRD structures so that we
strictly follow the rules for ordering of writes to the CPB flags and
response flags, and prevent duplicate initialization.
Signed-off-by: Robert Hancock [EMAIL PROTECTED]
--- linux-2.6.20-git6edit/drivers/ata/sata_nv.c 2007
When error handling occurs with pending commands, output the contents
of the next CPB count and next CPB index registers as well as the others,
since these may be useful for debugging.
Signed-off-by: Robert Hancock [EMAIL PROTECTED]
--- linux-2.6.20-git6edit/drivers/ata/sata_nv.c 2007-02-15 22
We already have code that handles hotplug interrupt indications in ADMA
mode, this turns on the control flag that actually enables these interrupts.
Also fixes some cases in the same functions where a 16-bit register was read
using a readl instead of a readw.
Signed-off-by: Robert Hancock [EMAIL
This edits the taskfile setup to more closely match the way that libata
sends the taskfile for other controllers. This avoids putting taskfile writes
into the CPB buffer that are not needed according to the taskfile flags.
Signed-off-by: Robert Hancock [EMAIL PROTECTED]
--- linux-2.6.20
, accessing them will likely result in a cache miss.
Signed-off-by: Robert Hancock [EMAIL PROTECTED]
--- linux-2.6.20-git6edit/drivers/ata/sata_nv.c 2007-02-15 22:36:02.0
-0600
+++ linux-2.6.20-git6edit/drivers/ata/sata_nv.c.delayandfixes 2007-02-19
17:00:14.0 -0600
@@ -853,22
(since that one is known to have
problems) as well as for ITE821x when in smart mode.
Signed-off-by: Robert Hancock [EMAIL PROTECTED]
---
Any comments on this version? It's essentially what I posted previously
in libata FUA revisited, except that the default for FUA support remains
off, so
like pata_amd does an
ata_pci_clear_simplex only for certain chip models, maybe this model
needs it as well?
--
Robert Hancock Saskatoon, SK, Canada
To email, remove nospam from [EMAIL PROTECTED]
Home Page: http://www.roberthancock.com/
-
To unsubscribe from this list: send the line
Jeff Garzik wrote:
Robert Hancock wrote:
It's curious that only the post-cache-flush command is having issues,
and normal NCQ operation seems fine. Maybe it's related to that tag 0
being reused repeatedly?
If you take cache flush out of the equation, what happens when NCQ is
enabled
the commands to the controller, using the
APPEND register. That's another thing that's not in the ADMA standard.
It's curious that only the post-cache-flush command is having issues,
and normal NCQ operation seems fine. Maybe it's related to that tag 0
being reused repeatedly?
--
Robert Hancock
..
--
Robert Hancock Saskatoon, SK, Canada
To email, remove nospam from [EMAIL PROTECTED]
Home Page: http://www.roberthancock.com/
-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo
. Eric, do you have any info on the blacklisting of that
Maxtor 7B250S0 drive? I would hope that Silicon Image would have a good
reason for blacklisting that one..
--
Robert Hancock Saskatoon, SK, Canada
To email, remove nospam from [EMAIL PROTECTED]
Home Page: http://www.roberthancock.com
ADMA-capable controllers provide a bit in the status register that appears
to indicate that the controller detected an SError condition. Update sata_nv
to detect this and trigger error handling in order to handle the fault.
Signed-off-by: Robert Hancock [EMAIL PROTECTED]
--- drivers/ata
it won't spew at inappropriate times like suspend/resume.
Signed-off-by: Robert Hancock [EMAIL PROTECTED]
--- linux-2.6.20-git6/drivers/ata/sata_nv.c 2007-02-11 17:31:19.0
-0600
+++ linux-2.6.20-git6edit/drivers/ata/sata_nv.c 2007-02-11 17:40:48.0
-0600
@@ -1442,6 +1442,26
HTS541010G9SA00 MBZOC60D
(the latter 3 being Hitachi Travelstar drives)
--
Robert Hancock Saskatoon, SK, Canada
To email, remove nospam from [EMAIL PROTECTED]
Home Page: http://www.roberthancock.com/
-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the body
that problem,
this is something we should likely be doing in any case.
Signed-off-by: Robert Hancock [EMAIL PROTECTED]
--- linux-2.6.20-rc6-mm3/drivers/ata/sata_nv.c 2007-02-04 21:48:25.0
-0600
+++ linux-2.6.20-rc6-mm3edit/drivers/ata/sata_nv.c 2007-02-04
22:13:36.0 -0600
ata_pci_device_do_resume can fail if the PCI device couldn't be re-enabled.
Update sata_nv to propagate the return value from this call and to
not try to do any other resume activities if it fails. Fixes a compile
warning.
Signed-off-by: Robert Hancock [EMAIL PROTECTED]
--- linux-2.6.20-rc6
Stefan Richter wrote:
Robert Hancock wrote:
http://marc.theaimsgroup.com/?t=11692262122
It looks like Tejun's patch essentially does the same thing as mine with
the addition of the control from userspace. There is one exception
though, my patch also does the stop on removal of the SCSI
, the main how-to page I found had an addendum
that I gave up on this, it's too hard, I just attach the patches. If
anyone has gotten any new insight..
--
Robert Hancock Saskatoon, SK, Canada
To email, remove nospam from [EMAIL PROTECTED]
Home Page: http://www.roberthancock.com
to read it.
Signed-off-by: Robert Hancock [EMAIL PROTECTED]
--
Robert Hancock Saskatoon, SK, Canada
To email, remove nospam from [EMAIL PROTECTED]
Home Page: http://www.roberthancock.com/
--- linux-2.6.20-rc6nv/drivers/ata/sata_nv.c2007-01-28 17:05:27.0
-0600
+++ linux-2.6.20
says this means
disable the standby timer, which effectively does nothing. Change this
to issue a STANDBY IMMEDIATE command which will actually spin the drive
down. The SAT (SCSI/ATA Translation) standard revision 9 concurs with
this choice.
Signed-off-by: Robert Hancock [EMAIL PROTECTED
-to-IDE drive enclosures. The support for
START STOP UNIT on those seems rather poor though, on one enclosure with
a Genesys bridge chip it returned a check condition with Invalid field
in CDB, and on another with a JMicron chip the request succeeded but it
didn't actually spin the drive down.
--
Robert
already dumps the state of all active commands on errors (and it also
triggers at times when it shouldn't, like when suspending). Take this
out.
Signed-off-by: Robert Hancock [EMAIL PROTECTED]
--- linux-2.6.20-rc5/drivers/ata/sata_nv.c 2007-01-12 23:18:08.0
-0600
+++ linux-2.6.20
Robert Hancock wrote:
-In the error_handler function the code would always go through and do
an ADMA channel reset and also dump out the state of all the CPBs. This
reset seems heinous in this situation since we haven't even decided to
reset anything yet. The output seems redundant
Since I've been the one making the most changes in sata_nv lately I
figured I would make some more comments on this patch:
Subject:
RE: [PATCH] SCSI: Add the SGPIO support for sata_nv.c
From:
Peer Chen [EMAIL PROTECTED]
Date:
Tue, 7 Nov 2006 17:55:11 +0800
To:
Christoph Hellwig [EMAIL
potentially still be
used.
Signed-off-by: Robert Hancock [EMAIL PROTECTED]
--- linux-2.6.19-rc6-mm2/drivers/ata/sata_nv.c 2006-12-12 17:49:02.0
-0600
+++ linux-2.6.19-rc6-mm2admafix/drivers/ata/sata_nv.c 2006-12-11
22:15:58.0 -0600
@@ -49,7 +49,7 @@
#include linux/libata.h
change for sata_nv introduced a potential bug where
the hpriv structure could be used after it was freed in nv_remove_one.
Fix that.
Signed-off-by: Robert Hancock [EMAIL PROTECTED]
---
Robert Hancock Saskatoon, SK, Canada
To email, remove nospam from [EMAIL PROTECTED]
Home Page: http
, this also removes the inline helper functions
for getting ADMA register locations by storing the pointers so we don't
have to keep calculating them all the time.
Signed-off-by: Robert Hancock [EMAIL PROTECTED]
---
Robert Hancock Saskatoon, SK, Canada
To email, remove nospam from [EMAIL
-by: Robert Hancock [EMAIL PROTECTED]
--
Robert Hancock Saskatoon, SK, Canada
To email, remove nospam from [EMAIL PROTECTED]
Home Page: http://www.roberthancock.com/
--- linux-2.6.19-rc6-mm1/drivers/ata/sata_nv.c 2006-11-25 10:04:14.0
-0600
+++ linux-2.6.19-rc6-mm1-admafix/drivers/ata
101 - 166 of 166 matches
Mail list logo
