Re: [PATCH 14/63] ide-cd: fix trailing whitespaces in changelog

2007-12-21 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http

[PATCH pata-2.6] hpt366: merge set_dma_mode() methods

2007-12-14 Thread Sergei Shtylyov
Group the array of pointers to the timing tables with the timing register masks which allows us to merge HPT36x/HPT37x set_dma_mode() methods into one. Signed-off-by: Sergei Shtylyov [EMAIL PROTECTED] --- The patch is against the pata-2.6 patchset... drivers/ide/pci/hpt366.c | 129

Re: [PATCH 14/20] ide: convert empty REQ_TYPE_ATA_CMD requests to use REQ_TYPE_ATA_TASKFILE

2007-12-13 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: Based on the previous work by Tejun Heo. There should be no functionality changes caused by this patch. I didn't get the point. Why do you consider them empty? Cc: Tejun Heo [EMAIL PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED]

Re: [PATCH 15/20] ide: don't enable local IRQs for PIO-in in driver_cmd_intr()

2007-12-13 Thread Sergei Shtylyov
). Cc: Sergei Shtylyov [EMAIL PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info

Re: [PATCH 17/21] ide: drop 'initializing' argument from ide_register_hw()

2007-12-13 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: * Rename init_hwif_data() to ide_init_port_data() and export it. * For all users of ide_register_hw() with 'initializing' argument set hwif-present and hwif-hold are always zero so convert these host drivers to use

Re: [PATCH 17/21] ide: drop 'initializing' argument from ide_register_hw()

2007-12-13 Thread Sergei Shtylyov
-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 20/21] ide: fix host drivers depending on ide_generic to probe for interfaces

2007-12-12 Thread Sergei Shtylyov
Hello. Bartlomiej Zolnierkiewicz wrote: * Add mpc8xx_ide_probe() to mpc8xx.c and call it from probe_for_hwifs(). * Convert ide_arm, ide-cris, ide-h8300, ide-pnp, buddha, falconide, gayle, macide, q40ide, cmd640 and mpc8xx host drivers to use ide_device_add(). This removes dependency

Re: [PATCH 17/21] ide: drop 'initializing' argument from ide_register_hw()

2007-12-11 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: * Rename init_hwif_data() to ide_init_port_data() and export it. * For all users of ide_register_hw() with 'initializing' argument set hwif-present and hwif-hold are always zero so convert these host drivers to use

Re: [PATCH] hpt366: fix HPT37x PIO mode timings (take 2)

2007-12-10 Thread Sergei Shtylyov
Hello. Bartlomiej Zolnierkiewicz wrote: --- Many PIO modes at 55/66 MHz (as well as MDDMA modes at all clocks) are also underclocked but I decided not to touch them, at least for the time being. The patch is against the Linus' tree, with PIO0 setup time correct this time... Since it is

Re: [PATCH pata-2.6] hpt366: change timing register masks

2007-12-10 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: Since PIO autotuning is now done always, there's no need anymore to program the taskfile timings also on DMA modes, so chenge the IDE timing register masks accordingly, inverting the polarity of the masks while at it... Signed-off-by: Sergei Shtylyov [EMAIL

Re: [PATCH 1/20] ide: fix -io_32bit race in set_io_32bit()

2007-12-10 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: set_io_32bit() (ide_procset_t function) can race against running PIO transfers. Fix it by using ide_spin_wait_hwgroup(). Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei - To unsubscribe

Re: [PATCH 5/20] ide: fix final status check in task_in_intr()

2007-12-10 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: Check for DRQ bit being cleared on the final status check. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei - To unsubscribe from this list: send the line unsubscribe linux-ide in the body

Re: [PATCH 4/20] ide: clear HOB bit for REQ_TYPE_ATA_CMD requests in ide_end_drive_cmd()

2007-12-10 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: ide_dump_status() may set HOB bit before ide_end_drive_cmd() is called. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei - To unsubscribe from this list: send the line unsubscribe linux-ide

Re: [PATCH 11/20] ide: kill DATA_READY define

2007-12-10 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http

Re: [PATCH 12/20] ide: use wait_drive_not_busy() in drive_cmd_intr()

2007-12-10 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] Index: b/drivers/ide/ide-taskfile.c === --- a/drivers/ide/ide-taskfile.c +++ b/drivers/ide

Re: [PATCH 13/20] ide: initialize rq-cmd_type in ide_init_drive_cmd() callers

2007-12-10 Thread Sergei Shtylyov
PROTECTED] Despite the patch hardly seems necessary to me Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 16/20] ide: check BUSY and ERROR status bits before reading data in drive_cmd_intr()

2007-12-10 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http

Re: [PATCH 15/20] ide: don't enable local IRQs for PIO-in in driver_cmd_intr()

2007-12-10 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: Don't enable local IRQs for PIO-in protocol in driver_cmd_intr(). While at it: * Remove redundant rq-cmd_type check. * Read status register after enabling local IRQs for no-data protocol. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED]

Re: [PATCH 17/20] ide: fix final status check in drive_cmd_intr()

2007-12-10 Thread Sergei Shtylyov
[EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH] hpt366: fix HPT37x PIO mode timings (take 2)

2007-12-08 Thread Sergei Shtylyov
). Signed-off-by: Sergei Shtylyov [EMAIL PROTECTED] --- Many PIO modes at 55/66 MHz (as well as MDDMA modes at all clocks) are also underclocked but I decided not to touch them, at least for the time being. The patch is against the Linus' tree, with PIO0 setup time correct this time... drivers

[PATCH pata-2.6] hpt366: change timing register masks

2007-12-08 Thread Sergei Shtylyov
Since PIO autotuning is now done always, there's no need anymore to program the taskfile timings also on DMA modes, so chenge the IDE timing register masks accordingly, inverting the polarity of the masks while at it... Signed-off-by: Sergei Shtylyov [EMAIL PROTECTED] --- The patch is against

[PATCH pata-2.6] hpt366: kill set_dma_mode() method wrapper

2007-12-08 Thread Sergei Shtylyov
There's no reason to keep the set_dma_mode() method wrapper for two different chip families, so get rid of it... Signed-off-by: Sergei Shtylyov [EMAIL PROTECTED] --- The patch is against the pata-2.6 patchset... drivers/ide/pci/hpt366.c | 21 +++-- 1 files changed, 7

Re: Peculiar out-of-sync boot log lines

2007-12-07 Thread Sergei Shtylyov
Hello. Bartlomiej Zolnierkiewicz wrote: [PATCH] ide: DMA reporting and validity checking fixes (take 2) * ide_xfer_verbose() fixups: - beautify returned mode names - fix PIO5 reporting - make it return 'const char *' * Change printk() level from KERN_DEBUG to KERN_INFO in

[PATCH pata-2.6] hpt366: fix HPT37x PIO mode timings

2007-12-07 Thread Sergei Shtylyov
). Signed-off-by: Sergei Shtylyov [EMAIL PROTECTED] --- Many PIO modes at 55/66 MHz (as well as MDDMA modes at all clocks) are also underclocked but I decided not to touch them, at least for the time being... The patch is agains the Linus' tree. drivers/ide/pci/hpt366.c | 71

Re: [PATCH 8/21] ide: don't try to unregister interfaces if 'initializing' in ide_register_hw()

2007-12-07 Thread Sergei Shtylyov
. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH pata-2.6] hpt366: fix HPT37x PIO mode timings

2007-12-07 Thread Sergei Shtylyov
timings have been tested on HPT370 chip (at 33 MHz PCI clock) and on HPT371N chip (at both 50 and 66 MHz DPLL clock). Signed-off-by: Sergei Shtylyov [EMAIL PROTECTED] Will post the updated patch later... MBR, Sergei - To unsubscribe from this list: send the line unsubscribe linux-ide

Re: [PATCH 9/9] ide-disk: use do_rw_taskfile()

2007-12-07 Thread Sergei Shtylyov
Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 10/13] ide-cris: fix DMA methods

2007-12-07 Thread Sergei Shtylyov
[EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 9/21] ide: kill probe_hwif_init()

2007-12-07 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: There should be no functionality changes caused by this patch. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei - To unsubscribe from this list: send the line unsubscribe linux-ide

Re: a question about interrupt of IDE controller( bug 5637)

2007-12-05 Thread Sergei Shtylyov
Hello. Alan Cox wrote: When IDE device works in legacy mode, the IRQ of IDE is fixed at 14/15 for the two channel. But IDE controller is a PCI device, OS will assign an interrupt number for the PCI device in which IDE controller resides. This is realized by calling ide_pci_enable, which will

Re: reset IOCTLs

2007-12-04 Thread Sergei Shtylyov
Hello. Kantor Zsolt wrote: Can somebody tell me what is the difference between these reset commands (I'm developing an open source application and I would like to know this): one is in the cdrom.h (CDROMRESET - 0x5312), This one seems to be handled only by discrete (non-IDE) CD-ROM

Re: [PATCH 2/6] ide: remove stale changelog from ide-disk.c

2007-12-04 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http

Re: [PATCH 6/6] cmd64x: remove /proc/ide/cmd64x

2007-12-04 Thread Sergei Shtylyov
They're 0 there anyway, so the code worked properly. Also while at it remove unused CNTRL_DIS_RA0/1 defines. Cc: Sergei Shtylyov [EMAIL PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei - To unsubscribe from

Re: [PATCH 1/6] ide: remove dead code from __ide_dma_test_irq()

2007-12-04 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http

Re: [PATCH 3/6] ide: remove stale changelog from ide-probe.c

2007-12-04 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http

Re: [PATCH 5/6] ide: remove broken disk byte-swapping support

2007-12-04 Thread Sergei Shtylyov
dust it off if needed). ] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http

Re: [PATCH v2 4/4] [libata] pata_platform: s/ioport_shift/reg_shift/g

2007-12-04 Thread Sergei Shtylyov
registers, despite the fact that shifting is meaningless for ctl register. This patch should make Sergei Shtylyov a bit more happy. ;-) In fact, I don't care about how platform driver calls this stuff. ;-) I only care about the property name. MBR, Sergei - To unsubscribe from this list: send

Re: reset IOCTLs

2007-12-04 Thread Sergei Shtylyov
Kantor Zsolt wrote: Thanks a lot ! I have one more question: I see that the HDIO_DRIVE_RESET - 0x031c is a soft reset, but the WIN_DEVICE_RESET - 0x08 for ATAPI devices is a soft reset too ? Yes. and the first one for non-IDE CD-ROMs is a hard reset ? Don't know. because in the

Re: [PATCH 26/28] blk_end_request: changing ide-cd (take 3)

2007-12-03 Thread Sergei Shtylyov
PROTECTED] Cc: [EMAIL PROTECTED] Cc: Kiyoshi Ueda [EMAIL PROTECTED] Cc: Jun'ichi Nomura [EMAIL PROTECTED] Cc: Tejun Heo [EMAIL PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei - To unsubscribe from this list: send the line

Re: [PATCH 2/3] [libata] pata_of_platform: OF-Platform PATA device driver

2007-11-30 Thread Sergei Shtylyov
Anton Vorontsov wrote: Remaining question: any preferred name for that property? pio-mode okay? It's assuming that PIO6 capable bus supports PIO0 as well, thus no mask. I've already suggested generic. A name simple also comes to my mind. You've misread my question. I didn't ask about

Re: [PATCH 2/3] [libata] pata_of_platform: OF-Platform PATA device driver

2007-11-30 Thread Sergei Shtylyov
Anton Vorontsov wrote: Remaining question: any preferred name for that property? pio-mode okay? It's assuming that PIO6 capable bus supports PIO0 as well, thus no mask. I've already suggested generic. A name simple also comes to my mind. You've misread my question. I didn't ask about

Re: [PATCH 2/3] [libata] pata_of_platform: OF-Platform PATA device driver

2007-11-30 Thread Sergei Shtylyov
Anton Vorontsov wrote: Remaining question: any preferred name for that property? pio-mode okay? It's assuming that PIO6 capable bus supports PIO0 as well, thus no mask. I've already suggested generic. A name simple also comes to my mind. WBR, Sergei - To unsubscribe from this list: send

Re: [PATCH 8/8] ide: make CONFIG_IDEPCI_PCIBUS_ORDER visible and deprecate it

2007-11-30 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http

Re: [PATCH 5/8] ide: fix ide_scan_pcibus() error message

2007-11-30 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http

Re: [PATCH 14/15] ide: remove 'command_type' field from ide_task_t

2007-11-29 Thread Sergei Shtylyov
be no functionality changes caused by this patch. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info

Re: [PATCH 6/9] ide: remove 'handler' field from ide_task_t

2007-11-29 Thread Sergei Shtylyov
. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 5/6] rapide: remove write-only hwif-hwif_data

2007-11-28 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: Cc: Russell King [EMAIL PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL

Re: [PATCH 6/6] ide-pmac: use custom hwif-sg_max_nents only if DMA support is enabled

2007-11-28 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: Move setting hwif-sg_max_nents from pmac_ide_setup_device() to pmac_ide_setup_dma(). Cc: Benjamin Herrenschmidt [EMAIL PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei

Re: [PATCH 3/6] ide: always use ide_std_init_ports() in setup-pci.c

2007-11-28 Thread Sergei Shtylyov
and thus hwif-io_ports[IDE_DATA_OFFSET] is also non-zero always clear hwif-noprobe. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei - To unsubscribe from this list: send the line unsubscribe linux-ide in the body

Re: [PATCH 2/6] au1xxx-ide: use ide_init_port_hw()

2007-11-28 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http

Re: [PATCH 1/6] au1xxx-ide: au_ide_probe() fixes

2007-11-28 Thread Sergei Shtylyov
if CONFIG_BLK_DEV_IDE_AU1XXX_MDMA2_DBDMA is defined? Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info

Re: [PATCH 2/3] [libata] pata_of_platform: OF-Platform PATA device driver

2007-11-28 Thread Sergei Shtylyov
Anton Vorontsov wrote: This driver nicely wraps around pata_platform library functions, and provides OF platform bus bindings to the PATA devices. +static struct of_device_id pata_of_platform_match[] = { + { .compatible = pata-platform, }, +}; pata-platform really means nothing

Re: [PATCH 2/3] [libata] pata_of_platform: OF-Platform PATA device driver

2007-11-28 Thread Sergei Shtylyov
Hello. Arnd Bergmann wrote: This driver nicely wraps around pata_platform library functions, and provides OF platform bus bindings to the PATA devices. +static struct of_device_id pata_of_platform_match[] = { + { .compatible = pata-platform, }, +}; pata-platform really means nothing

Re: [PATCH 11/21] rapide: set hwif-chipset

2007-11-27 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: hwif-chipset should be set if the hwif is claimed by host driver. Cc: Russell King [EMAIL PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei - To unsubscribe from this list: send

Re: [PATCH 13/21] ide: add hwif-chipset fixup to ide_device_add()

2007-11-27 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: Add hwif-chipset fixup identical to the one in ideprobe_init() to ide_device_add(). Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei - To unsubscribe from this list: send the line

Re: [PATCH 15/21] sgiioc4: always init hwif-io_ports

2007-11-27 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: 'if (hwif-io_ports[IDE_DATA_OFFSET] != cmd_base)' is always true. Cc: Jeremy Higdon [EMAIL PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei - To unsubscribe from this list: send

Re: [PATCH 7/21] ide-cris: don't override ide_register_hw() result

2007-11-27 Thread Sergei Shtylyov
-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 19/21] cmd640: fix dependency on IDE_GENERIC

2007-11-27 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: Make BLK_DEV_CMD640 select IDE_GENERIC. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message

Re: [PATCH 16/21] ide: add ide_init_port_hw() helper

2007-11-27 Thread Sergei Shtylyov
be no functionality changes caused by this patch. Cc: Russell King [EMAIL PROTECTED] Cc: Anton Vorontsov [EMAIL PROTECTED] Cc: Jeremy Higdon [EMAIL PROTECTED] Cc: Benjamin Herrenschmidt [EMAIL PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED

Re: [PATCH 3/3] [POWERPC] MPC8349E-mITX: introduce localbus and pata nodes

2007-11-27 Thread Sergei Shtylyov
Hello. Anton Vorontsov wrote: This patch adds localbus and pata nodes to use CF IDE interface on MPC8349E-mITX boards. Patch also adds code to probe localbus. Signed-off-by: Anton Vorontsov [EMAIL PROTECTED] --- arch/powerpc/boot/dts/mpc8349emitx.dts| 17 -

Re: [PATCH 3/3] [POWERPC] MPC8349E-mITX: introduce localbus and pata nodes

2007-11-27 Thread Sergei Shtylyov
Anton Vorontsov wrote: This patch adds localbus and pata nodes to use CF IDE interface on MPC8349E-mITX boards. Patch also adds code to probe localbus. Signed-off-by: Anton Vorontsov [EMAIL PROTECTED] --- arch/powerpc/boot/dts/mpc8349emitx.dts| 17 -

Re: [PATCH 3/3] [POWERPC] MPC8349E-mITX: introduce localbus and pata nodes

2007-11-27 Thread Sergei Shtylyov
Anton Vorontsov wrote: All I want is that ioport-* be renamed. I give up. Don't. :-) The final name is..? I can think out wrong one, so you'd better convoy me on that way. ;-) reg-shift sounds okay? Yes. Thanks, WBR, Sergei - To unsubscribe from this list: send the line

Re: [PATCH 3/3] [POWERPC] MPC8349E-mITX: introduce localbus and pata nodes

2007-11-27 Thread Sergei Shtylyov
Anton Vorontsov wrote: 2. ioport because shift^Wstride ;-) applies only to the io range (yes, it's obvious, but worth open-wording, no?). Contrarywise, to memory range. By io range I meant I/O base, in contrast to CTL base. There is no need to apply shifting for CTL. That's why

Re: [PATCH 3/3] [POWERPC] MPC8349E-mITX: introduce localbus and pata nodes

2007-11-27 Thread Sergei Shtylyov
Anton Vorontsov wrote: 2. ioport because shift^Wstride ;-) applies only to the io range (yes, it's obvious, but worth open-wording, no?). Contrarywise, to memory range. By io range I meant I/O base, in contrast to CTL base. There is no need to apply shifting for CTL. That's why

Re: [PATCH 2/21] ide: merge -fixup and -quirkproc methods

2007-11-27 Thread Sergei Shtylyov
. Then convert ide_register_hw() to accept 'quirkproc' argument instead of 'fixup' one. * Remove no longer needed -fixup method. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei - To unsubscribe from this list: send the line

Re: [PATCH] alim15x3: add Mitac 8317 and derivatives to ali_cable_override()

2007-11-23 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: Port of Alan's patch for pata_ali.c. Cc: Alan Cox [EMAIL PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei - To unsubscribe from this list: send the line unsubscribe linux-ide

Re: [PATCH] piix: add HP compaq laptop to short cable list

2007-11-23 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: Port of Jeff's libata commit 54174db300ee1bac632d62e4ac37fe02e47d1f18 ([libata] ata_piix: add HP compaq laptop to short cable list). Cc: Jeff Garzik [EMAIL PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov

Re: [PATCH] ali14xx: constify __initdata

2007-11-23 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http

Re: Lost interrupt with cmd 64x

2007-11-23 Thread Sergei Shtylyov
Hello. Bartlomiej Zolnierkiewicz wrote: This problem should have been already fixed by: http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=6183289cd4356b790c5eaa619020fb887ec0fa44 which was merged into 2.6.24-rc3. Put your attenction at the version

Re: [PATCH] trm290: remove bogus init_hwif_trm290() comment

2007-11-23 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http

Re: [PATCH] ide: remove bogus ide_fix_driveid() comment

2007-11-23 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http

Re: [PATCH] ide: add TORiSAN model: CD-ROM CDR_U200 fw: 1.09 to DMA blacklist

2007-11-23 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: Based on the report from [EMAIL PROTECTED] Should fix kernel bugzilla bug #9195. Cc: [EMAIL PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei - To unsubscribe from this list

Re: [PATCH 6/21] ide: move CONFIG_IDE_ETRAX to drivers/ide/Kconfig

2007-11-21 Thread Sergei Shtylyov
it be the other way around, i.e. BLK_DEV_IDEDMA is enabled by ETRAX_IDE as is the case with this option otherwise? Well, having a simple config BLK_DEV_IDEDMA bool and making the other options select it seems to be a better solution. Well, then Acked-by: Sergei Shtylyov [EMAIL

Re: [PATCH 3/21] macide/q40ide: add missing __init tag to {macide,q40ide}_init()

2007-11-19 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http

Re: [PATCH 1/21] ide: dump taskfile HOB registers in ide_tf_load() (if DEBUG is defined)

2007-11-19 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: * Dump taskfile HOB registers in ide_tf_load() (if DEBUG is defined). * Remove no longer needed DEBUG code from __ide_do_rw_disk(). Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei

Re: [PATCH 5/21] ide: add CONFIG_IDE_H8300 config option

2007-11-19 Thread Sergei Shtylyov
] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH] pata_sil680: kill bogus reset code

2007-11-16 Thread Sergei Shtylyov
Since writing to two reserved bits ain't much of a housekeeping, I think it's time we get rid of the custom error handler in this driver. ;-) Signed-off-by: Sergei Shtylyov [EMAIL PROTECTED] --- This code has been discussed 4 months ago, and is still in the same state. :-| The patch is against

Re: [PATCH] ide: don't set PIO mode on pre-EIDE drives

2007-11-16 Thread Sergei Shtylyov
Alan Cox wrote: Fix handling of the PIO modes for the pre-EIDE drives that did not support the PIO Flow Control Transfer Mode value (1 nnn) of the Set Transfer Mode feature by skipping the actual mode programming. You also need to cater for CF 1.1 compliant devices which do not have

Re: [PATCH][RESUBMIT] drivers/ide/ide-probe.c, kernel 2.6.23.1

2007-11-16 Thread Sergei Shtylyov
Jonas Stare wrote: diff -u linux-2.6.23.1-orig/drivers/ide/ide-probe.c linux-2.6.23.1/drivers/ide/ide-probe.c --- linux-2.6.23.1-orig/drivers/ide/ide-probe.c 2007-10-12 18:43:44.0 +0200 +++ linux-2.6.23.1/drivers/ide/ide-probe.c 2007-11-16 10:26:23.0 +0100 @@ -643,6

[PATCH] siimage: remove resetproc() method

2007-11-16 Thread Sergei Shtylyov
The intent behind siimage_reset() was probably to hard reset the interface and the SATA PHY but as the code writes to two reserved bits instead, it obviously has been ineffective from the start. So, just remove it. Signed-off-by: Sergei Shtylyov [EMAIL PROTECTED] --- This was discussed on linux

Re: [PATCH 7/9] via82cxxx: keep local ide_pci_device_t copy

2007-11-16 Thread Sergei Shtylyov
IDE_HFLAGS_VIA define. * Bump driver version. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info

Re: [PATCH] cmd64x: don't clear the other channels interrupt

2007-11-16 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: Make sure to not clear the other IDE channel's interrupt when clearing an IDE interrupt via the MRDMODE register. Thanks to Bart for finding a coding mistake. Could you resend with Signed-off-by: and Tested-by: tags? [ A reference to the problematic

Re: [PATCH 14/18] ide: add IDE_HFLAG_ABUSE_SET_DMA_MODE host flag

2007-11-15 Thread Sergei Shtylyov
Hello, I wrote: It's tome that I go and make a patch which deals with 0x00 (default s/tome/time/ PIO mode)... But I'm unsure how this value could reach us form userspace because of the argument check present everywhere that filters out 0 value form being passed -- look at

Re: [PATCH 9/18] ide: kill duplicate code in ide_dump_{ata,atapi}_status()

2007-11-14 Thread Sergei Shtylyov
[EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 4/13] cy82c693: correct DMA modes clipping

2007-11-14 Thread Sergei Shtylyov
to be Alpha specific though) * Bump driver version. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo

Re: [PATCH 9/13] ide: remove -ide_dma_on and -dma_off_quietly methods from ide_hwif_t

2007-11-14 Thread Sergei Shtylyov
() and ide_dma_off_quietly() instead. * Remove no longer needed -ide_dma_on and -dma_off_quietly methods from ide_hwif_t. * Make ide_dma_on() void. There should be no functionality changes caused by this patch. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei

Re: [PATCH 13/13] ide: merge -dma_host_{on,off} methods into -dma_host_set method

2007-11-14 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: Merge -dma_host_{on,off} methods into -dma_host_set method which takes 'int on' argument. There should be no functionality changes caused by this patch. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED

Re: [PATCH 8/13] au1xxx-ide: add ide_toggle_bounce() calls

2007-11-13 Thread Sergei Shtylyov
Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 6/13] sgiioc4: add ide_toggle_bounce() calls

2007-11-13 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: Add ide_toggle_bounce() call to -ide_dma_on/-dma_off_quietly methods so they match generic __ide_dma_on()/ide_dma_off_quietly(). Cc: Jeremy Higdon [EMAIL PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL

Re: [PATCH 7/13] icside: add ide_toggle_bounce() calls

2007-11-13 Thread Sergei Shtylyov
Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 12/13] ide: move drive-using_dma check to callers of -dma_host_on method

2007-11-13 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei Index: b/drivers/ide/ide-dma.c === --- a/drivers/ide/ide-dma.c +++ b/drivers

Re: [PATCH 1/13] serverworks: cleanup -set_dma_mode method

2007-11-13 Thread Sergei Shtylyov
), ultra_timing); Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 5/9] ide: use -data_phase to set -handler in do_rw_taskfile()

2007-11-12 Thread Sergei Shtylyov
. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 8/9] ide-disk: add ide_tf_set_cmd() helper

2007-11-12 Thread Sergei Shtylyov
__ide_do_rw_disk() to use the new ide_tf_set_cmd() helper. There should be no functionality changes caused by this patch. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei - To unsubscribe from this list: send the line unsubscribe linux

Re: [PATCH 7/18] ide: add ide_tf_read() helper

2007-11-09 Thread Sergei Shtylyov
[EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] Index: b/include/linux/ide.h === --- a/include/linux/ide.h +++ b/include/linux/ide.h @@ -913,6 +913,27 @@ enum { IDE_TFLAG_IN_DATA = (1 17

[PATCH] cmd64x: don't clear the other channels interrupt

2007-11-09 Thread Sergei Shtylyov
Make sure to not clear the other IDE channel's interrupt when clearing an IDE interrupt via the MRDMODE register. Thanks to Bart for finding a coding mistake. --- The patch is against the Linus tree. drivers/ide/pci/cmd64x.c |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-)

Re: [PATCH 3/15] ide: remove ata_status_t and atapi_status_t

2007-11-09 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: Remove ata_status_t (unused) and atapi_status_t. While at it: * replace 'HWIF(drive)' by 'drive-hwif' (or just 'hwif' where possible) Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei

Re: [PATCH 8/15] ide-cd: fix register loading order in cdrom_start_packet_command()

2007-11-09 Thread Sergei Shtylyov
comment in the right place. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http

Re: [PATCH 15/15] ide: remove 'tf_in_flags' field from ide_task_t

2007-11-09 Thread Sergei Shtylyov
-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 3/9] ide: merge flagged_taskfile() into do_rw_taskfile()

2007-11-09 Thread Sergei Shtylyov
-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

<    1   2   3   4   5   6   7   8   >