Bob Ham wrote:
hpt37x: DPLL did not stabilize.
pata_hpt37x: BIOS has not set timing clocks.
hpt37x: DPLL did not stabilize.
Yes, this ia a known issue, and the fix for it is in the -mm tree:
I applied just that pata_hpt37x.c patch, not the whole -mm tree. It
locks the machine hard
Bob Ham wrote:
I've had a Highpoint Rocket 1540 (not RocketRAID) SATA controller for
a while now, using a proprietary binary driver from Highpoint in a linux
2.4 kernel. The chipset is an hpt374. The hpt366 driver freezes on
boot, as reported by others.
Can we see a bootlog please?
I'm
PROTECTED]
Acked-by: Sergei Shtylyov [EMAIL PROTECTED]
diff -u --new-file --recursive --exclude-from /usr/src/exclude
linux.vanilla-2.6.23rc1-mm1/drivers/ata/libata-core.c
linux-2.6.23rc1-mm1/drivers/ata/libata-core.c
--- linux.vanilla-2.6.23rc1-mm1/drivers/ata/libata-core.c 2007-07-26
15
Hello, I wrote:
I've had a Highpoint Rocket 1540 (not RocketRAID) SATA controller for
a while now, using a proprietary binary driver from Highpoint in a linux
2.4 kernel. The chipset is an hpt374. The hpt366 driver freezes on
boot, as reported by others.
Can we see a bootlog please?
Hello.
Bartlomiej Zolnierkiewicz wrote:
* Move ide_in_drive_list() from ide-dma.c to ide-iops.c.
* Add ivb_list[] table for listening early UDMA66 devices which don't conform
to ATA4 standard wrt cable detection (bit14 is zero, only bit13 is valid)
and use only device side cable
Hello, I wrote:
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED]
Acked-by: Sergei Shtylyov [EMAIL PROTECTED]
Oh, sorry for the dupe ack's... :-
I'd just noticed that I didn't ack the amd74xx patch, so thought I hadn't
ack'ed all the series.
MBR, Sergei
-
To unsubscribe
Bartlomiej Zolnierkiewicz wrote:
Ok, there's a combination of things here:
- First, doing a set_pio from userland (hdparm -p XX) causes the kernel
to disable DMA, which I think is incorrect. It's not the case with
2.6.22 from my quick tests. The problem is that ide_config_drive_speed
Bartlomiej Zolnierkiewicz wrote:
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED]
Acked-by: Sergei Shtylyov [EMAIL PROTECTED]
MBR, Sergei
-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http
redundant
setting of -{init,current}_speed.
* Bump driver version.
Acked-by: Sergei Shtylyov [EMAIL PROTECTED]
MBR, Sergei
PS: There's no need to notify about Acked-by: addition I think -- would save
everyone a keystroke or two... ;-)
-
To unsubscribe from this list: send the line unsubscribe
Hello.
Bartlomiej Zolnierkiewicz wrote:
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED]
Acked-by: Sergei Shtylyov [EMAIL PROTECTED]
MBR, Sergei
-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the body of a message to [EMAIL PROTECTED]
More majordomo info
Hello again. :-)
Bartlomiej Zolnierkiewicz wrote:
* Convert {ide_hwif_t,ide_pci_device_t}-host_flag to be u16.
* Add IDE_HFLAG_POST_SET_MODE host to indicate the need to program the
host for the transfer mode after programming the device. Set it in
-by: Sergei Shtylyov [EMAIL PROTECTED]
MBR, Sergei
-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Bartlomiej Zolnierkiewicz wrote:
If -dma_base is not set (== PCI BAR4 cannot be reserved) then DMA hooks
shouldn't be initialized or bad things will happen.
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED]
Acked-by: Sergei Shtylyov [EMAIL PROTECTED]
MBR, Sergei
-
To unsubscribe
Bartlomiej Zolnierkiewicz wrote:
If -dma_base is not set (== PCI BAR4 cannot be reserved) then DMA hooks
shouldn't be initialized or bad things will happen.
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED]
Acked-by: Sergei Shtylyov [EMAIL PROTECTED]
MBR, Sergei
-
To unsubscribe
Bartlomiej Zolnierkiewicz wrote:
If -dma_base is not set (== PCI BAR4 cannot be reserved) then DMA hooks
shouldn't be initialized or bad things will happen.
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED]
Acked-by: Sergei Shtylyov [EMAIL PROTECTED]
MBR, Sergei
-
To unsubscribe
Hello.
Bartlomiej Zolnierkiewicz wrote:
On Fri, 27 Jul 2007 02:22:27 +0200
Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] wrote:
* Convert {ide_hwif_t,ide_pci_device_t}-host_flag to be u16.
* Add IDE_HFLAG_POST_SET_MODE host to indicate the need to program the
host for the transfer mode
Hello.
Jeff Garzik wrote:
Note that the olde driver has MWDMA fixed, and the new one has it
still borken, yet MWDMA2 is the mode you're using.
What about MWDMA is broken?
The code that sets MWDMA timings is completely bogus -- I've already
reported that before. And now I've fixed
Hello.
Jeff Garzik wrote:
Note that the olde driver has MWDMA fixed, and the new one has it
still borken, yet MWDMA2 is the mode you're using.
What about MWDMA is broken?
The code that sets MWDMA timings is completely bogus -- I've
already reported that before. And now I've fixed
Hello.
Vitaly Bordug wrote:
I acn undertand your complaint in the context of an OF driver
(which we don't have yet) but mmio-ide just means nothing to the
current driver, and it doesn't convery enough info on the
programming interface for the conceivable OF driver, it also does
need to know
Bartlomiej Zolnierkiewicz wrote:
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED]
Acked-by: Sergei Shtylyov [EMAIL PROTECTED]
MBR, Sergei
-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http
Zolnierkiewicz [EMAIL PROTECTED]
Acked-by: Sergei Shtylyov [EMAIL PROTECTED]
MBR, Sergei
-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Hello.
Guennadi Liakhovetski wrote:
driver to using platform-device. I got a reply, that it's not worth it now
that IDE is slowly becoming obsolete, and the pata_platform serves the
perpose perfectly well. I found this argument reasonable, I had the same
doubt, just wanted to double-check.
Hello, I wrote:
Also, what mmio-ide in the compat properly means in the context
of ide_platform which is able to handle both port and memory mapped
IDE.
I/O-space is only valid in the context of PCI, ISA, or similar buses,
and
the bus-specific reg format indicates whether it's mmio-space
Mikael Pettersson wrote:
This fix inspired me to finally try to convert my Sun Ultra5
(sparc64) with a CMD646 [1095:0646 rev 03] to libata.
With pata_cmd64x the machine has so far survived a usual
boot/mrproper/reconfig/make/install/reboot kernel update
cycle without any issues, and
Bartlomiej Zolnierkiewicz wrote:
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED]
Acked-by: Sergei Shtylyov [EMAIL PROTECTED]
-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http
Hello.
Alan Cox wrote:
I must have been half asleep when doing the original code
Signed-off-by: Alan Cox [EMAIL PROTECTED]
Acked-by: Sergei Shtylyov [EMAIL PROTECTED]
diff -u --new-file --recursive --exclude-from /usr/src/exclude
linux.vanilla-2.6.23rc1-mm1/drivers/ata/pata_cmd64x.c
Hello, I wrote:
diff --git a/arch/powerpc/boot/dts/mpc8349emitx.dts
b/arch/powerpc/boot/dts/mpc8349emitx.dts
index db0d003..f8f0e8a 100644
--- a/arch/powerpc/boot/dts/mpc8349emitx.dts
+++ b/arch/powerpc/boot/dts/mpc8349emitx.dts
@@ -37,6 +37,15 @@
reg = 1000;
Vitaly Bordug wrote:
This is now very similar to pata_platform.c, they both use
same platform data structure and same resources.
To achieve that, byte_lanes_swapping platform data variable
and platform specified iops removed from that driver. It's fine,
since those were never used anyway.
Hello.
Scott Wood wrote:
+hwif-hw.io_ports[IDE_DATA_OFFSET] = port;
+
+port += (1 pdata-ioport_shift);
+for (i = IDE_ERROR_OFFSET; i = IDE_STATUS_OFFSET;
+ i++, port += (1 pdata-ioport_shift))
Looks like shift doesn't buy as anything, why not just use stride?
It
Guennadi Liakhovetski wrote:
This is now very similar to pata_platform.c, they both use
same platform data structure and same resources.
To achieve that, byte_lanes_swapping platform data variable
and platform specified iops removed from that driver. It's fine,
since those were never used
Guennadi Liakhovetski wrote:
This is now very similar to pata_platform.c, they both use
same platform data structure and same resources.
To achieve that, byte_lanes_swapping platform data variable
and platform specified iops removed from that driver. It's fine,
since those were never used
Scott Wood wrote:
Scott Wood wrote:
Also, what mmio-ide in the compat properly means in the context
of ide_platform which is able to handle both port and memory mapped
IDE.
I/O-space is only valid in the context of PCI, ISA, or similar buses,
and
the bus-specific reg format indicates
Hello.
Scott Wood wrote:
Also, what mmio-ide in the compat properly means in the context of
ide_platform which is able to handle both port and memory mapped IDE.
I/O-space is only valid in the context of PCI, ISA, or similar buses, and
the bus-specific reg format indicates whether it's
Scott Wood wrote:
It doesn't buy us anything in here, but it's conceivable that someone
may want to write a driver that uses a shift in the I/O accessor
rather than an array of port offsets,
It wouldn't be IDE driver then, and neither it would be libata
which also does this another way
Hello.
Alan Cox wrote:
Just one version of Linux ago
The PLL code broke - oh no!
But set the right mode
And fix up the code
Makes the PLL timing sync go
/me applauds :-)
Closes-bug: #8791
Signed-off-by: Alan Cox [EMAIL PROTECTED]
Acked-by: Sergei
Hello.
Benjamin Herrenschmidt wrote:
Note that with all your patches applied, it doesn't seem to auto-tune
the speed at boot anymore and doesn't enable DMA. I can make it do so
with hdparm -d1, in which case, for example, on this wallstreet, I get
MDMA2 which is correct, however, it seems to
comment for ide_wait_stat() from linux/ide.h.
Cc: Benjamin Herrenschmidt [EMAIL PROTECTED]
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED]
Acked-by: Sergei Shtylyov [EMAIL PROTECTED]
MBR, Sergei
-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the body
Hello.
Alan Cox wrote:
/* Only use IORDY/NWAIT for PIO mode 3 and 4 */
if (pio_mode 3)
info-smc.nwait_mode = 0;
else
info-smc.nwait_mode = 3;
That is wrong.
Yeah.
Any mode for PIO2+ will use IORDY. Modes below may require
it
Hello.
Benjamin Herrenschmidt wrote:
Ok, there's a combination of things here:
- First, doing a set_pio from userland (hdparm -p XX) causes the kernel
to disable DMA, which I think is incorrect.
That's the way ide_config_drive_speed() works.
And I still think that's bad.
Bart
Zolnierkiewicz [EMAIL PROTECTED]
Acked-by: Sergei Shtylyov [EMAIL PROTECTED]
MBR, Sergei
-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Bartlomiej Zolnierkiewicz wrote:
Upper layers are responsible for controlling nIEN so don't clear nIEN after
command execution in pmac_ide_do_setfeature().
Cc: Benjamin Herrenschmidt [EMAIL PROTECTED]
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED]
Acked-by: Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote:
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED]
Acked-by: Sergei Shtylyov [EMAIL PROTECTED]
Index: b/drivers/ide/pci/it8213.c
===
--- a/drivers/ide/pci/it8213.c
+++ b/drivers/ide/pci
Bartlomiej Zolnierkiewicz wrote:
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED]
Acked-by: Sergei Shtylyov [EMAIL PROTECTED]
MBR, Sergei
-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http
Hello.
Rogier Wolff wrote:
Ah, that makes sense -- during PIO interrupts happen a lot more often.
20 secs still seem to be too much.
I don't think so, even for modern drives.
Figure 8-10 seconds max for spin-up,
plus 6-9 seconds to do a sector re-assignment
or retries on a bad block (a
Hello.
Bartlomiej Zolnierkiewicz wrote:
ide_config_drive_speed() called by sc1200_set_xfer_mode() already gives
a meaningful warning message in case of failure.
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED]
Acked-by: Sergei Shtylyov [EMAIL PROTECTED]
MBR, Sergei
for PIO modes in siimage_tune_chipset().
* Bump driver version.
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED]
Acked-by: Sergei Shtylyov [EMAIL PROTECTED]
Index: b/drivers/ide/pci/siimage.c
===
--- a/drivers/ide/pci
ide_config_drive_speed() at the end of icside_set_speed().
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED]
Acked-by: Sergei Shtylyov [EMAIL PROTECTED]
MBR, Sergei
-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the body of a message to [EMAIL PROTECTED]
More majordomo info
Hello.
Mark Lord wrote:
O BTW, why the timeout is so damn long? 2*WAIT_CMD is 20 secs,
and if DMA is
not complete or interrupt pending, it may wait 10 more secs...
I really don't remember... :)
Maybe Mark or Alan could help with figuring this out.
They also have probably
PROTECTED]
Nice cleanups...
Acked-by: Sergei Shtylyov [EMAIL PROTECTED]
MBR, Sergei
-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
/ IORDY + two invalid values)
being set on the device instead of values 0x08-0x0c (XFER_PIO_[0,4]).
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED]
Acked-by: Sergei Shtylyov [EMAIL PROTECTED]
MBR, Sergei
-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the body
for DMA modes).
This patch should have no effect on the default kernel behavior because
IDE pmac driver doesn't enable -autotune (this would also explain why some
of the above bugs remained unfixed for so long).
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED]
Acked-by: Sergei
timings)
* Bump driver version.
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED]
Acked-by: Sergei Shtylyov [EMAIL PROTECTED]
MBR, Sergei
-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http
Mark Lord wrote:
I've lost the original question from this thread, but the idea of the
The original question concerned specifically the DMA command
timeout which is twice more than the usual one, WAIT_CMD (10 seconds).
longish
timeouts was that drive *may* be spun down (standby), and
Mark Lord wrote:
O BTW, why the timeout is so damn long? 2*WAIT_CMD is 20
secs, and if DMA is not complete or interrupt pending, it may wait
10 more secs...
..
I've lost the original question from this thread, but the idea of the
The original question concerned specifically the
Mark Lord wrote:
The original question concerned specifically the DMA command
timeout which is twice more than the usual one, WAIT_CMD (10 seconds)...
When a drive is in standby, we don't send it anything special to wake
up.
So even DMA commands have to have a long enough timeout to
be no functionality changes caused by this patch.
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED]
Acked-by: Sergei Shtylyov [EMAIL PROTECTED]
MBR, Sergei
-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the body of a message to [EMAIL PROTECTED]
More majordomo info
Hello.
Tejun Heo wrote:
eighty_ninty_three() had word 93 validitity check but not the 80c bit
test itself (bit 12). This increases the chance of incorrect wire
detection especially because host side cable detection is often
unreliable and we sometimes soley depend on drive side cable
Hello, I wrote:
The 80c wire bit is bit 13, not 14. Bit 14 is always 1 if word93 is
implemented. This increases the chance of incorrect wire detection
especially because host side cable detection is often unreliable and
we sometimes soley depend on drive side cable detection. Fix the test
Hello.
Bartlomiej Zolnierkiewicz wrote:
Moreover, I think the patch is quite broken. If an invalid DMA mode
is passed, currently the driver sets the cycle time to 480ns (stored
in drive_data) since both cycle_time and use_dma_info will be zero.
Moreover, 'on' will be zero, causing
Zolnierkiewicz [EMAIL PROTECTED]
Acked-by: Sergei Shtylyov [EMAIL PROTECTED]
MBR, Sergei
-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
PROTECTED]
Acked-by: Sergei Shtylyov [EMAIL PROTECTED]
I wonder why Sergei's acking this patch - do you have the hardware to
test it on? Are you somehow involved in this driver? I think the
answer to both is most likely no.
This just signified my positive review (as for any other IDE patch
Alan Cox wrote:
I guess it's been blindly copied over form drivers/ide/pci/siimage.c...
Yet the order of events between IDE and libata drivers is different:
the old driver's resetproc() method is called just after the twiddling the bit
on/off, the new driver calls ata_std_softreset()
Zolnierkiewicz [EMAIL PROTECTED]
Acked-by: Sergei Shtylyov [EMAIL PROTECTED]
MBR, Sergei
-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Hello.
Bartlomiej Zolnierkiewicz wrote:
On Feb 20, 2007, at 5:44 PM, Bartlomiej Zolnierkiewicz wrote:
On Wednesday 21 February 2007 02:19, Suleiman Souhlal wrote:
It can be changed via /proc/ide/hd?/settings.
Why do we need to change IDE DMA timeout dynamically?
I've used it to
Bartlomiej Zolnierkiewicz wrote:
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED]
Acked-by: Sergei Shtylyov [EMAIL PROTECTED]
MBR, Sergei
-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http
Hello.
Fajun Chen wrote:
Could someone help me interpret the code snippet below:
static int sil680_bus_reset(struct ata_port *ap,unsigned int *classes)
{
struct pci_dev *pdev = to_pci_dev(ap-host-dev);
unsigned long addr = sil680_selreg(ap, 0);
u8 reset;
Hello.
Vitaly Bordug wrote:
This adds support for MMIO IDE device like CompactFlash
in TrueIDE mode.
Signed-off-by: Anton Vorontsov [EMAIL PROTECTED]
Signed-off-by: Vitaly Bordug [EMAIL PROTECTED]
[...]
diff --git a/drivers/ide/legacy/mmio-ide.c b/drivers/ide/legacy/mmio-ide.c
new file
:
* Fix PIO number being returned incorrectly instead of PIO mode
(Noticed by Sergei).
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED]
Acked-by: Sergei Shtylyov [EMAIL PROTECTED]
MBR, Sergei
-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the body
Bartlomiej Zolnierkiewicz wrote:
I was thinking of checking if the drive really supports IORDY before
issuing a command to set PIO mode (and just skipping the command if there's no
IORDY -- well, maybe adding an extra check that the passed mode is acceptable
to the drive, i.e. = its default
/fixups per Sergei's suggestions.
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED]
Though some nits haven't been addressed:
Acked-by: Sergei Shtylyov [EMAIL PROTECTED]
Index: b/drivers/ide/pci/jmicron.c
Bartlomiej Zolnierkiewicz wrote:
* Add sil_tuneproc() wrapper for siimage_tuneproc() which also sets
PIO mode on the device.
Planning on the global prefix change? :-)
Yep.
Well, it didn't work out with 'ata_'... ;-)
Because of bad libata taking over our preciouss
modes are available.
* Bump driver version.
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED]
Acked-by: Sergei Shtylyov [EMAIL PROTECTED]
MBR, Sergei
-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the body of a message to [EMAIL PROTECTED]
More majordomo
...
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED]
Acked-by: Sergei Shtylyov [EMAIL PROTECTED]
Index: b/drivers/ide/pci/it8213.c
===
--- a/drivers/ide/pci/it8213.c
+++ b/drivers/ide/pci/it8213.c
@@ -276,6 +276,7 @@ static
Bartlomiej Zolnierkiewicz wrote:
* Add IDE_HFLAG_ABUSE_{PREFETCH,FAST_DEVSEL,DMA_MODES} flags
and set them in ht6560, cmd640, cmd64x and sc1200 host drivers.
* Add set_pio_mode_abuse() for checking if host driver has a non-standard
-tuneproc() implementation and use it in do_special().
Bartlomiej Zolnierkiewicz wrote:
* Add -host_flags to ide_hwif_t to store ide_pci_device_t.host_flags,
assign it in setup-pci.c:ide_pci_setup_ports().
* Add IDE_HFLAG_PIO_NO_{BLACKLIST,DOWNGRADE} to ide_pci_device_t.host_flags
and teach ide_get_best_pio_mode() about them. Also remove
Hello.
Bartlomiej Zolnierkiewicz wrote:
* Add ide_dev_has_iordy() helper and use it sl82c105 host driver.
* Remove no longer needed ide_pio_data_t.use_iordy field.
v2/v3:
* Fix issues noticed by Sergei:
- correct patch description
- fix comment in ide_get_best_pio_mode()
v4:
* Fix
Hello.
Bartlomiej Zolnierkiewicz wrote:
* Drop no longer needed PIO data argument from ide_get_best_pio_mode()
and convert all users accordingly.
* Remove no longer needed ide_pio_data_t.
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED]
Acked-by: Sergei Shtylyov [EMAIL
Hello.
Michal Piotrowski wrote:
IDE
Subject: 2.6.22-rcX: hda: lost interrupt
References : http://lkml.org/lkml/2007/6/29/121
Submitter : David Chinner [EMAIL PROTECTED]
Status : unknown
Probing IDE interface ide0...
hda: probing with STATUS(0xa0) instead of ALTSTATUS(0x58)
Hello, I wrote:
I've got a hard lockup in the ide subsystem, probably
due to some irq spew or something like that.
I've just bought a brand new Maxtor 320GB disk driver for the insane
price of $70 US to replace another failing drive. It works well under
light load;
I was able to copy about
The HPT36x chips finally turned out to have the channel enable bits -- however,
badly implemented. Make use of them despite it's probably only going to burden
the driver's code -- assuming both channels are always enabled by the HighPoint
BIOS anyway...
Signed-off-by: Sergei Shtylyov [EMAIL
Hello.
Bartlomiej Zolnierkiewicz wrote:
[...]
Damn, I should have re-check ATA specs before writing this. :)
Yeah, never hurts... but takes time. ;-)
I was thinking of checking if the drive really supports IORDY before
issuing a command to set PIO mode (and just skipping the command
hpt_info' with 'max_ultra' specifying
the maximum UltraDMA mode allowed;
- rewrite hpt3xx_udma_filter() to differ the filters based on the 'chip_type'
field, and only use it for HPT366 and HPT370[A] where it's really necessary.
Signed-off-by: Sergei Shtylyov [EMAIL PROTECTED]
Signed-off
Add the MAXTOR STM3320620A drive into the UltraDMA/66 mode blacklist
for the HPT36x chips.
Signed-off-by: Sergei Shtylyov [EMAIL PROTECTED]
---
Linas, here's the patch at last -- it should apply atop 2.6.21.5.
Please, make sure it works for you.
drivers/ide/pci/hpt366.c |3 ++-
1 files
/v3:
* Fix issues noticed by Sergei:
- correct patch description
- fix comment in ide_get_best_pio_mode()
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED]
Acked-by: Sergei Shtylyov [EMAIL PROTECTED]
MBR, Sergei
-
To unsubscribe from this list: send the line unsubscribe linux-ide
Hello.
Linas Vepstas wrote:
Now I'm confused too -- did you get any DMA timeouts this time?
No. And yes, this is confusing, as the initial hang that I was seeing
was preceeded by DMA timeout messages on the screen (as posted in the
initial email). Now, with the patched kernel, I'm not
Hello.
Bartlomiej Zolnierkiewicz wrote:
Backport short cables support from pata_via.c.
This patch should allow UDMA 2 modes on Acer Ferrari 3400.
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED]
Acked-by: Sergei Shtylyov [EMAIL PROTECTED]
MBR, Sergei
-
To unsubscribe from
Bartlomiej Zolnierkiewicz wrote:
Backport short cables support from pata_ali.c and while at it cleanup
existing cable detection code.
This patch should allow UDMA 2 modes on HP Pavilion N5430 and Fujitsu P2000.
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED]
Acked-by: Sergei
Bartlomiej Zolnierkiewicz wrote:
Backport short cables support from ata_piix.c.
This patch should allow UDMA 2 modes on:
- Acer 5602WLMi
- Acer 3682WLMi
- Asus W5F
- Acer Aspire 2023WLMi
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED]
Acked-by: Sergei Shtylyov [EMAIL
Bartlomiej Zolnierkiewicz wrote:
Backport short cables support from pata_sis.c.
This patch should allow UDMA 2 modes on ASUS A6K.
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED]
Acked-by: Sergei Shtylyov [EMAIL PROTECTED]
Index: b/drivers/ide/pci/sis5513.c
Bartlomiej Zolnierkiewicz wrote:
A lot to argue about here...
* Add sil_tuneproc() wrapper for siimage_tuneproc() which also sets
PIO mode on the device.
Planning on the global prefix change? :-)
* Add code limiting maximum PIO mode according to the pair device capabilities
to
description
- remove stale comment from ide_get_best_pio_mode()
I meant something like changing use_iordy to IORDY but it's good as is now...
- use only ata_dev_has_iordy() in sl82c105 host driver
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED]
Acked-by: Sergei Shtylyov [EMAIL
Hello.
Linas Vepstas wrote:
Reset HPT36x's DMA state machine on a DMA timeout the way it's done for
HPT370.
drivers/ide/pci/hpt366.c | 24 +++-
This worked great!
I hope you meant those messages were preceeded by DMA timeouts
(otherwise this code wouldn't come
Bartlomiej Zolnierkiewicz wrote:
Various old IDE drivers go mapping ROM devices for no apparent reason and
without using the ROM mapping API we now have. They don't actually use
Hm, do you mean the sysfs based aproach? I've tried that and somehow it
failed to work for me -- that's because
Bartlomiej Zolnierkiewicz wrote:
* Rename ide_pci_device_t.flags to ide_pci_device_t.host_flags
and IDEPCI_FLAG_ISA_PORTS flag to IDE_HFLAG_ISA_PORTS.
Erm, do you intend also adding device_flags field? :-O ;-)
* Add IDE_HFLAG_SINGLE flag for single channel devices.
* Convert core
]
Acked-by: Sergei Shtylyov [EMAIL PROTECTED]
MBR, Sergei
-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Bartlomiej Zolnierkiewicz wrote:
This one is actually arguable...
* Add ata_dev_has_iordy() helper.
I thought IDE subsys make use of only 'ide_' prefixes. :-)
* Use it in sl82c105 host driver so it always gets the correct info
(use_iordy was incorrectly set for pio != 255 cases).
Hello.
Alan Cox wrote:
PIO4 is a maximum PIO mode supported by a driver. Using 255 as a max_mode
argument to ide_get_best_pio_mode() could result in wrong timings being used
by a driver (for pio equal to 5) or OOPS (for pio values 5 255).
The qdi6580 driver is somewhat hosed. The libata
[EMAIL PROTECTED]
Acked-by: Sergei Shtylyov [EMAIL PROTECTED]
---
drivers/ide/legacy/qd65xx.c |3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
Index: b/drivers/ide/legacy/qd65xx.c
===
--- a/drivers/ide/legacy/qd65xx.c
Hello.
Alan Cox wrote:
Various old IDE drivers go mapping ROM devices for no apparent reason and
without using the ROM mapping API we now have. They don't actually use
Hm, do you mean the sysfs based aproach? I've tried that and somehow it
failed to work for me -- that's because I
Hello.
Michael Tokarev wrote:
On each and every machine out there, and on every dmesg
output posted on numerous mailinglists, I see messages
similar to this:
scsi 0:0:0:0: Direct-Access ATA ST3250620NS 3.AE PQ: 0 ANSI: 5
SCSI device sda: 488397168 512-byte hdwr sectors (250059
401 - 500 of 702 matches
Mail list logo
