[PATCH 07/12] libata-pmp-prep: implement ATA_LFLAG_NO_SRST, ASSUME_ATA and ASSUME_SEMB

2007-09-22 Thread Tejun Heo
currently supported yet so the _UNSUP variant is used. Signed-off-by: Tejun Heo [EMAIL PROTECTED] --- drivers/ata/libata-eh.c | 42 -- include/linux/libata.h |4 2 files changed, 36 insertions(+), 10 deletions(-) diff --git a/drivers/ata/libata

[PATCH 05/12] libata-pmp-prep: implement ops-qc_defer()

2007-09-22 Thread Tejun Heo
* once deferred the command won't be repeated until another command completes which usually is a very long time cpu-wise. Signed-off-by: Tejun Heo [EMAIL PROTECTED] --- drivers/ata/ahci.c|2 + drivers/ata/libata-core.c | 31 ++ drivers/ata/libata-scsi.c | 62

[PATCH 08/12] libata-pmp-prep: implement ATA_LFLAG_NO_RETRY

2007-09-22 Thread Tejun Heo
Some PMP links are connected to internal pseudo devices which may come and go depending on situation. There's no reason to try hard to recover them. ATA_LFLAG_NO_RETRY tells EH to not retry if the device attached to the link fails. Signed-off-by: Tejun Heo [EMAIL PROTECTED] --- drivers/ata

[PATCH 11/12] libata-pmp-prep: implement ATA_HORKAGE_SKIP_PM

2007-09-22 Thread Tejun Heo
Some pseudo devices fail PM commands unnecessarily aborting system suspend. Implement ATA_HORKAGE_SKIP_PM which makes libata skip PM commands for these devices. Signed-off-by: Tejun Heo [EMAIL PROTECTED] --- drivers/ata/libata-scsi.c |7 +++ include/linux/libata.h|1 + 2 files

[PATCH 12/12] libata-pmp-prep: implement sata_async_notification()

2007-09-22 Thread Tejun Heo
is not available. Signed-off-by: Tejun Heo [EMAIL PROTECTED] Cc: Kriten Carlson Accardi [EMAIL PROTECTED] --- drivers/ata/ahci.c| 24 -- drivers/ata/libata-core.c | 13 +-- drivers/ata/libata-eh.c | 73 + drivers/ata/libata-scsi.c

[PATCH 09/12] libata-pmp-prep: implement ATA_LFLAG_DISABLED

2007-09-22 Thread Tejun Heo
Implement ATA_LFLAG_DISABLED. The flag indicates the link is disabled due to EH recovery failure. While a link is disabled, no EH action is taken on the link and suspend/resume become noop too. This will be used by PMP links to manage failed links. Signed-off-by: Tejun Heo [EMAIL PROTECTED

[PATCH 10/12] libata-pmp-prep: implement EH fast-fail path

2007-09-22 Thread Tejun Heo
If PMP itself becomes inaccessible while trying to link a downstream link, spending time to recover the downstream link doesn't make any sense. Make EH skip retry and fail fast if -ERESTART is received. Signed-off-by: Tejun Heo [EMAIL PROTECTED] --- drivers/ata/libata-eh.c |2 +- 1 files

[PATCH 06/12] libata-pmp-prep: implement qc_defer helpers

2007-09-22 Thread Tejun Heo
of helpers seem enough for both sil24 (ATAPI exclusion needed) and cmd-switching PMP. Signed-off-by: Tejun Heo [EMAIL PROTECTED] --- drivers/ata/libata-core.c | 22 -- drivers/ata/libata-eh.c |5 + include/linux/libata.h|8 3 files changed, 33

[PATCHSET 2/2] implement PMP support, take 6

2007-09-22 Thread Tejun Heo
Hello, all. his is the sixth take of libata-pmp patchset. This patchset contains 10 patches and implements PMP support. Changes from the last take[L] are. * Better AN handling. All AHCI now can do hotplug on downstream ports whether it has SNTF or not - patch #6 and #8 updated. *

[PATCH 01/10] libata-pmp: update ata_eh_reset() for PMP

2007-09-22 Thread Tejun Heo
-by: Tejun Heo [EMAIL PROTECTED] --- drivers/ata/libata-eh.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/drivers/ata/libata-eh.c b/drivers/ata/libata-eh.c index 60186f8..687419b 100644 --- a/drivers/ata/libata-eh.c +++ b/drivers/ata/libata-eh.c @@ -2003,6 +2003,8 @@ static int

[PATCH 04/10] libata-pmp: extend ACPI support to cover PMP

2007-09-22 Thread Tejun Heo
Extend ata_acpi_associate_sata_port() such that it can handle PMP and call it when PMP is attached and detached. Build breakage when !CONFIG_ATA_ACPI was spotted and fixed by Petr Vandrovec. Signed-off-by: Tejun Heo [EMAIL PROTECTED] Cc: Petr Vandrovec [EMAIL PROTECTED] --- drivers/ata/libata

[PATCH 03/10] libata-pmp: hook PMP support and enable it

2007-09-22 Thread Tejun Heo
Hook PMP support into libata and enable it. Connect SCR and probing functions, and update ata_dev_classify() to detect PMP. Signed-off-by: Tejun Heo [EMAIL PROTECTED] --- drivers/ata/libata-core.c | 113 - drivers/ata/libata-eh.c | 18 ++- 2

[PATCH 02/10] libata-pmp: implement Port Multiplier support

2007-09-22 Thread Tejun Heo
prereset, hardreset and postreset methods. This patch only implements PMP support. The next patch will integrate PMP into the reset of libata and thus enable PMP support. Signed-off-by: Tejun Heo [EMAIL PROTECTED] --- drivers/ata/Makefile |3 +- drivers/ata/libata-core.c | 11

[PATCH 05/10] libata-pmp: implement qc_defer for command switching PMP support

2007-09-22 Thread Tejun Heo
Implement sata_pmp_qc_defer_cmd_switch() - standard qc_defer for command switching PMP support. Signed-off-by: Tejun Heo [EMAIL PROTECTED] --- drivers/ata/libata-core.c |1 + drivers/ata/libata-pmp.c | 30 ++ include/linux/libata.h|1 + 3 files changed

[PATCH 07/10] sata_sil24: implement PORT_RST

2007-09-22 Thread Tejun Heo
As DEV_RST (hardreset) sometimes fail to recover the controller (especially after PMP DMA CS errata). In such cases, perform PORT_RST prior to DEV_RST. Signed-off-by: Tejun Heo [EMAIL PROTECTED] --- drivers/ata/sata_sil24.c | 93 ++--- 1 files changed

[PATCH 06/10] sata_sil24: implement PMP support

2007-09-22 Thread Tejun Heo
them before fetching sense data. Unfortunately, ATAPI CHECK SENSE causes a lot of problem if command is outstanding to any other device usually resulting in port-wide reset. So, sata_sil24 implements sil24_qc_defer() which guarantees ATAPI command is run by itself. Signed-off-by: Tejun Heo [EMAIL

[PATCH 10/10] ahci: implement AHCI_HFLAG_NO_PMP

2007-09-22 Thread Tejun Heo
Of course some controllers lie about PMP support. Black list them. Signed-off-by: Tejun Heo [EMAIL PROTECTED] --- drivers/ata/ahci.c | 11 +-- 1 files changed, 9 insertions(+), 2 deletions(-) diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c index dc2..ad3ff29 100644

[PATCH 08/10] ahci: implement PMP support

2007-09-22 Thread Tejun Heo
Implement AHCI PMP support. ahci only supports command based switching. Also, for some reason, NCQ over PMP doesn't work now. Other than that, everything works. Tested on ICH9R, JMB360/363 + SIMG3726, 4726 and 5744. Signed-off-by: Tejun Heo [EMAIL PROTECTED] Cc: Forrest Zhao [EMAIL PROTECTED

[PATCH 09/10] ahci: move host flags over to pi.private_data

2007-09-22 Thread Tejun Heo
Private pi.flags area is full and we need more private flags. Move host private flags over to pi.private_data. During initialization, these flags are copied to hpriv-flags. Signed-off-by: Tejun Heo [EMAIL PROTECTED] --- drivers/ata/ahci.c | 63

[PATCH] pata_sis: add missing UDMA5 timing value in sis_66_set_dmamode()

2007-09-21 Thread Tejun Heo
. Signed-off-by: Tejun Heo [EMAIL PROTECTED] Cc: Adam Blech [EMAIL PROTECTED] --- drivers/ata/pata_sis.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/ata/pata_sis.c b/drivers/ata/pata_sis.c index da3f720..3b5be77 100644 --- a/drivers/ata/pata_sis.c +++ b/drivers

[PATCH] sata_via: kill SATA_PATA_SHARING register handling

2007-09-21 Thread Tejun Heo
that. Also, pata_via should work fine under all configurations. This patch removes unnecessary attach failures. It seems recent via chipsets are defaulting to different values or are actually connected to SATA PHY triggering this more often. Signed-off-by: Tejun Heo [EMAIL PROTECTED] --- drivers/ata

Re: [PATCH] pata_sis: add missing UDMA5 timing value in sis_66_set_dmamode()

2007-09-21 Thread Tejun Heo
Alan Cox wrote: On Fri, 21 Sep 2007 16:29:05 +0900 Tejun Heo [EMAIL PROTECTED] wrote: sis_66_set_dmamode() also handles early UDMA100 (SIS630 ET) but is missing udma timing value for UDMA100. According to sis5513, this should be 0x8000. This caused UDMA100 device to fail on pata_sis till

[PATCH #upstream] libata: fix ata_set_max_sectors()

2007-09-21 Thread Tejun Heo
In ata_set_max_sectors(), the highest nibble in LBA28 mode was missing. This made drives sized between 8G and 128G with HPA turned on to be resized to under 8G. Fix it. Signed-off-by: Tejun Heo [EMAIL PROTECTED] --- This one fixes my dumb mistake. drivers/ata/libata-core.c |5 - 1

Re: sata_sil24 with port multiplier

2007-09-21 Thread Tejun Heo
Jon Chelton wrote: Hello, I am having issues using kernel 2.6.22.1 with your latest patch applied. I am using a Addonics 4 port SATA card with an external enclosure and port multiplier connected to 4 250GB western digital SATA drives. I am receiving this error frequently (on 2

Re: [PATCH]libata-acpi: add ACPI _PSx method

2007-09-20 Thread Tejun Heo
Hello, Shaohua Li wrote: + /* channel first and then drives for power on and verse versa for power off */ + if (state.event == PM_EVENT_ON) + acpi_bus_set_power(ap-acpi_handle, ACPI_STATE_D0); + + if (ap-flags ATA_FLAG_SLAVE_POSS) + max_devices++;

Re: [PATCH] libata: Integrate ACPI-based PATA/SATA hotplug - version 2

2007-09-20 Thread Tejun Heo
Matthew Garrett wrote: On Thu, Sep 20, 2007 at 06:04:22PM -0400, Jeff Garzik wrote: the code looks correct. I have one main reservation. how can we be sure that this is active only where other hand-programmed hotplug code is absent? Yes, that's difficult. As Tejun pointed out, there's

Re: [PATCH] libata: Integrate ACPI-based PATA/SATA hotplug - version 2

2007-09-20 Thread Tejun Heo
Matthew Garrett wrote: On Fri, Sep 21, 2007 at 11:35:05AM +0900, Tejun Heo wrote: Matthew Garrett wrote: The alternative would be to add a flag to the ap structure indicating whether the hotplugging is handled by the firmware or not. If we find a reference to a controller or port

Re: [PATCH] libata: Integrate ACPI-based PATA/SATA hotplug - version 2

2007-09-20 Thread Tejun Heo
Matthew Garrett wrote: On Fri, Sep 21, 2007 at 11:53:33AM +0900, Tejun Heo wrote: Maybe just letting both events in is the best idea. It's not like two duplicate events are gonna break anything and I don't think many vendors are gonna implement separate mechanism when the default SATA phy

Re: [PATCH] libata: Integrate ACPI-based PATA/SATA hotplug - version 2

2007-09-20 Thread Tejun Heo
Matthew Garrett wrote: On Fri, Sep 21, 2007 at 12:08:07PM +0900, Tejun Heo wrote: Yeah, that's the intended behavior. SATA PHY link can break from time to time (have ever seen a SATA storage box going through ECC testing? PHY goes offline as soon as you begin to hit it with some EM pulses

Re: [PATCH] libata: Add a drivers/ide style DMA disable

2007-09-19 Thread Tejun Heo
Chuck Ebbert wrote: On 08/22/2007 06:37 PM, Alan Cox wrote: This is useful when debugging, handling problem systems, or for distributions just to get the system installed so it can be sorted out later. This is a bit smarter than the old IDE one and lets you do libata.pata_dma=0

Re: Fw: Spurious completions during NCQ

2007-09-17 Thread Tejun Heo
Jeff Garzik wrote: Andrew Morton wrote: Begin forwarded message: Date: Fri, 07 Sep 2007 12:57:14 -0500 From: Sumanth J.V [EMAIL PROTECTED] To: [EMAIL PROTECTED] Subject: Spurious completions during NCQ I keep seeing this message a few times a day on my box. ata1.00: exception Emask

Re: [PATCH 1/1] pata_it821x: fix lost interrupt with atapi devices

2007-09-17 Thread Tejun Heo
[cc'ing Albert and linux-ide] Alan Cox wrote: /from the media. */ + if (qc-nbytes 2048) + return -EOPNOTSUPP; + /* No ATAPI DMA in smart mode */ if (itdev-smart) return -EOPNOTSUPP; This looks like a gross hack. Aren't you supposed to inspect the

Re: Problems with Promise controller or Seagate 500g ST3500630AS ?

2007-09-17 Thread Tejun Heo
Glen Larkins wrote: I'm currently running under Edgy and kernel 2.6.17-10, and I'm still getting timeouts just during the boot process. I've included my current dmesg, though its a bit lengthy. This particular boot has 3 of the 4 500g drives disconnected. Please report kernel log including

Re: 2.6.22.6 sata_sil device errors timeouts

2007-09-17 Thread Tejun Heo
Andrew Paprocki wrote: 1) When built with modules disabled, and libata handling the sata + pata (AMD CS5536) connections, the pata drives come _after_ the sata drives (i.e. w/ 2 sata drives, the first IDE drive is sdc). This makes boot configuration more complicated if booting off the pata

Re: ata_piix, laptop cdrom, ICH7: EH, limiting speed to PIO

2007-09-17 Thread Tejun Heo
Sergey Dolgov wrote: On 9/16/07, Tejun Heo [EMAIL PROTECTED] wrote: Michal Piotrowski wrote: Sergey Dolgov pisze: On Wed, Sep 12, 2007 at 10:19:03PM +0200, Michal Piotrowski wrote: Sergey Dolgov pisze: Hi Michal, On Wed, Sep 12, 2007 at 06:33:20PM +0200, Michal Piotrowski wrote: Hi Sergey

Re: [PATCH 1/1] pata_it821x: fix lost interrupt with atapi devices

2007-09-17 Thread Tejun Heo
Jeff Garzik wrote: Tejun Heo wrote: [cc'ing Albert and linux-ide] Alan Cox wrote: /from the media. */ +if (qc-nbytes 2048) +return -EOPNOTSUPP; + /* No ATAPI DMA in smart mode */ if (itdev-smart) return -EOPNOTSUPP; This looks like a gross

Re: 2.6.22.6 sata_sil device errors timeouts

2007-09-17 Thread Tejun Heo
[cc'ing Bruce Allen] Andrew Paprocki wrote: I didn't mention it before, but I'm also getting these errors every time I boot. I'm thinking they're related to the drive not supporting cmds that smartd is sending it. If so, is there any way that libata/smartd can handle this more gracefully?

Re: ata_piix, laptop cdrom, ICH7: EH, limiting speed to PIO

2007-09-16 Thread Tejun Heo
Michal Piotrowski wrote: Sergey Dolgov pisze: On Wed, Sep 12, 2007 at 10:19:03PM +0200, Michal Piotrowski wrote: Sergey Dolgov pisze: Hi Michal, On Wed, Sep 12, 2007 at 06:33:20PM +0200, Michal Piotrowski wrote: Hi Sergey, On 11/09/2007, Sergey Dolgov [EMAIL PROTECTED] wrote: Hi! On my

Re: HDIO_DRIVE_TASKFILE not supported in libata ?

2007-09-16 Thread Tejun Heo
Jeff Garzik wrote: Kantor Zsolt wrote: HDIO_DRIVE_TASKFILE is not supported in libata ? and if not then which was the last version of libata that supported the HDIO_DRIVE_TASKFILE command in which kernel ? libata has never supported HDIO_DRIVE_TASKFILE. it won't. The TASKFILE interface

Re: [PATCH] libata: Integrate ACPI-based PATA/SATA hotplug - version 2

2007-09-16 Thread Tejun Heo
Matthew Garrett wrote: +static void ata_acpi_notify(acpi_handle handle, u32 event, void *data) +{ + struct ata_port *ap = data; + struct ata_eh_info *ehi = ap-eh_info; + + ata_ehi_clear_desc(ehi); + ata_ehi_push_desc(ehi, ACPI event); + ata_ehi_hotplugged(ehi); +

[PATCH #upstream-fixes] libata: add ST9120822AS 3.CLF to NONCQ blacklist

2007-09-14 Thread Tejun Heo
ST9120822AS 3.CLF does spurious NCQ completions, add it to NONCQ blacklist. Signed-off-by: Tejun Heo [EMAIL PROTECTED] --- It's likely that all the drives with 3.CLF firmware are bonkers regarding this. Maybe we should blacklist by firmware version only. drivers/ata/libata-core.c |1 + 1

Re: SATA problems

2007-09-13 Thread Tejun Heo
Andrew Morton wrote: On Thu, 30 Aug 2007 09:24:18 + Nigel Kukard [EMAIL PROTECTED] wrote: Hrmmm, Jun 14 07:55:52 nigel-m2v kernel: ATA: abnormal status 0x7F on port 0x0001c807 Jun 14 07:55:52 nigel-m2v kernel: ATA: abnormal status 0x7F on port 0x0001c807

Re: sata_nv issues with MCP51 SATA controller

2007-09-13 Thread Tejun Heo
Jon Ivar Rykkelid wrote: I'm having serious disk-issues when using the on-board nvidia controller for my HDDs (My motherboard is a Gigabyte GA-N650SLI-DS4 with nvidia chipset, cpu is intel Core2Quad) excerpt from lspci: 00:0d.0 IDE interface: nVidia Corporation MCP51 IDE (rev a1) 00:0e.0

Re: HSM violation on bootup, ICH7 + ata_piix 2.6.22

2007-09-13 Thread Tejun Heo
Eamonn Hamilton wrote: Thanks for that, I checked the disks and sure enough they were in an extended self test, I aborted that and it's all back to normal. the only problem, however, is that the system is already running version 5.37 of the smartmontools package, which is the most recent as

Re: Maxtor 6L200M0 sata irq timeouts

2007-09-10 Thread Tejun Heo
Michal Suchanek wrote: Hello (please CC me when replying) On 09/09/2007, Joris [EMAIL PROTECTED] wrote: Hi, Just a note to let you know you're not alone. I have the same problem, and someone else reported something simelar. What sata controller are you using? The via onboard

Re: Maxtor 6L200M0 sata irq timeouts

2007-09-10 Thread Tejun Heo
Michal Suchanek wrote: What does 'smartctl -a /dev/sda' say? Attaching output. Hmmm... How often does the condition occur? smartlog records only two occasions. -- tejun - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More

Re: Port Multiplier Patch 2.6.22.1 on Alpha

2007-09-09 Thread Tejun Heo
Tom Evans wrote: I do not see any console or syslog messages at the time - perhaps I do not have a debug level set appropriately? Executing dmesg after the event should give you the messages if the kernel has spoken anything. Also, as an aside, I noticed that the device scan on the remote

Re: Port Multiplier Patch 2.6.22.1 on Alpha

2007-09-09 Thread Tejun Heo
Tom Evans wrote: No real performance change, but the # of unaligned kernel goes from ~14 to zero on my system. It's really just cosmetic I believe. Care to post signed-off patch? -- tejun - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to

Re: [PATCH] libata: Add a drivers/ide style DMA disable

2007-09-08 Thread Tejun Heo
Jeff Garzik wrote: FWIW -- as I noted to Alan personally at KS, I would rather drop the pata_ and have it apply to all, PATA or SATA. Having the distinction between sata and pata is also nice tho considering many modern machines mix the two and use the P part for ATAPI, CF kind of stuff. It's

Re: CF as IDE on ICH6M using libata

2007-09-08 Thread Tejun Heo
Mark Lord wrote: Tejun Heo wrote: Eddie Hung wrote: However, I think we can conclude that ICH6M (which on the X41, has a SATA-PATA bridge to connect a PATA drive) does not seem to support MWDMA It isn't clear whether the fault is at the driver or the CF device. It's probably the bridge

Re: shut down msg

2007-09-08 Thread Tejun Heo
Bruno Buys wrote: Hi, I am using debian sid in an acer notebook, and I do see the spin down msg referred in http://linux-ata.org/shutdown.html. Linux is 2.6.22-1-686 and hd is sata. Am I to worry? Thanks! You better update your shutdown program. Especially so if your drive makes funny sound

Re: [2.6.22.5] irq X: nobody cared but X is successfully used by libata

2007-09-08 Thread Tejun Heo
Paul Rolland wrote: Hello, My machine (an ASUS P5W-DH-Deluxe, Core2, 4Go RAM, 3 SATA and 2IDE) is reporting a : irq 23: nobody cared (try booting with the irqpoll option) together with a Call Trace, but : - irqpoll is present on the command line, - the irq is reported to be used by

Re: Fwd: Intel 82801G (ICH7) SATA port reset

2007-09-08 Thread Tejun Heo
Joris wrote: Hello List, I have a rather annoying problem. On an Intel S3000AHLX (http://www.intel.com/design/servers/boards/s3000ah/index.htm) motherboard, I can't seem to utilize all SATA interfaces to the maximum. The first sata interface frequently resets every few seconds under

Re: HSM violation on bootup, ICH7 + ata_piix 2.6.22

2007-09-08 Thread Tejun Heo
Eamonn Hamilton wrote: Hi, I'm looking ta a Dell SC440 system for a friend, and it's giving HSM violations at startup. The system itself has an ICH7 chipset, with two seagate ST3160812AS drives attached along with a single ST3400832AS, running kernel 2.6.22 and the ata_piix driver.

Re: a disk timeout and a disk state

2007-09-08 Thread Tejun Heo
Raz wrote: Jeff Hello We have in our machines several sata (mostly maxtor-segate) disks in an array. These disks generate too many ata-io errors at clients sites. From raid1 code I have learned that a re-write sometimes fixes a disk. Question: Why ? Question: Does it always work ?

Re: [PATCH] Asynchronous scan support for libata

2007-09-08 Thread Tejun Heo
Matthew Wilcox wrote: Last December, I posted this: http://lwn.net/Articles/213635/ Here's an updated version. It shaves 5 seconds off boot time on my configuration (qla2xxx, emulex, two ata_piix, dual fusion), but could save more or less on other setups. I think I can remove the 'sync'

Re: [PATCH] Remove sync waiting code from libata

2007-09-08 Thread Tejun Heo
Matthew Wilcox wrote: By using the scsi async probing code, we can remove the 'sync' argument from ata_scsi_scan_host(): Hmmm... How so? @sync is there to keep device numbering stable even when SCSI scan fails due to allocation failure. I don't see how async probing changes that. -- tejun

Re: [PATCH] Remove sync waiting code from libata

2007-09-08 Thread Tejun Heo
Matthew Wilcox wrote: On Sat, Sep 08, 2007 at 05:14:21PM +0900, Tejun Heo wrote: Matthew Wilcox wrote: By using the scsi async probing code, we can remove the 'sync' argument from ata_scsi_scan_host(): Hmmm... How so? @sync is there to keep device numbering stable even when SCSI scan fails

Re: [PATCH] Asynchronous scan support for libata

2007-09-08 Thread Tejun Heo
Matthew Wilcox wrote: On Sat, Sep 08, 2007 at 05:10:27PM +0900, Tejun Heo wrote: I think it's generally okay although it would need to spend quite some time in -mm and we'll need to exclude several drivers which require host-wide silence for mode programming (the current code is buggy

Re: [PATCH] Asynchronous scan support for libata

2007-09-08 Thread Tejun Heo
Jeff Garzik wrote: Matthew Wilcox wrote: Can you tell me a bit more about these drivers? Would it be possible to convert them to one host/many channels, which would give us the exclusion we want? As a tangent, I would prefer a more natural representation than current, where there is a 1-1

Re: [PATCH] Remove sync waiting code from libata

2007-09-08 Thread Tejun Heo
Alan Cox wrote: async probing also keeps device numbering stable. As long as the device responds within ten seconds (and the current code has half a second as the timeout), it'll get the same number it would have had, even though other hosts have successfully completed their probes during

Re: Port Multiplier Patch 2.6.22.1 on Alpha

2007-09-08 Thread Tejun Heo
Tom Evans wrote: I decided to put the Norco 4618 card into the first PCI slot of my DS20. It and the PMP support seem to like that location much better - I'm successfully creating an array at the moment. The system still responds, but accessing currently running filesystems (another

Re: CF as IDE on ICH6M using libata

2007-09-06 Thread Tejun Heo
Eddie Hung wrote: However, I think we can conclude that ICH6M (which on the X41, has a SATA-PATA bridge to connect a PATA drive) does not seem to support MWDMA It isn't clear whether the fault is at the driver or the CF device. (especially as it is not completely supported under Windows

Re: Resets on sil3124 sil3726 PMP

2007-09-06 Thread Tejun Heo
Petr Vandrovec wrote: Concurrent hdparm -t, like hdparm -t /dev/sdd hdparm -t /dev/sde hdparm -t /dev/sdf hdparm -t /dev/sdg sleep 20 (and from hdparm output visually confirmed that all activity LEDs go on off simultaneously) Not sure whether it matters but 'hdparm' tests are

Re: CF as IDE on ICH6M using libata

2007-09-06 Thread Tejun Heo
[adding-back linux-ide, please don't drop cc's] Eddie Hung wrote: On 06/09/07, Tejun Heo [EMAIL PROTECTED] wrote: Eddie Hung wrote: However, I think we can conclude that ICH6M (which on the X41, has a SATA-PATA bridge to connect a PATA drive) does not seem to support MWDMA It isn't clear

Re: Stardom SATA HSM violation

2007-09-06 Thread Tejun Heo
Bryan Woods wrote: The full dmesg and hdparm -I command output are attached. I have received word from the vendor that the Stardom 2611 will do RAID0 or 1 under windows, but only RAID1 under Linux. (Their manual said it worked with Linux but failed to mention the RAID mode restriction:

Re: HSM violation spew.

2007-09-06 Thread Tejun Heo
Dave Jones wrote: scsi 2:0:0:0: Direct-Access ATA WDC WD3200AAJS-0 12.0 PQ: 0 ANSI: 5 This could have been truncated, please post the result of 'hdparm -I /dev/sda'. Thanks. -- tejun - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to

Re: [PATCH] libata: Add a drivers/ide style DMA disable

2007-09-06 Thread Tejun Heo
] Acked-by: Tejun Heo [EMAIL PROTECTED] -- tejun - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: ATA_PIIX - soft resetting port, port is slow to respond, machine freezes for a few seconds

2007-09-06 Thread Tejun Heo
Tomasz Chmielewski wrote: Joris schrieb: Btw, out on a limb here: my board has specific combinations of sata port usage leading to a reset. Avoiding to use sata0 (sda) (unplug the cable) works perfectly. Do you have the same symptoms? No idea, no SATA here. Joris, can you please post more

Re: ATA_PIIX - soft resetting port, port is slow to respond, machine freezes for a few seconds

2007-09-06 Thread Tejun Heo
Tomasz Chmielewski wrote: Joris schrieb: Hello Tomasz, This appears remarkably simelar to what I'm experiencing, altough I'm getting that on sata ports. I'm currently at a loss on what caused this, but if there's two of us... ;-) See: http://marc.info/?l=linux-idem=118812690407577w=2

Re: Stardom SATA HSM violation

2007-09-06 Thread Tejun Heo
Hello, Mark Lord wrote: I reported a very similar bug back a few releases ago. Anyone who wants to try it themselves, can do this with hdparm-7.7 (from sourceforge): hdparm --drq-hsm-error /dev/sda Whether or not it hangs the machine does depend upon exactly which SATA LLD is used,

Re: [PATCH resubmit] /drivers/ata ioremap returncode check

2007-09-03 Thread Tejun Heo
of the module does not contain these messages. When auditing (as I am for ioremap checking here) I am attempting to keep changes in the style of their surroundings. Otherwise it's massive scope screep on these patches. Signed-off-by: Scott Thompson postfail at hushmail.com Acked-by: Tejun Heo

Re: Resets on sil3124 sil3726 PMP

2007-09-03 Thread Tejun Heo
Petr Vandrovec wrote: For comparsion 1TB Hitachi behind 3726 PMP (again MS4UM) with sata_sil patch I sent last week (no NCQ, 1.5Gbps link between 3512 and PMP, and 3.0Gbps link between PMP and drive... why is it faster?): If you turn off NCQ by echoing 1 to /sys/block/sdd/device/queue_depth on

Re: CF as IDE on ICH6M using libata

2007-09-03 Thread Tejun Heo
Eddie Hung wrote: I am pursuing another possibility: the CF card is not a genuine Sandisk one at all, especially as it was off eBay! I compared my hdparm -I with the one in the thread above (which as I've found out is a Sandisk Extreme II 4GB) and there are big differences, namely the model

Re: Resets on sil3124 sil3726 PMP

2007-09-03 Thread Tejun Heo
Hello, Petr Vandrovec wrote: I have recompiled kernel with all debugging disabled, and it brought me 1.5MBps, so it is still consistently 1MBps slower than on sil. Disabling NCQ seems to improve concurrent access a bit (for which I have no explanation), while slows down single drive scenario:

Re: CF as IDE on ICH6M using libata

2007-09-02 Thread Tejun Heo
Eddie Hung wrote: Hello everyone, In the hope of making myself a cheap SSD, I decided to replace my IDE HDD on my IBM Thinkpad X41 (non tablet) with a generic CF-IDE adaptor, and a Sandisk Extreme IV 4Gb CF, for reasonable prices off ebay. This was partly influenced by the report that one

[PATCH 1/2 #upstream,REGENERATED] libata: udpate ata_dev_try_classify() arguments

2007-09-02 Thread Tejun Heo
. @present will be used to improve diagnostic failure handling. Signed-off-by: Tejun Heo [EMAIL PROTECTED] --- drivers/ata/libata-core.c | 30 -- drivers/ata/pata_scc.c|6 -- drivers/ata/sata_mv.c |2 +- include/linux/libata.h|3 ++- 4 files

[PATCH 2/2 #upstream,REGENERATED] libata: assume ATA_DEV_ATA on diagnostic failure

2007-09-02 Thread Tejun Heo
Certain device which reports diagnostic failure also reports invalid device signature. Assume ATA_DEV_ATA on diagnostic failure if reset indicates device presence. This is fix for bugzilla bug 8784. http://bugzilla.kernel.org/show_bug.cgi?id=8784 Signed-off-by: Tejun Heo [EMAIL PROTECTED

Re: CF as IDE on ICH6M using libata

2007-09-02 Thread Tejun Heo
drivers/ata/Eddie Hung wrote: ATA device, with non-removable media Model Number: SMI MODEL Serial Number: SZAUSWIN06E5 Firmware Revision: 20070709 Standards: Likely used: 5 Configuration: Logical max current cylinders

[PATCH #upstream-fixes]: libata clear horkage on ata_dev_init()

2007-09-02 Thread Tejun Heo
dev-horkage should be cleared over device hotunplug/plug. Clear it in ata_dev_init(). Signed-off-by: Tejun Heo [EMAIL PROTECTED] --- drivers/ata/libata-core.c |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c index 2ad4dda..112e7a9

[PATCH 1/3] libata: move ata_id_n_sectors() upward

2007-09-02 Thread Tejun Heo
Move ata_id_n_sectors() upward right below ata_id_c_string(). This is to accomodate later changes. Signed-off-by: Tejun Heo [EMAIL PROTECTED] --- drivers/ata/libata-core.c | 30 +++--- 1 files changed, 15 insertions(+), 15 deletions(-) diff --git a/drivers/ata/libata

[PATCH 2/3] libata: clean up read/set native_max address functions

2007-09-02 Thread Tejun Heo
instead of 0x40 This is in preparation of ata_hpa_resize() update. Signed-off-by: Tejun Heo [EMAIL PROTECTED] --- drivers/ata/libata-core.c | 174 - 1 files changed, 77 insertions(+), 97 deletions(-) diff --git a/drivers/ata/libata-core.c b/drivers/ata

[PATCH REGENERATED] ahci: reimplement port_map handling

2007-09-02 Thread Tejun Heo
needed results in weird detection failure. This changed logic should be able to handle all known cases correctly automatically. Verified on ICH6 (reports 0 PI), ICH8 (with holes in port_map), ICH9, JMB360 and JMB363. Signed-off-by: Tejun Heo [EMAIL PROTECTED] --- Regenerated on top of the current

[PATCH #upstream-fixes] libata: implement BROKEN_HPA horkage and apply it to affected drives

2007-08-28 Thread Tejun Heo
Some drives choke on READ_NATIVE_MAX_ADDRESS[_EXT]. Implement ATA_HORKAGE_BROKEN_HPA and apply it to affected drives. Signed-off-by: Tejun Heo [EMAIL PROTECTED] --- MAXTOR 6L080L4 added from bugzilla bug 7119. drivers/ata/libata-core.c | 11 --- include/linux/libata.h|1 + 2

Re: Fwd: Re: libata pmp support

2007-08-27 Thread Tejun Heo
Hello, Weksler Izik wrote: I did it yesterday with the 2.6.22.5 vanilla from kernel.org. It works. I don't have the dmesg output here - I'll send it to you in the evening. Generally: It defines ATA2 as Config disk but doesn't wait for device ID and doesn't perform several resets - no delay

Re: Fwd: Re: libata pmp support

2007-08-26 Thread Tejun Heo
Izik Weksler wrote: -- Forwarded Message -- Subject: Re: libata pmp support Date: Thursday 23 August 2007 From: Izik Weksler [EMAIL PROTECTED] To: Tejun Heo [EMAIL PROTECTED] On Thursday 23 August 2007, you wrote: Izik Weksler wrote: Tejun, If you're sending

Re: Resets on sil3124 sil3726 PMP

2007-08-26 Thread Tejun Heo
Hello, Rusty. Rusty Conover wrote: I have some interesting results. I had a pair of Seagate 250 GB SATA disks (models below) and tried those out rather then the WD's.At the 1.5 gbps rather they appear to work just fine both being on the same PMP, at 3.0 gbps they timeout just like the

Re: Resets on sil3124 sil3726 PMP

2007-08-26 Thread Tejun Heo
Hello, Rusty. Rusty Conover wrote: After all I decided to send back the piece of hardware and just switch to a solution that has the SATA ports on the main board. Thanks for you help trying to get all of this working, I probably just had a bad adaptor card or drive enclosure. 3726/4726 work

Re: Fwd: Re: libata pmp support

2007-08-26 Thread Tejun Heo
Izik Weksler wrote: On Saturday 25 August 2007, Tejun Heo wrote: Izik Weksler wrote: -- Forwarded Message -- Subject: Re: libata pmp support Date: Thursday 23 August 2007 From: Izik Weksler [EMAIL PROTECTED] To: Tejun Heo [EMAIL PROTECTED] On Thursday 23 August 2007

Re: Need help

2007-08-26 Thread Tejun Heo
chia wrote: Dear Tejun, I have installed 10.3 Beta 2. It works in the halfway so I need to ask your help. To the point download software to the drive and installation are OK. However, when trying to read the data out, it stalls for a long time (1~2 min). The same software in normal harddrive

Re: [PATCHSET #upstream-fixes] libata: update HPA handling

2007-08-26 Thread Tejun Heo
Tejun Heo wrote: Jeff Garzik wrote: Tejun Heo wrote: Hello, The current HPA handling implementation isn't robust enough and causes regressions on several cases. This patchset contains HPA handling update. * blacklist devices which puke on READ_NATIVE_MAX * proper/better error handling

[PATCH #upstream-fixes] ata_piix: add Satellite U200 to broken suspend list

2007-08-24 Thread Tejun Heo
Satellite U200 also shares the problem. Add it to the broken suspend list. Original patch from John Schember. Signed-off-by: Tejun Heo [EMAIL PROTECTED] Cc: John Schember [EMAIL PROTECTED] --- drivers/ata/ata_piix.c |7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/ata

Re: Resets on sil3124 sil3726 PMP

2007-08-22 Thread Tejun Heo
Does the attached patch make any difference? -- tejun --- drivers/ata/libata-core.c |1 + 1 file changed, 1 insertion(+) Index: work1/drivers/ata/libata-core.c === --- work1.orig/drivers/ata/libata-core.c +++

Re: Resets on sil3124 sil3726 PMP

2007-08-22 Thread Tejun Heo
Rusty Conover wrote: After adding a semicolon to the added line, and recompiling there are still timeouts like before on the PMP ports. Oops. It did have the effect of setting the SATA speed to 1.5 rather then 3.0 on boot though. Yeah, that was the intention. I'm running out of ideas.

Re: no need to add new DID's to AHCI driver?

2007-08-22 Thread Tejun Heo
Jeff Garzik wrote: Gaston, Jason D wrote: Hello, Now that the AHCI driver has support for all controllers with the 0x0106 (AHCI) class code, I am not planning on adding controller DeviceID's for AHCI controllers. I want to verify that this is the correct course of action. Note: I still

[PATCH #upstream-fixes] ata_piix: implement IOCFG bit18 quirk

2007-08-22 Thread Tejun Heo
Some notebooks need bit18 of IOCFG to be cleared for the drive bay to work even though the bit is NOOP according to the datasheet. This patch implement IOCFG bit18 quirk and apply it to Clevo M570U. http://bugzilla.kernel.org/show_bug.cgi?id=8051 Signed-off-by: Tejun Heo [EMAIL PROTECTED] Cc

Re: libata pmp support

2007-08-22 Thread Tejun Heo
Izik Weksler wrote: Tejun, If you're sending the patch please send it to this address. Okay, please test the attached patch and please cc linux-ide@vger.kernel.org when replying. Thanks. -- tejun diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c index 06f212f..d838bdd 100644 ---

Re:

2007-08-21 Thread Tejun Heo
chia-ming liu wrote: Dear Tejun, I am not very good at linux and just enough to get by. I have tried to use your patch by issuing the command 'patch -p1 combined.patch' and I receive this msvlsi63:~/libata-tj-2.6.18.1-20061020 # patch -p1 combined.patch can't find file to patch at input

Re: Resets on sil3124 sil3726 PMP

2007-08-21 Thread Tejun Heo
Rusty Conover wrote: Hi Tejun, Just as some further testing and poking I added the drives to the list of disks to disable NCQ for, it didn't resolve the issue. I increased the PMP timeout to 1000 rather then 250 and that didn't resolve the problem either. The interface still has

Re:

2007-08-21 Thread Tejun Heo
chia wrote: Dear Tejun, Is 10.3 beta stable? Do I still need to patch it? If I do, what version I should use? Can I apply a higher version patch to lower version of kernel? Thanks! It's beta after all so it wouldn't be too stable but you don't need to patch anything. -- tejun - To

<    4   5   6   7   8   9   10   11   12   13   >