Re: [PATCH/RFC 7/9] libata: pdc_freeze() semantic change

2007-06-17 Thread Tejun Heo
Albert Lee wrote: Patch 7/9: After checking the current implementations of freeze()/thaw(), it seems only pdc_freeze() do more than simple irq masking. Remove the DMA disable code from pdc_freeze(). The question is the design/semantic of freeze()/thaw(). Maybe we should limit them to

[PATCH/RFC 7/9] libata: pdc_freeze() semantic change

2007-06-14 Thread Albert Lee
Patch 7/9: After checking the current implementations of freeze()/thaw(), it seems only pdc_freeze() do more than simple irq masking. Remove the DMA disable code from pdc_freeze(). The question is the design/semantic of freeze()/thaw(). Maybe we should limit them to simple irq on/off?