Re: [PATCH] libata: Integrate ACPI-based PATA/SATA hotplug - version 3

2007-10-02 Thread Matthew Garrett
On Tue, Oct 02, 2007 at 11:04:41AM -0400, Jeff Garzik wrote: > 1) Check dev->sdev for NULL Ok. > 2) remove the unnecessary ata_device loop. If you know the ata_device > pointer, you should not throw it away and then do a search to find it again. > > You need two functions, ata_acpi_ap_notify(

Re: [PATCH] libata: Integrate ACPI-based PATA/SATA hotplug - version 3

2007-10-02 Thread Jeff Garzik
Matthew Garrett wrote: Modern laptops with hotswap bays still tend to utilise a PATA interface on a SATA bridge, generally with the host controller in some legacy emulation mode rather than AHCI. This means that the existing hotplug code in libata is unable to work. The ACPI specification state

Re: [PATCH] libata: Integrate ACPI-based PATA/SATA hotplug - version 3

2007-09-27 Thread Henrique de Moraes Holschuh
On Thu, 27 Sep 2007, Matthew Garrett wrote: > The spec seems to imply that even if the drive hotswap bay and the > battery bay are physically the same, they're logically distinct. 10.2.1 That holds true for thinkpads up to the T43, at least. I don't know about the newer ones. You get bay eject

Re: [PATCH] libata: Integrate ACPI-based PATA/SATA hotplug - version 3

2007-09-27 Thread Matthew Garrett
On Thu, Sep 27, 2007 at 10:26:59AM -0700, Kristen Carlson Accardi wrote: > 1. How does it handle things when you have a bay that is located behind > a dock and the dock ejects? In the acpi bay driver, I use the mechanism > that the dock driver exports to get undock notifications so that the bay

Re: [PATCH] libata: Integrate ACPI-based PATA/SATA hotplug - version 3

2007-09-27 Thread Kristen Carlson Accardi
On Tue, 25 Sep 2007 00:14:36 +0100 Matthew Garrett <[EMAIL PROTECTED]> wrote: > Modern laptops with hotswap bays still tend to utilise a PATA interface > on a SATA bridge, generally with the host controller in some legacy > emulation mode rather than AHCI. This means that the existing hotplug >

[PATCH] libata: Integrate ACPI-based PATA/SATA hotplug - version 3

2007-09-24 Thread Matthew Garrett
Modern laptops with hotswap bays still tend to utilise a PATA interface on a SATA bridge, generally with the host controller in some legacy emulation mode rather than AHCI. This means that the existing hotplug code in libata is unable to work. The ACPI specification states that these devices ca