Re: [PATCH 1/6] qd65xx: fix PIO mode selection

2007-06-23 Thread Alan Cox
On Sat, 23 Jun 2007 20:02:07 +0200 Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] wrote: PIO4 is a maximum PIO mode supported by a driver. Using 255 as a max_mode argument to ide_get_best_pio_mode() could result in wrong timings being used by a driver (for pio equal to 5) or OOPS (for pio

Re: [PATCH 1/6] qd65xx: fix PIO mode selection

2007-06-23 Thread Sergei Shtylyov
Hello. Alan Cox wrote: PIO4 is a maximum PIO mode supported by a driver. Using 255 as a max_mode argument to ide_get_best_pio_mode() could result in wrong timings being used by a driver (for pio equal to 5) or OOPS (for pio values 5 255). The qdi6580 driver is somewhat hosed. The libata

Re: [PATCH 1/6] qd65xx: fix PIO mode selection

2007-06-23 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: PIO4 is a maximum PIO mode supported by a driver. Using 255 as a max_mode argument to ide_get_best_pio_mode() could result in wrong timings being used by a driver (for pio equal to 5) or OOPS (for pio values 5 255). Signed-off-by: Bartlomiej Zolnierkiewicz

[PATCH 1/6] qd65xx: fix PIO mode selection

2007-06-23 Thread Bartlomiej Zolnierkiewicz
PIO4 is a maximum PIO mode supported by a driver. Using 255 as a max_mode argument to ide_get_best_pio_mode() could result in wrong timings being used by a driver (for pio equal to 5) or OOPS (for pio values 5 255). Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] ---

Re: [PATCH 1/6] qd65xx: fix PIO mode selection

2007-06-23 Thread Bartlomiej Zolnierkiewicz
On Saturday 23 June 2007, Alan Cox wrote: Possibly we should just drop support as I know of only one user and thats purely to test the code Fine with me, please send a patch. PS Added yours Reviewed-by: to this patch as I still need to push it (I have other patches in the queue depending on